eslint-config-beslogic 3.0.2 → 3.1.2

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 3.1.2
+
+- Removed `globalThis` from `no-restricted-globals` as the adoption is now much wider (no more IE11) and it conflicts with `unicorn/prefer-global-this`
+
+## 3.1.1
+
+- Turned on `"objectLiteralTypeAssertions": "allow-as-parameter"` as error for `@typescript-eslint/consistent-type-assertions` in extra-strict config
+- Enabled `@typescript-eslint/consistent-type-assertions` (but without the "as parameter" restriction) for Jest
+- Added `boolean` and `nullish` to `@typescript-eslint/restrict-template-expressions` in `extra-strict` preset
+  If you really meant to write "true", "false", "null" or "undefined", then explicitly stringify it using `String()` (or `Intl.ListFormat` for `Array`s)
+- Disabled `default-case` rule in TypeScript as it is redundant with `@typescript-eslint/switch-exhaustiveness-check` and conflicts with `unicorn/no-useless-switch-case`
+- Bumped `eslint-plugin-sonarjs` to `2.0.4`
+- Stopped attempting to support pre-commit.ci. Read the [`PR Autofixes`](https://github.com/BesLogic/shared-configs/blob/main/README.md#pr-autofixes) section of our Shared Configs for an explanation and alternatives.
+
 ## 3.0.2
 
 - Made `eslint-plugin-sonarjs` optional for pre-commit.ci contexts

package/README.md

@@ -17,7 +17,7 @@ These are configuration files you'll have to update manually to best work with t
 
 ### `package.json`
 
-Read the [`package.json`](https://github.com/BesLogic/shared-configs#packagejson-for-dprint-and-eslint) section of our Shared Configs for one-liner shortcut scripts you can use.
+Read the [`package.json`](https://github.com/BesLogic/shared-configs/blob/main/README.md#packagejson) section of our Shared Configs for one-liner shortcut scripts you can use.
 
 ### Base `tsconfig.json`
 
@@ -61,60 +61,10 @@ If you'd like to pin your config version, you can use a commit hash, like `https
 
 If also using [`beslogic/json-like` preset](#beslogicjson-like) extend from `https://raw.githubusercontent.com/BesLogic/shared-configs/main/dprint-json-like.json` instead.
 
-### Usage with `pre-commit.ci` (`.pre-commit-config.yaml`)
+### PR Autofixes
 
-<!-- Use the following hook: <https://github.com/pre-commit/mirrors-eslint>
-Set `args: [--ignore-path, .gitignore, --fix, --quiet]`.\
-For mono-repos, specify your frontend project: `args: [frontend_project, --ignore-path, frontend_project/.gitignore, --fix, --quiet]`.
--->
-
-```yaml
-repos:
-  - repo: local
-    hooks:
-      - id: eslint
-        name: eslint
-        language: node
-        # To run at root
-        entry: npm run eslint -- --fix --quiet
-        # To run in specific project (for monorepos)
-        entry: bash -c 'cd frontend_project && npm run eslint -- --fix --quiet'
-        files: \.[jt]sx?$ # *.js, *.jsx, *.ts and *.tsx
-        types: [file]
-        pass_filenames: false
-        additional_dependencies: [...]
-```
-
-In the `additional_dependencies` field, you'll need to include _all_ the plugins we use (copy this project's `dependencies` in `package.json`), as well as the optional plugins you need for yor presets.
-
-As you'll easily bust the 250MiB limit on the free tier, omit the following dependencies as they're special-cased to always be ignored on `pre-commit.ci` anyway:
-
-- `dprint`
-- `@eslint-community/eslint-plugin-eslint-comments`
-- `esling-plugin-no-autofix`
-- `eslint-import-resolver-typescript`
-- `eslint-plugin-etc`
-- `eslint-plugin-jest-formatting`
-- `eslint-plugin-jest`
-- `eslint-plugin-sonarjs`
-- `eslint-plugin-testing-library`
-
-If using TypeScript and pre-commit.ci, in your ESLint config you'll _have to_ use the project service, or you'll run into OOM issues:
-
-```js
-/** @type {import("eslint").Linter.Config} */
-module.exports = {
-  parser: "@typescript-eslint/parser",
-  parserOptions: {
-    projectService: {
-      allowDefaultProject: []
-    },
-    // Still needed for plugins that haven't updated to typescript-eslint@8 yet
-    // Namely: eslint-plugin-sonarjs
-    EXPERIMENTAL_useProjectService: true
-  }
-}
-```
+We've stopped attempting to support pre-commit.ci.\
+Read the [`PR Autofixes`](https://github.com/BesLogic/shared-configs/blob/main/README.md#pr-autofixes) section of our Shared Configs for an explanation and alternatives.
 
 ## Patched packages
 

package/TODO-SONARJS_CHECK_IF_DUPLICATED.json

@@ -50,7 +50,6 @@
   "sonarjs/media-has-caption": "error",
   "sonarjs/misplaced-loop-counter": "error",
   "sonarjs/mouse-events-a11y": "error",
-  "sonarjs/new-cap": "error",
   "sonarjs/new-operator-misuse": "error",
   "sonarjs/no-accessor-field-mismatch": "error",
   "sonarjs/no-all-duplicated-branches": "error",

package/angular.js

@@ -1,16 +1,10 @@
 // SPDX-License-Identifier: MIT
 // Copyright 2024 Beslogic Inc.
 
-const { getModuleVersion, jestNoRestrictedSyntax, jestFilePatterns, resolveModuleLocation } =
-  require("./lib/utils")
+const { getModuleVersion, jestNoRestrictedSyntax, jestFilePatterns } = require("./lib/utils")
 
 const angularEslintVersion = getModuleVersion("@angular-eslint/eslint-plugin", 16.2)
 const typescriptVersion = getModuleVersion("typescript", 4.7)
-const hasTestingLibrary = !!resolveModuleLocation("eslint-plugin-testing-library")
-// eslint-plugin-no-autofix is broken when run through pre-commit
-// https://github.com/aladdin-add/eslint-plugin/issues/98
-// Even if it gets fixed, `no-autofix` rules necessarily don't provide fixes anyway
-const hasNoAutofix = !!resolveModuleLocation("eslint-plugin-no-autofix")
 
 const javascriptConfig = require("./javascript")
 const typescriptConfig = require("./typescript")
@@ -81,9 +75,7 @@ module.exports = {
   "overrides": [
     {
       "files": ["*.html"],
-      "plugins": hasNoAutofix
-        ? ["no-autofix"]
-        : [],
+      "plugins": ["no-autofix"],
       "extends": ["plugin:@angular-eslint/template/all"],
       "rules": {
         "@angular-eslint/template/click-events-have-key-events": "off",
@@ -331,9 +323,7 @@ module.exports = {
     },
     {
       "files": jestFilePatterns,
-      "extends": hasTestingLibrary
-        ? ["plugin:testing-library/angular"]
-        : [],
+      "extends": ["plugin:testing-library/angular"],
       "rules": { "no-restricted-syntax": jestNoRestrictedSyntax(noRestrictedSyntax) }
     },
     {

package/extra-strict.js

@@ -1,9 +1,18 @@
-const { isPreCommitCI, resolveModuleLocation } = require("./lib/utils")
+const { resolveModuleLocation, jestFilePatterns } = require("./lib/utils")
 
-const hasEtc = !!resolveModuleLocation("eslint-plugin-etc")
-const hasNoAutofix = !!resolveModuleLocation("eslint-plugin-no-autofix")
+// TODO: ADD no-unsafe-type-assertion ONCE IT'S PUBLISHED ! (and the message I used to include)
+// (remove from non-strict, add back here, then re-disable for jest at the bottom of the file)
+// https://github.com/typescript-eslint/typescript-eslint/pull/10051
+// https://github.com/typescript-eslint/typescript-eslint/issues/7173
+
+// These extra strict configs are not only for Angular. User may be using a different framework
 const hasAngularEslintTemplate = !!resolveModuleLocation("@angular-eslint/eslint-plugin-template")
 
+const typeScriptConfig = require("./typescript")
+
+const restrictTemplateExpressionsConfig = typeScriptConfig.overrides?.[0].rules
+  ?.["@typescript-eslint/restrict-template-expressions"]?.[1]
+
 /** @type {import("eslint").Linter.Config} */
 module.exports = {
   "overrides": [
@@ -16,13 +25,9 @@ module.exports = {
         /*
          * Cartant's etc rules
          */
-        "etc/no-commented-out-code": hasEtc
-          ? "error"
-          : "off",
+        "etc/no-commented-out-code": "error",
         "sonarjs/no-commented-code": "off",
-        "etc/no-enum": hasEtc
-          ? "warn" // warn instead of error, not as problematic as of TS 5
-          : "off",
+        "etc/no-enum": "warn", // warn instead of error, not as problematic as of TS 5
 
         // This is caught when noImplicitThis is enabled, which we assume in this config
         // https://typescript-eslint.io/rules/no-invalid-this/
@@ -36,7 +41,8 @@ module.exports = {
          * (copied from https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Reference/_wiki/wikis/Beslogic-Architecture-Reference.wiki/656/Frontend-linting-and-formatting?anchor=total-functions/no-unsafe-type-assertion)
          * It can sometimes be hard to make sense of this rule, but let's be strict!
          * Tips:
-         * - Prefer coercion over assertion: `String(value ?? '')` over `value as string | null`
+         * - Prefer coercion over assertion: e.g `String(value ?? '')` over `value as string | null`
+         *   (this depends on your functional logic)
          * - Try to assign to an explicitly typed variable and TypeScript will tell you about the type difference!
          *     ie: `const newValue: ExpectedType = unsafeValue`
          * - If using TypeScript 4.9+, consider using the `satisfies` Operator:
@@ -44,19 +50,30 @@ module.exports = {
          *     `const newValue = {a: "A", b: 2} satisfies ExpectedType`
          * - If using TypeScript 4.9+, consider using the `in` Operator to narrow unlisted properties:
          *     (https://devblogs.microsoft.com/typescript/announcing-typescript-4-9/#unlisted-property-narrowing-with-the-in-operator)
-         *     `if ("name" in unsafeValue&& typeof unsafeValue.name === "string") ...`
+         *     `if ("name" in unsafeValue && typeof unsafeValue.name === "string") ...`
          * - Sometimes just casting as `Partial<>` is sufficient
          * - Double check that you are not accidentally removing `null | undefined` from the type when casting:
          *   - `inputEvent.target as Partial<HTMLInputElement>` <-- Oops!
          *   - `event.target as Partial<HTMLInputElement> | null` <-- Ok!
          */
-        "no-autofix/@typescript-eslint/consistent-type-assertions": [
-          hasNoAutofix
-            ? "warn"
-            : "off",
+        "@typescript-eslint/consistent-type-assertions": [
+          "error",
           { "assertionStyle": "as", "objectLiteralTypeAssertions": "allow-as-parameter" }
         ],
 
+        "@typescript-eslint/restrict-template-expressions": [
+          "error",
+          {
+            ...restrictTemplateExpressionsConfig,
+            // Writing "false", "null" or "undefined" may not be intended in a string
+            // for example: className={`form-control ${form?.errors && 'invalid'} `}
+            // If this is really intended, then stringify it using String()
+            // (or Intl.ListFormat for Arrays)
+            "allowBoolean": false,
+            "allowNullish": false
+          }
+        ],
+
         /*
          * @typescript-eslint rules that require strictNullChecks
          * These requires stricter tsconfig or fails.
@@ -65,9 +82,7 @@ module.exports = {
         // Setting allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing makes this rule useless on
         // null/undefined checks. So only set it in non-strict preset.
         "@typescript-eslint/no-unnecessary-condition": [
-          isPreCommitCI
-            ? "off" // Missing types lead to false-positives
-            : "error",
+          "error",
           { "allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing": false }
         ],
         "@typescript-eslint/prefer-nullish-coalescing": "error",
@@ -88,7 +103,7 @@ module.exports = {
         "@angular-eslint/template/i18n": "off",
         "no-autofix/@angular-eslint/template/i18n": [
           // Too many TODO and needs per-project extensions to justify this as "error"
-          hasNoAutofix && hasAngularEslintTemplate
+          hasAngularEslintTemplate
             ? "warn"
             : "off",
           {
@@ -133,6 +148,16 @@ module.exports = {
           }
         ]
       }
+    },
+    {
+      "files": jestFilePatterns,
+      "rules": {
+        // Allow fake types in tests, back to default config of allowing everywhere
+        "@typescript-eslint/consistent-type-assertions": [
+          "error",
+          { "assertionStyle": "as", "objectLiteralTypeAssertions": "allow" }
+        ]
+      }
     }
   ]
 }

package/javascript.js

@@ -5,22 +5,9 @@ const restrictedGlobals = require("confusing-browser-globals")
 const {
   jestNoRestrictedSyntax,
   jestFilePatterns,
-  resolveModuleLocation,
-  idLenghtConfig,
-  isPreCommitCI
+  idLenghtConfig
 } = require("./lib/utils")
 
-// eslint-plugin-no-autofix is broken when run through pre-commit
-// https://github.com/aladdin-add/eslint-plugin/issues/98
-// Even if it gets fixed, `no-autofix` rules necessarily don't provide fixes anyway
-const hasNoAutofix = !!resolveModuleLocation("eslint-plugin-no-autofix")
-// @eslint-community/eslint-comments' only autofix is removing unused suppression comments
-// Some rules get globally disabled for pre-commit.ci, so finding unused comments is expected
-const hasEslintComments = !!resolveModuleLocation("@eslint-community/eslint-plugin-eslint-comments")
-// eslint-plugin-sonarjs@2 pulls in a ton of extra dependnecies we don't need
-// https://community.sonarsource.com/t/warning-react-version-not-specified-in-eslint-plugin-react/125412/11?u=avasam
-const hasSonarJS = !!resolveModuleLocation("eslint-plugin-sonarjs")
-
 const noRestrictedSyntax = [
   "error",
   "WithStatement",
@@ -46,24 +33,18 @@ module.exports = {
   "plugins": [
     "@stylistic",
     "extra-rules",
-    ...hasNoAutofix
-      ? ["no-autofix"]
-      : [],
+    "no-autofix",
     "no-relative-import-paths",
     "prefer-arrow",
     "simple-import-sort"
   ],
   "extends": [
     "eslint:recommended",
-    ...hasSonarJS
-      ? ["plugin:sonarjs/recommended-legacy"] // "legacy" is for ESLint v8 compatibility
-      : [],
+    "plugin:sonarjs/recommended-legacy", // "legacy" is for ESLint v8 compatibility
     "plugin:unicorn/all",
     "plugin:regexp/all",
     "plugin:import/recommended",
-    ...hasEslintComments
-      ? ["plugin:@eslint-community/eslint-comments/recommended"]
-      : []
+    "plugin:@eslint-community/eslint-comments/recommended"
   ],
   "env": {
     // https://eslint.org/docs/v8.x/use/configure/language-options#specifying-environments
@@ -245,9 +226,7 @@ module.exports = {
         ],
         // Using this to completely disallow all console calls except info, warn, error
         "no-autofix/no-console": [
-          hasNoAutofix
-            ? "error"
-            : "off",
+          "error",
           {
             "allow": [
               "info",
@@ -261,14 +240,12 @@ module.exports = {
          *  @eslint-community/eslint-comments/recommended overrides (https://eslint-community.github.io/eslint-plugin-eslint-comments/rules)
          */
         // TODO: Move back to "all files" once HTML parsing crash is fixed https://github.com/eslint-community/eslint-plugin-eslint-comments/issues/162
-        "@eslint-community/eslint-comments/disable-enable-pair": hasEslintComments
-          ? [
-            "error",
-            {
-              "allowWholeFile": true
-            }
-          ]
-          : "off"
+        "@eslint-community/eslint-comments/disable-enable-pair": [
+          "error",
+          {
+            "allowWholeFile": true
+          }
+        ]
       }
     },
     {
@@ -312,52 +289,41 @@ module.exports = {
     }
   ],
   "rules": {
-    ...hasEslintComments
-      ? {
-        /*
-         *  @eslint-community/eslint-comments/recommended overrides (https://eslint-community.github.io/eslint-plugin-eslint-comments/rules)
-         */
-        "@eslint-community/eslint-comments/no-unused-disable": "error",
-        "@eslint-community/eslint-comments/require-description": [
-          "error",
-          {
-            "ignore": ["eslint-enable"]
-          }
-        ]
+    /*
+     *  @eslint-community/eslint-comments/recommended overrides (https://eslint-community.github.io/eslint-plugin-eslint-comments/rules)
+     */
+    "@eslint-community/eslint-comments/no-unused-disable": "error",
+    "@eslint-community/eslint-comments/require-description": [
+      "error",
+      {
+        "ignore": ["eslint-enable"]
       }
-      : {},
+    ],
 
-    ...hasSonarJS
-      ? {
-        /*
-         * sonarjs/recommended overrides (https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md#rules)
-         */
-        // Same as eslint (cyclomatic) complexity
-        // This is also based on the fact that react-app service workers template hits this
-        "sonarjs/cognitive-complexity": [
-          "warn",
-          20
-        ],
-        // False-positives with top-level Promises (and maybe more, but that was enough for me ot disable)
-        "sonarjs/constructor-for-side-effects": "off",
-        "sonarjs/deprecation": "warn",
-        "sonarjs/no-duplicate-string": "error",
-        // Duplicates etc/no-commented-out-code. But is faster but also catches less.
-        // Incidentally this is good for a non-strict config.
-        "sonarjs/no-commented-code": "error",
-        // Too annoying, let us use our lovely PATH :)
-        "sonarjs/no-os-command-from-path": "off",
-        // Too annoying, consider maybe for an extra-strict
-        // but JS doesn't have kw params unlike Python
-        "sonarjs/no-selector-parameter": "off",
-        // Is default, but let's note that this option replaced `eslint-plugin-unused-imports` entirely,
-        // so if there's an issue, we can always go back.
-        "sonarjs/unused-import": "error",
-        // TODO: Raise an issue. Also mention that online doc examples sees to be inverted
-        // False-positives using Intl.DateTimeFormat()
-        "sonarjs/new-cap": "off"
-      }
-      : {},
+    /*
+     * sonarjs/recommended overrides (https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md#rules)
+     */
+    // Same as eslint (cyclomatic) complexity
+    // This is also based on the fact that react-app service workers template hits this
+    "sonarjs/cognitive-complexity": [
+      "warn",
+      20
+    ],
+    // False-positives with top-level Promises (and maybe more, but that was enough for me to disable)
+    "sonarjs/constructor-for-side-effects": "off",
+    "sonarjs/deprecation": "warn",
+    "sonarjs/no-duplicate-string": "error",
+    // Duplicates etc/no-commented-out-code. But is faster but also catches less.
+    // Incidentally this is good for a non-strict config.
+    "sonarjs/no-commented-code": "error",
+    // Too annoying, let us use our lovely PATH :)
+    "sonarjs/no-os-command-from-path": "off",
+    // Too annoying, consider maybe for an extra-strict
+    // but JS doesn't have keyword-only params, unlike Python
+    "sonarjs/no-selector-parameter": "off",
+    // Is default, but let's note that this option replaced `eslint-plugin-unused-imports` entirely,
+    // so if there's an issue, we can always go back.
+    "sonarjs/unused-import": "error",
 
     /*
      * eslint-plugin-sonarjs@2 added rules that duplicate base ESLint rules or specific plugins we prefer
@@ -372,6 +338,7 @@ module.exports = {
     // Base ESLint rules duplications (same names)
 
     "sonarjs/default-param-last": "off",
+    "sonarjs/new-cap": "off",
     "sonarjs/no-delete-var": "off",
     "sonarjs/no-empty-function": "off",
     "sonarjs/no-extend-native": "off",
@@ -482,9 +449,7 @@ module.exports = {
 
     // Extracted restricted import into its own rule so it's easier for projects to override/ignore
     "no-autofix/no-relative-import-paths/no-relative-import-paths": [
-      hasNoAutofix
-        ? "error"
-        : "off",
+      "error",
       {
         "allowSameFolder": true
       }
@@ -530,9 +495,7 @@ module.exports = {
     "unicorn/no-null": "off",
     // This rule has been deprecated in favor of eslint-plugin-regexp
     "unicorn/no-unsafe-regex": "off",
-    "unicorn/no-useless-undefined": isPreCommitCI
-      ? "off" // Missing types lead to false-positives
-      : "error",
+    "unicorn/no-useless-undefined": "error",
     "unicorn/numeric-separators-style": "error",
     "unicorn/prefer-add-event-listener": "error",
     "unicorn/prefer-array-find": [
@@ -624,9 +587,7 @@ module.exports = {
     // Autofixing is only applied when only checking for `singleReturnOnly: true`
     // but we still want to check for other cases
     "no-autofix/prefer-arrow/prefer-arrow-functions": [
-      hasNoAutofix
-        ? "error"
-        : "off",
+      "error",
       {
         "classPropertiesAllowed": true,
         "disallowPrototype": true,
@@ -863,9 +824,7 @@ module.exports = {
     // HACK: Workaround for coordinates objects
     // TODO: Should be using rule composition instead
     "no-autofix/id-length": [
-      hasNoAutofix
-        ? "error"
-        : "off",
+      "error",
       idLenghtConfig
     ],
     "no-empty-function": "error",
@@ -954,7 +913,6 @@ module.exports = {
     "no-promise-executor-return": "error",
     "no-restricted-globals": [
       "error",
-      "globalThis",
       ...restrictedGlobals,
       {
         "message": "Please import from react instead.",

package/jest.js

@@ -1,41 +1,22 @@
 // SPDX-License-Identifier: MIT
 // Copyright 2024 Beslogic Inc.
-const { getModuleVersion, resolveModuleLocation } = require("./lib/utils")
+const { getModuleVersion } = require("./lib/utils")
 
 const jestGlobalsVersion = getModuleVersion("@jest/globals", 29)
-// These are big modules for pre-commit.
-// Outside of pre-commit, these should NOT be considered optional !
-const hasTestingLibrary = !!resolveModuleLocation("eslint-plugin-testing-library")
-const hasJestFormatting = !!resolveModuleLocation("eslint-plugin-jest-formatting")
-const hasJest = !!resolveModuleLocation("eslint-plugin-jest")
-// eslint-plugin-sonarjs@2 pulls in a ton of extra dependnecies we don't need
-// https://community.sonarsource.com/t/warning-react-version-not-specified-in-eslint-plugin-react/125412/11?u=avasam
-const hasSonarJS = !!resolveModuleLocation("eslint-plugin-sonarjs")
 
 /** @type {import("eslint").Linter.Config} */
 module.exports = {
   "extends": [
-    ...hasJest
-      ? ["plugin:jest/all"]
-      : [],
-    ...hasJestFormatting
-      ? ["plugin:jest-formatting/strict"]
-      : [],
+    "plugin:jest/all",
+    "plugin:jest-formatting/strict",
     // Note: The DOM preset includes some rules not in Marko or Vue (eg.: no-await-sync-events).
     // Those must be disabled in their preset if we ever support them.
-    ...hasTestingLibrary
-      ? ["plugin:testing-library/dom"]
-      : []
+    "plugin:testing-library/dom"
   ],
   "env": {
     "browser": false,
     "jest": true,
-    ...hasJest
-      ? {
-        // Setting to `false` is not enough: Environment key "jest/globals" is unknown
-        "jest/globals": true
-      }
-      : {}
+    "jest/globals": true
   },
   "overrides": [
     {
@@ -62,8 +43,6 @@ module.exports = {
         ]
       }
     ],
-    // Allow fake types in tests
-    "no-autofix/@typescript-eslint/consistent-type-assertions": "off",
     // We can mock functions as empty
     "no-empty-function": "off",
     "@typescript-eslint/no-empty-function": "off",
@@ -76,66 +55,55 @@ module.exports = {
     "@typescript-eslint/no-unsafe-call": "off",
     // Allow printing "as-is" in tests
     "@typescript-eslint/restrict-template-expressions": "off",
-    ...hasSonarJS
-      ? {
-        // Higher requirements for tests since we like being explicit
-        // Arbitrary same as max-params (+1 because this is exclusive)
-        "sonarjs/no-duplicate-string": [
-          "error",
-          { "threshold": 8 }
-        ],
-        // We could bump it higher than 4, but doc doesn't provide its config
-        // So disabling since fluent tests are nested functions
-        // (same comment in jsx)
-        "sonarjs/no-nested-functions": "off"
-      }
-      : {},
+
+    // Higher requirements for tests since we like being explicit
+    // Arbitrary same as max-params (+1 because this is exclusive)
+    "sonarjs/no-duplicate-string": [
+      "error",
+      { "threshold": 8 }
+    ],
+    // We could bump it higher than 4, but doc doesn't provide its config
+    // So disabling since fluent tests are nested functions
+    // (same comment in jsx)
+    "sonarjs/no-nested-functions": "off",
 
     /*
      * jest/all overrides (https://github.com/jest-community/eslint-plugin-jest#rules)
      */
-    ...hasJest
-      ? {
-        // Doesn't print well with testing-library's `findBy` and `waitFor`
-        "jest/prefer-expect-resolves": "off",
-        // May lead to accidentally missed expects
-        "jest/prefer-expect-assertions": [
-          "error",
-          {
-            "onlyFunctionsWithExpectInCallback": true,
-            "onlyFunctionsWithExpectInLoop": true
-          }
-        ],
-        // https://github.com/jestjs/jest/issues/15084
-        // Since this will require a major jest version bump anyway,
-        // I feel confortable not waiting for our own major version bump to add this
-        ...jestGlobalsVersion < 30
-          ? { "jest/prefer-importing-jest-globals": "off" }
-          : {},
-        // Top-level describe is often used for component name, which is capitalized
-        "jest/prefer-lowercase-title": [
-          "error",
-          { "ignoreTopLevelDescribe": true }
-        ],
-        // Allow clearing mocks in beforeEach
-        "jest/no-hooks": [
-          "error",
-          {
-            "allow": ["beforeEach"]
-          }
-        ]
+    // Doesn't print well with testing-library's `findBy` and `waitFor`
+    "jest/prefer-expect-resolves": "off",
+    // May lead to accidentally missed expects
+    "jest/prefer-expect-assertions": [
+      "error",
+      {
+        "onlyFunctionsWithExpectInCallback": true,
+        "onlyFunctionsWithExpectInLoop": true
       }
+    ],
+    // https://github.com/jestjs/jest/issues/15084
+    // Since this will require a major jest version bump anyway,
+    // I feel confortable not waiting for our own major version bump to add this
+    ...jestGlobalsVersion < 30
+      ? { "jest/prefer-importing-jest-globals": "off" }
       : {},
+    // Top-level describe is often used for component name, which is capitalized
+    "jest/prefer-lowercase-title": [
+      "error",
+      { "ignoreTopLevelDescribe": true }
+    ],
+    // Allow clearing mocks in beforeEach
+    "jest/no-hooks": [
+      "error",
+      {
+        "allow": ["beforeEach"]
+      }
+    ],
 
     /*
      * testing-library overrides (https://github.com/testing-library/eslint-plugin-testing-library#supported-rules)
      */
-    ...hasTestingLibrary
-      ? {
-        "testing-library/no-debugging-utils": "error",
-        "testing-library/prefer-user-event": "warn",
-        "testing-library/prefer-explicit-assert": "error"
-      }
-      : {}
+    "testing-library/no-debugging-utils": "error",
+    "testing-library/prefer-user-event": "warn",
+    "testing-library/prefer-explicit-assert": "error"
   }
 }

package/lib/utils.js

@@ -1,5 +1,3 @@
-const isPreCommitCI = __dirname.startsWith("/pc/clone/")
-
 const getModuleVersion = (
   /** @type {string} */ nodeModule,
   /** @type {number} */ fallbackVersion
@@ -23,14 +21,7 @@ const getModuleVersion = (
 
 const resolveModuleLocation = (/** @type {string} */ nodeModule) => {
   try {
-    const resolved = require.resolve(nodeModule)
-    // equivalent to resolved.startsWith("/pc/clone/"))
-    if (isPreCommitCI) {
-      // Assume it's omitted from the pre-commit.ci run
-      return false
-    }
-
-    return resolved
+    return require.resolve(nodeModule)
   } catch {
     return false
   }
@@ -86,7 +77,6 @@ module.exports = {
   getModuleVersion,
   idLenghtConfig,
   jestFilePatterns,
-  isPreCommitCI,
   jestNoRestrictedSyntax,
   resolveModuleLocation
 }

package/node-js.js

@@ -84,7 +84,6 @@ module.exports = {
     "no-console": "error",
     "no-restricted-globals": [
       "error",
-      "globalThis",
       {
         "name": "Request",
         "message": expressGlobalMessage

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "3.0.2",
+  "version": "3.1.2",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",
@@ -35,8 +35,7 @@
     "material-ui",
     "angular",
     "dprint",
-    "autofix",
-    "pre-commit"
+    "autofix"
   ],
   "author": "Samuel Therrien <samuel.therrien@beslogic.com>",
   "license": "MIT",
@@ -63,7 +62,7 @@
     "eslint-plugin-prefer-arrow": "^1.2",
     "eslint-plugin-regexp": "^2.0",
     "eslint-plugin-simple-import-sort": ">=12.0",
-    "eslint-plugin-sonarjs": "2.0.3",
+    "eslint-plugin-sonarjs": "2.0.4",
     "eslint-plugin-testing-library": "^6.0",
     "eslint-plugin-unicorn": ">=49.0"
   },

package/react.js

@@ -3,9 +3,7 @@
 
 const javascriptConfig = require("./javascript")
 const typescriptConfig = require("./typescript")
-const { jestFilePatterns, resolveModuleLocation } = require("./lib/utils")
-
-const hasTestingLibrary = !!resolveModuleLocation("eslint-plugin-testing-library")
+const { jestFilePatterns } = require("./lib/utils")
 
 const typeDefinitionOverride = typescriptConfig.overrides?.find(
   override => override.files === "*.d.ts"
@@ -100,9 +98,7 @@ module.exports = {
     },
     {
       "files": jestFilePatterns,
-      "extends": hasTestingLibrary
-        ? ["plugin:testing-library/react"]
-        : []
+      "extends": "plugin:testing-library/react"
     },
     {
       "files": [

package/typescript.js

@@ -2,17 +2,7 @@
 // Copyright 2024 Beslogic Inc.
 
 const javascriptConfig = require("./javascript")
-const { jestNoRestrictedSyntax, jestFilePatterns, resolveModuleLocation, isPreCommitCI } = require(
-  "./lib/utils"
-)
-
-// The only autofix we use is `no-implicit-any-catch` and this is a big module for pre-commit
-// Outside of pre-commit, `eslint-plugin-etc` should NOT be considered optional !
-const hasEtc = !!resolveModuleLocation("eslint-plugin-etc")
-// Causes the following error in pre-commit.ci:
-// Resolve error: File 'eslint-config-beslogic/tsconfig.5.0.json' not found.
-// Outside of pre-commit, `eslint-import-resolver-typescript` should NOT be considered optional !
-const hasImportResolverTypescript = !!resolveModuleLocation("eslint-import-resolver-typescript")
+const { jestNoRestrictedSyntax, jestFilePatterns } = require("./lib/utils")
 
 const noRestrictedSyntax = [
   ...javascriptConfig.rules?.["no-restricted-syntax"] ?? {},
@@ -41,6 +31,7 @@ const noUnusedVariablesConfig = autofixOverridesRules?.["autofix/no-unused-vars"
 /** @type {import("eslint").Linter.Config} */
 module.exports = {
   "overrides": [
+    // It's important to keep this override first, as other rules will extend from it
     {
       "files": [
         "*.ts",
@@ -48,35 +39,27 @@ module.exports = {
       ],
       "extends": [
         "plugin:@typescript-eslint/all",
-        ...hasEtc
-          ? ["plugin:etc/recommended"]
-          : [],
-        ...hasImportResolverTypescript
-          ? ["plugin:import/typescript"]
-          : []
+        "plugin:etc/recommended",
+        "plugin:import/typescript"
       ],
       "env": {
         // https://eslint.org/docs/v8.x/use/configure/language-options#specifying-environments
         "es2022": true // Same as tsconfig.json > compilerOptions.lib
       },
       "settings": {
-        ...hasImportResolverTypescript
-          ? {
-            "import/resolver": {
-              "typescript": {
-                // Recommended by eslint-import-resolver-typescript
-                // Always try to resolve types under `<root>@types` directory even it doesn't contain any source code, like `@types/unist`
-                "alwaysTryTypes": true,
-                // Doesn't support `project: true` or `useProjectService`
-                // https://github.com/import-js/eslint-import-resolver-typescript/issues/282
-                "project": [
-                  "tsconfig?(.*).json",
-                  "projects/*/tsconfig?(.*).json"
-                ]
-              }
-            }
+        "import/resolver": {
+          "typescript": {
+            // Recommended by eslint-import-resolver-typescript
+            // Always try to resolve types under `<root>@types` directory even it doesn't contain any source code, like `@types/unist`
+            "alwaysTryTypes": true,
+            // Doesn't support `project: true` or `useProjectService`
+            // https://github.com/import-js/eslint-import-resolver-typescript/issues/282
+            "project": [
+              "tsconfig?(.*).json",
+              "projects/*/tsconfig?(.*).json"
+            ]
           }
-          : {},
+        },
         "import/parsers": {
           "@typescript-eslint/parser": [
             ".ts",
@@ -118,21 +101,17 @@ module.exports = {
         /*
          * Cartant's etc rules
          */
-        ...hasEtc
-          ? {
-            "etc/no-const-enum": "error",
-            // This rule currently crashes :( Turn back to error if fixed
-            // https://github.com/cartant/eslint-plugin-etc/issues/47
-            "etc/throw-error": "off",
-            "etc/underscore-internal": "error",
-            // These two are extremely slow. More than should be expected
-            // https://github.com/cartant/eslint-plugin-etc/issues/10#issuecomment-1618450905
-            "etc/no-deprecated": "off",
-            "etc/no-internal": "off",
-            // See https://github.com/cartant/eslint-plugin-etc/issues/45#issuecomment-1137305254
-            "etc/prefer-interface": "off"
-          }
-          : {},
+        "etc/no-const-enum": "error",
+        // This rule currently crashes :( Turn back to error if fixed
+        // https://github.com/cartant/eslint-plugin-etc/issues/47
+        "etc/throw-error": "off",
+        "etc/underscore-internal": "error",
+        // These two are extremely slow. More than should be expected
+        // https://github.com/cartant/eslint-plugin-etc/issues/10#issuecomment-1618450905
+        "etc/no-deprecated": "off",
+        "etc/no-internal": "off",
+        // See https://github.com/cartant/eslint-plugin-etc/issues/45#issuecomment-1137305254
+        "etc/prefer-interface": "off",
 
         /*
          * Overrides of base Javascript rules
@@ -144,6 +123,9 @@ module.exports = {
         // Obsoleted by @typescript-eslint/prefer-string-starts-ends-with
         "unicorn/prefer-string-starts-ends-with": "off",
 
+        // Redundant with @typescript-eslint/switch-exhaustiveness-check
+        // and conflicts with unicorn/no-useless-switch-case
+        "default-case": "off",
         // Using simple-import-sort instead
         "sort-imports": "off",
         // Not usable with typescript anyway
@@ -176,12 +158,6 @@ module.exports = {
             "ignoreClassesThatImplementAnInterface": true
           }
         ],
-        // Is default, just expicitly setting it to contrast
-        // no-autofix/@typescript-eslint/consistent-type-assertions in extra-strict
-        "@typescript-eslint/consistent-type-assertions": [
-          "error",
-          { "assertionStyle": "as", "objectLiteralTypeAssertions": "allow" }
-        ],
         // Prefer "noImplicitReturns": true in tsconfig.json
         "@typescript-eslint/consistent-return": "off",
         "@typescript-eslint/no-deprecated": "warn",
@@ -367,18 +343,6 @@ module.exports = {
           { "ignoreDifferentlyNamedParameters": true }
         ],
 
-        ...isPreCommitCI // Missing types lead to false-positives
-          // TODO: Under pre-commit.ci, consider extending
-          // https://typescript-eslint.io/users/configs/#disable-type-checked
-          ? {
-            "@typescript-eslint/no-redundant-type-constituents": "off",
-            "@typescript-eslint/no-unsafe-argument": "off",
-            "@typescript-eslint/no-unsafe-member-access": "off",
-            "@typescript-eslint/no-unsafe-return": "off",
-            "@typescript-eslint/prefer-optional-chain": "off"
-          }
-          : {},
-
         /*
          * @typescript-eslint rules that require strictNullChecks
          * These requires stricter tsconfig or fails.
@@ -387,9 +351,7 @@ module.exports = {
         // Setting allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing makes this rule useless on
         // null/undefined checks. So only set it in non-strict preset.
         "@typescript-eslint/no-unnecessary-condition": [
-          isPreCommitCI
-            ? "off" // Missing types lead to false-positives
-            : "error",
+          "error",
           { "allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing": true }
         ],
         // IDEM, but fully useless w/o strictNullChecks