eslint-config-beslogic 2.4.6 → 2.4.8

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 2.4.8
+
+Go back to explicit `@typescript-eslint/parser` and `@typescript-eslint/eslint-plugin` dependencies instead of `typescript-eslint` due to <https://github.com/danielnixon/eslint-plugin-total-functions/issues/477#issuecomment-2327088201>.
+
+## 2.4.7
+
+- No longer recommending to explicitely annotate void returning awaitable arrow functions as `(param): void => { statement }` in JavaScript.
+
 ## 2.4.6
 
 - Replaced `@typescript-eslint/*` with `typescript-eslint`

package/javascript.js

@@ -31,12 +31,6 @@ const noRestrictedSyntax = [
     "message":
       "Prefer `Promise.resolve().then()` instead of `setTimeout` without a specified delay. " +
       "See: https://developer.mozilla.org/en-US/docs/Web/API/setTimeout#reasons_for_delays_longer_than_specified and https://angular.io/guide/change-detection-zone-pollution"
-  },
-  {
-    "selector":
-      "ArrowFunctionExpression[body.body.length=1][body.body.0.type=\"ExpressionStatement\"]:not([returnType.typeAnnotation.type=\"TSVoidKeyword\"])",
-    "message": "Consider removing braces around the arrow function's body. " +
-      "If it really needs to return `void` you can mark its return type explicitely with `(param): void => { statement }` to disable this warning."
   }
 ]
 

package/lib/utils.js

@@ -1,4 +1,4 @@
-// const isPreCommitCI = __dirname.startsWith("/pc/clone/")
+// TEST const isPreCommitCI = __dirname.startsWith("/pc/clone/")
 // console.log(__dirname)
 // console.log(__filename)
 
@@ -23,10 +23,10 @@ const getModuleVersion = (
 
 const resolveModuleLocation = (/** @type {string} */ nodeModule) => {
   try {
-    // console.log(__dirname)
-    // console.log(__filename)
     const resolved = require.resolve(nodeModule)
     // DEBUG: console.log(resolved)
+    console.log(resolved)
+    console.log(resolved.startsWith("/pc/clone/"))
     if (resolved.startsWith("/pc/clone/")) {
       // Assume it's omitted from the pre-commit.ci run
       return false
@@ -86,7 +86,6 @@ const idLenghtConfig = {
 module.exports = {
   getModuleVersion,
   idLenghtConfig,
-  // isPreCommitCI,
   jestFilePatterns,
   jestNoRestrictedSyntax,
   resolveModuleLocation

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "2.4.6",
+  "version": "2.4.8",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",
@@ -39,9 +39,12 @@
   "author": "Samuel Therrien <samuel.therrien@beslogic.com>",
   "license": "MIT",
   "// @babel/eslint-parser": "Bumped json5 to fix prototype Pollution in minimist <1.2.6",
+  "// typescript-eslint": "Can't use the proxy package because of total-functions: https://github.com/danielnixon/eslint-plugin-total-functions/issues/477#issuecomment-2327088201",
   "dependencies": {
     "@babel/eslint-parser": "^7.20.12",
     "@eslint-community/eslint-plugin-eslint-comments": "^4.1",
+    "@typescript-eslint/eslint-plugin": "^7.4",
+    "@typescript-eslint/parser": "^7.4",
     "confusing-browser-globals": "^1.0",
     "dprint": "^0.40.2",
     "eslint": "^8.56",
@@ -60,8 +63,7 @@
     "eslint-plugin-sonarjs": "^1.0",
     "eslint-plugin-testing-library": "^6.0",
     "eslint-plugin-unicorn": ">=49.0",
-    "eslint-plugin-unused-imports": "^3.2",
-    "typescript-eslint": "^7.4"
+    "eslint-plugin-unused-imports": "^3.2"
   },
   "// eslint-plugin-total-functions": "Supported version is dictated by TypeScript and ESLint",
   "// (cont)": "Also made optional because of extra strictness",

package/typescript.js

@@ -12,6 +12,12 @@ const hasTotalFunctions = !!resolveModuleLocation("eslint-plugin-total-functions
 const commaDangleDefault = "always-multiline"
 const noRestrictedSyntax = [
   ...javascriptConfig.rules?.["no-restricted-syntax"] ?? {},
+  {
+    "selector":
+      "ArrowFunctionExpression[body.body.length=1][body.body.0.type=\"ExpressionStatement\"]:not([returnType.typeAnnotation.type=\"TSVoidKeyword\"])",
+    "message": "Consider removing braces around the arrow function's body. " +
+      "If it really needs to return `void` you can mark its return type explicitely with `(param): void => { statement }` to disable this warning."
+  },
   // @typescript-eslint won't make this a rule
   // https://github.com/typescript-eslint/typescript-eslint/issues/4247
   {