eslint-config-beslogic 2.4.5 → 2.4.7

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 2.4.7
+
+- No longer recommending to explicitely annotate void returning awaitable arrow functions as `(param): void => { statement }` in JavaScript.
+
+## 2.4.6
+
+- Replaced `@typescript-eslint/*` with `typescript-eslint`
+- Loosened rules requirering `strictNullChecks` if `eslint-plugin-total-functions` isn't also installed
+
 ## 2.4.5
 
 - Include documentation about usage with `.pre-commit-config.yaml`/`pre-commit.ci`
@@ -15,6 +24,7 @@
 - Moved `eslint-plugin-testing-library` to `dependencies`
 - Bumped `eslint-plugin-unused-imports` to `^3.2.0` to fix error with `@typescript-eslint@7.8`
 - Don't check for camelcase properties in eslint config files
+- Turn on `prefer-arrow/prefer-arrow-functions` autofixing for `singleReturnOnly`
 
 ## 2.3.2
 

package/angular.js

@@ -77,7 +77,9 @@ module.exports = {
   "overrides": [
     {
       "files": ["*.html"],
-      "plugins": hasNoAutofix ? ["no-autofix"] : [],
+      "plugins": hasNoAutofix
+        ? ["no-autofix"]
+        : [],
       "extends": ["plugin:@angular-eslint/template/all"],
       "rules": {
         "@angular-eslint/template/click-events-have-key-events": "off",

package/javascript.js

@@ -31,12 +31,6 @@ const noRestrictedSyntax = [
     "message":
       "Prefer `Promise.resolve().then()` instead of `setTimeout` without a specified delay. " +
       "See: https://developer.mozilla.org/en-US/docs/Web/API/setTimeout#reasons_for_delays_longer_than_specified and https://angular.io/guide/change-detection-zone-pollution"
-  },
-  {
-    "selector":
-      "ArrowFunctionExpression[body.body.length=1][body.body.0.type=\"ExpressionStatement\"]:not([returnType.typeAnnotation.type=\"TSVoidKeyword\"])",
-    "message": "Consider removing braces around the arrow function's body. " +
-      "If it really needs to return `void` you can mark its return type explicitely with `(param): void => { statement }` to disable this warning."
   }
 ]
 
@@ -44,7 +38,9 @@ const noRestrictedSyntax = [
 module.exports = {
   "plugins": [
     "extra-rules",
-    ...hasNoAutofix ? ["no-autofix"] : [],
+    ...hasNoAutofix
+      ? ["no-autofix"]
+      : [],
     "prefer-arrow",
     "simple-import-sort",
     "no-relative-import-paths",

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "2.4.5",
+  "version": "2.4.7",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",
   "scripts": {
-    "eslint": "eslint ./ --ignore-path .gitignore",
+    "eslint": "set TIMING=1 && eslint ./ --ignore-path .gitignore",
     "lint": "node ./node_modules/dprint/bin check && npm run eslint",
     "lint:fix": "node ./node_modules/dprint/bin fmt && npm run eslint -- --fix",
     "upgrade": "npx npm-check-updates -u & npm i",
@@ -42,7 +42,6 @@
   "dependencies": {
     "@babel/eslint-parser": "^7.20.12",
     "@eslint-community/eslint-plugin-eslint-comments": "^4.1",
-    "@typescript-eslint/eslint-plugin": "^7.4",
     "confusing-browser-globals": "^1.0",
     "dprint": "^0.40.2",
     "eslint": "^8.56",
@@ -61,7 +60,8 @@
     "eslint-plugin-sonarjs": "^1.0",
     "eslint-plugin-testing-library": "^6.0",
     "eslint-plugin-unicorn": ">=49.0",
-    "eslint-plugin-unused-imports": "^3.2"
+    "eslint-plugin-unused-imports": "^3.2",
+    "typescript-eslint": "^7.4"
   },
   "// eslint-plugin-total-functions": "Supported version is dictated by TypeScript and ESLint",
   "// (cont)": "Also made optional because of extra strictness",

package/typescript.js

@@ -12,6 +12,12 @@ const hasTotalFunctions = !!resolveModuleLocation("eslint-plugin-total-functions
 const commaDangleDefault = "always-multiline"
 const noRestrictedSyntax = [
   ...javascriptConfig.rules?.["no-restricted-syntax"] ?? {},
+  {
+    "selector":
+      "ArrowFunctionExpression[body.body.length=1][body.body.0.type=\"ExpressionStatement\"]:not([returnType.typeAnnotation.type=\"TSVoidKeyword\"])",
+    "message": "Consider removing braces around the arrow function's body. " +
+      "If it really needs to return `void` you can mark its return type explicitely with `(param): void => { statement }` to disable this warning."
+  },
   // @typescript-eslint won't make this a rule
   // https://github.com/typescript-eslint/typescript-eslint/issues/4247
   {
@@ -302,10 +308,6 @@ module.exports = {
           }
         ],
         "@typescript-eslint/no-type-alias": "off",
-        "@typescript-eslint/no-unnecessary-condition": [
-          "error",
-          { "allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing": true }
-        ],
         // Note: These 2 drown TS2304 and actually make the errors harder to understand.
         // See: https://github.com/typescript-eslint/typescript-eslint/issues/2665
         // There's nothing we can do until a pedantic any check in TypeScript is added
@@ -313,8 +315,9 @@ module.exports = {
         // Which is likely never gonna happen: https://github.com/microsoft/TypeScript/issues/24737
         // We still want to be aware that we are using an any type and should be cautious
         //
-        // TODO: Turn back no-unsafe-assignment to error after creating and publishing type extensions that replaces any
-        // with unknown in standard libs. See Empassion for example *.d.ts files
+        // TODO: Turn back no-unsafe-assignment to error after creating and publishing type
+        // extensions that replaces any with unknown in standard libs.
+        // See Empassion for example *.d.ts files
         // Refs: https://github.com/Microsoft/TypeScript/issues/26188
         // and https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html
         "@typescript-eslint/no-unsafe-assignment": "warn",
@@ -456,11 +459,6 @@ module.exports = {
             "int32Hint": true
           }
         ],
-        // We accept nullish as falsy
-        "@typescript-eslint/strict-boolean-expressions": [
-          "off",
-          { "allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing": true }
-        ],
         "@typescript-eslint/switch-exhaustiveness-check": [
           "error",
           {
@@ -476,7 +474,24 @@ module.exports = {
         "@typescript-eslint/unified-signatures": [
           "error",
           { "ignoreDifferentlyNamedParameters": true }
-        ]
+        ],
+
+        /*
+         * @typescript-eslint rules that require strictNullChecks
+         * Similar to eslint-plugin-total-functions, these requires stricter tsconfig or fails.
+         */
+        // Setting allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing makes this rule useless on
+        // null/undefined checks. So only set it if we don't already enforce stricter TS configs.
+        "@typescript-eslint/no-unnecessary-condition": [
+          "error",
+          { "allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing": !hasTotalFunctions }
+        ],
+        // IDEM, but fully useless w/o strictNullChecks
+        "@typescript-eslint/prefer-nullish-coalescing": hasTotalFunctions
+          ? "error"
+          : "off",
+        // We accept nullish as falsy
+        "@typescript-eslint/strict-boolean-expressions": "off"
       }
     },
     {