eslint-config-beslogic 2.4.12 → 2.4.13

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 2.4.13
+
+- Made `eslint-import-resolver-typescript` optional since it can't correctly resolve our shared `tsconfig.json` when ran in pre-commit.ci
+
 ## 2.4.12
 
 - Restored `regexp/prefer-d` pre-2.4 behaviour of prefering `/[\d_]/` over `/[0-9_]/`

package/README.md

@@ -85,6 +85,7 @@ As you'll easily bust the 250MiB limit on the free tier, omit the following depe
 
 - `dprint`
 - `@eslint-community/eslint-plugin-eslint-comments`
+- `eslint-import-resolver-typescript`
 - `eslint-plugin-total-functions`
 - `esling-plugin-no-autofix`
 - `eslint-plugin-testing-library`

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "2.4.12",
+  "version": "2.4.13",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",

package/typescript.js

@@ -6,10 +6,14 @@ const { jestNoRestrictedSyntax, jestFilePatterns, resolveModuleLocation, isPreCo
   "./lib/utils"
 )
 
+const hasTotalFunctions = !!resolveModuleLocation("eslint-plugin-total-functions")
 // The only autofix we use is `no-implicit-any-catch` and this is a big module for pre-commit
 // Outside of pre-commit, `eslint-plugin-etc` should NOT be considered optional !
 const hasEtc = !!resolveModuleLocation("eslint-plugin-etc")
-const hasTotalFunctions = !!resolveModuleLocation("eslint-plugin-total-functions")
+// Causes the following error in pre-commit.ci:
+// Resolve error: File 'eslint-config-beslogic/tsconfig.5.0.json' not found.
+// Outside of pre-commit, `eslint-import-resolver-typescript` should NOT be considered optional !
+const hasImportResolverTypescript = !!resolveModuleLocation("eslint-import-resolver-typescript")
 
 const commaDangleDefault = "always-multiline"
 const noRestrictedSyntax = [
@@ -54,31 +58,35 @@ module.exports = {
         ...hasEtc
           ? ["plugin:etc/recommended"]
           : [],
-        "plugin:import/typescript"
+        ...hasImportResolverTypescript
+          ? ["plugin:import/typescript"]
+          : []
       ],
       "env": {
         "es2021": true
       },
       "settings": {
+        ...hasImportResolverTypescript
+          ? {
+            "import/resolver": {
+              "typescript": {
+                // Recommended by eslint-import-resolver-typescript
+                // Always try to resolve types under `<root>@types` directory even it doesn't contain any source code, like `@types/unist`
+                "alwaysTryTypes": true,
+                "project": [
+                  "tsconfig?(.*).json",
+                  "projects/*/tsconfig?(.*).json"
+                ]
+              }
+            }
+          }
+          : {},
         "import/parsers": {
           "@typescript-eslint/parser": [
             ".ts",
             ".tsx"
           ]
         },
-        "import/resolver": {
-          "typescript": {
-            "typescript": {
-              // Recommended by eslint-import-resolver-typescript
-              // Always try to resolve types under `<root>@types` directory even it doesn't contain any source code, like `@types/unist`
-              "alwaysTryTypes": true,
-              "project": [
-                "tsconfig?(.*).json",
-                "projects/*/tsconfig?(.*).json"
-              ]
-            }
-          }
-        },
         // Required even with plugin:import/typescript
         "import/extensions": [
           ".ts",