eslint-config-beslogic 2.3.2 → 2.4.6

package/.vscode/extensions.json

@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: MIT
 // Copyright 2024 Beslogic Inc.
-// Keep in sync with https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Templates/_wiki/wikis/Beslogic-Architecture-Templates.wiki/757/VSCode-settings-and-extensions-(.vscode-.code-workspace)
+// Keep in sync with https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Reference/_wiki/wikis/Beslogic-Architecture-Reference.wiki/757/VSCode-settings-and-extensions-(.vscode-.code-workspace)
 //
 // Please keep in alphabetical order
 {

package/.vscode/settings.json

@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: MIT
 // Copyright 2024 Beslogic Inc.
-// Keep in sync with https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Templates/_wiki/wikis/Beslogic-Architecture-Templates.wiki/757/VSCode-settings-and-extensions-(.vscode-.code-workspace)
+// Keep in sync with https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Reference/_wiki/wikis/Beslogic-Architecture-Reference.wiki/757/VSCode-settings-and-extensions-(.vscode-.code-workspace)
 
 {
   "files.associations": {

package/CHANGELOG.md

@@ -1,8 +1,30 @@
 # Changelog
 
+## 2.4.6
+
+- Replaced `@typescript-eslint/*` with `typescript-eslint`
+- Loosened rules requirering `strictNullChecks` if `eslint-plugin-total-functions` isn't also installed
+
+## 2.4.5
+
+- Include documentation about usage with `.pre-commit-config.yaml`/`pre-commit.ci`
+- Allow omitting `esling-plugin-no-autofix`, `eslint-plugin-jest`, `eslint-plugin-jest-formatting` and `eslint-plugin-etc` for `.pre-commit-config.yaml`/`pre-commit.ci`
+- `pre-commit.ci` run will always assume the following are not installed to save on space:
+  - `eslint-plugin-total-functions`
+  - `esling-plugin-no-autofix`
+  - `eslint-plugin-testing-library`
+  - `eslint-plugin-jest-formatting`
+  - `eslint-plugin-jest`
+  - `eslint-plugin-etc`
+- Moved `eslint-plugin-angular-file-naming` to `optionalDependencies`
+- Moved `eslint-plugin-testing-library` to `dependencies`
+- Bumped `eslint-plugin-unused-imports` to `^3.2.0` to fix error with `@typescript-eslint@7.8`
+- Don't check for camelcase properties in eslint config files
+- Turn on `prefer-arrow/prefer-arrow-functions` autofixing for `singleReturnOnly`
+
 ## 2.3.2
 
-- Added "data-service", "interceptor" and "guard" as valid suffix for `angular-file-naming/service-filename-suffix`.
+- Added "data-service", "interceptor" and "guard" as valid suffix for `angular-file-naming/service-filename-suffix`
 
 ## 2.3.1
 
@@ -32,7 +54,7 @@
   - Check context objects with `react/display-name`
   - Added React 18 deprecations
 - Remove accidental recommendation to install `eslint-plugn-react-redux` from non-redux presets in `README.md`
-- Now enforce at least 1 newline after imports even with dprint preset.
+- Now enforce at least 1 newline after imports even with dprint preset
 - Turn on `allowImplicit`, `checkForEach`, and `allowVoid` for rule `array-callback-return`
 - Bumped `eslint-plugin-total-functions` to `>=6.0`
   - which bumps `typescript` dependency to `4.7.3`

package/README.md

@@ -51,7 +51,7 @@ If deploying / bundling with an Angular npm package, also set `angularCompilerOp
 
 ### `.vscode/settings.json` and `.vscode/extensions.json`
 
-<!-- Keep in sync with https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Templates/_wiki/wikis/Beslogic-Architecture-Templates.wiki/757/VSCode-settings-and-extensions-(.vscode-.code-workspace) -->
+<!-- Keep in sync with https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Reference/_wiki/wikis/Beslogic-Architecture-Reference.wiki/757/VSCode-settings-and-extensions-(.vscode-.code-workspace) -->
 
 Read and copy from [VSCode Settings and Extensions](https://socket.dev/npm/package/eslint-config-beslogic/files/latest/.vscode)
 
@@ -73,6 +73,24 @@ If you'd like to pin your config version, you can use a commit hash, like `https
 
 If also using [`beslogic/json-like` preset](#beslogicjson-like) extend from `https://raw.githubusercontent.com/BesLogic/shared-configs/main/dprint-json-like.json` instead.
 
+### Usage with `pre-commit.ci` (`.pre-commit-config.yaml`)
+
+Use the following hook: <https://github.com/pre-commit/mirrors-eslint>
+
+Set `args: [--fix, --quiet]`.
+
+In the `additional_dependencies` field, you'll need to include _all_ the plugins we use (copy this project's `dependencies` in `package.json`), as well as the optional plugins you need for yor presets.
+
+As you'll easily bust the 250MiB limit on the free tier, omit the following dependencies as they're special-cased to always be ignored on `pre-commit.ci` anyway:
+
+- `dprint`
+- `eslint-plugin-total-functions`
+- `esling-plugin-no-autofix`
+- `eslint-plugin-testing-library`
+- `eslint-plugin-jest-formatting`
+- `eslint-plugin-jest`
+- `eslint-plugin-etc`
+
 ## Patched packages
 
 The following packages cause problems or have other type-safety issues that are automatically patched out by `eslint-config-beslogic` on install. To see the complete logs, add `foreground-scripts=true` to a root `.npmrc` file, or run `npm install` with `--foreground-scripts`.

package/angular.js

@@ -1,10 +1,16 @@
 // SPDX-License-Identifier: MIT
 // Copyright 2024 Beslogic Inc.
 
-const { getModuleVersion, jestNoRestrictedSyntax, jestFilePatterns } = require("./lib/utils")
+const { getModuleVersion, jestNoRestrictedSyntax, jestFilePatterns, resolveModuleLocation } =
+  require("./lib/utils")
 
 const angularEslintVersion = getModuleVersion("@angular-eslint/eslint-plugin", 16.2)
 const typescriptVersion = getModuleVersion("typescript", 4.7)
+const hasTestingLibrary = !!resolveModuleLocation("eslint-plugin-testing-library")
+// eslint-plugin-no-autofix is broken when run through pre-commit
+// https://github.com/aladdin-add/eslint-plugin/issues/98
+// Even if it gets fixed, `no-autofix` rules necessarily don't provide fixes anyway
+const hasNoAutofix = !!resolveModuleLocation("eslint-plugin-no-autofix")
 
 const javascriptConfig = require("./javascript")
 const typescriptConfig = require("./typescript")
@@ -71,7 +77,9 @@ module.exports = {
   "overrides": [
     {
       "files": ["*.html"],
-      "plugins": ["no-autofix"],
+      "plugins": hasNoAutofix
+        ? ["no-autofix"]
+        : [],
       "extends": ["plugin:@angular-eslint/template/all"],
       "rules": {
         "@angular-eslint/template/click-events-have-key-events": "off",
@@ -113,7 +121,9 @@ module.exports = {
         "@angular-eslint/template/i18n": "off",
         "no-autofix/@angular-eslint/template/i18n": [
           // Too many TODO and needs per-project extensions to justify this as "error"
-          "warn",
+          hasNoAutofix
+            ? "warn"
+            : "off",
           {
             // NOTE: doesn't work for text elements.
             // See: https://github.com/angular-eslint/angular-eslint/issues/999
@@ -363,7 +373,9 @@ module.exports = {
     },
     {
       "files": jestFilePatterns,
-      "extends": ["plugin:testing-library/angular"],
+      "extends": hasTestingLibrary
+        ? ["plugin:testing-library/angular"]
+        : [],
       "rules": { "no-restricted-syntax": jestNoRestrictedSyntax(noRestrictedSyntax) }
     },
     {

package/javascript.js

@@ -2,36 +2,20 @@
 // Copyright 2024 Beslogic Inc.
 
 const restrictedGlobals = require("confusing-browser-globals")
-const { jestNoRestrictedSyntax, jestFilePatterns } = require("./lib/utils")
+const { jestNoRestrictedSyntax, jestFilePatterns, resolveModuleLocation, idLenghtConfig } = require(
+  "./lib/utils"
+)
+
+// The only autofix we use is `no-implicit-any-catch` and this is a big module for pre-commit
+// Outside of pre-commit, `eslint-plugin-etc` should NOT be considered optional !
+const hasEtc = !!resolveModuleLocation("eslint-plugin-etc")
+// eslint-plugin-no-autofix is broken when run through pre-commit
+// https://github.com/aladdin-add/eslint-plugin/issues/98
+// Even if it gets fixed, `no-autofix` rules necessarily don't provide fixes anyway
+const hasNoAutofix = !!resolveModuleLocation("eslint-plugin-no-autofix")
 
 const commaDangleDefault = "always-multiline"
-const idLenghtConfig = {
-  "min": 3,
-  "max": 32,
-  "properties": "never",
-  "exceptionPatterns": [
-    // Unused result
-    "__?",
-    // Comparison and Iterations
-    "[a-bi-k]"
-  ],
-  "exceptions": [
-    "id",
-    "fn",
-    "to",
-    "TO",
-    // Matches
-    "or",
-    "OR",
-    "on",
-    // Date formats
-    "dd",
-    "mm",
-    "yy",
-    // HTTP status codes
-    "OK"
-  ]
-}
+
 const noRestrictedSyntax = [
   "error",
   "WithStatement",
@@ -60,12 +44,16 @@ const noRestrictedSyntax = [
 module.exports = {
   "plugins": [
     "extra-rules",
-    "no-autofix",
+    ...hasNoAutofix
+      ? ["no-autofix"]
+      : [],
     "prefer-arrow",
     "simple-import-sort",
     "no-relative-import-paths",
     "unused-imports",
-    "etc"
+    ...hasEtc
+      ? ["etc"]
+      : []
   ],
   "extends": [
     "eslint:recommended",
@@ -345,7 +333,9 @@ module.exports = {
         ],
         // Using this to completely disallow all console calls except info, warn, error
         "no-autofix/no-console": [
-          "error",
+          hasNoAutofix
+            ? "error"
+            : "off",
           {
             "allow": [
               "info",
@@ -394,6 +384,11 @@ module.exports = {
       // "extends": ["./json-like"]
       "globals": { "module": true },
       "rules": {
+        // We don't have control on keys names
+        "camelcase": [
+          "error",
+          { "properties": "never" }
+        ],
         // Keep consistent with preset rules
         "unicorn/prefer-string-raw": "off"
       }
@@ -452,7 +447,9 @@ module.exports = {
 
     // Extracted restricted import into its own rule so it's easier for projects to override/ignore
     "no-autofix/no-relative-import-paths/no-relative-import-paths": [
-      "error",
+      hasNoAutofix
+        ? "error"
+        : "off",
       {
         "allowSameFolder": true
       }
@@ -464,7 +461,9 @@ module.exports = {
     // Loosing imports when commenting to test is extremely annoying and slow,
     // so we only use this rule when ran from the command-line
     // no-autofix/unused-imports/no-unused-imports is redundant with no-unused-vars and and eslint.codeActionsOnSave.rules
-    "unused-imports/no-unused-imports": "warn",
+    "unused-imports/no-unused-imports": hasNoAutofix
+      ? "warn"
+      : "off",
 
     // unicorn/all overrides (https://github.com/sindresorhus/eslint-plugin-unicorn#rules)
     "unicorn/catch-error-name": [
@@ -569,7 +568,9 @@ module.exports = {
     /*
      *  Cartant's etc rules
      */
-    "etc/no-commented-out-code": "error",
+    "etc/no-commented-out-code": hasEtc
+      ? "error"
+      : "off",
 
     /*
      *  Simple import rules
@@ -599,12 +600,25 @@ module.exports = {
     /*
      *  Prefer Arrow rule
      */
+    // Autofixing is only applied when only checking for `singleReturnOnly: true`
+    // but we still want to check for other cases
+    "no-autofix/prefer-arrow/prefer-arrow-functions": [
+      hasNoAutofix
+        ? "error"
+        : "off",
+      {
+        "classPropertiesAllowed": true,
+        "disallowPrototype": true,
+        "singleReturnOnly": false,
+        "allowStandaloneDeclarations": false
+      }
+    ],
     "prefer-arrow/prefer-arrow-functions": [
       "error",
       {
         "classPropertiesAllowed": true,
         "disallowPrototype": true,
-        "singleReturnOnly": false,
+        "singleReturnOnly": true,
         "allowStandaloneDeclarations": false
       }
     ],
@@ -668,7 +682,9 @@ module.exports = {
     // HACK: Workaround for coordinates objects
     // TODO: Should be using rule composition instead
     "no-autofix/id-length": [
-      "error",
+      hasNoAutofix
+        ? "error"
+        : "off",
       idLenghtConfig
     ],
     "id-length": [

package/jest.js

@@ -1,22 +1,38 @@
 // SPDX-License-Identifier: MIT
 // Copyright 2024 Beslogic Inc.
-const { getModuleVersion } = require("./lib/utils")
+const { getModuleVersion, resolveModuleLocation } = require("./lib/utils")
 
 const jestGlobalsVersion = getModuleVersion("@jest/globals", 29)
+// These are big modules for pre-commit.
+// Outside of pre-commit, these should NOT be considered optional !
+const hasTestingLibrary = !!resolveModuleLocation("eslint-plugin-testing-library")
+const hasJestFormatting = !!resolveModuleLocation("eslint-plugin-jest-formatting")
+const hasJest = !!resolveModuleLocation("eslint-plugin-jest")
 
 /** @type {import("eslint").Linter.Config} */
 module.exports = {
   "extends": [
-    "plugin:jest/all",
-    "plugin:jest-formatting/strict",
+    ...hasJest
+      ? ["plugin:jest/all"]
+      : [],
+    ...hasJestFormatting
+      ? ["plugin:jest-formatting/strict"]
+      : [],
     // Note: The DOM preset includes some rules not in Marko or Vue (eg.: no-await-sync-events).
     // Those must be disabled in their preset if we ever support them.
-    "plugin:testing-library/dom"
+    ...hasTestingLibrary
+      ? ["plugin:testing-library/dom"]
+      : []
   ],
   "env": {
     "browser": false,
     "jest": true,
-    "jest/globals": true
+    ...hasJest
+      ? {
+        // Setting to `false` is not enough: Environment key "jest/globals" is unknown
+        "jest/globals": true
+      }
+      : {}
   },
   "overrides": [
     {
@@ -62,40 +78,52 @@ module.exports = {
       "error",
       { "threshold": 8 }
     ],
-    // Doesn't print well with testing-library's `findBy` and `waitFor`
-    "jest/prefer-expect-resolves": "off",
-    // May lead to accidentally missed expects
-    "jest/prefer-expect-assertions": [
-      "error",
-      {
-        "onlyFunctionsWithExpectInCallback": true,
-        "onlyFunctionsWithExpectInLoop": true
-      }
-    ],
-    // https://github.com/jestjs/jest/issues/15084
-    // Since this will require a major jest version bump anyway,
-    // I feel confortable not waiting for our own major version bump to add this
-    ...(jestGlobalsVersion < 30
-      ? { "jest/prefer-importing-jest-globals": "off" }
-      : {}),
-    // Top-level describe is often used for component name, which is capitalized
-    "jest/prefer-lowercase-title": [
-      "error",
-      { "ignoreTopLevelDescribe": true }
-    ],
-    // Allow clearing mocks in beforeEach
-    "jest/no-hooks": [
-      "error",
-      {
-        "allow": ["beforeEach"]
+
+    /*
+     * jest/all overrides (https://github.com/jest-community/eslint-plugin-jest#rules)
+     */
+    ...hasJest
+      ? {
+        // Doesn't print well with testing-library's `findBy` and `waitFor`
+        "jest/prefer-expect-resolves": "off",
+        // May lead to accidentally missed expects
+        "jest/prefer-expect-assertions": [
+          "error",
+          {
+            "onlyFunctionsWithExpectInCallback": true,
+            "onlyFunctionsWithExpectInLoop": true
+          }
+        ],
+        // https://github.com/jestjs/jest/issues/15084
+        // Since this will require a major jest version bump anyway,
+        // I feel confortable not waiting for our own major version bump to add this
+        ...jestGlobalsVersion < 30
+          ? { "jest/prefer-importing-jest-globals": "off" }
+          : {},
+        // Top-level describe is often used for component name, which is capitalized
+        "jest/prefer-lowercase-title": [
+          "error",
+          { "ignoreTopLevelDescribe": true }
+        ],
+        // Allow clearing mocks in beforeEach
+        "jest/no-hooks": [
+          "error",
+          {
+            "allow": ["beforeEach"]
+          }
+        ]
       }
-    ],
+      : {},
 
     /*
      * testing-library overrides (https://github.com/testing-library/eslint-plugin-testing-library#supported-rules)
      */
-    "testing-library/no-debugging-utils": "error",
-    "testing-library/prefer-user-event": "warn",
-    "testing-library/prefer-explicit-assert": "error"
+    ...hasTestingLibrary
+      ? {
+        "testing-library/no-debugging-utils": "error",
+        "testing-library/prefer-user-event": "warn",
+        "testing-library/prefer-explicit-assert": "error"
+      }
+      : {}
   }
 }

package/lib/utils.js

@@ -1,3 +1,7 @@
+// const isPreCommitCI = __dirname.startsWith("/pc/clone/")
+// console.log(__dirname)
+// console.log(__filename)
+
 const getModuleVersion = (
   /** @type {string} */ nodeModule,
   /** @type {number} */ fallbackVersion
@@ -19,7 +23,16 @@ const getModuleVersion = (
 
 const resolveModuleLocation = (/** @type {string} */ nodeModule) => {
   try {
-    return require.resolve(nodeModule)
+    // console.log(__dirname)
+    // console.log(__filename)
+    const resolved = require.resolve(nodeModule)
+    // DEBUG: console.log(resolved)
+    if (resolved.startsWith("/pc/clone/")) {
+      // Assume it's omitted from the pre-commit.ci run
+      return false
+    }
+
+    return resolved
   } catch {
     return false
   }
@@ -42,9 +55,39 @@ const jestFilePatterns = [
   "**/?(*.)+(spec|test).[jt]s?(x)"
 ]
 
+const idLenghtConfig = {
+  "min": 3,
+  "max": 32,
+  "properties": "never",
+  "exceptionPatterns": [
+    // Unused result
+    "__?",
+    // Comparison and Iterations
+    "[a-bi-k]"
+  ],
+  "exceptions": [
+    "id",
+    "fn",
+    "to",
+    "TO",
+    // Matches
+    "or",
+    "OR",
+    "on",
+    // Date formats
+    "dd",
+    "mm",
+    "yy",
+    // HTTP status codes
+    "OK"
+  ]
+}
+
 module.exports = {
   getModuleVersion,
+  idLenghtConfig,
+  // isPreCommitCI,
+  jestFilePatterns,
   jestNoRestrictedSyntax,
-  resolveModuleLocation,
-  jestFilePatterns
+  resolveModuleLocation
 }

package/mui.js

@@ -1,10 +1,9 @@
 // SPDX-License-Identifier: MIT
 // Copyright 2024 Beslogic Inc.
 
-const javascriptConfig = require("./javascript")
 const typeScriptConfig = require("./typescript")
+const { idLenghtConfig } = require("./lib/utils")
 
-const idLenghtConfig = javascriptConfig.rules?.["no-autofix/id-length"]?.[1]
 const noMagicNumbersConfig = typeScriptConfig.overrides?.[0].rules
   ?.["@typescript-eslint/no-magic-numbers"]?.[1]
 

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "2.3.2",
+  "version": "2.4.6",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",
   "scripts": {
-    "eslint": "eslint ./ --ignore-path .gitignore",
+    "eslint": "set TIMING=1 && eslint ./ --ignore-path .gitignore",
     "lint": "node ./node_modules/dprint/bin check && npm run eslint",
     "lint:fix": "node ./node_modules/dprint/bin fmt && npm run eslint -- --fix",
     "upgrade": "npx npm-check-updates -u & npm i",
@@ -42,12 +42,10 @@
   "dependencies": {
     "@babel/eslint-parser": "^7.20.12",
     "@eslint-community/eslint-plugin-eslint-comments": "^4.1",
-    "@typescript-eslint/eslint-plugin": "^7.4",
     "confusing-browser-globals": "^1.0",
     "dprint": "^0.40.2",
     "eslint": "^8.56",
     "eslint-import-resolver-typescript": "^3.2.6",
-    "eslint-plugin-angular-file-naming": "^1.0.6",
     "eslint-plugin-autofix": "^1.1 || ^2.0",
     "eslint-plugin-etc": "^2.0",
     "eslint-plugin-extra-rules": "^0.0.0-development",
@@ -60,8 +58,10 @@
     "eslint-plugin-regexp": "^2.0",
     "eslint-plugin-simple-import-sort": ">=12.0",
     "eslint-plugin-sonarjs": "^1.0",
+    "eslint-plugin-testing-library": "^6.0",
     "eslint-plugin-unicorn": ">=49.0",
-    "eslint-plugin-unused-imports": "^3.0"
+    "eslint-plugin-unused-imports": "^3.2",
+    "typescript-eslint": "^7.4"
   },
   "// eslint-plugin-total-functions": "Supported version is dictated by TypeScript and ESLint",
   "// (cont)": "Also made optional because of extra strictness",
@@ -69,6 +69,7 @@
     "@angular-eslint/eslint-plugin": ">=16.2",
     "@angular-eslint/eslint-plugin-template": ">=16.2",
     "@angular-eslint/template-parser": ">=16.2",
+    "eslint-plugin-angular-file-naming": "^1.0.6",
     "eslint-plugin-jsx-a11y": "^6.7.1",
     "eslint-plugin-mui": "^0.1.1",
     "eslint-plugin-n": ">=17.0",
@@ -79,7 +80,6 @@
     "eslint-plugin-rxjs": "^5.0.3",
     "eslint-plugin-rxjs-angular": "github:BesLogic/eslint-plugin-rxjs-angular#dist",
     "eslint-plugin-storybook": "^0.6.10",
-    "eslint-plugin-testing-library": "^6.0",
     "eslint-plugin-total-functions": ">=6.0"
   },
   "// plugins": "Test against highest supported version to catch new breaking changes",

package/react.js

@@ -3,6 +3,9 @@
 
 const javascriptConfig = require("./javascript")
 const typescriptConfig = require("./typescript")
+const { jestFilePatterns, resolveModuleLocation } = require("./lib/utils")
+
+const hasTestingLibrary = !!resolveModuleLocation("eslint-plugin-testing-library")
 
 const typeDefinitionOverride = typescriptConfig.overrides?.find(override =>
   override.files === "*.d.ts"
@@ -17,8 +20,6 @@ preventAbbreviationsConfig.allowList.Props = true
 preventAbbreviationsConfig.allowList.ref = true
 preventAbbreviationsConfig.allowList.Ref = true
 
-const { jestFilePatterns } = require("./lib/utils")
-
 /** @type {import("eslint").Linter.Config} */
 module.exports = {
   "extends": [
@@ -92,7 +93,9 @@ module.exports = {
     },
     {
       "files": jestFilePatterns,
-      "extends": ["plugin:testing-library/react"]
+      "extends": hasTestingLibrary
+        ? ["plugin:testing-library/react"]
+        : []
     },
     typeDefinitionOverride
   ],

package/typescript.js

@@ -2,8 +2,12 @@
 // Copyright 2024 Beslogic Inc.
 
 const javascriptConfig = require("./javascript")
-const { jestNoRestrictedSyntax, jestFilePatterns } = require("./lib/utils")
-const { resolveModuleLocation } = require("./lib/utils")
+const { jestNoRestrictedSyntax, jestFilePatterns, resolveModuleLocation } = require("./lib/utils")
+
+// The only autofix we use is `no-implicit-any-catch` and this is a big module for pre-commit
+// Outside of pre-commit, `eslint-plugin-etc` should NOT be considered optional !
+const hasEtc = !!resolveModuleLocation("eslint-plugin-etc")
+const hasTotalFunctions = !!resolveModuleLocation("eslint-plugin-total-functions")
 
 const commaDangleDefault = "always-multiline"
 const noRestrictedSyntax = [
@@ -23,8 +27,6 @@ const paddingLineBetweenStatementsConfig = javascriptConfig
   ?.find(override => override.extends === "plugin:autofix/all")
   ?.rules?.["autofix/padding-line-between-statements"]
 
-const hasTotalFunctions = !!resolveModuleLocation("eslint-plugin-total-functions")
-
 /** @type {import("eslint").Linter.Config} */
 module.exports = {
   "overrides": [
@@ -41,7 +43,9 @@ module.exports = {
         ...hasTotalFunctions
           ? ["plugin:total-functions/recommended"]
           : [],
-        "plugin:etc/recommended",
+        ...hasEtc
+          ? ["plugin:etc/recommended"]
+          : [],
         "plugin:import/typescript"
       ],
       "env": {
@@ -106,7 +110,7 @@ module.exports = {
         "total-functions/no-enums": "off",
         // It takes an advanced TypeScript user to fully make sense of this rule
         /**
-         * (copied from https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Templates/_wiki/wikis/Beslogic-Architecture-Templates.wiki/656/Frontend-linting-and-formatting?anchor=total-functions/no-unsafe-type-assertion)
+         * (copied from https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Reference/_wiki/wikis/Beslogic-Architecture-Reference.wiki/656/Frontend-linting-and-formatting?anchor=total-functions/no-unsafe-type-assertion)
          * It can sometimes be hard to make sense of this rule, but let's be strict!
          * Tips:
          * - Prefer coercion over assertion: `String(value ?? '')` over `value as string | null`
@@ -135,15 +139,21 @@ module.exports = {
         /*
          * Cartant's etc rules
          */
-        "etc/no-const-enum": "error",
-        // Same as total-functions/no-enums
-        "etc/no-enum": "warn",
-        "etc/throw-error": "error",
-        "etc/underscore-internal": "error",
-        // These two are extremely slow. More than should be expected
-        // https://github.com/cartant/eslint-plugin-etc/issues/10#issuecomment-1618450905
-        "etc/no-deprecated": "off",
-        "etc/no-internal": "off",
+        ...hasEtc
+          ? {
+            "etc/no-const-enum": "error",
+            // Same as total-functions/no-enums
+            "etc/no-enum": "warn",
+            "etc/throw-error": "error",
+            "etc/underscore-internal": "error",
+            // These two are extremely slow. More than should be expected
+            // https://github.com/cartant/eslint-plugin-etc/issues/10#issuecomment-1618450905
+            "etc/no-deprecated": "off",
+            "etc/no-internal": "off",
+            // See https://github.com/cartant/eslint-plugin-etc/issues/45#issuecomment-1137305254
+            "etc/prefer-interface": "off"
+          }
+          : {},
 
         /*
          * Overrides of base Javascript rules
@@ -292,10 +302,6 @@ module.exports = {
           }
         ],
         "@typescript-eslint/no-type-alias": "off",
-        "@typescript-eslint/no-unnecessary-condition": [
-          "error",
-          { "allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing": true }
-        ],
         // Note: These 2 drown TS2304 and actually make the errors harder to understand.
         // See: https://github.com/typescript-eslint/typescript-eslint/issues/2665
         // There's nothing we can do until a pedantic any check in TypeScript is added
@@ -303,8 +309,9 @@ module.exports = {
         // Which is likely never gonna happen: https://github.com/microsoft/TypeScript/issues/24737
         // We still want to be aware that we are using an any type and should be cautious
         //
-        // TODO: Turn back no-unsafe-assignment to error after creating and publishing type extensions that replaces any
-        // with unknown in standard libs. See Empassion for example *.d.ts files
+        // TODO: Turn back no-unsafe-assignment to error after creating and publishing type
+        // extensions that replaces any with unknown in standard libs.
+        // See Empassion for example *.d.ts files
         // Refs: https://github.com/Microsoft/TypeScript/issues/26188
         // and https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html
         "@typescript-eslint/no-unsafe-assignment": "warn",
@@ -446,8 +453,6 @@ module.exports = {
             "int32Hint": true
           }
         ],
-        // We accept nullish as falsy
-        "@typescript-eslint/strict-boolean-expressions": "off",
         "@typescript-eslint/switch-exhaustiveness-check": [
           "error",
           {
@@ -463,7 +468,24 @@ module.exports = {
         "@typescript-eslint/unified-signatures": [
           "error",
           { "ignoreDifferentlyNamedParameters": true }
-        ]
+        ],
+
+        /*
+         * @typescript-eslint rules that require strictNullChecks
+         * Similar to eslint-plugin-total-functions, these requires stricter tsconfig or fails.
+         */
+        // Setting allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing makes this rule useless on
+        // null/undefined checks. So only set it if we don't already enforce stricter TS configs.
+        "@typescript-eslint/no-unnecessary-condition": [
+          "error",
+          { "allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing": !hasTotalFunctions }
+        ],
+        // IDEM, but fully useless w/o strictNullChecks
+        "@typescript-eslint/prefer-nullish-coalescing": hasTotalFunctions
+          ? "error"
+          : "off",
+        // We accept nullish as falsy
+        "@typescript-eslint/strict-boolean-expressions": "off"
       }
     },
     {

package/.azuredevops/pull_request_template.md

@@ -1,16 +0,0 @@
-Thank you for your contribution to Beslogic's **ESLint-Config-Beslogic** repo.
-Before submitting this PR, please make sure:
-
-- [ ] The project is building
-- [ ] There are no linting issues
-- [ ] You updated the projects' README.md and CHANGELOG.md with the new changes
-- [ ] You reviewed your own PR and made sure there's no test/debug code or any obvious mistakes.
-- [ ] You set and configured auto-complete to "Complete associated work items after merging" & "Delete \<branch> after merging".
-- [ ] You cleaned up your commit history or set the PR Merge type to "Squash".
-
-Make sure that the code wasn't copied from elsewhere (check one):
-
-- [ ] This is your own original code
-- [ ] You have made sure that we have permission to use the copied code and that we follow its licensing
-
-_Add a short description_

package/.gitignore.npmignore

@@ -1 +0,0 @@
-static-tests