eslint-config-beslogic 2.3.0 → 2.3.2

package/.gitignore.npmignore

@@ -0,0 +1 @@
+static-tests

package/CHANGELOG.md

@@ -1,6 +1,18 @@
 # Changelog
 
-## Unreleased
+## 2.3.2
+
+- Added "data-service", "interceptor" and "guard" as valid suffix for `angular-file-naming/service-filename-suffix`.
+
+## 2.3.1
+
+- Fixed the following error when parsing `typescript` config:
+  `Configuration for rule "@typescript-eslint/prefer-string-starts-ends-with" is invalid: Value true should be string.`
+- Added `no-restricted-syntax` rules to ensure that Angular optional dependencies are marked as optional in TypeScript and vice-versa
+- Fixed Storybook custom `.ts` configuration not being applied
+- Disabled `autofix/indent-legacy`
+
+<!-- TODO: Validate that static-tests are not published -->
 
 ## 2.3.0
 

package/angular.js

@@ -31,6 +31,17 @@ const noRestrictedSyntax = [
     "message":
       "Forbidden non-null property assertion. https://typescript-eslint.io/rules/no-non-null-assertion . " +
       "This is only allowed on required component @Input({ required:true }). https://angular.io/api/core/Input#required"
+  },
+  {
+    "selector":
+      "MethodDefinition[key.name=\"constructor\"]:has(TSParameterProperty:has(Decorator[expression.callee.name=\"Optional\"]):not(:has(Identifier[optional=true])))",
+    "message":
+      "Constructor parameter with @Optional decorator should be marked as optional using `?`."
+  },
+  {
+    "selector":
+      "ClassDeclaration:has(Decorator :matches([name=\"Component\"], [name=\"Injectable\"], [name=\"Directive\"], [name=\"Pipe\"])) MethodDefinition[key.name=\"constructor\"]:has(TSParameterProperty:has(Identifier[optional=true]):not(:has(Decorator[expression.callee.name=\"Optional\"])))",
+    "message": "Optional constructor parameter should have @Optional decorator."
   }
 ]
 
@@ -191,7 +202,17 @@ module.exports = {
         "angular-file-naming/directive-filename-suffix": "error",
         "angular-file-naming/module-filename-suffix": "error",
         "angular-file-naming/pipe-filename-suffix": "error",
-        "angular-file-naming/service-filename-suffix": "error",
+        "angular-file-naming/service-filename-suffix": [
+          "error",
+          {
+            "suffixes": [
+              "service",
+              "data-service",
+              "interceptor",
+              "guard"
+            ]
+          }
+        ],
 
         /*
          * rxjs-angular rules

package/javascript.js

@@ -90,7 +90,6 @@ module.exports = {
   "ignorePatterns": ["node_modules/"],
   // Useful when using experimental features and code transpiled by Babel
   "parser": "@babel/eslint-parser",
-  "reportUnusedDisableDirectives": true,
   "overrides": [
     {
       "files": [
@@ -301,6 +300,9 @@ module.exports = {
           }
         ],
 
+        // indent-legacy is deprecated in favor of indent
+        "autofix/indent-legacy": "off",
+
         // Using simple-import-sort instead
         "autofix/sort-imports": "off",
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "2.3.0",
+  "version": "2.3.2",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",
@@ -10,6 +10,7 @@
     "lint:fix": "node ./node_modules/dprint/bin fmt && npm run eslint -- --fix",
     "upgrade": "npx npm-check-updates -u & npm i",
     "yalc": "yalc publish",
+    "prepack": "type .gitignore* > .npmignore",
     "postinstall": "node ./lib/patch-dependencies.js",
     "dependencies": "node ./lib/patch-dependencies.js"
   },
@@ -81,10 +82,17 @@
     "eslint-plugin-testing-library": "^6.0",
     "eslint-plugin-total-functions": ">=6.0"
   },
+  "// plugins": "Test against highest supported version to catch new breaking changes",
   "devDependencies": {
+    "@angular-eslint/eslint-plugin": ">=16.2",
+    "@angular-eslint/eslint-plugin-template": ">=16.2",
+    "@angular-eslint/template-parser": ">=16.2",
+    "@angular/core": ">=16.2",
     "@types/eslint": "^8.37.0",
     "@types/node": "^17.0",
     "eslint-plugin-eslint-plugin": "^4.1",
+    "eslint-plugin-storybook": "^0.6.10",
+    "eslint-plugin-total-functions": ">=6.0",
     "yalc": "^1.0.0-pre.53"
   }
 }

package/storybook.js

@@ -13,7 +13,7 @@ module.exports = {
   ],
   "overrides": [
     {
-      "files": [".ts"],
+      "files": ["*.ts"],
       "rules": {
         "no-restricted-syntax": [
           ...noRestrictedSyntax,

package/typescript.js

@@ -398,7 +398,7 @@ module.exports = {
         "@typescript-eslint/prefer-readonly-parameter-types": "off",
         "@typescript-eslint/prefer-string-starts-ends-with": [
           "error",
-          { "allowSingleElementEquality": true }
+          { "allowSingleElementEquality": "always" }
         ],
         "@typescript-eslint/promise-function-async": [
           "error",