eslint-config-beslogic 2.0.0 → 2.0.2

package/.eslintrc.js

@@ -1,40 +1,40 @@
-// SPDX-License-Identifier: MIT
-// Copyright 2024 Beslogic Inc.
-
-/** @type {import("eslint").Linter.Config} */
-module.exports = {
-  "root": true,
-  "plugins": ["eslint-plugin"],
-  "extends": [
-    "./node-js",
-    "plugin:eslint-plugin/all",
-    "./dprint",
-    "./json-like"
-  ],
-  "parserOptions": {
-    "sourceType": "script"
-  },
-  "rules": {
-    "max-len": "off",
-    "max-lines": "off",
-    // We're a script project, using the console is fine
-    // (same config as in jest)
-    "no-console": [
-      "error",
-      {
-        "allow": [
-          "error",
-          "warn",
-          "info"
-        ]
-      }
-    ],
-    "no-magic-numbers": "off",
-    "unicorn/filename-case": [
-      "error",
-      {
-        "case": "kebabCase"
-      }
-    ]
-  }
-}
+// SPDX-License-Identifier: MIT
+// Copyright 2024 Beslogic Inc.
+
+/** @type {import("eslint").Linter.Config} */
+module.exports = {
+  "root": true,
+  "plugins": ["eslint-plugin"],
+  "extends": [
+    "./node-js",
+    "plugin:eslint-plugin/all",
+    "./dprint",
+    "./json-like"
+  ],
+  "parserOptions": {
+    "sourceType": "script"
+  },
+  "rules": {
+    "max-len": "off",
+    "max-lines": "off",
+    // We're a script project, using the console is fine
+    // (same config as in jest)
+    "no-console": [
+      "error",
+      {
+        "allow": [
+          "error",
+          "warn",
+          "info"
+        ]
+      }
+    ],
+    "no-magic-numbers": "off",
+    "unicorn/filename-case": [
+      "error",
+      {
+        "case": "kebabCase"
+      }
+    ]
+  }
+}

package/.vscode/extensions.json

@@ -1,49 +1,49 @@
-// SPDX-License-Identifier: MIT
-// Copyright 2024 Beslogic Inc.
-// Keep in sync with https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Templates/_wiki/wikis/Beslogic-Architecture-Templates.wiki/757/VSCode-settings-and-extensions-(.vscode-.code-workspace)
-//
-// Please keep in alphabetical order
-{
-  // See https://go.microsoft.com/fwlink/?LinkId=827846 to learn about workspace recommendations.
-  // List of extensions which should be recommended for users of this workspace.
-  // Only keep those used by your specific project
-  "recommendations": [
-    // "angular.ng-template",
-    "davidanson.vscode-markdownlint",
-    "dbaeumer.vscode-eslint",
-    "dprint.dprint",
-    // "dotenv.dotenv-vscode",
-    "eamodio.gitlens",
-    // "firsttris.vscode-jest-runner",
-    // "ionic.ionic",
-    // "johnpapa.angular2",
-    "meganrogge.template-string-converter",
-    "ms-azure-devops.azure-pipelines",
-    // "nrwl.angular-console",
-    "pkief.material-icon-theme"
-    // "redhat.vscode-xml",
-    // "redhat.vscode-yaml",
-    // "webben.browserslist",
-  ],
-  // List of extensions recommended by VS Code that should not be recommended for users of this workspace.
-  // Developpers should uninstall or disable the following extensions for this workspace
-  // https://github.com/microsoft/vscode/issues/40239
-  "unwantedRecommendations": [
-    "dotjoshjohnson.xml", // Prevent VSCode from recommending a different XML extension than the one we recommend
-    "esbenp.prettier-vscode", // Lots of conflicts
-    "ms-vscode.vscode-typescript-next", // Use workspace version instead
-    "mikestead.dotenv", // Use the official plugin instead
-    "orta.vscode-jest", // firsttris.vscode-jest-runner is preferable and doesn't have issues with parametrized tests
-    "rvest.vs-code-prettier-eslint", // Lots of conflicts
-    "sonarsource.sonarlint-vscode", // Not project-configurable. And the ESLint plugin is sufficient in JS/TS projects
-    "vscodevim.vim", // Recommended on MacOS
-    // VSCode has implemented an optimized version
-    "coenraads.bracket-pair-colorizer",
-    "coenraads.bracket-pair-colorizer-2",
-    "shardulm94.trailing-spaces",
-    // Everything below is Deprecated
-    "eg2.tslint",
-    "ms-vscode.vscode-typescript-tslint-plugin",
-    "simonsiefke.prettier-vscode"
-  ]
-}
+// SPDX-License-Identifier: MIT
+// Copyright 2024 Beslogic Inc.
+// Keep in sync with https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Templates/_wiki/wikis/Beslogic-Architecture-Templates.wiki/757/VSCode-settings-and-extensions-(.vscode-.code-workspace)
+//
+// Please keep in alphabetical order
+{
+  // See https://go.microsoft.com/fwlink/?LinkId=827846 to learn about workspace recommendations.
+  // List of extensions which should be recommended for users of this workspace.
+  // Only keep those used by your specific project
+  "recommendations": [
+    // "angular.ng-template",
+    "davidanson.vscode-markdownlint",
+    "dbaeumer.vscode-eslint",
+    "dprint.dprint",
+    // "dotenv.dotenv-vscode",
+    "eamodio.gitlens",
+    // "firsttris.vscode-jest-runner",
+    // "ionic.ionic",
+    // "johnpapa.angular2",
+    "meganrogge.template-string-converter",
+    "ms-azure-devops.azure-pipelines",
+    // "nrwl.angular-console",
+    "pkief.material-icon-theme"
+    // "redhat.vscode-xml",
+    // "redhat.vscode-yaml",
+    // "webben.browserslist",
+  ],
+  // List of extensions recommended by VS Code that should not be recommended for users of this workspace.
+  // Developpers should uninstall or disable the following extensions for this workspace
+  // https://github.com/microsoft/vscode/issues/40239
+  "unwantedRecommendations": [
+    "dotjoshjohnson.xml", // Prevent VSCode from recommending a different XML extension than the one we recommend
+    "esbenp.prettier-vscode", // Lots of conflicts
+    "ms-vscode.vscode-typescript-next", // Use workspace version instead
+    "mikestead.dotenv", // Use the official plugin instead
+    "orta.vscode-jest", // firsttris.vscode-jest-runner is preferable and doesn't have issues with parametrized tests
+    "rvest.vs-code-prettier-eslint", // Lots of conflicts
+    "sonarsource.sonarlint-vscode", // Not project-configurable. And the ESLint plugin is sufficient in JS/TS projects
+    "vscodevim.vim", // Recommended on MacOS
+    // VSCode has implemented an optimized version
+    "coenraads.bracket-pair-colorizer",
+    "coenraads.bracket-pair-colorizer-2",
+    "shardulm94.trailing-spaces",
+    // Everything below is Deprecated
+    "eg2.tslint",
+    "ms-vscode.vscode-typescript-tslint-plugin",
+    "simonsiefke.prettier-vscode"
+  ]
+}

package/.vscode/settings.json

@@ -1,157 +1,157 @@
-// SPDX-License-Identifier: MIT
-// Copyright 2024 Beslogic Inc.
-// Keep in sync with https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Templates/_wiki/wikis/Beslogic-Architecture-Templates.wiki/757/VSCode-settings-and-extensions-(.vscode-.code-workspace)
-
-{
-  "files.associations": {
-    ".eslintrc*.json": "jsonc",
-    "dprint*.json": "jsonc"
-  },
-  "files.exclude": {
-    "*.zip": true,
-    "**/node_modules": false,
-    "**/build": true,
-    "**/dist/**/*.min.js": true,
-    "**/dist/**/*.map": true,
-    "**/src/react-app-env.d.ts": true
-  },
-  "search.exclude": {
-    "**/node_modules": true,
-    "**/bower_components": true,
-    "**/*.code-search": true,
-    "package-lock.json": true,
-    "*.lock": true
-  },
-  "editor.rulers": [
-    80,
-    100
-  ],
-  "[git-commit]": {
-    "editor.rulers": [
-      72
-    ]
-  },
-  "editor.detectIndentation": false,
-  "editor.tabSize": 2,
-  "editor.insertSpaces": true,
-  "files.eol": "\n",
-  "files.insertFinalNewline": true,
-  "files.trimFinalNewlines": true,
-  "files.trimTrailingWhitespace": true,
-  "editor.bracketPairColorization.enabled": true,
-  "editor.formatOnSave": true,
-  "editor.codeActionsOnSave": {
-    "source.fixAll": "explicit",
-    // "source.*Imports": https://github.com/microsoft/TypeScript/pull/50931#issuecomment-1416288712
-    // Let dedicated imports tool deal with it
-    "source.organizeImports": "never",
-    "source.sortImports": "never",
-    // IDEM, but also it's annoying to remove imports because of commented code while testing
-    "source.removeUnusedImports": "never"
-  },
-  // Set the default formatter to help avoid Prettier
-  // NOTE: due to a bug in VSCode, we have to specify these individually to ensure it overrides user settings
-  // Please upvote: https://github.com/microsoft/vscode/issues/168411
-  "[json]": {
-    "editor.defaultFormatter": "dprint.dprint"
-  },
-  "[jsonc]": {
-    "editor.defaultFormatter": "dprint.dprint"
-  },
-  "[javascript]": {
-    "editor.defaultFormatter": "dprint.dprint"
-  },
-  "[javascriptreact]": {
-    "editor.defaultFormatter": "dprint.dprint"
-  },
-  "[typescript]": {
-    "editor.defaultFormatter": "dprint.dprint"
-  },
-  "[typescriptreact]": {
-    "editor.defaultFormatter": "dprint.dprint"
-  },
-  "[markdown]": {
-    "editor.defaultFormatter": "dprint.dprint"
-  },
-  "[dockerfile]": {
-    "editor.defaultFormatter": "dprint.dprint"
-  },
-  // Specify the formatter in case other formatters are also installed (ie: Prettier)
-  "[html]": {
-    "editor.defaultFormatter": "vscode.html-language-features"
-  },
-  // TODO: Configure stylelint or dprint-prettier so I can recommend it
-  "[css]": {
-    "editor.defaultFormatter": "vscode.css-language-features"
-  },
-  "[scss]": {
-    "editor.defaultFormatter": "vscode.css-language-features"
-  },
-  "[postcss]": {
-    "editor.defaultFormatter": "vscode.css-language-features"
-  },
-  "[less]": {
-    "editor.defaultFormatter": "vscode.css-language-features"
-  },
-  "[yaml]": {
-    "editor.defaultFormatter": "redhat.vscode-yaml"
-  },
-  "[xml]": {
-    "editor.defaultFormatter": "redhat.vscode-xml"
-  },
-  // The following is only needed without dprint
-  // "[json][jsonc]": {
-  //   "editor.defaultFormatter": "vscode.json-language-features"
-  // },
-  // "[javascript][javascriptreact][typescript][typescriptreact]": {
-  //   "editor.defaultFormatter": "vscode.typescript-language-features"
-  // },
-  // "[markdown]": {
-  //   "files.trimTrailingWhitespace": false,
-  // },
-  "dprint.path": "node_modules/dprint/dprint",
-  "typescript.tsdk": "node_modules/typescript/lib",
-  "typescript.enablePromptUseWorkspaceTsdk": true,
-  "js/ts.implicitProjectConfig.checkJs": true,
-  "javascript.preferences.quoteStyle": "single",
-  "typescript.preferences.quoteStyle": "single",
-  "html.format.wrapAttributes": "force-expand-multiline",
-  // js/ts.format.* neededed without dprint
-  // "javascript.format.semicolons": "remove",
-  // "typescript.format.semicolons": "remove",
-  // "javascript.format.insertSpaceAfterOpeningAndBeforeClosingEmptyBraces": false,
-  // "typescript.format.insertSpaceAfterOpeningAndBeforeClosingEmptyBraces": false,
-  "javascript.preferences.importModuleSpecifier": "non-relative",
-  "typescript.preferences.importModuleSpecifier": "non-relative",
-  "eslint.validate": [
-    // For Angular: "html",
-    "javascript",
-    "javascriptreact",
-    "typescript",
-    "typescriptreact"
-  ],
-  "eslint.workingDirectories": [
-    {
-      "mode": "auto"
-    }
-  ],
-  "eslint.codeActionsOnSave.rules": [
-    // Clearing imports and unused vars because of commented code while testing is annoying
-    "!unused-imports/no-unused-imports",
-    "!autofix/no-debugger",
-    "!autofix/no-unused-vars",
-    "*"
-  ],
-  "eslint.rules.customizations": [
-    {
-      "rule": "*",
-      "severity": "downgrade"
-    }
-  ],
-  "jest.autoRun": "off",
-  "less.format.spaceAroundSelectorSeparator": true,
-  "css.format.spaceAroundSelectorSeparator": true,
-  "scss.format.spaceAroundSelectorSeparator": true,
-  "xml.codeLens.enabled": true,
-  "xml.format.maxLineWidth": 100
-}
+// SPDX-License-Identifier: MIT
+// Copyright 2024 Beslogic Inc.
+// Keep in sync with https://dev.azure.com/Beslogic/Beslogic%20Architecture%20Templates/_wiki/wikis/Beslogic-Architecture-Templates.wiki/757/VSCode-settings-and-extensions-(.vscode-.code-workspace)
+
+{
+  "files.associations": {
+    ".eslintrc*.json": "jsonc",
+    "dprint*.json": "jsonc"
+  },
+  "files.exclude": {
+    "*.zip": true,
+    "**/node_modules": false,
+    "**/build": true,
+    "**/dist/**/*.min.js": true,
+    "**/dist/**/*.map": true,
+    "**/src/react-app-env.d.ts": true
+  },
+  "search.exclude": {
+    "**/node_modules": true,
+    "**/bower_components": true,
+    "**/*.code-search": true,
+    "package-lock.json": true,
+    "*.lock": true
+  },
+  "editor.rulers": [
+    80,
+    100
+  ],
+  "[git-commit]": {
+    "editor.rulers": [
+      72
+    ]
+  },
+  "editor.detectIndentation": false,
+  "editor.tabSize": 2,
+  "editor.insertSpaces": true,
+  "files.eol": "\n",
+  "files.insertFinalNewline": true,
+  "files.trimFinalNewlines": true,
+  "files.trimTrailingWhitespace": true,
+  "editor.bracketPairColorization.enabled": true,
+  "editor.formatOnSave": true,
+  "editor.codeActionsOnSave": {
+    "source.fixAll": "explicit",
+    // "source.*Imports": https://github.com/microsoft/TypeScript/pull/50931#issuecomment-1416288712
+    // Let dedicated imports tool deal with it
+    "source.organizeImports": "never",
+    "source.sortImports": "never",
+    // IDEM, but also it's annoying to remove imports because of commented code while testing
+    "source.removeUnusedImports": "never"
+  },
+  // Set the default formatter to help avoid Prettier
+  // NOTE: due to a bug in VSCode, we have to specify these individually to ensure it overrides user settings
+  // Please upvote: https://github.com/microsoft/vscode/issues/168411
+  "[json]": {
+    "editor.defaultFormatter": "dprint.dprint"
+  },
+  "[jsonc]": {
+    "editor.defaultFormatter": "dprint.dprint"
+  },
+  "[javascript]": {
+    "editor.defaultFormatter": "dprint.dprint"
+  },
+  "[javascriptreact]": {
+    "editor.defaultFormatter": "dprint.dprint"
+  },
+  "[typescript]": {
+    "editor.defaultFormatter": "dprint.dprint"
+  },
+  "[typescriptreact]": {
+    "editor.defaultFormatter": "dprint.dprint"
+  },
+  "[markdown]": {
+    "editor.defaultFormatter": "dprint.dprint"
+  },
+  "[dockerfile]": {
+    "editor.defaultFormatter": "dprint.dprint"
+  },
+  // Specify the formatter in case other formatters are also installed (ie: Prettier)
+  "[html]": {
+    "editor.defaultFormatter": "vscode.html-language-features"
+  },
+  // TODO: Configure stylelint or dprint-prettier so I can recommend it
+  "[css]": {
+    "editor.defaultFormatter": "vscode.css-language-features"
+  },
+  "[scss]": {
+    "editor.defaultFormatter": "vscode.css-language-features"
+  },
+  "[postcss]": {
+    "editor.defaultFormatter": "vscode.css-language-features"
+  },
+  "[less]": {
+    "editor.defaultFormatter": "vscode.css-language-features"
+  },
+  "[yaml]": {
+    "editor.defaultFormatter": "redhat.vscode-yaml"
+  },
+  "[xml]": {
+    "editor.defaultFormatter": "redhat.vscode-xml"
+  },
+  // The following is only needed without dprint
+  // "[json][jsonc]": {
+  //   "editor.defaultFormatter": "vscode.json-language-features"
+  // },
+  // "[javascript][javascriptreact][typescript][typescriptreact]": {
+  //   "editor.defaultFormatter": "vscode.typescript-language-features"
+  // },
+  // "[markdown]": {
+  //   "files.trimTrailingWhitespace": false,
+  // },
+  "dprint.path": "node_modules/dprint/dprint",
+  "typescript.tsdk": "node_modules/typescript/lib",
+  "typescript.enablePromptUseWorkspaceTsdk": true,
+  "js/ts.implicitProjectConfig.checkJs": true,
+  "javascript.preferences.quoteStyle": "single",
+  "typescript.preferences.quoteStyle": "single",
+  "html.format.wrapAttributes": "force-expand-multiline",
+  // js/ts.format.* neededed without dprint
+  // "javascript.format.semicolons": "remove",
+  // "typescript.format.semicolons": "remove",
+  // "javascript.format.insertSpaceAfterOpeningAndBeforeClosingEmptyBraces": false,
+  // "typescript.format.insertSpaceAfterOpeningAndBeforeClosingEmptyBraces": false,
+  "javascript.preferences.importModuleSpecifier": "non-relative",
+  "typescript.preferences.importModuleSpecifier": "non-relative",
+  "eslint.validate": [
+    // For Angular: "html",
+    "javascript",
+    "javascriptreact",
+    "typescript",
+    "typescriptreact"
+  ],
+  "eslint.workingDirectories": [
+    {
+      "mode": "auto"
+    }
+  ],
+  "eslint.codeActionsOnSave.rules": [
+    // Clearing imports and unused vars because of commented code while testing is annoying
+    "!unused-imports/no-unused-imports",
+    "!autofix/no-debugger",
+    "!autofix/no-unused-vars",
+    "*"
+  ],
+  "eslint.rules.customizations": [
+    {
+      "rule": "*",
+      "severity": "downgrade"
+    }
+  ],
+  "jest.autoRun": "off",
+  "less.format.spaceAroundSelectorSeparator": true,
+  "css.format.spaceAroundSelectorSeparator": true,
+  "scss.format.spaceAroundSelectorSeparator": true,
+  "xml.codeLens.enabled": true,
+  "xml.format.maxLineWidth": 100
+}

package/CHANGELOG.md

@@ -1,7 +1,15 @@
-# Changelog
-
-## 2.0.0
-
-- Created CHANGELOG.md
-- Changed the maximum line length from `120` to `100`
-- Split language-specific `editor.defaultFormatter` to work around <https://github.com/microsoft/vscode/issues/168411>
+# Changelog
+
+## 2.0.2
+
+- Disabled the following rules in Storybook stories:
+  - `@angular-eslint/component-max-inline-declarations`
+  - `angular-file-naming/component-filename-suffix`
+- Fixed rule to detect using public non-readonly arrow function properties in Components and Directives with Storybook
+- Clarified that `beslogic/storybook` preset should be added to Angular project as well
+
+## 2.0.0
+
+- Created CHANGELOG.md
+- Changed the maximum line length from `120` to `100`
+- Split language-specific `editor.defaultFormatter` to work around <https://github.com/microsoft/vscode/issues/168411>

package/LICENSE

@@ -1,9 +1,9 @@
-The MIT License
-
-Copyright 2024 Beslogic Inc.
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+The MIT License
+
+Copyright 2024 Beslogic Inc.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.