eslint-config-auditor 0.2.0 → 0.5.0

package/finest/finest.json

@@ -57,6 +57,29 @@
 				"allowUnboundThis": true
 			}
     ],
-    "node/no-unsupported-features/es-syntax": "warn"
-	}
+    "node/no-unsupported-features/es-syntax": "warn",
+    "node/no-missing-import": "warn",
+    "import/no-relative-parent-imports": "warn",
+    "node/no-unsupported-features/node-builtins": "warn",
+    "no-duplicate-imports": "warn",
+    "import/exports-last": ["error", "never"],
+    "node/no-callback-literal": "error",
+    "jsx-a11y/aria-role": "error",
+    "jsx-a11y/alt-text": "error",
+		"array-callback-return": [
+			"error",
+			{
+				"allowImplicit": false,
+				"checkForEach": false
+			}
+		]
+  },
+  "object-shorthand": [
+    "error",
+    "always",
+    {
+      "avoidQuotes": true,
+      "ignoreConstructors": false
+    }
+  ]
 }

package/jest/jest.json

@@ -20,6 +20,7 @@
 		"jest/no-expect-resolves": "error",
 		"jest/no-if": "off",
 		"jest/no-test-return-statement": "off",
+    "jest/no-truthy-falsy": "off",
 		"jest/prefer-hooks-on-top": "error",
 		"jest/prefer-spy-on": "warn",
 		"jest/prefer-todo": "warn"

package/package.json

@@ -8,7 +8,7 @@
     "node": ">=10"
   },
   "name": "eslint-config-auditor",
-  "version": "0.2.0",
+  "version": "0.5.0",
   "description": "Shareable ESLint Config to help you write clear, efficient JavaScript code.",
   "main": "module.js",
   "author": {
@@ -50,23 +50,18 @@
     "standard",
     "alternative"
   ],
-  "peerDependencies": {
-    "eslint": "^7.12.1",
-    "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-promise": "^4.2.1"
-  },
   "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^4.9.1",
-    "@typescript-eslint/parser": "^4.9.1",
-    "eslint": "^7.12.1",
+    "@typescript-eslint/eslint-plugin": "^5.10.1",
+    "@typescript-eslint/parser": "^5.10.1",
+    "eslint": "^8.8.0",
     "eslint-config-rule-tester": "^0.2.0",
-    "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jest": "^24.1.3",
-    "eslint-plugin-jsx-a11y": "^6.4.1",
+    "eslint-plugin-import": "^2.25.4",
+    "eslint-plugin-jest": "^26.0.0",
+    "eslint-plugin-jsx-a11y": "^6.5.1",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-promise": "^4.2.1",
-    "eslint-plugin-react": "^7.21.5",
-    "eslint-plugin-react-hooks": "^4.2.0"
+    "eslint-plugin-promise": "^6.0.0",
+    "eslint-plugin-react": "^7.28.0",
+    "eslint-plugin-react-hooks": "^4.3.0",
+    "typescript": "^4.5.5"
   }
 }

package/react/react.json

@@ -13,7 +13,7 @@
 		"react",
 		"jsx-a11y",
 		"react-hooks"
-  ],
+	],
 	"settings": {
 		"linkComponents": [
 			{
@@ -44,7 +44,6 @@
 		"jsx-a11y/aria-activedescendant-has-tabindex": "error",
 		"jsx-a11y/aria-props": "error",
 		"jsx-a11y/aria-proptypes": "error",
-		"jsx-a11y/aria-role": "error",
 		"jsx-a11y/aria-unsupported-elements": "error",
 		"jsx-a11y/click-events-have-key-events": "error",
 		"jsx-a11y/control-has-associated-label": [
@@ -267,6 +266,7 @@
 			"error",
 			{
 				"allowArrowFunctions": true,
+				"allowFunctions": true,
 				"ignoreRefs": true
 			}
 		],
@@ -283,6 +283,7 @@
 				"allowAllCaps": true
 			}
 		],
+		"react/jsx-uses-react": "off",
 		"react/no-access-state-in-setstate": "error",
 		"react/no-multi-comp": "off",
 		"react/no-redundant-should-component-update": "error",
@@ -298,6 +299,7 @@
 				"skipUndeclared": true
 			}
 		],
+		"react/react-in-jsx-scope": "off",
 		"react/self-closing-comp": "warn",
 		"react/style-prop-object": "off",
 		"react/void-dom-elements-no-children": "error"

package/recommended/recommended.json

@@ -39,8 +39,7 @@
 		"array-callback-return": [
 			"error",
 			{
-				"allowImplicit": false,
-				"checkForEach": false
+				"allowImplicit": true
 			}
 		],
 		"array-element-newline": [
@@ -117,7 +116,12 @@
 			"error",
 			"multi-line"
 		],
-		"default-case": "error",
+		"default-case": [
+			"error",
+			{
+				"commentPattern": "^no default$"
+			}
+		],
 		"default-case-last": "error",
 		"default-param-last": "error",
 		"dot-location": [
@@ -143,6 +147,7 @@
 			"error",
 			"never"
 		],
+		"func-names": "warn",
 		"func-style": [
 			"warn",
 			"declaration",
@@ -173,7 +178,6 @@
 		],
 		"grouped-accessor-pairs": "error",
 		"import/export": "error",
-		"import/exports-last": "error",
 		"import/first": "error",
 		"import/newline-after-import": "error",
 		"import/no-absolute-path": [
@@ -191,15 +195,7 @@
 		"import/no-named-as-default": "error",
 		"import/no-named-as-default-member": "error",
 		"import/no-named-default": "error",
-		"import/no-relative-parent-imports": "error",
 		"import/no-self-import": "error",
-		"import/no-unresolved": [
-			2,
-			{
-				"caseSensitive": true,
-				"commonjs": true
-			}
-		],
 		"import/no-unused-modules": "error",
 		"import/no-useless-path-segments": [
 			"error",
@@ -219,9 +215,25 @@
 						"parent",
 						"sibling",
 						"index"
-					]
+					],
+					"object",
+					"type"
+				],
+				"newlines-between": "always",
+				"pathGroups": [
+					{
+						"group": "internal",
+						"pattern": "{$,@}/**"
+					},
+					{
+						"group": "object",
+						"pattern": "*.json",
+						"patternOptions": {
+							"matchBase": true
+						}
+					}
 				],
-				"newlines-between": "always"
+				"pathGroupsExcludedImportTypes": []
 			}
 		],
 		"indent": [
@@ -309,6 +321,10 @@
 				"exceptAfterSingleLine": true
 			}
 		],
+		"max-classes-per-file": [
+			"off",
+			1
+		],
 		"max-len": [
 			"error",
 			{
@@ -331,14 +347,14 @@
 			"error",
 			{
 				"capIsNew": false,
-				"newIsCap": true,
-				"properties": true
+				"newIsCap": true
 			}
 		],
 		"new-parens": "error",
 		"no-alert": "warn",
 		"no-array-constructor": "error",
 		"no-async-promise-executor": "error",
+		"no-await-in-loop": "error",
 		"no-caller": "error",
 		"no-case-declarations": "error",
 		"no-class-assign": "error",
@@ -348,6 +364,16 @@
 			"except-parens"
 		],
 		"no-confusing-arrow": "error",
+		"no-console": [
+			"off",
+			{
+				"allow": [
+					"info",
+					"warn",
+					"error"
+				]
+			}
+		],
 		"no-const-assign": "error",
 		"no-constant-condition": [
 			"error",
@@ -364,7 +390,6 @@
 		"no-dupe-else-if": "error",
 		"no-dupe-keys": "error",
 		"no-duplicate-case": "error",
-		"no-duplicate-imports": "error",
 		"no-else-return": [
 			"error",
 			{
@@ -415,24 +440,32 @@
 		],
 		"no-implied-eval": "error",
 		"no-import-assign": "error",
-		"no-inline-comments": "warn",
+		"no-inline-comments": "off",
 		"no-inner-declarations": "error",
 		"no-invalid-regexp": "error",
 		"no-invalid-this": "error",
 		"no-irregular-whitespace": "error",
 		"no-iterator": "error",
 		"no-label-var": "error",
-		"no-labels": [
-			"error",
-			{
-				"allowLoop": false,
-				"allowSwitch": false
-			}
-		],
+		"no-labels": "error",
 		"no-lone-blocks": "error",
-		"no-lonely-if": "error",
+		"no-lonely-if": "off",
 		"no-loop-func": "error",
 		"no-loss-of-precision": "error",
+		"no-magic-numbers": [
+			"off",
+			{
+				"detectObjects": false,
+				"enforceConst": true,
+				"ignore": [
+					0,
+					1,
+					2,
+					3
+				],
+				"ignoreArrayIndexes": true
+			}
+		],
 		"no-misleading-character-class": "error",
 		"no-mixed-operators": [
 			"error",
@@ -471,6 +504,7 @@
 				"maxEOF": 0
 			}
 		],
+		"no-negated-condition": "off",
 		"no-nested-ternary": "error",
 		"no-new": "error",
 		"no-new-func": "error",
@@ -482,75 +516,12 @@
 		"no-octal-escape": "error",
 		"no-proto": "error",
 		"no-prototype-builtins": "error",
-		"no-redeclare": [
-			"error",
-			{
-				"builtinGlobals": false
-			}
-		],
+		"no-redeclare": "error",
 		"no-regex-spaces": "error",
 		"no-restricted-globals": [
 			"error",
 			"isFinite",
-			"isNaN",
-			"addEventListener",
-			"blur",
-			"close",
-			"closed",
-			"confirm",
-			"defaultStatus",
-			"defaultstatus",
-			"event",
-			"external",
-			"find",
-			"focus",
-			"frameElement",
-			"frames",
-			"history",
-			"innerHeight",
-			"innerWidth",
-			"length",
-			"location",
-			"locationbar",
-			"menubar",
-			"moveBy",
-			"moveTo",
-			"name",
-			"onblur",
-			"onerror",
-			"onfocus",
-			"onload",
-			"onresize",
-			"onunload",
-			"open",
-			"opener",
-			"opera",
-			"outerHeight",
-			"outerWidth",
-			"pageXOffset",
-			"pageYOffset",
-			"parent",
-			"print",
-			"removeEventListener",
-			"resizeBy",
-			"resizeTo",
-			"screen",
-			"screenLeft",
-			"screenTop",
-			"screenX",
-			"screenY",
-			"scroll",
-			"scrollbars",
-			"scrollBy",
-			"scrollTo",
-			"scrollX",
-			"scrollY",
-			"self",
-			"status",
-			"statusbar",
-			"stop",
-			"toolbar",
-			"top"
+			"isNaN"
 		],
 		"no-restricted-syntax": [
 			"error",
@@ -582,6 +553,25 @@
 		"no-self-compare": "error",
 		"no-sequences": "error",
 		"no-setter-return": "error",
+		"no-shadow": [
+			"error",
+			{
+				"allow": [
+					"cb",
+					"callback",
+					"data",
+					"done",
+					"error",
+					"item",
+					"items",
+					"next",
+					"reject",
+					"res",
+					"resolve",
+					"response"
+				]
+			}
+		],
 		"no-shadow-restricted-names": "error",
 		"no-sparse-arrays": "error",
 		"no-tabs": "error",
@@ -623,7 +613,7 @@
 			}
 		],
 		"no-use-before-define": [
-			"error",
+			"off",
 			{
 				"classes": false,
 				"functions": false,
@@ -632,16 +622,19 @@
 		],
 		"no-useless-backreference": "error",
 		"no-useless-call": "error",
-		"no-useless-catch": "error",
+		"no-useless-catch": "off",
 		"no-useless-computed-key": "error",
 		"no-useless-constructor": "error",
 		"no-useless-escape": "error",
-		"no-useless-rename": "error",
+		"no-useless-rename": [
+			"error"
+		],
 		"no-useless-return": "error",
-		"no-var": "warn",
+		"no-var": "error",
 		"no-void": "error",
 		"no-whitespace-before-property": "error",
 		"no-with": "error",
+		"node/callback-return": "off",
 		"node/exports-style": [
 			"error",
 			"module.exports",
@@ -649,19 +642,19 @@
 				"allowBatchAssign": false
 			}
 		],
+		"node/global-require": "error",
 		"node/handle-callback-err": [
 			"error",
 			"^(err|error|reason)$"
 		],
-		"node/no-callback-literal": "error",
 		"node/no-deprecated-api": "error",
 		"node/no-exports-assign": "error",
 		"node/no-extraneous-import": "error",
 		"node/no-extraneous-require": "error",
-		"node/no-missing-import": "error",
 		"node/no-missing-require": "error",
 		"node/no-new-require": "error",
 		"node/no-path-concat": "error",
+		"node/no-process-env": "off",
 		"node/no-process-exit": "error",
 		"node/no-restricted-import": 2,
 		"node/no-restricted-require": 2,
@@ -672,7 +665,6 @@
 			}
 		],
 		"node/no-unsupported-features/es-builtins": "error",
-		"node/no-unsupported-features/node-builtins": "error",
 		"node/prefer-global/buffer": "error",
 		"node/prefer-global/console": "error",
 		"node/prefer-global/process": "error",
@@ -680,6 +672,8 @@
 		"node/prefer-global/text-encoder": "error",
 		"node/prefer-global/url": "error",
 		"node/prefer-global/url-search-params": "error",
+		"node/prefer-promises/dns": "warn",
+		"node/prefer-promises/fs": "warn",
 		"node/process-exit-as-throw": "error",
 		"node/shebang": "error",
 		"object-curly-newline": [
@@ -691,7 +685,7 @@
 		],
 		"object-curly-spacing": [
 			"error",
-			"always"
+			"never"
 		],
 		"object-property-newline": [
 			"error",
@@ -709,9 +703,7 @@
 		],
 		"one-var": [
 			"error",
-			{
-				"initialized": "never"
-			}
+			"never"
 		],
 		"operator-assignment": [
 			"error",
@@ -774,16 +766,25 @@
 				"next": "return",
 				"prev": "*"
 			},
+			{
+				"blankLine": "any",
+				"next": "return",
+				"prev": "if"
+			},
+			{
+				"blankLine": "always",
+				"next": "return",
+				"prev": "block-like"
+			},
 			{
 				"blankLine": "always",
 				"next": [
 					"case",
-					"break",
 					"default"
 				],
 				"prev": [
-					"case",
-					"break"
+					"break",
+					"return"
 				]
 			},
 			{
@@ -794,6 +795,22 @@
 					"class",
 					"multiline-block-like"
 				]
+			},
+			{
+				"blankLine": "any",
+				"next": [
+					"cjs-import"
+				],
+				"prev": [
+					"cjs-import"
+				]
+			}
+		],
+		"prefer-arrow-callback": [
+			"off",
+			{
+				"allowNamedFunctions": false,
+				"allowUnboundThis": true
 			}
 		],
 		"prefer-const": [
@@ -803,16 +820,27 @@
 				"ignoreReadBeforeAssign": true
 			}
 		],
-		"prefer-exponentiation-operator": "error",
-		"prefer-numeric-literals": "error",
-		"prefer-object-spread": "error",
-		"prefer-promise-reject-errors": "error",
-		"prefer-regex-literals": [
+		"prefer-destructuring": [
 			"warn",
 			{
-				"disallowRedundantWrapping": true
+				"AssignmentExpression": {
+					"array": false,
+					"object": false
+				},
+				"VariableDeclarator": {
+					"array": true,
+					"object": true
+				}
+			},
+			{
+				"enforceForRenamedProperties": false
 			}
 		],
+		"prefer-exponentiation-operator": "error",
+		"prefer-numeric-literals": "error",
+		"prefer-object-spread": "error",
+		"prefer-promise-reject-errors": "error",
+		"prefer-regex-literals": "warn",
 		"prefer-rest-params": "error",
 		"prefer-spread": "error",
 		"prefer-template": "warn",
@@ -837,6 +865,7 @@
 			}
 		],
 		"radix": "error",
+		"require-atomic-updates": "off",
 		"require-await": "error",
 		"require-yield": "error",
 		"rest-spread-spacing": [
@@ -881,24 +910,27 @@
 				"block": {
 					"balanced": true,
 					"exceptions": [
-						"*"
+						"-",
+						"+"
 					],
 					"markers": [
-						"*package",
-						"!",
-						",",
-						":",
-						"::",
-						"flow-include"
+						"-",
+						"+",
+						"?",
+						"!"
 					]
 				},
 				"line": {
+					"exceptions": [
+						"-",
+						"+"
+					],
 					"markers": [
-						"*package",
+						"-",
+						"+",
+						"?",
 						"!",
-						"/",
-						",",
-						"="
+						"/"
 					]
 				}
 			}

package/typescript/typescript.json

@@ -11,6 +11,15 @@
 			}
 		},
 		{
+			"files": [
+			  "*.test.ts",
+        "*.test.tsx"
+      ],
+      "rules": {
+        "@typescript-eslint/no-non-null-assertion": "off"
+      }
+    },
+    {
 			"extends": [
 				"plugin:import/typescript",
 				"plugin:@typescript-eslint/eslint-recommended",
@@ -29,7 +38,7 @@
 					"*/*/tsconfig{.eslint.json,.json}"
 				],
 				"projectFolderIgnoreList": [
-					"node_modules/**/*"
+					"/node_modules/i"
 				],
 				"sourceType": "module"
 			},
@@ -55,6 +64,30 @@
 						"ts-nocheck": true
 					}
 				],
+				"@typescript-eslint/ban-types": [
+					"error",
+					{
+						"types": {
+							"Boolean": {
+								"fixWith": "boolean",
+								"message": "Use boolean instead"
+							},
+							"Number": {
+								"fixWith": "number",
+								"message": "Use number instead"
+							},
+							"String": {
+								"fixWith": "string",
+								"message": "Use string instead"
+							},
+							"Symbol": {
+								"fixWith": "symbol",
+								"message": "Use symbol instead"
+							}
+						}
+					}
+				],
+				"@typescript-eslint/consistent-type-assertions": "error",
 				"@typescript-eslint/consistent-type-definitions": "off",
 				"@typescript-eslint/consistent-type-imports": [
 					"warn",
@@ -64,6 +97,7 @@
 					}
 				],
 				"@typescript-eslint/default-param-last": "error",
+				"@typescript-eslint/dot-notation": "error",
 				"@typescript-eslint/explicit-function-return-type": "off",
 				"@typescript-eslint/explicit-member-accessibility": [
 					"error",
@@ -82,6 +116,7 @@
 					"error",
 					{
 						"format": [
+							"PascalCase",
 							"camelCase"
 						],
 						"leadingUnderscore": "allow",
@@ -114,6 +149,10 @@
 					{
 						"format": null,
 						"selector": "memberLike"
+					},
+					{
+						"format": null,
+						"selector": "parameter"
 					}
 				],
 				"@typescript-eslint/no-empty-function": [
@@ -126,7 +165,14 @@
 						]
 					}
 				],
+				"@typescript-eslint/no-empty-interface": "error",
 				"@typescript-eslint/no-implied-eval": "error",
+				"@typescript-eslint/no-inferrable-types": [
+					"error",
+					{
+						"ignoreParameters": true
+					}
+				],
 				"@typescript-eslint/no-magic-numbers": [
 					"off",
 					{
@@ -143,6 +189,8 @@
 						"ignoreNumericLiteralTypes": true
 					}
 				],
+				"@typescript-eslint/no-misused-new": "error",
+				"@typescript-eslint/no-namespace": "error",
 				"@typescript-eslint/no-non-null-asserted-optional-chain": "error",
 				"@typescript-eslint/no-non-null-assertion": "warn",
 				"@typescript-eslint/no-require-imports": "warn",
@@ -150,11 +198,17 @@
 					"error",
 					{
 						"allow": [
+							"cb",
+							"callback",
+							"data",
 							"done",
+							"error",
 							"next",
-							"resolve",
 							"reject",
-							"cb"
+							"req",
+							"res",
+							"resolve",
+							"response"
 						]
 					}
 				],
@@ -162,6 +216,7 @@
 				"@typescript-eslint/no-unnecessary-qualifier": "warn",
 				"@typescript-eslint/no-unnecessary-type-arguments": "warn",
 				"@typescript-eslint/no-unnecessary-type-constraint": "warn",
+				"@typescript-eslint/no-unused-expressions": "error",
 				"@typescript-eslint/no-unused-vars": [
 					"warn",
 					{
@@ -182,6 +237,8 @@
 				"@typescript-eslint/no-useless-constructor": "error",
 				"@typescript-eslint/prefer-as-const": "error",
 				"@typescript-eslint/prefer-enum-initializers": "warn",
+				"@typescript-eslint/prefer-function-type": "error",
+				"@typescript-eslint/prefer-namespace-keyword": "error",
 				"@typescript-eslint/prefer-nullish-coalescing": [
 					"warn",
 					{
@@ -191,13 +248,32 @@
 					}
 				],
 				"@typescript-eslint/prefer-optional-chain": "warn",
+				"@typescript-eslint/quotes": [
+					"error",
+					"single"
+				],
 				"@typescript-eslint/require-array-sort-compare": "error",
 				"@typescript-eslint/restrict-plus-operands": [
 					"error",
 					{
 						"checkCompoundAssignments": true
 					}
-				]
+				],
+				"@typescript-eslint/triple-slash-reference": [
+					"error",
+					{
+						"lib": "always",
+						"path": "always",
+						"types": "prefer-import"
+					}
+				],
+				"camelcase": "off",
+				"default-param-last": "off",
+				"no-empty-function": "off",
+				"no-magic-numbers": "off",
+				"no-unused-vars": "off",
+				"no-use-before-define": "off",
+				"no-useless-constructor": "off"
 			}
 		}
 	]