eslint-config-agent 1.9.3 → 2.0.1

package/configs/overrides.js

@@ -86,15 +86,6 @@ export const overridesConfig = (
     },
   },
 
-  // className requirement for JSX files
-  {
-    files: ['**/*.{tsx,jsx}'],
-    ignores: ['**/*.stories.{js,jsx,ts,tsx}'],
-    rules: {
-      'custom/jsx-classname-required': 'error',
-    },
-  },
-
   // Function and file length rules - strict error thresholds
   {
     files: ['**/*.{ts,tsx,js,jsx}'],

package/index.js

@@ -1,4 +1,6 @@
 import js from '@eslint/js'
+import earlyReturn from 'eslint-plugin-early-return'
+import jsxClassname from 'eslint-plugin-jsx-classname'
 import reactHooks from 'eslint-plugin-react-hooks'
 import { defineConfig } from 'eslint/config'
 import tseslint from 'typescript-eslint'
@@ -104,23 +106,10 @@ const config = defineConfig([
   {
     plugins,
   },
-  // Use recommended-latest if available (v5+), otherwise create flat config equivalent of legacy recommended
-  ...(reactHooks.configs['recommended-latest']
-    ? [reactHooks.configs['recommended-latest']]
-    : [
-        {
-          name: 'react-hooks/recommended-flat',
-          plugins: {
-            'react-hooks': reactHooks,
-          },
-          rules: {
-            'react-hooks/rules-of-hooks': 'error',
-            'react-hooks/exhaustive-deps': 'warn',
-          },
-        },
-      ]),
+  reactHooks.configs['recommended-latest'],
   js.configs.recommended,
   ...tseslint.configs.recommended,
+  earlyReturn.configs.recommended,
 
   // Base plugin strict configs (error, default, guard-clauses)
   ...basePluginsConfig,
@@ -153,7 +142,14 @@ const config = defineConfig([
   // Examples files configuration
   ...examplesConfig,
 
-  // Final overrides (index files, switch case, className, length rules)
+  // className requirement for JSX files (strict: errors + rejects Tailwind-only classNames)
+  {
+    ...jsxClassname.configs.strict,
+    files: ['**/*.{tsx,jsx}'],
+    ignores: ['**/*.stories.{js,jsx,ts,tsx}'],
+  },
+
+  // Final overrides (index files, switch case, length rules)
   ...overridesConfig(sharedRestrictedSyntax, tsOnlyRestrictedSyntax),
 ])
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-agent",
-  "version": "1.9.3",
+  "version": "2.0.1",
   "description": "ESLint configuration package with TypeScript support",
   "main": "index.js",
   "type": "module",
@@ -61,37 +61,17 @@
   "author": "tupe12334",
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/tupe12334/eslint-config.git"
+    "url": "git+https://github.com/tupe12334/eslint-config-agent.git"
   },
   "bugs": {
-    "url": "https://github.com/tupe12334/eslint-config/issues"
+    "url": "https://github.com/tupe12334/eslint-config-agent/issues"
   },
-  "homepage": "https://github.com/tupe12334/eslint-config#readme",
+  "homepage": "https://github.com/tupe12334/eslint-config-agent#readme",
   "license": "MIT",
   "publishConfig": {
     "access": "public"
   },
   "packageManager": "pnpm@10.18.2",
-  "peerDependencies": {
-    "@eslint/eslintrc": "^3.3.1",
-    "@eslint/js": "^9.34.0",
-    "@typescript-eslint/eslint-plugin": "^8.40.0",
-    "@typescript-eslint/parser": "^8.40.0",
-    "eslint": "^9.34.0",
-    "eslint-plugin-class-export": "^1.0.1",
-    "eslint-plugin-import": "^2.32.0",
-    "eslint-plugin-n": "^17.21.3",
-    "eslint-plugin-react": "^7.37.5",
-    "eslint-plugin-react-hooks": "^5.2.0",
-    "eslint-plugin-security": "^3.0.1",
-    "eslint-plugin-storybook": "^9.1.5",
-    "typescript-eslint": "^8.40.0"
-  },
-  "peerDependenciesMeta": {
-    "eslint-plugin-preact": {
-      "optional": true
-    }
-  },
   "devDependencies": {
     "@commitlint/cli": "^20.1.0",
     "@commitlint/config-conventional": "^20.0.0",
@@ -119,12 +99,28 @@
     "typescript-eslint": "^8.46.1"
   },
   "dependencies": {
+    "@eslint/eslintrc": "^3.3.1",
+    "@eslint/js": "^9.34.0",
+    "@typescript-eslint/eslint-plugin": "^8.40.0",
+    "@typescript-eslint/parser": "^8.40.0",
+    "eslint": "^9.34.0",
+    "eslint-plugin-class-export": "^1.0.1",
     "eslint-plugin-ddd": "^0.5.2",
     "eslint-plugin-default": "^1.1.0",
+    "eslint-plugin-early-return": "^1.0.0",
     "eslint-plugin-error": "^1.3.0",
+    "eslint-plugin-import": "^2.32.0",
+    "eslint-plugin-jsx-classname": "^1.0.1",
+    "eslint-plugin-n": "^17.21.3",
     "eslint-plugin-no-optional-chaining": "^1.0.0",
+    "eslint-plugin-preact": "^0.1.0",
+    "eslint-plugin-react": "^7.37.5",
+    "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-required-exports": "^0.2.0",
+    "eslint-plugin-security": "^3.0.1",
     "eslint-plugin-single-export": "^1.1.2",
-    "globals": "^16.4.0"
+    "eslint-plugin-storybook": "^9.1.5",
+    "globals": "^16.4.0",
+    "typescript-eslint": "^8.40.0"
   }
 }

package/plugins/index.js

@@ -17,17 +17,9 @@ import errorPlugin from 'eslint-plugin-error'
 import defaultPlugin from 'eslint-plugin-default'
 import noOptionalChainingPlugin from 'eslint-plugin-no-optional-chaining'
 import dddPlugin from 'eslint-plugin-ddd'
-import allRules from '../rules/index.js'
+import preactPlugin from 'eslint-plugin-preact'
 import { noDefaultClassExportRule } from '../rules/no-default-class-export/index.js'
 
-// Conditionally import preact plugin if available
-let preactPlugin = null
-try {
-  preactPlugin = (await import('eslint-plugin-preact')).default
-} catch {
-  // eslint-plugin-preact is not available
-}
-
 // Centralized plugin configuration
 export const plugins = {
   react: reactPlugin,
@@ -42,11 +34,10 @@ export const plugins = {
   default: defaultPlugin,
   'no-optional-chaining': noOptionalChainingPlugin,
   ddd: dddPlugin,
-  ...(preactPlugin && { preact: preactPlugin }),
+  preact: preactPlugin,
   custom: {
     rules: {
       'no-default-class-export': noDefaultClassExportRule,
-      'jsx-classname-required': allRules.jsxClassNameRequiredRule,
     },
   },
 }

package/rules/error-only-exports/index.js

@@ -119,26 +119,28 @@ export const errorOnlyExportsRule = {
         // Only check on program exit to ensure we've seen all exports
       },
       'Program:exit'(node) {
-        if (isErrorOnlyFile(context)) {
-          // Check if the file already has the eslint-disable comment
-          const sourceCode = context.sourceCode || context.getSourceCode()
-          const comments = sourceCode.getAllComments()
-
-          const hasDisableComment = comments.some(
-            comment =>
-              comment.value.includes('eslint-disable ddd/require-spec-file') ||
-              comment.value.includes(
-                'eslint-disable-next-line ddd/require-spec-file'
-              )
-          )
-
-          // Only report if the disable comment is not present
-          if (!hasDisableComment) {
-            context.report({
-              node,
-              messageId: 'errorOnlyFile',
-            })
-          }
+        if (!isErrorOnlyFile(context)) {
+          return
+        }
+
+        // Check if the file already has the eslint-disable comment
+        const sourceCode = context.sourceCode || context.getSourceCode()
+        const comments = sourceCode.getAllComments()
+
+        const hasDisableComment = comments.some(
+          comment =>
+            comment.value.includes('eslint-disable ddd/require-spec-file') ||
+            comment.value.includes(
+              'eslint-disable-next-line ddd/require-spec-file'
+            )
+        )
+
+        // Only report if the disable comment is not present
+        if (!hasDisableComment) {
+          context.report({
+            node,
+            messageId: 'errorOnlyFile',
+          })
         }
       },
     }

package/rules/index.js

@@ -22,7 +22,6 @@ import { noTypeAssertionsConfig } from './no-type-assertions/index.js'
 import { noExportSpecifiersConfig } from './no-empty-exports/index.js'
 import { noClassPropertyDefaultsConfig } from './no-class-property-defaults/index.js'
 import { noDefaultClassExportRules } from './no-default-class-export/index.js'
-import { jsxClassNameRequiredRule } from './jsx-classname-required/index.js'
 import { noNullishCoalescingConfig } from './nullish-coalescing/index.js'
 import { switchStatementsReturnTypeConfigs } from './switch-statements-return-type/index.js'
 import { switchCaseFunctionsReturnTypeConfigs } from './switch-case-functions-return-type/index.js'
@@ -49,7 +48,6 @@ const allRules = {
   noExportSpecifiersConfig,
   noClassPropertyDefaultsConfig,
   noDefaultClassExportRules,
-  jsxClassNameRequiredRule,
   noNullishCoalescingConfig,
   switchStatementsReturnTypeConfigs,
   switchCaseFunctionsReturnTypeConfigs,
@@ -79,7 +77,6 @@ export {
   noExportSpecifiersConfig,
   noClassPropertyDefaultsConfig,
   noDefaultClassExportRules,
-  jsxClassNameRequiredRule,
   noNullishCoalescingConfig,
   switchStatementsReturnTypeConfigs,
   switchCaseFunctionsReturnTypeConfigs,

package/rules/jsx-classname-required/index.js

@@ -1,95 +0,0 @@
-/**
- * ESLint rule to require className attribute on HTML elements in JSX
- *
- * This rule enforces that all HTML elements in JSX must have a non-empty className attribute.
- * It excludes React components (starting with capital letters), fragments, and title elements.
- *
- * Examples:
- * - ❌ <div>Content</div>
- * - ❌ <div className="">Content</div>
- * - ✅ <div className="container">Content</div>
- * - ✅ <MyComponent>Content</MyComponent> (ignored - React component)
- * - ✅ <Fragment>Content</Fragment> (ignored - fragment)
- * - ✅ <React.Fragment>Content</React.Fragment> (ignored - React fragment)
- * - ✅ <React.StrictMode>Content</React.StrictMode> (ignored - React component)
- * - ✅ <title>Page Title</title> (ignored - title element)
- */
-
-const jsxClassNameRequiredRule = {
-  meta: {
-    type: 'layout',
-    docs: {
-      description:
-        'Require non-empty className attribute on HTML elements in JSX',
-      category: 'Stylistic Issues',
-      recommended: false,
-    },
-    fixable: null,
-    schema: [],
-    messages: {
-      missingClassName: 'HTML elements must have a className attribute.',
-      emptyClassName:
-        'HTML elements must have a non-empty className attribute.',
-    },
-  },
-
-  create(context) {
-    return {
-      JSXOpeningElement(node) {
-        // Skip if this is a React component (starts with capital letter)
-        if (
-          node.name.type === 'JSXIdentifier' &&
-          /^[A-Z]/.test(node.name.name)
-        ) {
-          return
-        }
-
-        // Skip if this is Fragment
-        if (
-          node.name.type === 'JSXIdentifier' &&
-          node.name.name === 'Fragment'
-        ) {
-          return
-        }
-
-        // Skip if this is React.Something (like React.Fragment, React.StrictMode, etc.)
-        if (
-          node.name.type === 'JSXMemberExpression' &&
-          node.name.object.name === 'React' &&
-          /^[A-Z]/.test(node.name.property.name)
-        ) {
-          return
-        }
-
-        // Skip if this is a title element (used in document head)
-        if (node.name.type === 'JSXIdentifier' && node.name.name === 'title') {
-          return
-        }
-
-        // Find className attribute
-        const classNameAttr = node.attributes.find(
-          attr => attr.type === 'JSXAttribute' && attr.name.name === 'className'
-        )
-
-        if (!classNameAttr) {
-          context.report({
-            node,
-            messageId: 'missingClassName',
-          })
-          return
-        }
-
-        // Check if className is an empty string
-        const value = classNameAttr.value
-        if (value && value.type === 'Literal' && value.value === '') {
-          context.report({
-            node,
-            messageId: 'emptyClassName',
-          })
-        }
-      },
-    }
-  },
-}
-
-export { jsxClassNameRequiredRule }