eslint-config-agent 1.0.21 → 1.0.22

package/CHANGELOG.md

@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file. See [Conven
 
 
 
+## [1.0.22](https://github.com/tupe12334/eslint-config/compare/v1.0.21...v1.0.22) (2025-09-04)
+
+### Features
+
+* add max-lines and max-lines-per-function rules with configurations and tests ([218f29c](https://github.com/tupe12334/eslint-config/commit/218f29ca497ca1b49e027f3e33f87cf836e7ff02))
+
+### Bug Fixes
+
+* resolve linting issues for release ([3c812cd](https://github.com/tupe12334/eslint-config/commit/3c812cd223f169360cb0d1520e401a17a6a9b960))
+
 ## [1.0.21](https://github.com/tupe12334/eslint-config/compare/v1.0.19...v1.0.21) (2025-09-04)
 
 ### Bug Fixes

package/index.js

@@ -7,6 +7,8 @@ import reactPlugin from "eslint-plugin-react";
 import importPlugin from "eslint-plugin-import";
 import globals from "globals";
 import noTrailingSpacesConfig from "./rules/no-trailing-spaces/index.js";
+import { maxFunctionLinesWarning, maxFunctionLinesError } from "./rules/max-function-lines/index.js";
+import { maxFileLinesWarning, maxFileLinesError } from "./rules/max-file-lines/index.js";
 
 // Conditionally import preact plugin if available
 let preactPlugin = null;
@@ -41,10 +43,8 @@ const sharedRules = {
   "import/first": "off",
   "import/prefer-default-export": "off",
   "react/react-in-jsx-scope": "off",
-  "max-lines-per-function": [
-    "warn",
-    { max: 100, skipBlankLines: true, skipComments: true },
-  ],
+  "max-lines-per-function": maxFunctionLinesWarning,
+  "max-lines": maxFileLinesWarning,
   "react/jsx-filename-extension": ["error", { extensions: [".tsx", ".jsx"] }],
   semi: "off",
   "react/function-component-definition": "off",
@@ -73,8 +73,10 @@ const sharedRestrictedSyntax = [
     message: "Optional chaining is not allowed.",
   },
   {
-    selector: "MemberExpression[object.type='MemberExpression'][object.object.name='process'][object.property.name='env']",
-    message: "Direct access to process.env properties is not allowed. Use a configuration object or environment validation instead.",
+    selector:
+      "MemberExpression[object.type='MemberExpression'][object.object.name='process'][object.property.name='env']",
+    message:
+      "Direct access to process.env properties is not allowed. Use a configuration object or environment validation instead.",
   },
   {
     selector: "CallExpression[optional=true]",
@@ -261,7 +263,6 @@ const config = [
   },
   js.configs.recommended,
 
-
   // TypeScript and TSX files
   {
     files: ["**/*.ts", "**/*.tsx"],
@@ -500,10 +501,7 @@ const config = [
     },
     rules: {
       ...sharedRules,
-      "no-restricted-syntax": [
-        "error",
-        ...sharedRestrictedSyntax,
-      ],
+      "no-restricted-syntax": ["error", ...sharedRestrictedSyntax],
     },
   },
 
@@ -769,8 +767,10 @@ const config = [
         "error",
         // Process.env rule (applies to all file types)
         {
-          selector: "MemberExpression[object.type='MemberExpression'][object.object.name='process'][object.property.name='env']",
-          message: "Direct access to process.env properties is not allowed. Use a configuration object or environment validation instead.",
+          selector:
+            "MemberExpression[object.type='MemberExpression'][object.object.name='process'][object.property.name='env']",
+          message:
+            "Direct access to process.env properties is not allowed. Use a configuration object or environment validation instead.",
         },
         // Switch case rules as errors
         {
@@ -853,6 +853,30 @@ const config = [
     },
   },
 
+  // Function and file length rules - strict error thresholds
+  {
+    files: ["**/*.{ts,tsx,js,jsx}"],
+    rules: {
+      // Function length: error at 70+ lines
+      "max-lines-per-function": maxFunctionLinesError,
+      // File length: error at 100+ lines
+      "max-lines": maxFileLinesError,
+    },
+  },
+
+  // Disable file length rules for configuration and spec files
+  {
+    files: [
+      "index.js", // Main configuration file
+      "**/rules/**/*.spec.js", // Spec files in rules directory
+      "**/scripts/**/*.js", // Script files
+    ],
+    rules: {
+      "max-lines": "off",
+      "max-lines-per-function": "off",
+    },
+  },
+
   // Allow default exports in configuration files (must be last to override)
   {
     files: [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-agent",
-  "version": "1.0.21",
+  "version": "1.0.22",
   "description": "ESLint configuration package with TypeScript support",
   "main": "index.js",
   "type": "module",

package/rules/max-file-lines/index.js

@@ -0,0 +1,43 @@
+/**
+ * Rule configuration for max-lines
+ *
+ * This rule enforces a maximum number of lines per file to encourage
+ * smaller, more maintainable files and better separation of concerns.
+ *
+ * Warnings at >70 lines, errors at >100 lines
+ *
+ * @see https://eslint.org/docs/latest/rules/max-lines
+ */
+
+// Warning configuration (70 lines)
+export const warningRule = "warn";
+export const warningOptions = {
+  max: 70,
+  skipBlankLines: true,
+  skipComments: true,
+};
+
+// Error configuration (100 lines)
+export const errorRule = "error";
+export const errorOptions = {
+  max: 100,
+  skipBlankLines: true,
+  skipComments: true,
+};
+
+/**
+ * Export the warning rule configuration (applied first)
+ * Can be used in ESLint config as:
+ * "max-lines": maxFileLinesWarning
+ */
+export const maxFileLinesWarning = [warningRule, warningOptions];
+
+/**
+ * Export the error rule configuration (applied later to override)
+ * Can be used in ESLint config as:
+ * "max-lines": maxFileLinesError
+ */
+export const maxFileLinesError = [errorRule, errorOptions];
+
+// Default export is the warning configuration
+export default maxFileLinesWarning;

package/rules/max-file-lines/max-file-lines.spec.js

@@ -0,0 +1,75 @@
+/* global process */
+import {
+  warningRule,
+  warningOptions,
+  errorRule,
+  errorOptions,
+  maxFileLinesWarning,
+  maxFileLinesError
+} from "./index.js";
+
+console.log("Testing max-file-lines rule configuration exports...");
+
+// Test warning configuration
+console.log("\n📋 Warning Configuration:");
+console.log("Rule level:", warningRule);
+console.log("Options:", warningOptions);
+console.log("Complete config:", maxFileLinesWarning);
+
+// Validate warning configuration
+if (warningRule === "warn" &&
+    warningOptions.max === 70 &&
+    warningOptions.skipBlankLines === true &&
+    warningOptions.skipComments === true) {
+  console.log("✅ Warning configuration is correct");
+} else {
+  console.log("❌ Warning configuration is incorrect");
+  process.exit(1);
+}
+
+// Test error configuration
+console.log("\n📋 Error Configuration:");
+console.log("Rule level:", errorRule);
+console.log("Options:", errorOptions);
+console.log("Complete config:", maxFileLinesError);
+
+// Validate error configuration
+if (errorRule === "error" &&
+    errorOptions.max === 100 &&
+    errorOptions.skipBlankLines === true &&
+    errorOptions.skipComments === true) {
+  console.log("✅ Error configuration is correct");
+} else {
+  console.log("❌ Error configuration is incorrect");
+  process.exit(1);
+}
+
+console.log("\n✅ All max-file-lines configuration tests passed!");
+
+// Test that the configurations are properly formatted for ESLint
+console.log("\n📋 ESLint Configuration Format:");
+console.log("Warning format:", JSON.stringify(maxFileLinesWarning));
+console.log("Error format:", JSON.stringify(maxFileLinesError));
+
+// Validate ESLint format
+if (Array.isArray(maxFileLinesWarning) &&
+    maxFileLinesWarning.length === 2 &&
+    maxFileLinesWarning[0] === "warn" &&
+    typeof maxFileLinesWarning[1] === "object") {
+  console.log("✅ Warning ESLint format is correct");
+} else {
+  console.log("❌ Warning ESLint format is incorrect");
+  process.exit(1);
+}
+
+if (Array.isArray(maxFileLinesError) &&
+    maxFileLinesError.length === 2 &&
+    maxFileLinesError[0] === "error" &&
+    typeof maxFileLinesError[1] === "object") {
+  console.log("✅ Error ESLint format is correct");
+} else {
+  console.log("❌ Error ESLint format is incorrect");
+  process.exit(1);
+}
+
+console.log("\n🎉 All tests completed successfully!");

package/rules/max-function-lines/index.js

@@ -0,0 +1,43 @@
+/**
+ * Rule configuration for max-lines-per-function
+ *
+ * This rule enforces a maximum number of lines per function to encourage
+ * smaller, more maintainable functions.
+ *
+ * Warnings at >50 lines, errors at >70 lines
+ *
+ * @see https://eslint.org/docs/latest/rules/max-lines-per-function
+ */
+
+// Warning configuration (50 lines)
+export const warningRule = "warn";
+export const warningOptions = {
+  max: 50,
+  skipBlankLines: true,
+  skipComments: true,
+};
+
+// Error configuration (70 lines)
+export const errorRule = "error";
+export const errorOptions = {
+  max: 70,
+  skipBlankLines: true,
+  skipComments: true,
+};
+
+/**
+ * Export the warning rule configuration (applied first)
+ * Can be used in ESLint config as:
+ * "max-lines-per-function": maxFunctionLinesWarning
+ */
+export const maxFunctionLinesWarning = [warningRule, warningOptions];
+
+/**
+ * Export the error rule configuration (applied later to override)
+ * Can be used in ESLint config as:
+ * "max-lines-per-function": maxFunctionLinesError
+ */
+export const maxFunctionLinesError = [errorRule, errorOptions];
+
+// Default export is the warning configuration
+export default maxFunctionLinesWarning;

package/rules/max-function-lines/max-function-lines.spec.js

@@ -0,0 +1,75 @@
+/* global process */
+import {
+  warningRule,
+  warningOptions,
+  errorRule,
+  errorOptions,
+  maxFunctionLinesWarning,
+  maxFunctionLinesError
+} from "./index.js";
+
+console.log("Testing max-function-lines rule configuration exports...");
+
+// Test warning configuration
+console.log("\n📋 Warning Configuration:");
+console.log("Rule level:", warningRule);
+console.log("Options:", warningOptions);
+console.log("Complete config:", maxFunctionLinesWarning);
+
+// Validate warning configuration
+if (warningRule === "warn" &&
+    warningOptions.max === 50 &&
+    warningOptions.skipBlankLines === true &&
+    warningOptions.skipComments === true) {
+  console.log("✅ Warning configuration is correct");
+} else {
+  console.log("❌ Warning configuration is incorrect");
+  process.exit(1);
+}
+
+// Test error configuration
+console.log("\n📋 Error Configuration:");
+console.log("Rule level:", errorRule);
+console.log("Options:", errorOptions);
+console.log("Complete config:", maxFunctionLinesError);
+
+// Validate error configuration
+if (errorRule === "error" &&
+    errorOptions.max === 70 &&
+    errorOptions.skipBlankLines === true &&
+    errorOptions.skipComments === true) {
+  console.log("✅ Error configuration is correct");
+} else {
+  console.log("❌ Error configuration is incorrect");
+  process.exit(1);
+}
+
+console.log("\n✅ All max-function-lines configuration tests passed!");
+
+// Test that the configurations are properly formatted for ESLint
+console.log("\n📋 ESLint Configuration Format:");
+console.log("Warning format:", JSON.stringify(maxFunctionLinesWarning));
+console.log("Error format:", JSON.stringify(maxFunctionLinesError));
+
+// Validate ESLint format
+if (Array.isArray(maxFunctionLinesWarning) &&
+    maxFunctionLinesWarning.length === 2 &&
+    maxFunctionLinesWarning[0] === "warn" &&
+    typeof maxFunctionLinesWarning[1] === "object") {
+  console.log("✅ Warning ESLint format is correct");
+} else {
+  console.log("❌ Warning ESLint format is incorrect");
+  process.exit(1);
+}
+
+if (Array.isArray(maxFunctionLinesError) &&
+    maxFunctionLinesError.length === 2 &&
+    maxFunctionLinesError[0] === "error" &&
+    typeof maxFunctionLinesError[1] === "object") {
+  console.log("✅ Error ESLint format is correct");
+} else {
+  console.log("❌ Error ESLint format is incorrect");
+  process.exit(1);
+}
+
+console.log("\n🎉 All tests completed successfully!");