eslint-config-1stdibs 8.1.0 → 9.1.0

package/README.md

@@ -2,6 +2,13 @@
 
 ## Breaking Changes
 
+v9.0.0
+
+-   updated base `eslint` to `^9`
+-   provide v9 flat config
+-   export default config combined of base, react and ts
+-   re-export base config, export react and ts as separate files
+
 v5.0.0
 
 -   deleted `./rules/test.js` since it contained mocha-specific settings, base config contains `jest` rules

package/base.js

@@ -0,0 +1,4 @@
+const { defineConfig } = require('eslint/config');
+const baseConfig = require('eslint-config-1stdibs-base');
+
+module.exports = defineConfig(baseConfig);

package/index.js

@@ -1,3 +1,6 @@
-module.exports = {
-    extends: ['eslint-config-1stdibs-base', './rules/react'].map(require.resolve),
-};
+const { defineConfig } = require('eslint/config');
+const baseConfig = require('./base');
+const reactConfig = require('./react');
+const typescriptConfig = require('./typescript');
+
+module.exports = defineConfig([...baseConfig, ...reactConfig, ...typescriptConfig]);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-config-1stdibs",
   "github": "https://github.com/1stdibs/eslint-config-1stdibs",
-  "version": "8.1.0",
+  "version": "9.1.0",
   "description": "ESLint configurations for 1stdibs projects.",
   "main": "index.js",
   "author": "1stdibs <npm@1stdibs.com> (https://1stdibs.com)",
@@ -10,20 +10,22 @@
     "url": "https://github.com/1stdibs/eslint-config-1stdibs"
   },
   "dependencies": {
+    "@eslint/eslintrc": "^3.3.5",
+    "@eslint/js": "^9.3.4",
     "@typescript-eslint/eslint-plugin": "^8.25.0",
     "@typescript-eslint/parser": "^8.25.0",
-    "eslint-config-1stdibs-base": "^6.2.0",
+    "eslint-config-1stdibs-base": "^7.0.0",
     "eslint-plugin-import": "^2.31.0",
     "eslint-plugin-react": "^7.37.4",
-    "eslint-plugin-react-hooks": "5.0.0",
+    "eslint-plugin-react-hooks": "^7.1.1",
     "eslint-plugin-relay": "^2.0.0"
   },
   "devDependencies": {
-    "eslint": "*",
+    "eslint": ">=9.0.0",
     "typescript": "*"
   },
   "peerDependencies": {
-    "eslint": "*",
+    "eslint": ">=9.0.0",
     "typescript": "*"
   }
 }

package/react.js

@@ -0,0 +1,24 @@
+const { defineConfig } = require('eslint/config');
+
+// Plugins
+const reactPlugin = require('eslint-plugin-react');
+const reactHooksPlugin = require('eslint-plugin-react-hooks');
+const relayPlugin = require('eslint-plugin-relay');
+// Rules
+const { rules: reactRules } = require('./rules/react');
+
+module.exports = defineConfig([
+    {
+        plugins: {
+            react: reactPlugin,
+            'react-hooks': reactHooksPlugin,
+            relay: relayPlugin,
+        },
+        settings: {
+            react: {
+                version: '19.2',
+            },
+        },
+        rules: reactRules,
+    },
+]);

package/rules/react.js

@@ -1,16 +1,4 @@
 module.exports = {
-    extends: ['prettier/react'],
-    plugins: ['react', 'react-hooks', 'relay'],
-    settings: {
-        react: {
-            version: '16.5',
-        },
-    },
-    parserOptions: {
-        ecmaFeatures: {
-            jsx: true,
-        },
-    },
     rules: {
         'react/jsx-boolean-value': 'warn',
         'react/jsx-no-duplicate-props': 'error',
@@ -29,6 +17,7 @@ module.exports = {
         'react/prefer-es6-class': ['warn', 'always'],
         'react/prefer-stateless-function': 'warn',
         'react/jsx-no-target-blank': 'warn',
+        // Core hooks rules
         'react-hooks/rules-of-hooks': 'error',
         'react-hooks/exhaustive-deps': 'warn',
         // relay

package/rules/typescript.js

@@ -0,0 +1,39 @@
+module.exports = {
+    rules: {
+        'react/prop-types': 'off',
+        '@typescript-eslint/camelcase': 'off',
+        '@typescript-eslint/explicit-member-accessibility': 'off',
+        '@typescript-eslint/no-explicit-any': 'warn',
+        '@typescript-eslint/prefer-interface': 'off',
+        '@typescript-eslint/explicit-function-return-type': [
+            'error',
+            {
+                allowExpressions: true,
+                allowTypedFunctionExpressions: true,
+            },
+        ],
+        '@typescript-eslint/indent': 'off',
+        'no-restricted-syntax': [
+            'error',
+            {
+                selector: 'TSEnumDeclaration',
+                message: "Don't declare enums. TypeScript + babel issues",
+            },
+        ],
+        'import/consistent-type-specifier-style': ['error', 'prefer-inline'],
+        '@typescript-eslint/no-inferrable-types': 'off',
+        '@typescript-eslint/ban-ts-ignore': 'off',
+        '@typescript-eslint/ban-ts-comment': 'off',
+        '@typescript-eslint/no-empty-function': 'off',
+        // turn off generic no-use-before-define
+        'no-use-before-define': 'off',
+        // turn on ts supported no-use-before-define
+        '@typescript-eslint/no-use-before-define': 'error',
+        '@typescript-eslint/no-unused-vars': [
+            'error',
+            {
+                caughtErrors: 'none',
+            },
+        ],
+    },
+};

package/typescript.js

@@ -1,47 +1,38 @@
-module.exports = {
-    plugins: ['@typescript-eslint/eslint-plugin'],
-    parser: '@typescript-eslint/parser', // Specifies the ESLint parser
-    extends: [
-        'eslint-config-1stdibs-base',
-        'plugin:@typescript-eslint/recommended',
-        'prettier/@typescript-eslint', // Uses eslint-config-prettier to disable ESLint rules from @typescript-eslint/eslint-plugin that would conflict with prettier
-        'plugin:import/typescript',
-    ],
-    rules: {
-        'react/prop-types': 'off',
-        '@typescript-eslint/camelcase': 'off',
-        '@typescript-eslint/explicit-member-accessibility': 'off',
-        '@typescript-eslint/no-explicit-any': 'warn',
-        '@typescript-eslint/prefer-interface': 'off',
-        '@typescript-eslint/explicit-function-return-type': [
-            'error',
-            {
-                allowExpressions: true,
-                allowTypedFunctionExpressions: true,
-            },
-        ],
-        '@typescript-eslint/indent': 'off',
-        'no-restricted-syntax': [
-            'error',
-            {
-                selector: 'TSEnumDeclaration',
-                message: "Don't declare enums. TypeScript + babel issues",
-            },
-        ],
-        'import/consistent-type-specifier-style': ['error', 'prefer-inline'],
-        '@typescript-eslint/no-inferrable-types': 'off',
-        '@typescript-eslint/ban-ts-ignore': 'off',
-        '@typescript-eslint/ban-ts-comment': 'off',
-        '@typescript-eslint/no-empty-function': 'off',
-        // turn off generic no-use-before-define
-        'no-use-before-define': 'off',
-        // turn on ts supported no-use-before-define
-        '@typescript-eslint/no-use-before-define': 'error',
-        '@typescript-eslint/no-unused-vars': [
-            'error',
-            {
-                caughtErrors: 'none',
-            },
-        ],
+const { defineConfig } = require('eslint/config');
+const { FlatCompat } = require('@eslint/eslintrc');
+const js = require('@eslint/js');
+
+// Plugins
+const tsPlugin = require('@typescript-eslint/eslint-plugin');
+const importPlugin = require('eslint-plugin-import');
+// Parser
+const tsParser = require('@typescript-eslint/parser');
+// Rules
+const { rules: typescriptRules } = require('./rules/typescript');
+
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all,
+});
+
+module.exports = defineConfig([
+    {
+        files: ['**/*.{ts,tsx,cts,mts}'],
+        extends: compat.extends('plugin:@typescript-eslint/recommended'),
+        plugins: {
+            '@typescript-eslint': tsPlugin,
+        },
+        languageOptions: {
+            parser: tsParser,
+        },
+        settings: {
+            ...importPlugin.flatConfigs.typescript.settings,
+        },
+        rules: {
+            ...tsPlugin.configs.recommended.rules,
+            ...importPlugin.flatConfigs.typescript.rules,
+            ...typescriptRules,
+        },
     },
-};
+]);