eslint-cdk-plugin 3.1.0 → 3.2.0

package/dist/index.mjs

@@ -3,12 +3,18 @@ import { ESLintUtils, AST_NODE_TYPES, AST_TOKEN_TYPES } from '@typescript-eslint
 import * as path from 'path';
 
 var name = "eslint-cdk-plugin";
-var version = "3.1.0";
+var version = "3.2.0";
 
 const createRule = ESLintUtils.RuleCreator(
   (name) => `https://eslint-cdk-plugin.dev/rules/${name}`
 );
 
+const getConstructor = (node) => {
+  return node.body.body.find(
+    (member) => member.type === AST_NODE_TYPES.MethodDefinition && member.kind === "constructor"
+  );
+};
+
 const isConstructOrStackType = (type, ignoredClasses = ["App", "Stage"]) => {
   if (ignoredClasses.includes(type.symbol?.name ?? "")) return false;
   return isTargetSuperClassType(
@@ -51,9 +57,7 @@ const constructConstructorProperty = createRule({
       ClassDeclaration(node) {
         const type = parserServices.getTypeAtLocation(node);
         if (!isConstructType(type)) return;
-        const constructor = node.body.body.find(
-          (member) => member.type === AST_NODE_TYPES.MethodDefinition && member.kind === "constructor"
-        );
+        const constructor = getConstructor(node);
         if (!constructor) return;
         validateConstructorProperty(constructor, context, parserServices);
       }
@@ -174,9 +178,7 @@ const noConstructInPublicPropertyOfConstruct = createRule({
         const type = parserServices.getTypeAtLocation(node);
         if (!isConstructOrStackType(type)) return;
         validatePublicPropertyOfConstruct(node, context, parserServices);
-        const constructor = node.body.body.find(
-          (member) => member.type === AST_NODE_TYPES.MethodDefinition && member.kind === "constructor"
-        );
+        const constructor = getConstructor(node);
         if (!constructor || constructor.value.type !== AST_NODE_TYPES.FunctionExpression) {
           return;
         }
@@ -244,6 +246,12 @@ const toPascalCase = (str) => {
   }).join("");
 };
 
+const getPropertyNames = (properties) => {
+  return properties.reduce(
+    (acc, prop) => prop.type === AST_NODE_TYPES.Property && prop.key.type === AST_NODE_TYPES.Identifier ? [...acc, prop.key.name] : acc,
+    []
+  );
+};
 const getConstructorPropertyNames = (type) => {
   const declarations = type.symbol?.declarations;
   if (!declarations?.length) return [];
@@ -765,6 +773,176 @@ const validateConstructId$2 = ({
   }
 };
 
+const propsUsageTrackerFactory = (propsType) => {
+  const getPropsPropertyNames = (propsType2) => {
+    const typeProperties = propsType2.getProperties();
+    if (typeProperties.length) {
+      return typeProperties.reduce(
+        (acc, prop) => !isInternalProperty(prop.name) ? [...acc, prop.name] : acc,
+        []
+      );
+    }
+    const symbol = propsType2.getSymbol();
+    if (!symbol?.members) return [];
+    return Array.from(symbol.members.keys()).reduce((acc, key) => {
+      const name = String(key);
+      return !isInternalProperty(name) ? [...acc, name] : acc;
+    }, []);
+  };
+  const isInternalProperty = (propertyName) => {
+    return propertyName.startsWith("_") || propertyName === "constructor" || propertyName === "prototype";
+  };
+  const markAsUsed = (propertyName) => {
+    if (propUsages.has(propertyName)) propUsages.set(propertyName, true);
+  };
+  const propUsages = new Map(
+    getPropsPropertyNames(propsType).map((name) => [name, false])
+  );
+  const getUnusedProperties = () => {
+    return Array.from(propUsages.entries()).reduce(
+      (acc, [name, used]) => !used ? [...acc, name] : acc,
+      []
+    );
+  };
+  const markAsUsedForMemberExpression = (node, propsParamName) => {
+    if (node.object.type === AST_NODE_TYPES.Identifier && node.object.name === propsParamName && node.property.type === AST_NODE_TYPES.Identifier) {
+      markAsUsed(node.property.name);
+      return;
+    }
+    if (node.object.type === AST_NODE_TYPES.MemberExpression && node.object.object.type === AST_NODE_TYPES.ThisExpression && node.object.property.type === AST_NODE_TYPES.Identifier && node.object.property.name === "props" && node.property.type === AST_NODE_TYPES.Identifier) {
+      markAsUsed(node.property.name);
+      return;
+    }
+  };
+  const markAsUsedForVariableDeclarator = (node, propsParamName) => {
+    if (node.id.type !== AST_NODE_TYPES.ObjectPattern || node.init?.type !== AST_NODE_TYPES.Identifier || node.init.name !== propsParamName) {
+      return;
+    }
+    const propertyNames = getPropertyNames(node.id.properties);
+    for (const name of propertyNames) {
+      markAsUsed(name);
+    }
+  };
+  const markAsUsedForAssignmentExpression = (node, propsParamName) => {
+    if (node.right.type !== AST_NODE_TYPES.MemberExpression || node.right.object.type !== AST_NODE_TYPES.Identifier || node.right.object.name !== propsParamName || node.right.property.type !== AST_NODE_TYPES.Identifier) {
+      return;
+    }
+    markAsUsed(node.right.property.name);
+  };
+  const markAsUsedForObjectPattern = (node) => {
+    for (const propName of getPropertyNames(node.properties)) {
+      markAsUsed(propName);
+    }
+  };
+  if (!propUsages.size) return null;
+  return {
+    getUnusedProperties,
+    markAsUsedForMemberExpression,
+    markAsUsedForVariableDeclarator,
+    markAsUsedForAssignmentExpression,
+    markAsUsedForObjectPattern
+  };
+};
+
+const noUnusedProps = createRule({
+  name: "no-unused-props",
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "Enforces that all properties defined in props type are used within the constructor"
+    },
+    messages: {
+      unusedProp: "Property '{{propName}}' is defined in props but never used"
+    },
+    schema: []
+  },
+  defaultOptions: [],
+  create(context) {
+    const parserServices = ESLintUtils.getParserServices(context);
+    return {
+      ClassDeclaration(node) {
+        const type = parserServices.getTypeAtLocation(node);
+        if (!isConstructType(type)) return;
+        const constructor = getConstructor(node);
+        if (!constructor) return;
+        analyzePropsUsage(constructor, context, parserServices);
+      }
+    };
+  }
+});
+const analyzePropsUsage = (constructor, context, parserServices) => {
+  const params = constructor.value.params;
+  if (params.length < 3) return;
+  const propsParam = params[2];
+  switch (propsParam.type) {
+    case AST_NODE_TYPES.Identifier: {
+      const propsType = parserServices.getTypeAtLocation(propsParam);
+      const tracker = propsUsageTrackerFactory(propsType);
+      if (!tracker || !constructor.value.body) return;
+      analyzeConstructorBody(constructor.value.body, propsParam.name, tracker);
+      reportUnusedProperties(tracker, propsParam, context);
+      return;
+    }
+    case AST_NODE_TYPES.ObjectPattern: {
+      const typeAnnotation = propsParam.typeAnnotation?.typeAnnotation;
+      if (!typeAnnotation) return;
+      const propsType = parserServices.getTypeAtLocation(typeAnnotation);
+      const tracker = propsUsageTrackerFactory(propsType);
+      if (!tracker) return;
+      tracker.markAsUsedForObjectPattern(propsParam);
+      reportUnusedProperties(tracker, propsParam, context);
+      return;
+    }
+    default:
+      return;
+  }
+};
+const analyzeConstructorBody = (body, propsParamName, tracker) => {
+  const visited = /* @__PURE__ */ new Set();
+  const visitNode = (node) => {
+    if (visited.has(node)) return;
+    visited.add(node);
+    switch (node.type) {
+      case AST_NODE_TYPES.MemberExpression:
+        tracker.markAsUsedForMemberExpression(node, propsParamName);
+        break;
+      case AST_NODE_TYPES.VariableDeclarator:
+        tracker.markAsUsedForVariableDeclarator(node, propsParamName);
+        break;
+      case AST_NODE_TYPES.AssignmentExpression:
+        tracker.markAsUsedForAssignmentExpression(node, propsParamName);
+        break;
+    }
+    const children = getChildNodes(node);
+    for (const child of children) {
+      visitNode(child);
+    }
+  };
+  visitNode(body);
+};
+const reportUnusedProperties = (tracker, propsParam, context) => {
+  for (const propName of tracker.getUnusedProperties()) {
+    context.report({
+      node: propsParam,
+      messageId: "unusedProp",
+      data: {
+        propName
+      }
+    });
+  }
+};
+const getChildNodes = (node) => {
+  return Object.entries(node).reduce((acc, [key, value]) => {
+    if (["parent", "range", "loc"].includes(key)) return acc;
+    if (isESTreeNode(value)) return [...acc, value];
+    if (Array.isArray(value)) return [...acc, ...value.filter(isESTreeNode)];
+    return acc;
+  }, []);
+};
+const isESTreeNode = (value) => {
+  return value !== null && typeof value === "object" && "type" in value && typeof value.type === "string";
+};
+
 const noVariableConstructId = createRule({
   name: "no-variable-construct-id",
   meta: {
@@ -901,10 +1079,9 @@ const propsNameConvention = createRule({
         if (!node.id || !node.superClass) return;
         const type = parserServices.getTypeAtLocation(node.superClass);
         if (!isConstructType(type)) return;
-        const constructor = node.body.body.find(
-          (member) => member.type === AST_NODE_TYPES.MethodDefinition && member.kind === "constructor"
-        );
-        const propsParam = constructor?.value.params?.[2];
+        const constructor = getConstructor(node);
+        if (!constructor) return;
+        const propsParam = constructor.value.params?.[2];
         if (propsParam?.type !== AST_NODE_TYPES.Identifier) return;
         const typeAnnotation = propsParam.typeAnnotation;
         if (typeAnnotation?.type !== AST_NODE_TYPES.TSTypeAnnotation) return;
@@ -946,9 +1123,10 @@ const requireJSDoc = createRule({
     const parserServices = ESLintUtils.getParserServices(context);
     return {
       TSPropertySignature(node) {
-        if (node.key.type !== AST_NODE_TYPES.Identifier || node.parent?.type !== AST_NODE_TYPES.TSInterfaceBody) {
-          return;
-        }
+        if (node.key.type !== AST_NODE_TYPES.Identifier) return;
+        const parent = node.parent.parent;
+        if (parent.type !== AST_NODE_TYPES.TSInterfaceDeclaration) return;
+        if (!parent.id.name.endsWith("Props")) return;
         const sourceCode = context.sourceCode;
         const comments = sourceCode.getCommentsBefore(node);
         const hasJSDoc = comments.some(
@@ -1077,14 +1255,11 @@ const requirePropsDefaultDoc = createRule({
   create(context) {
     return {
       TSPropertySignature(node) {
+        if (node.key.type !== AST_NODE_TYPES.Identifier) return;
         if (!node.optional) return;
-        const parent = node.parent?.parent;
-        if (parent?.type !== AST_NODE_TYPES.TSInterfaceDeclaration) {
-          return;
-        }
-        if (parent.id.type !== AST_NODE_TYPES.Identifier || !parent.id.name.endsWith("Props")) {
-          return;
-        }
+        const parent = node.parent.parent;
+        if (parent.type !== AST_NODE_TYPES.TSInterfaceDeclaration) return;
+        if (!parent.id.name.endsWith("Props")) return;
         const sourceCode = context.sourceCode;
         const comments = sourceCode.getCommentsBefore(node);
         const hasDefaultDoc = comments.some(
@@ -1095,7 +1270,7 @@ const requirePropsDefaultDoc = createRule({
             node,
             messageId: "missingDefaultDoc",
             data: {
-              propertyName: node.key.type === AST_NODE_TYPES.Identifier ? node.key.name : "unknown"
+              propertyName: node.key.name
             }
           });
         }
@@ -1113,6 +1288,7 @@ const rules = {
   "no-mutable-property-of-props-interface": noMutablePropertyOfPropsInterface,
   "no-mutable-public-property-of-construct": noMutablePublicPropertyOfConstruct,
   "no-parent-name-construct-id-match": noParentNameConstructIdMatch,
+  "no-unused-props": noUnusedProps,
   "no-variable-construct-id": noVariableConstructId,
   "pascal-case-construct-id": pascalCaseConstructId,
   "props-name-convention": propsNameConvention,
@@ -1149,6 +1325,8 @@ const recommended = createFlatConfig({
     "error",
     { disallowContainingParentName: false }
   ],
+  // TODO: Enable this rule at v4.0.0
+  // "cdk/no-unused-props": "error",
   "cdk/no-variable-construct-id": "error",
   "cdk/pascal-case-construct-id": "error",
   "cdk/require-passing-this": ["error", { allowNonThisAndDisallowScope: true }]
@@ -1165,6 +1343,7 @@ const strict = createFlatConfig({
     "error",
     { disallowContainingParentName: true }
   ],
+  "cdk/no-unused-props": "error",
   "cdk/no-variable-construct-id": "error",
   "cdk/pascal-case-construct-id": "error",
   "cdk/props-name-convention": "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-cdk-plugin",
-  "version": "3.1.0",
+  "version": "3.2.0",
   "description": "eslint plugin for AWS CDK projects",
   "main": "./dist/index.mjs",
   "types": "./dist/index.d.ts",

package/src/index.ts

@@ -1,4 +1,5 @@
 import tsParser from "@typescript-eslint/parser";
+import { FlatConfig } from "@typescript-eslint/utils/ts-eslint";
 
 import { name, version } from "../package.json";
 
@@ -10,6 +11,7 @@ import { noImportPrivate } from "./rules/no-import-private";
 import { noMutablePropertyOfPropsInterface } from "./rules/no-mutable-property-of-props-interface";
 import { noMutablePublicPropertyOfConstruct } from "./rules/no-mutable-public-property-of-construct";
 import { noParentNameConstructIdMatch } from "./rules/no-parent-name-construct-id-match";
+import { noUnusedProps } from "./rules/no-unused-props";
 import { noVariableConstructId } from "./rules/no-variable-construct-id";
 import { pascalCaseConstructId } from "./rules/pascal-case-construct-id";
 import { propsNameConvention } from "./rules/props-name-convention";
@@ -27,6 +29,7 @@ const rules = {
   "no-mutable-property-of-props-interface": noMutablePropertyOfPropsInterface,
   "no-mutable-public-property-of-construct": noMutablePublicPropertyOfConstruct,
   "no-parent-name-construct-id-match": noParentNameConstructIdMatch,
+  "no-unused-props": noUnusedProps,
   "no-variable-construct-id": noVariableConstructId,
   "pascal-case-construct-id": pascalCaseConstructId,
   "props-name-convention": propsNameConvention,
@@ -40,7 +43,13 @@ const cdkPlugin = {
   rules,
 };
 
-const createFlatConfig = (rules: Record<string, unknown>) => {
+const createFlatConfig = (
+  rules: FlatConfig.Rules
+): {
+  languageOptions: FlatConfig.LanguageOptions;
+  plugins: FlatConfig.Plugins;
+  rules: FlatConfig.Rules;
+} => {
   return {
     languageOptions: {
       parser: tsParser,
@@ -66,6 +75,8 @@ const recommended = createFlatConfig({
     "error",
     { disallowContainingParentName: false },
   ],
+  // TODO: Enable this rule at v4.0.0
+  // "cdk/no-unused-props": "error",
   "cdk/no-variable-construct-id": "error",
   "cdk/pascal-case-construct-id": "error",
   "cdk/require-passing-this": ["error", { allowNonThisAndDisallowScope: true }],
@@ -83,6 +94,7 @@ const strict = createFlatConfig({
     "error",
     { disallowContainingParentName: true },
   ],
+  "cdk/no-unused-props": "error",
   "cdk/no-variable-construct-id": "error",
   "cdk/pascal-case-construct-id": "error",
   "cdk/props-name-convention": "error",
@@ -100,7 +112,10 @@ export { configs, rules };
 
 export interface EslintCdkPlugin {
   rules: typeof rules;
-  configs: typeof configs;
+  configs: Readonly<{
+    recommended: FlatConfig.Config;
+    strict: FlatConfig.Config;
+  }>;
 }
 
 const eslintCdkPlugin: EslintCdkPlugin = {

package/src/rules/construct-constructor-property.ts

@@ -7,6 +7,7 @@ import {
 } from "@typescript-eslint/utils";
 
 import { createRule } from "../utils/createRule";
+import { getConstructor } from "../utils/getConstructor";
 import { isConstructType } from "../utils/typeCheck";
 
 type Context = TSESLint.RuleContext<
@@ -47,14 +48,7 @@ export const constructConstructorProperty = createRule({
         const type = parserServices.getTypeAtLocation(node);
         if (!isConstructType(type)) return;
 
-        // NOTE: Find the constructor method
-        const constructor = node.body.body.find(
-          (member): member is TSESTree.MethodDefinition =>
-            member.type === AST_NODE_TYPES.MethodDefinition &&
-            member.kind === "constructor"
-        );
-
-        // NOTE: Skip if there's no constructor
+        const constructor = getConstructor(node);
         if (!constructor) return;
 
         validateConstructorProperty(constructor, context, parserServices);

package/src/rules/no-construct-in-public-property-of-construct.ts

@@ -8,6 +8,7 @@ import {
 
 import { SYMBOL_FLAGS } from "../constants/tsInternalFlags";
 import { createRule } from "../utils/createRule";
+import { getConstructor } from "../utils/getConstructor";
 import { isConstructOrStackType } from "../utils/typeCheck";
 
 type Context = TSESLint.RuleContext<"invalidPublicPropertyOfConstruct", []>;
@@ -42,11 +43,7 @@ export const noConstructInPublicPropertyOfConstruct = createRule({
         validatePublicPropertyOfConstruct(node, context, parserServices);
 
         // NOTE: Check constructor parameter properties
-        const constructor = node.body.body.find(
-          (member): member is TSESTree.MethodDefinition =>
-            member.type === AST_NODE_TYPES.MethodDefinition &&
-            member.kind === "constructor"
-        );
+        const constructor = getConstructor(node);
         if (
           !constructor ||
           constructor.value.type !== AST_NODE_TYPES.FunctionExpression

package/src/rules/no-construct-stack-suffix.ts

@@ -7,7 +7,7 @@ import {
 
 import { toPascalCase } from "../utils/convertString";
 import { createRule } from "../utils/createRule";
-import { getConstructorPropertyNames } from "../utils/parseType";
+import { getConstructorPropertyNames } from "../utils/getPropertyNames";
 import { isConstructOrStackType } from "../utils/typeCheck";
 
 const SUFFIX_TYPE = {

package/src/rules/no-unused-props.ts

@@ -0,0 +1,176 @@
+import {
+  AST_NODE_TYPES,
+  ESLintUtils,
+  ParserServicesWithTypeInformation,
+  TSESLint,
+  TSESTree,
+} from "@typescript-eslint/utils";
+
+import { createRule } from "../utils/createRule";
+import { getConstructor } from "../utils/getConstructor";
+import {
+  IPropsUsageTracker,
+  propsUsageTrackerFactory,
+} from "../utils/propsUsageTracker";
+import { isConstructType } from "../utils/typeCheck";
+
+type Context = TSESLint.RuleContext<"unusedProp", []>;
+
+/**
+ * Enforces that all properties defined in props type are used within the constructor
+ * @param context - The rule context provided by ESLint
+ * @returns An object containing the AST visitor functions
+ */
+export const noUnusedProps = createRule({
+  name: "no-unused-props",
+  meta: {
+    type: "suggestion",
+    docs: {
+      description:
+        "Enforces that all properties defined in props type are used within the constructor",
+    },
+    messages: {
+      unusedProp: "Property '{{propName}}' is defined in props but never used",
+    },
+    schema: [],
+  },
+  defaultOptions: [],
+  create(context) {
+    const parserServices = ESLintUtils.getParserServices(context);
+
+    return {
+      ClassDeclaration(node) {
+        const type = parserServices.getTypeAtLocation(node);
+        if (!isConstructType(type)) return;
+
+        const constructor = getConstructor(node);
+        if (!constructor) return;
+
+        analyzePropsUsage(constructor, context, parserServices);
+      },
+    };
+  },
+});
+
+/**
+ * Analyzes props usage in the constructor
+ */
+const analyzePropsUsage = (
+  constructor: TSESTree.MethodDefinition,
+  context: Context,
+  parserServices: ParserServicesWithTypeInformation
+): void => {
+  const params = constructor.value.params;
+
+  // NOTE: Check if constructor has props parameter (3rd parameter)
+  if (params.length < 3) return;
+
+  const propsParam = params[2];
+
+  switch (propsParam.type) {
+    case AST_NODE_TYPES.Identifier: {
+      // NOTE: Standard props parameter (e.g. props: MyConstructProps)
+      const propsType = parserServices.getTypeAtLocation(propsParam);
+      const tracker = propsUsageTrackerFactory(propsType);
+      if (!tracker || !constructor.value.body) return;
+
+      analyzeConstructorBody(constructor.value.body, propsParam.name, tracker);
+      reportUnusedProperties(tracker, propsParam, context);
+      return;
+    }
+    case AST_NODE_TYPES.ObjectPattern: {
+      // NOTE: Inline destructuring (e.g. { bucketName, enableVersioning }: MyConstructProps)
+      const typeAnnotation = propsParam.typeAnnotation?.typeAnnotation;
+      if (!typeAnnotation) return;
+
+      const propsType = parserServices.getTypeAtLocation(typeAnnotation);
+      const tracker = propsUsageTrackerFactory(propsType);
+      if (!tracker) return;
+
+      tracker.markAsUsedForObjectPattern(propsParam);
+      reportUnusedProperties(tracker, propsParam, context);
+      return;
+    }
+    default:
+      return;
+  }
+};
+
+/**
+ * Analyzes constructor body for props usage patterns
+ */
+const analyzeConstructorBody = (
+  body: TSESTree.BlockStatement,
+  propsParamName: string,
+  tracker: IPropsUsageTracker
+): void => {
+  const visited = new Set<TSESTree.Node>();
+
+  const visitNode = (node: TSESTree.Node): void => {
+    if (visited.has(node)) return;
+    visited.add(node);
+
+    switch (node.type) {
+      case AST_NODE_TYPES.MemberExpression:
+        tracker.markAsUsedForMemberExpression(node, propsParamName);
+        break;
+      case AST_NODE_TYPES.VariableDeclarator:
+        tracker.markAsUsedForVariableDeclarator(node, propsParamName);
+        break;
+      case AST_NODE_TYPES.AssignmentExpression:
+        tracker.markAsUsedForAssignmentExpression(node, propsParamName);
+        break;
+    }
+
+    // NOTE: Recursively visit child nodes
+    const children = getChildNodes(node);
+    for (const child of children) {
+      visitNode(child);
+    }
+  };
+
+  visitNode(body);
+};
+
+/**
+ * Reports unused properties to ESLint
+ */
+const reportUnusedProperties = (
+  tracker: IPropsUsageTracker,
+  propsParam: TSESTree.Parameter,
+  context: Context
+): void => {
+  for (const propName of tracker.getUnusedProperties()) {
+    context.report({
+      node: propsParam,
+      messageId: "unusedProp",
+      data: {
+        propName,
+      },
+    });
+  }
+};
+
+/**
+ * Safely gets child nodes from a TSESTree.Node
+ */
+const getChildNodes = (node: TSESTree.Node): TSESTree.Node[] => {
+  return Object.entries(node).reduce<TSESTree.Node[]>((acc, [key, value]) => {
+    if (["parent", "range", "loc"].includes(key)) return acc; // Keys to skip to avoid circular references and unnecessary properties
+    if (isESTreeNode(value)) return [...acc, value];
+    if (Array.isArray(value)) return [...acc, ...value.filter(isESTreeNode)];
+    return acc;
+  }, []);
+};
+
+/**
+ * Type guard to check if a value is a TSESTree.Node
+ */
+const isESTreeNode = (value: unknown): value is TSESTree.Node => {
+  return (
+    value !== null &&
+    typeof value === "object" &&
+    "type" in value &&
+    typeof (value as { type: unknown }).type === "string"
+  );
+};

package/src/rules/no-variable-construct-id.ts

@@ -6,7 +6,7 @@ import {
 } from "@typescript-eslint/utils";
 
 import { createRule } from "../utils/createRule";
-import { getConstructorPropertyNames } from "../utils/parseType";
+import { getConstructorPropertyNames } from "../utils/getPropertyNames";
 import { isConstructType } from "../utils/typeCheck";
 
 type Context = TSESLint.RuleContext<"invalidConstructId", []>;

package/src/rules/pascal-case-construct-id.ts

@@ -7,7 +7,7 @@ import {
 
 import { toPascalCase } from "../utils/convertString";
 import { createRule } from "../utils/createRule";
-import { getConstructorPropertyNames } from "../utils/parseType";
+import { getConstructorPropertyNames } from "../utils/getPropertyNames";
 import { isConstructOrStackType } from "../utils/typeCheck";
 
 const QUOTE_TYPE = {

package/src/rules/props-name-convention.ts

@@ -1,10 +1,7 @@
-import {
-  AST_NODE_TYPES,
-  ESLintUtils,
-  TSESTree,
-} from "@typescript-eslint/utils";
+import { AST_NODE_TYPES, ESLintUtils } from "@typescript-eslint/utils";
 
 import { createRule } from "../utils/createRule";
+import { getConstructor } from "../utils/getConstructor";
 import { isConstructType } from "../utils/typeCheck";
 
 /**
@@ -37,13 +34,10 @@ export const propsNameConvention = createRule({
         if (!isConstructType(type)) return;
 
         // NOTE: check constructor parameter
-        const constructor = node.body.body.find(
-          (member): member is TSESTree.MethodDefinition =>
-            member.type === AST_NODE_TYPES.MethodDefinition &&
-            member.kind === "constructor"
-        );
+        const constructor = getConstructor(node);
+        if (!constructor) return;
 
-        const propsParam = constructor?.value.params?.[2];
+        const propsParam = constructor.value.params?.[2];
         if (propsParam?.type !== AST_NODE_TYPES.Identifier) return;
 
         const typeAnnotation = propsParam.typeAnnotation;