errhandler-rca 1.0.0 → 1.0.1

package/errorHandler.js

@@ -1,38 +1,38 @@
-const { CommandSucceededEvent } = require("mongodb");
-
 const errorHandler = (err, req, res, next) => {
-    console.error(err.stack);
+    // Default values
+    let statusCode = err.statusCode || 500;
+    let message = err.message || 'Server Error';
+
+    // Log error only in development
+    if (process.env.NODE_ENV !== 'production') {
+        console.error(err);
+    }
 
-    //Mongoose Validational error
+    // Mongoose Validation Error
     if (err.name === 'ValidationError') {
-        const message = Object.values(err.errors).map(e => e.message);
-        return res.status(400).json({
-            success: false,
-            error: message.join(', ')
-        })
+        statusCode = 400;
+        message = Object.values(err.errors)
+            .map(error => error.message)
+            .join(', ');
     }
 
-    //Mongoose Bad objectId
+    // Mongoose CastError (Invalid ObjectId)
     if (err.name === 'CastError') {
-        return res.status(404).json({
-            success: false,
-            error: 'Resource Not Found'
-        })
+        statusCode = 404;
+        message = 'Resource not found';
     }
 
-    //Mongoose Duplicate key(Handling Duplicated Keys)
+    // MongoDB Duplicate Key Error
     if (err.code === 11000) {
-        return res.status(400).json({
-            success: false,
-            error: 'Duplicated Field Value Entered'
-        })
+        statusCode = 400;
+        const field = Object.keys(err.keyValue)[0];
+        message = `${field} already exists`;
     }
 
-    //Handling a default erro
-    res.status(err.statusCode || 500).json({
+    res.status(statusCode).json({
         success: false,
-        error: err.message || 'Server Error'
-    })
+        error: message
+    });
 };
 
-module.exports = errorHandler
+module.exports = errorHandler;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "errhandler-rca",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "this package will help people handle errors when using Nodejs to use in thier backend systems",
   "main": "errorHandler.js",
   "scripts": {