erosolar-cli 2.1.167 → 2.1.169

package/dist/shell/interactiveShell.js

@@ -134,8 +134,6 @@ export class InteractiveShell {
     lastContextWarningLevel = null;
     sessionPreferences;
     autosaveEnabled;
-    autoContinueEnabled;
-    autoContinueEnforced = true;
     verificationEnabled = false;
     criticalApprovalMode = 'auto';
     editGuardMode = 'display-edits';
@@ -162,10 +160,6 @@ export class InteractiveShell {
     lastUserQuery = '';
     lastAssistantResponse = null;
     responseRendered = false;
-    autoContinueInsightState = {
-        attempt: 0,
-        lastMessage: null,
-    };
     lastFailure = null;
     lastAutoTestRun = null;
     // Auto-build tracking
@@ -209,12 +203,6 @@ export class InteractiveShell {
         this.sessionPreferences = loadSessionPreferences();
         this.thinkingMode = this.sessionPreferences.thinkingMode;
         this.autosaveEnabled = this.sessionPreferences.autosave;
-        this.autoContinueEnabled = this.sessionPreferences.autoContinue;
-        if (this.autoContinueEnforced && !this.autoContinueEnabled) {
-            // Project policy: keep auto-continue locked on to avoid stalls
-            this.autoContinueEnabled = true;
-            saveSessionPreferences({ autoContinue: true });
-        }
         this.criticalApprovalMode = this.sessionPreferences.criticalApprovalMode;
         const featureFlags = loadFeatureFlags();
         this.verificationEnabled = featureFlags.verification === true;
@@ -312,7 +300,6 @@ export class InteractiveShell {
             onChange: ({ text, cursor }) => this.handleInputChange(text, cursor, 'renderer'),
             onEditModeChange: (mode) => this.handleEditModeChange(mode),
             onToggleVerify: () => this.toggleVerificationMode(),
-            onToggleAutoContinue: () => this.toggleAutoContinueMode(),
             onToggleThinking: () => this.cycleThinkingMode(),
             onClearContext: () => this.handleClearContext(),
             onToggleCriticalApproval: () => this.toggleCriticalApprovalMode('shortcut'),
@@ -818,7 +805,6 @@ export class InteractiveShell {
             '/output-style',
             // Mode toggles
             '/thinking',
-            '/autocontinue',
             // Discovery and plugins
             '/local', '/discover',
             '/plugins',
@@ -908,65 +894,6 @@ export class InteractiveShell {
             : '🛡️ High-impact actions now require your approval. (Ctrl+Shift+A to toggle; use /approvals ask to persist)';
         display.showSystemMessage(message);
     }
-    enforceAutoContinuePolicy() {
-        if (!this.autoContinueEnforced) {
-            return;
-        }
-        if (!this.autoContinueEnabled) {
-            this.autoContinueEnabled = true;
-            saveSessionPreferences({ autoContinue: true });
-            if (this.agent) {
-                this.agent.setAutoContinue(true);
-            }
-            this.refreshControlBar();
-        }
-    }
-    resetAutoContinueInsights() {
-        this.autoContinueInsightState = { attempt: 0, lastMessage: null };
-    }
-    showAutoContinueInsight(attempt, maxAttempts, message) {
-        const normalized = (message || '').trim();
-        const isDuplicate = this.autoContinueInsightState.attempt === attempt &&
-            this.autoContinueInsightState.lastMessage === normalized;
-        if (isDuplicate) {
-            return;
-        }
-        this.autoContinueInsightState = { attempt, lastMessage: normalized };
-        const detail = normalized || 'Continuing automatically after intent without action.';
-        display.showSystemMessage(`Auto-continue ${attempt}/${maxAttempts}: ${detail}`);
-    }
-    toggleAutoContinueMode() {
-        if (this.autoContinueEnforced) {
-            this.enforceAutoContinuePolicy();
-            display.showInfo('Auto-continue is enforced ON for erosolar-cli reliability and cannot be disabled.');
-            return;
-        }
-        this.setAutoContinueMode(!this.autoContinueEnabled, 'shortcut');
-    }
-    setAutoContinueMode(enabled, source) {
-        if (this.autoContinueEnforced && !enabled) {
-            this.enforceAutoContinuePolicy();
-            if (source === 'command') {
-                display.showInfo('Auto-continue is enforced ON for erosolar-cli reliability and cannot be disabled.');
-            }
-            return;
-        }
-        const changed = this.autoContinueEnabled !== enabled;
-        this.autoContinueEnabled = enabled;
-        saveSessionPreferences({ autoContinue: this.autoContinueEnabled });
-        if (this.agent) {
-            this.agent.setAutoContinue(this.autoContinueEnabled);
-        }
-        this.refreshControlBar();
-        if (!changed && source === 'shortcut') {
-            return;
-        }
-        const modeLabel = this.autoContinueEnabled ? 'enabled' : 'disabled';
-        const behavior = this.autoContinueEnabled
-            ? 'The model will be auto-prompted to continue when it expresses intent but does not use tools.'
-            : 'The model will not be auto-prompted to continue.';
-        display.showInfo(`Auto-continue ${modeLabel}. ${behavior} Toggle with Ctrl+Shift+C.`);
-    }
     /**
      * Expand the last tool result (Ctrl+O shortcut).
      * Shows the full output from the most recent tool call.
@@ -1712,9 +1639,7 @@ export class InteractiveShell {
     refreshControlBar() {
         this.terminalInput.setModeToggles({
             verificationEnabled: this.verificationEnabled,
-            autoContinueEnabled: this.autoContinueEnabled,
             verificationHotkey: 'ctrl+shift+v',
-            autoContinueHotkey: 'ctrl+shift+c',
             thinkingModeLabel: (this.thinkingMode || 'off').toString(),
             thinkingHotkey: 'tab',
             criticalApprovalMode: this.criticalApprovalMode,
@@ -2493,9 +2418,6 @@ export class InteractiveShell {
                 case '/thinking':
                     this.handleThinkingCommand(input);
                     break;
-                case '/autocontinue':
-                    this.handleAutoContinueCommand(input);
-                    break;
                 case '/shortcuts':
                 case '/keys':
                     this.handleShortcutsCommand();
@@ -2659,7 +2581,6 @@ export class InteractiveShell {
             theme.bold('  Mode Toggles'),
             `    ${theme.info('Shift+Tab')}      ${theme.ui.muted('Toggle edit mode (auto/ask)')}`,
             `    ${theme.info('Option+V')}       ${theme.ui.muted('Toggle verification')}`,
-            `    ${theme.info('Option+C')}       ${theme.ui.muted('Toggle auto-continue')}`,
             `    ${theme.info('Ctrl+Shift+A')}   ${theme.ui.muted('Toggle approvals for high-impact actions')}`,
             `    ${theme.info('Option+T')}       ${theme.ui.muted('Cycle thinking mode')}`,
             `    ${theme.info('Option+E')}       ${theme.ui.muted('Toggle edit permission mode')}`,
@@ -4373,28 +4294,6 @@ export class InteractiveShell {
         clearAutosaveSnapshot(this.profile);
         display.showInfo('Cleared autosave history.');
     }
-    handleAutoContinueCommand(input) {
-        const tokens = input.split(/\s+/).slice(1);
-        const value = tokens[0]?.toLowerCase();
-        if (!value) {
-            // Show current status
-            const lockedNote = this.autoContinueEnforced
-                ? ' (locked ON for erosolar-cli reliability)'
-                : ' Use /autocontinue on|off or Ctrl+Shift+C to toggle.';
-            display.showInfo(`Auto-continue is ${this.autoContinueEnabled ? 'enabled' : 'disabled'}.${lockedNote}`);
-            return;
-        }
-        if (value !== 'on' && value !== 'off') {
-            display.showWarning('Usage: /autocontinue on|off');
-            return;
-        }
-        if (value === 'off' && this.autoContinueEnforced) {
-            this.enforceAutoContinuePolicy();
-            display.showInfo('Auto-continue is enforced ON for erosolar-cli reliability and cannot be disabled.');
-            return;
-        }
-        this.setAutoContinueMode(value === 'on', 'command');
-    }
     // ==================== Erosolar-CLI Style Commands ====================
     async handleRewindCommand(_input) {
         const lines = [];
@@ -4626,9 +4525,6 @@ export class InteractiveShell {
         lines.push(`${theme.primary('Provider/Model')}: ${theme.info(`${this.providerLabel(this.sessionState.provider)} · ${this.sessionState.model}`)}`);
         lines.push(`${theme.primary('Workspace')}: ${theme.ui.muted(this.abbreviatePath(this.workingDir))}`);
         lines.push(`${theme.primary('Autosave')}: ${this.autosaveEnabled ? theme.success('on') : theme.ui.muted('off')}`);
-        const autoContinueStatus = this.autoContinueEnabled ? 'on' : 'off';
-        const autoContinueLabel = this.autoContinueEnforced ? `${autoContinueStatus} (locked)` : autoContinueStatus;
-        lines.push(`${theme.primary('Auto-continue')}: ${this.autoContinueEnabled ? theme.success(autoContinueLabel) : theme.ui.muted(autoContinueLabel)}`);
         lines.push(`${theme.primary('Verification')}: ${this.verificationEnabled ? theme.success('on') : theme.ui.muted('off')}`);
         lines.push(`${theme.primary('Approvals')}: ${theme.ui.muted(this.describeEditGuardMode())}`);
         lines.push(`${theme.primary('Critical approvals')}: ${this.criticalApprovalMode === 'approval' ? theme.warning('ask') : theme.ui.muted('auto')}`);
@@ -5840,9 +5736,6 @@ export class InteractiveShell {
         this.clearInlinePanel();
         this.syncRendererInput();
     }
-    // NOTE: emitPromptAcknowledgement has been removed - acknowledgement is now handled
-    // by the onRequestReceived callback in agent.send(), which fires IMMEDIATELY when
-    // the request is received, guaranteeing instant user feedback before any processing.
     async processRequest(request) {
         if (this.isProcessing) {
             this.enqueueFollowUpAction({ type: 'request', text: request });
@@ -5858,8 +5751,6 @@ export class InteractiveShell {
         if (!agent) {
             return;
         }
-        this.enforceAutoContinuePolicy();
-        this.resetAutoContinueInsights();
         this.runtimeSession.toolRuntime.clearDiffSnapshots?.();
         if (this.suppressNextNetworkReset) {
             this.suppressNextNetworkReset = false;
@@ -5889,8 +5780,6 @@ export class InteractiveShell {
         this.currentTaskType = classifyTaskType(request);
         this.currentToolCalls = [];
         this.clearToolUsageMeta();
-        // NOTE: Acknowledgement is now handled by onRequestReceived callback in agent.send()
-        // This fires IMMEDIATELY when the request is received, before any provider call
         this.renderer?.setActivity('Starting...');
         this.uiAdapter.startProcessing('Working on your request');
         this.setProcessingStatus();
@@ -6013,8 +5902,6 @@ export class InteractiveShell {
         if (!agent) {
             return;
         }
-        this.enforceAutoContinuePolicy();
-        this.resetAutoContinueInsights();
         this.lastUserQuery = initialRequest;
         this.clearToolUsageMeta();
         this.isProcessing = true;
@@ -6037,7 +5924,6 @@ export class InteractiveShell {
         completionDetector.reset();
         // Display user prompt in scrollback (Claude Code style)
         this.logUserPrompt(initialRequest);
-        // NOTE: Acknowledgement is now handled by onRequestReceived callback in agent.send()
         display.showSystemMessage(`Continuous mode active. Ctrl+C to stop.`);
         this.uiAdapter.startProcessing('Continuous execution mode');
         this.setProcessingStatus();
@@ -6074,8 +5960,6 @@ When truly finished with ALL tasks, explicitly state "TASK_FULLY_COMPLETE".`;
                     // Send the request and capture the response (streaming disabled)
                     display.showThinking('Responding...');
                     this.refreshStatusLine(true);
-                    this.enforceAutoContinuePolicy();
-                    this.resetAutoContinueInsights();
                     const response = await agent.send(currentPrompt, true);
                     this.finishStreamingFormatter(undefined, { refreshPrompt: false, mode: 'complete' });
                     await this.awaitPendingCleanup();
@@ -6782,8 +6666,6 @@ Return ONLY JSON array:
             // Send the error to the agent for fixing
             display.showThinking('Analyzing build errors');
             this.refreshStatusLine(true);
-            this.enforceAutoContinuePolicy();
-            this.resetAutoContinueInsights();
             const response = await this.agent.send(prompt, true);
             display.stopThinking();
             this.refreshStatusLine(true);
@@ -6803,7 +6685,6 @@ Return ONLY JSON array:
     rebuildAgent() {
         try {
             ensureSecretForProvider(this.sessionState.provider);
-            this.enforceAutoContinuePolicy();
             this.runtimeSession.updateToolContext(this.sessionState);
             this.ensureActiveSummarizer(this.runtimeSession.contextManager);
             const selection = {
@@ -6813,16 +6694,26 @@ Return ONLY JSON array:
                 maxTokens: this.sessionState.maxTokens,
                 systemPrompt: this.buildSystemPrompt(),
                 reasoningEffort: this.sessionState.reasoningEffort,
-                autoContinue: this.autoContinueEnabled,
             };
             this.agent = this.runtimeSession.createAgent(selection, {
+                onRequestReceived: (requestPreview) => {
+                    const normalized = requestPreview?.trim();
+                    const activity = normalized ? `Working: ${normalized}` : 'Working';
+                    this.renderer?.setActivity(activity);
+                },
+                onBeforeFirstToolCall: (toolNames) => {
+                    const primaryTool = toolNames[0];
+                    if (primaryTool) {
+                        this.renderer?.setActivity(`Running ${primaryTool}`);
+                    }
+                    return undefined;
+                },
                 onStreamChunk: (chunk, type) => {
                     this.handleStreamChunk(chunk, type ?? 'content');
                 },
                 onAssistantMessage: (content, metadata) => {
                     const enriched = this.buildDisplayMetadata(metadata);
                     const streamedVisible = metadata.wasStreamed && this.streamingContentSeen && !this.streamingOutputSuppressed;
-                    const displaySuppressed = metadata.suppressDisplay === true;
                     let renderedFinal = false;
                     // Update streaming token count from usage info (more accurate than chunk counting)
                     if (metadata.usage) {
@@ -6842,16 +6733,14 @@ Return ONLY JSON array:
                         // Show the response if it wasn't already rendered during streaming
                         if (!streamedVisible) {
                             if (thoughtContent) {
-                                if (!displaySuppressed) {
-                                    const summary = this.extractThoughtSummary(thoughtContent);
-                                    if (summary) {
-                                        display.updateThinking(`💭 ${summary}`);
-                                    }
-                                    display.showAssistantMessage(thoughtContent, { ...enriched, isFinal: false });
-                                    renderedFinal = true;
+                                const summary = this.extractThoughtSummary(thoughtContent);
+                                if (summary) {
+                                    display.updateThinking(`💭 ${summary}`);
                                 }
+                                display.showAssistantMessage(thoughtContent, { ...enriched, isFinal: false });
+                                renderedFinal = true;
                             }
-                            if (finalContent && !displaySuppressed) {
+                            if (finalContent) {
                                 display.showAssistantMessage(finalContent, enriched);
                                 renderedFinal = true;
                             }
@@ -6869,7 +6758,7 @@ Return ONLY JSON array:
                                 this.updateContextUsage(percentage);
                             }
                         }
-                        if (finalContent && !displaySuppressed) {
+                        if (finalContent) {
                             this.lastAssistantResponse = finalContent;
                         }
                         // Track thought + response as a single response event for telemetry
@@ -6891,7 +6780,7 @@ Return ONLY JSON array:
                         // Stop spinner and show the narrative text directly
                         display.stopThinking();
                         // Skip display if content was already streamed to avoid double-display
-                        if (!streamedVisible && !displaySuppressed) {
+                        if (!streamedVisible) {
                             const narrative = content.trim();
                             if (narrative) {
                                 display.showNarrative(narrative);
@@ -6942,11 +6831,6 @@ Return ONLY JSON array:
                     this.updateStatusMessage('Retrying with reduced context...');
                     this.syncRendererInput();
                 },
-                onAutoContinue: (attempt, maxAttempts, message) => {
-                    // Surface insight about why auto-continue fired while keeping UX responsive
-                    this.renderer?.setActivity('Continuing...');
-                    this.showAutoContinueInsight(attempt, maxAttempts, message);
-                },
                 onCancelled: () => {
                     // Update UI to show operation was cancelled
                     display.showWarning('Operation cancelled.');
@@ -6981,48 +6865,11 @@ Return ONLY JSON array:
                         this.renderer?.setActivity('Thinking');
                     }
                 },
-                onBeforeFirstToolCall: (toolNames, hasModelNarration) => {
-                    // ALWAYS inject acknowledgement - even if model provided narration
-                    // This ensures user always sees immediate feedback that their request was received
-                    // The acknowledgement appears BEFORE any tool output
-                    const primaryTool = toolNames[0] || 'tools';
-                    const toolDescriptions = {
-                        'list_files': 'Looking at the project files...',
-                        'Glob': 'Searching for files...',
-                        'read_file': 'Reading the file...',
-                        'Read': 'Reading the file...',
-                        'execute_bash': 'Running command...',
-                        'Bash': 'Running command...',
-                        'grep_search': 'Searching the code...',
-                        'Grep': 'Searching the code...',
-                        'write_file': 'Writing the file...',
-                        'Write': 'Writing the file...',
-                        'edit_file': 'Editing the file...',
-                        'Edit': 'Editing the file...',
-                        'WebFetch': 'Fetching web content...',
-                        'WebSearch': 'Searching the web...',
-                        'Task': 'Starting task...',
-                    };
-                    // Return acknowledgement regardless of hasModelNarration
-                    // If model provided narration, it will appear after this acknowledgement
-                    return toolDescriptions[primaryTool] || 'Running tools to advance your request...';
-                },
                 onVerificationNeeded: (response, context) => {
                     this.lastAssistantResponse = response;
                     void this.runAutoQualityChecks('verification', response, context);
                 },
-                // NEW: Immediate acknowledgement when request is received (BEFORE provider call)
-                onRequestReceived: (requestPreview) => {
-                    // This fires IMMEDIATELY when user submits request, guaranteeing instant feedback
-                    // The message appears before any AI processing begins
-                    const normalized = requestPreview?.trim();
-                    const message = normalized
-                        ? `⚡ Acknowledged — focusing on "${normalized}" and acting now.`
-                        : '⚡ Acknowledged — acting now.';
-                    display.showAssistantMessage(message, { isFinal: false });
-                    this.renderer?.setActivity('Acknowledged');
-                },
-                // NEW: Retry notification for transient errors
+                // Retry notification for transient errors
                 onRetrying: (attempt, maxAttempts, error) => {
                     const shortError = error.message.slice(0, 100);
                     display.showSystemMessage(`⚡ Retry ${attempt}/${maxAttempts}: ${shortError}${error.message.length > 100 ? '...' : ''}`);