epicshop 6.84.5 → 6.84.7

package/dist/commands/admin/launch-readiness.js

@@ -12,6 +12,27 @@ function stripEpicAiSlugSuffix(value) {
 function normalizeHost(host) {
     return host.toLowerCase().replace(/^www\./, '');
 }
+function parseEpicWorkshopSlugFromEmbedUrl(urlString) {
+    const parseSegments = (segments) => {
+        // Expected: /workshops/<workshopSlug>/...
+        if (segments[0] !== 'workshops')
+            return null;
+        const workshopSlug = segments[1] ?? null;
+        return workshopSlug ? stripEpicAiSlugSuffix(workshopSlug) : null;
+    };
+    try {
+        const url = new URL(urlString);
+        const segments = url.pathname.split('/').filter(Boolean);
+        return parseSegments(segments);
+    }
+    catch {
+        // Fall back to naive parsing (best-effort).
+        const withoutHash = urlString.split('#')[0] ?? urlString;
+        const withoutQuery = withoutHash.split('?')[0] ?? withoutHash;
+        const segments = withoutQuery.split('/').filter(Boolean);
+        return parseSegments(segments);
+    }
+}
 function parseEpicLessonSlugFromEmbedUrl(urlString) {
     const parseSegments = (segments) => {
         if (segments.length === 0)
@@ -38,6 +59,10 @@ function parseEpicLessonSlugFromEmbedUrl(urlString) {
         return parseSegments(segments);
     }
 }
+function formatProductLessonUrl({ productHost, productSlug, lessonSlug, }) {
+    // The product site will typically redirect to a section-specific path when needed.
+    return `https://${productHost}/workshops/${productSlug}/${lessonSlug}`;
+}
 function formatIssue(issue, workshopRoot) {
     const icon = issue.level === 'error' ? chalk.red('❌') : chalk.yellow('⚠️ ');
     const filePart = issue.file
@@ -202,21 +227,6 @@ async function buildExpectedFiles({ workshopRoot, exerciseDirName, }) {
                     relativePath: path.relative(workshopRoot, problemReadme),
                 });
             }
-            const problemFinished = await resolveMdxFile(problemDir, 'FINISHED');
-            if (!problemFinished) {
-                issues.push({
-                    level: 'error',
-                    code: 'missing-step-problem-finished',
-                    message: `Missing step problem FINISHED.mdx for step ${stepNumber}`,
-                    file: path.join(problemDir, 'FINISHED.mdx'),
-                });
-            }
-            else {
-                contentFiles.push({
-                    fullPath: problemFinished,
-                    relativePath: path.relative(workshopRoot, problemFinished),
-                });
-            }
         }
         for (const solutionDir of dirs.solutions) {
             const solutionReadme = await resolveMdxFile(solutionDir, 'README');
@@ -239,21 +249,6 @@ async function buildExpectedFiles({ workshopRoot, exerciseDirName, }) {
                     relativePath: path.relative(workshopRoot, solutionReadme),
                 });
             }
-            const solutionFinished = await resolveMdxFile(solutionDir, 'FINISHED');
-            if (!solutionFinished) {
-                issues.push({
-                    level: 'error',
-                    code: 'missing-step-solution-finished',
-                    message: `Missing step solution FINISHED.mdx for step ${stepNumber}`,
-                    file: path.join(solutionDir, 'FINISHED.mdx'),
-                });
-            }
-            else {
-                contentFiles.push({
-                    fullPath: solutionFinished,
-                    relativePath: path.relative(workshopRoot, solutionFinished),
-                });
-            }
         }
     }
     return { files, contentFiles, issues };
@@ -725,7 +720,7 @@ export async function launchReadiness(options = {}) {
             });
         }
     }
-    // Also scan the remaining required MDX files for EpicVideo embeds (e.g. step FINISHED.mdx),
+    // Also scan the remaining required MDX files for EpicVideo embeds,
     // but do not require that they include a video.
     {
         const videoFilePaths = new Set(filesToCheck.map((f) => f.fullPath));
@@ -819,14 +814,30 @@ export async function launchReadiness(options = {}) {
     // -------------------------------------------------------
     // 4) Remote product lesson list vs local embedded videos
     // -------------------------------------------------------
-    const localLessonSlugs = new Set();
-    for (const embedUrl of embedOccurrences.keys()) {
-        const slug = parseEpicLessonSlugFromEmbedUrl(embedUrl);
-        if (slug)
-            localLessonSlugs.add(slug);
-    }
     if (!skipRemote) {
         if (productHost && productSlug) {
+            // Only consider embeds that belong to this workshop on the configured host.
+            // It's valid for content to include EpicVideo embeds from other workshops/paths.
+            const localProductLessonSlugs = new Set();
+            const normalizedConfigHost = normalizeHost(productHost);
+            for (const embedUrl of embedOccurrences.keys()) {
+                const lessonSlug = parseEpicLessonSlugFromEmbedUrl(embedUrl);
+                if (!lessonSlug)
+                    continue;
+                const workshopSlug = parseEpicWorkshopSlugFromEmbedUrl(embedUrl);
+                if (!workshopSlug || workshopSlug !== productSlug)
+                    continue;
+                try {
+                    const url = new URL(embedUrl);
+                    if (normalizeHost(url.host) !== normalizedConfigHost)
+                        continue;
+                }
+                catch {
+                    // Invalid URLs are reported elsewhere (host/path validation); ignore here.
+                    continue;
+                }
+                localProductLessonSlugs.add(lessonSlug);
+            }
             const remote = await fetchRemoteWorkshopLessonSlugs({
                 productHost,
                 workshopSlug: productSlug,
@@ -847,25 +858,48 @@ export async function launchReadiness(options = {}) {
                         message: 'Product API returned no lessons. Is the workshop published on the product site?',
                     });
                 }
-                const missing = remoteLessonSlugs.filter((slug) => !localLessonSlugs.has(slug));
+                const missing = remoteLessonSlugs.filter((slug) => !localProductLessonSlugs.has(slug));
                 if (missing.length) {
+                    const formatted = missing
+                        .sort()
+                        .map((slug) => `- ${slug}: ${formatProductLessonUrl({
+                        productHost,
+                        productSlug,
+                        lessonSlug: slug,
+                    })}`)
+                        .join('\n');
                     issues.push({
                         level: 'error',
                         code: 'missing-product-videos-in-workshop',
-                        message: `Missing videos in workshop for product lessons: ${missing
-                            .sort()
-                            .join(', ')}`,
+                        message: `Missing videos in workshop for product lessons:\n${formatted}`,
                     });
                 }
-                const extras = [...localLessonSlugs].filter((slug) => !remoteLessonSlugs.includes(slug));
-                if (extras.length) {
-                    issues.push({
-                        level: 'warning',
-                        code: 'extra-local-videos',
-                        message: `Found EpicVideo embeds for lesson slugs not present in the product lesson list: ${extras
-                            .sort()
-                            .join(', ')}`,
-                    });
+                const remoteLessonSlugSet = new Set(remoteLessonSlugs);
+                for (const [embedUrl, usedBy] of embedOccurrences.entries()) {
+                    const lessonSlug = parseEpicLessonSlugFromEmbedUrl(embedUrl);
+                    if (!lessonSlug)
+                        continue;
+                    const workshopSlug = parseEpicWorkshopSlugFromEmbedUrl(embedUrl);
+                    if (!workshopSlug || workshopSlug !== productSlug)
+                        continue;
+                    try {
+                        const url = new URL(embedUrl);
+                        if (normalizeHost(url.host) !== normalizedConfigHost)
+                            continue;
+                    }
+                    catch {
+                        continue;
+                    }
+                    if (remoteLessonSlugSet.has(lessonSlug))
+                        continue;
+                    for (const file of usedBy) {
+                        issues.push({
+                            level: 'warning',
+                            code: 'extra-local-videos',
+                            message: `EpicVideo embed not present in the product lesson list: ${embedUrl}`,
+                            file,
+                        });
+                    }
                 }
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "epicshop",
-  "version": "6.84.5",
+  "version": "6.84.7",
   "publishConfig": {
     "access": "public"
   },
@@ -105,7 +105,7 @@
     "build:watch": "nx watch --projects=epicshop -- nx run \\$NX_PROJECT_NAME:build"
   },
   "dependencies": {
-    "@epic-web/workshop-utils": "6.84.5",
+    "@epic-web/workshop-utils": "6.84.7",
     "@inquirer/prompts": "^8.2.0",
     "@sentry/node": "^10.38.0",
     "chalk": "^5.6.2",