ep_spellcheck 0.0.92 → 0.0.93

package/.github/workflows/backend-tests.yml

@@ -26,6 +26,10 @@ jobs:
         with:
           repository: ether/etherpad-lite
           path: etherpad-lite
+      - uses: actions/setup-node@v4
+        name: Install Node.js
+        with:
+          node-version: 22
       - uses: pnpm/action-setup@v6
         name: Install pnpm
         with:

package/.github/workflows/frontend-tests.yml

@@ -16,6 +16,10 @@ jobs:
         with:
           repository: ether/etherpad-lite
           path: etherpad-lite
+      - uses: actions/setup-node@v4
+        name: Install Node.js
+        with:
+          node-version: 22
       - uses: pnpm/action-setup@v6
         name: Install pnpm
         with:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ep_spellcheck",
-  "version": "0.0.92",
+  "version": "0.0.93",
   "keywords": [
     "spell",
     "check",

package/static/tests/frontend-new/specs/spellcheck.spec.ts

@@ -8,11 +8,22 @@ test.beforeEach(async ({page}) => {
 test.describe('ep_spellcheck', () => {
   test('Spellcheck is on by default when not disabled', async ({page}) => {
     // ep_spellcheck flips the spellcheck attribute on the inner editor
-    // body. Wait up to 5s in case it's set asynchronously after pad init.
+    // body. Under Firefox the nested ace_inner iframe can be late to
+    // attach; wait for it before dereferencing, and read the attribute
+    // through the iframe element directly so a delayed body element
+    // doesn't keep us in a 90s test timeout.
+    await expect.poll(
+        async () => page.frame('ace_inner') != null,
+        {timeout: 10_000})
+        .toBe(true);
     const innerFrame = page.frame('ace_inner')!;
     await expect.poll(
-        async () => innerFrame.locator('body').getAttribute('spellcheck'),
-        {timeout: 5_000})
+        async () => {
+          const body = innerFrame.locator('body');
+          if (await body.count() === 0) return null;
+          return body.getAttribute('spellcheck');
+        },
+        {timeout: 10_000})
         .toBe('true');
   });
 });