ep_special_characters 0.0.51 → 0.0.53

package/.github/workflows/backend-tests.yml

@@ -26,7 +26,7 @@ jobs:
         with:
           repository: ether/etherpad-lite
           path: etherpad-lite
-      - uses: pnpm/action-setup@v3
+      - uses: pnpm/action-setup@v6
         name: Install pnpm
         with:
           version: 10
@@ -35,7 +35,7 @@ jobs:
         shell: bash
         run: |
           echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
-      - uses: actions/cache@v4
+      - uses: actions/cache@v5
         name: Setup pnpm cache
         with:
           path: ${{ env.STORE_PATH }}

package/.github/workflows/frontend-tests.yml

@@ -15,7 +15,7 @@ jobs:
         uses: actions/checkout@v6
         with:
           repository: ether/etherpad-lite
-      - uses: pnpm/action-setup@v3
+      - uses: pnpm/action-setup@v6
         name: Install pnpm
         with:
           version: 10
@@ -24,7 +24,7 @@ jobs:
         shell: bash
         run: |
           echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
-      - uses: actions/cache@v4
+      - uses: actions/cache@v5
         name: Setup pnpm cache
         with:
           path: ${{ env.STORE_PATH }}

package/.github/workflows/npmpublish.yml

@@ -31,7 +31,7 @@ jobs:
         uses: actions/checkout@v6
         with:
           repository: ether/etherpad-lite
-      - uses: pnpm/action-setup@v5
+      - uses: pnpm/action-setup@v6
         name: Install pnpm
         with:
           version: 10
@@ -59,12 +59,20 @@ jobs:
           [ "${NEW_COMMITS}" -gt 0 ] || exit 0
           git config user.name 'github-actions[bot]'
           git config user.email '41898282+github-actions[bot]@users.noreply.github.com'
-          pnpm i
+          pnpm i --frozen-lockfile
           # `pnpm version patch` bumps package.json, makes a commit, and creates
           # a `v<new-version>` tag. Capture the new tag name from package.json
           # rather than parsing pnpm's output, which has historically varied.
-          pnpm version patch
-          NEW_TAG="v$(node -p "require('./package.json').version")"
+          # Bump the patch component directly with Node. pnpm/action-setup@v6
+          # sometimes installs pnpm 11 pre-releases even when version: 10.x is
+          # requested (pnpm/action-setup#225); those pre-releases either skip
+          # the git commit/tag or reject --no-git-tag-version as unknown.
+          # Doing the bump in Node sidesteps both failure modes.
+          NEW_VERSION=$(node -e "const fs=require('fs');const p=require('./package.json');const v=p.version.split('.');v[2]=String(Number(v[2])+1);p.version=v.join('.');fs.writeFileSync('./package.json',JSON.stringify(p,null,2)+'\n');console.log(p.version);")
+          NEW_TAG="v${NEW_VERSION}"
+          git add package.json
+          git commit -m "${NEW_TAG}"
+          git tag -a "${NEW_TAG}" -m "${NEW_TAG}"
           # CRITICAL: use --atomic so the branch update and the tag update
           # succeed (or fail) as a single transaction on the server. The old
           # `git push --follow-tags` was non-atomic per ref: if a concurrent

package/README.md

@@ -1,7 +1,11 @@
-![Publish Status](https://github.com/ether/ep_special_characters/workflows/Node.js%20Package/badge.svg) [![Backend Tests Status](https://github.com/ether/ep_special_characters/actions/workflows/test-and-release.yml/badge.svg)](https://github.com/ether/ep_special_characters/actions/workflows/test-and-release.yml)
+[![Backend Tests Status](https://github.com/ether/ep_special_characters/actions/workflows/test-and-release.yml/badge.svg)](https://github.com/ether/ep_special_characters/actions/workflows/test-and-release.yml)
 
-# ep_special_characters
+> ⚠️ **Known issue:** Clicking a character in the picker currently throws
+> `ReferenceError: require is not defined` because [`static/js/main.js:16`](static/js/main.js)
+> uses a browser-side `require()` that Etherpad's current esbuild bundler
+> doesn't expose. Tracking fix in [#87](https://github.com/ether/ep_special_characters/issues/87).
 
+# Special Character Picker for Etherpad
 TODO: Describe the plugin.
 
 ## Installation

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "ep_special_characters",
   "description": "Insert special characters into a pad",
-  "version": "0.0.51",
+  "version": "0.0.53",
   "author": {
     "name": "Johnyma22",
     "email": "john@mclear.co.uk",
@@ -20,7 +20,7 @@
   },
   "devDependencies": {
     "eslint": "^8.57.1",
-    "eslint-config-etherpad": "^4.0.4",
+    "eslint-config-etherpad": "^4.0.5",
     "typescript": "^6.0.2"
   },
   "scripts": {

package/static/js/hooks.js

@@ -11,6 +11,7 @@ exports.aceAttribsToClasses = (hookName, args, cb) => {
   if (args.key === 'specialCharacters' && args.value !== '') {
     return cb([`specialCharacters:${args.value}`]);
   }
+  return cb([]);
 };
 
 exports.aceCreateDomLine = (hookName, args, cb) => {

package/static/tests/backend/specs/hooks.js

@@ -0,0 +1,32 @@
+'use strict';
+
+const assert = require('assert').strict;
+const hooks = require('../../../../static/js/hooks');
+
+describe(__filename, function () {
+  describe('aceAttribsToClasses', function () {
+    it('invokes cb with the class when key matches and value is set', function (done) {
+      hooks.aceAttribsToClasses('aceAttribsToClasses', {key: 'specialCharacters', value: 'Ω'},
+          (classes) => {
+            assert.deepEqual(classes, ['specialCharacters:Ω']);
+            done();
+          });
+    });
+
+    it('invokes cb with an empty array when key does not match (regression for #4)', function (done) {
+      hooks.aceAttribsToClasses('aceAttribsToClasses', {key: 'bold', value: 'true'},
+          (classes) => {
+            assert.deepEqual(classes, []);
+            done();
+          });
+    });
+
+    it('invokes cb with an empty array when value is empty (regression for #4)', function (done) {
+      hooks.aceAttribsToClasses('aceAttribsToClasses', {key: 'specialCharacters', value: ''},
+          (classes) => {
+            assert.deepEqual(classes, []);
+            done();
+          });
+    });
+  });
+});