ep_set_title_on_pad 0.6.37 → 0.6.39

package/.github/workflows/backend-tests.yml

@@ -26,7 +26,7 @@ jobs:
         with:
           repository: ether/etherpad-lite
           path: etherpad-lite
-      - uses: pnpm/action-setup@v3
+      - uses: pnpm/action-setup@v6
         name: Install pnpm
         with:
           version: 10

package/.github/workflows/frontend-tests.yml

@@ -15,7 +15,7 @@ jobs:
         uses: actions/checkout@v6
         with:
           repository: ether/etherpad-lite
-      - uses: pnpm/action-setup@v3
+      - uses: pnpm/action-setup@v6
         name: Install pnpm
         with:
           version: 10

package/.github/workflows/npmpublish.yml

@@ -31,7 +31,7 @@ jobs:
         uses: actions/checkout@v6
         with:
           repository: ether/etherpad-lite
-      - uses: pnpm/action-setup@v5
+      - uses: pnpm/action-setup@v6
         name: Install pnpm
         with:
           version: 10
@@ -59,12 +59,20 @@ jobs:
           [ "${NEW_COMMITS}" -gt 0 ] || exit 0
           git config user.name 'github-actions[bot]'
           git config user.email '41898282+github-actions[bot]@users.noreply.github.com'
-          pnpm i
+          pnpm i --frozen-lockfile
           # `pnpm version patch` bumps package.json, makes a commit, and creates
           # a `v<new-version>` tag. Capture the new tag name from package.json
           # rather than parsing pnpm's output, which has historically varied.
-          pnpm version patch
-          NEW_TAG="v$(node -p "require('./package.json').version")"
+          # Bump the patch component directly with Node. pnpm/action-setup@v6
+          # sometimes installs pnpm 11 pre-releases even when version: 10.x is
+          # requested (pnpm/action-setup#225); those pre-releases either skip
+          # the git commit/tag or reject --no-git-tag-version as unknown.
+          # Doing the bump in Node sidesteps both failure modes.
+          NEW_VERSION=$(node -e "const fs=require('fs');const p=require('./package.json');const v=p.version.split('.');v[2]=String(Number(v[2])+1);p.version=v.join('.');fs.writeFileSync('./package.json',JSON.stringify(p,null,2)+'\n');console.log(p.version);")
+          NEW_TAG="v${NEW_VERSION}"
+          git add package.json
+          git commit -m "${NEW_TAG}"
+          git tag -a "${NEW_TAG}" -m "${NEW_TAG}"
           # CRITICAL: use --atomic so the branch update and the tag update
           # succeed (or fail) as a single transaction on the server. The old
           # `git push --follow-tags` was non-atomic per ref: if a concurrent

package/README.md

@@ -1,6 +1,6 @@
 # ep_set_title_on_pad
 
-[![Publish Status](https://github.com/ether/ep_set_title_on_pad/workflows/Node.js%20Package/badge.svg)](https://github.com/ether/ep_set_title_on_pad/actions/workflows/test-and-release.yml) 
+[![Demo](demo.gif)](https://github.com/ether/ep_set_title_on_pad/actions/workflows/test-and-release.yml) 
 [![Backend Tests Status](https://github.com/ether/ep_set_title_on_pad/actions/workflows/test-and-release.yml/badge.svg)](https://github.com/ether/ep_set_title_on_pad/actions/workflows/test-and-release.yml)
 
 Adds a title field to pads that updates in real time and is used as the export filename.

package/ep.json

@@ -11,7 +11,9 @@
         "handleMessage": "ep_set_title_on_pad/handleMessage",
         "eejsBlock_mySettings": "ep_set_title_on_pad/index",
         "exportFileName":"ep_set_title_on_pad/index",
-        "clientVars": "ep_set_title_on_pad/handleMessage"
+        "clientVars": "ep_set_title_on_pad/handleMessage",
+        "padRemove": "ep_set_title_on_pad/index",
+        "padCopy": "ep_set_title_on_pad/index"
       }
     }
   ]

package/index.js

@@ -20,3 +20,12 @@ exports.eejsBlock_mySettings = (hookName, args, cb) => {
   args.content += eejs.require('ep_set_title_on_pad/templates/settings.ejs');
   cb();
 };
+
+exports.padRemove = async (hookName, {pad}) => {
+  await db.remove(`title:${pad.id}`);
+};
+
+exports.padCopy = async (hookName, {srcPad, dstPad}) => {
+  const title = await db.get(`title:${srcPad.id}`);
+  if (title) await db.set(`title:${dstPad.id}`, title);
+};

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "ep_set_title_on_pad",
   "description": "Set the title on a pad in Etherpad, also includes real time updates to the UI",
-  "version": "0.6.37",
+  "version": "0.6.39",
   "license": "Apache-2.0",
   "author": "johnyma22 (John McLear) <john@mclear.co.uk>",
   "keywords": [
@@ -26,8 +26,8 @@
   },
   "devDependencies": {
     "eslint": "^8.57.1",
-    "eslint-config-etherpad": "^4.0.4",
-    "typescript": "^6.0.2"
+    "eslint-config-etherpad": "^4.0.5",
+    "typescript": "^6.0.3"
   },
   "scripts": {
     "lint": "eslint .",

package/static/tests/backend/specs/title_lifecycle.js

@@ -0,0 +1,42 @@
+'use strict';
+
+const assert = require('assert').strict;
+const common = require('ep_etherpad-lite/tests/backend/common');
+const padManager = require('ep_etherpad-lite/node/db/PadManager');
+const DB = require('ep_etherpad-lite/node/db/DB');
+
+const titleKey = (padId) => `title:${padId}`;
+
+describe(__filename, function () {
+  before(async function () {
+    await common.init();
+  });
+
+  it('removes the title when the pad is removed (regression for #109)', async function () {
+    const padId = `title-rm-${common.randomString()}`;
+    const pad = await padManager.getPad(padId, '\n');
+    await DB.set(titleKey(padId), 'My Pad Title');
+    assert.equal(await DB.get(titleKey(padId)), 'My Pad Title');
+
+    await pad.remove();
+
+    // Different DB drivers return either null or undefined for missing keys.
+    assert(await DB.get(titleKey(padId)) == null);
+  });
+
+  it('copies the title when the pad is copied', async function () {
+    const srcId = `title-cp-src-${common.randomString()}`;
+    const dstId = `title-cp-dst-${common.randomString()}`;
+    const src = await padManager.getPad(srcId, '\n');
+    await DB.set(titleKey(srcId), 'Original Title');
+
+    await src.copy(dstId);
+
+    assert.equal(await DB.get(titleKey(dstId)), 'Original Title');
+
+    // cleanup
+    const dst = await padManager.getPad(dstId);
+    await src.remove();
+    await dst.remove();
+  });
+});