ep_set_title_on_pad 0.5.51 → 0.6.1

package/.github/workflows/backend-tests.yml

@@ -22,12 +22,12 @@ jobs:
           sudo apt install -y --no-install-recommends libreoffice libreoffice-pdfimport
       -
         name: Install etherpad core
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: ether/etherpad-lite
       -
         name: Checkout plugin repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           path: ./node_modules/__tmp
       -
@@ -45,12 +45,14 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
             src/bin/doc/package-lock.json
             node_modules/${{ steps.plugin_name.outputs.plugin_name }}/package-lock.json
+      - run: npm install npm@6.14.18 -g
+        name: Install legacy npm for correct dependency resolution
       -
         name: Install plugin dependencies
         run: |

package/.github/workflows/codeql.yml

@@ -0,0 +1,41 @@
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+  schedule:
+    - cron: "41 16 * * 0"
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ javascript ]
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v2
+        with:
+          languages: ${{ matrix.language }}
+          queries: +security-and-quality
+
+      - name: Autobuild
+        uses: github/codeql-action/autobuild@v2
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v2
+        with:
+          category: "/language:${{ matrix.language }}"

package/.github/workflows/frontend-tests.yml

@@ -7,19 +7,8 @@ on: [push]
 jobs:
   test:
     runs-on: ubuntu-latest
-
+    if: ${{ github.actor != 'dependabot[bot]' }}
     steps:
-      -
-        name: Fail if Dependabot
-        if: github.actor == 'dependabot[bot]'
-        run: |
-          cat <<EOF >&2
-          Frontend tests skipped because Dependabot can't access secrets.
-          Manually re-run the jobs to run the frontend tests.
-          For more information, see:
-          https://github.blog/changelog/2021-02-19-github-actions-workflows-triggered-by-dependabot-prs-will-run-with-read-only-permissions/
-          EOF
-          exit 1
       -
         name: Generate Sauce Labs strings
         id: sauce_strings
@@ -28,20 +17,22 @@ jobs:
           printf %s\\n '::set-output name=tunnel_id::${{ github.run_id }}-${{ github.run_number }}-${{ github.job }}'
       -
         name: Check out Etherpad core
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: ether/etherpad-lite
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
             src/bin/doc/package-lock.json
+      - run: npm install npm@6.14.18 -g
+        name: Install legacy npm for correct dependency resolution
       -
         name: Check out the plugin
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           path: ./node_modules/__tmp
       -
@@ -92,7 +83,7 @@ jobs:
         name: Remove standard frontend test files
         run: rm -rf src/tests/frontend/specs
       -
-        uses: saucelabs/sauce-connect-action@v2.1.1
+        uses: saucelabs/sauce-connect-action@v2.3.4
         with:
           username: ${{ secrets.SAUCE_USERNAME }}
           accessKey: ${{ secrets.SAUCE_ACCESS_KEY }}

package/.github/workflows/npmpublish.yml

@@ -22,7 +22,7 @@ jobs:
       # conflicts with this plugin's clone, etherpad-lite must be cloned and
       # moved out before this plugin's repo is cloned to $GITHUB_WORKSPACE.
       -
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: ether/etherpad-lite
           path: etherpad-lite
@@ -31,7 +31,7 @@ jobs:
       # etherpad-lite has been moved outside of $GITHUB_WORKSPACE, so it is now
       # safe to clone this plugin's repo to $GITHUB_WORKSPACE.
       -
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       # This is necessary for actions/setup-node because '..' can't be used in
       # cache-dependency-path.
       -
@@ -42,12 +42,14 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             node_modules/ep_etherpad-lite/package-lock.json
             node_modules/ep_etherpad-lite/bin/doc/package-lock.json
             package-lock.json
+      - run: npm install npm@6.14.18 -g
+        name: Install legacy npm for correct dependency resolution
       # All of ep_etherpad-lite's devDependencies are installed because the
       # plugin might do `require('ep_etherpad-lite/node_modules/${devDep}')`.
       # Eventually it would be nice to create an ESLint plugin that prohibits
@@ -77,7 +79,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       -
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
       -

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "ep_set_title_on_pad",
   "description": "Set the title on a pad in Etherpad, also includes real time updates to the UI",
-  "version": "0.5.51",
+  "version": "0.6.1",
   "license": "Apache-2.0",
   "author": "johnyma22 (John McLear) <john@mclear.co.uk>",
   "keywords": [
@@ -26,9 +26,9 @@
     "url": "https://etherpad.org/"
   },
   "devDependencies": {
-    "eslint": "^8.11.0",
-    "eslint-config-etherpad": "^3.0.9",
-    "typescript": "^4.6.2"
+    "eslint": "^8.51.0",
+    "eslint-config-etherpad": "^3.0.22",
+    "typescript": "^4.9.5"
   },
   "scripts": {
     "lint": "eslint .",

package/static/js/index.js

@@ -3,11 +3,14 @@
 exports.handleClientMessage_CUSTOM = (hook, context, cb) => {
   if (context.payload.action === 'recieveTitleMessage') {
     const message = context.payload.message;
-    if (!$('#input_title').is(':visible')) { // if we're not editing..
+    const padTitleElement = $('#input_title');
+    const titleTag = $('#title > h1 > a');
+    if (!padTitleElement.is(':visible')) { // if we're not editing..
       if (message) {
         window.document.title = message;
-        $('#title > h1 > a').text(message);
-        $('#input_title').val(message);
+        titleTag.text(message);
+        titleTag.removeAttr('data-l10n-id');
+        padTitleElement.val(message);
         clientVars.ep_set_title_on_pad = {};
         clientVars.ep_set_title_on_pad.title = message;
       }
@@ -39,6 +42,7 @@ exports.documentReady = () => {
 
   if (!clientVars.ep_set_title_on_pad) {
     $('#title > h1 > a').text(clientVars.padId);
+    $('#title > h1 > a').removeAttr('data-l10n-id');
   }
 
   if (!$('#editorcontainerbox').hasClass('flex-layout')) {
@@ -46,7 +50,7 @@ exports.documentReady = () => {
       title: 'Error',
       text: 'ep_set_title_on_pad: Upgrade to etherpad 1.8.3+ for this plugin to work correctly',
       sticky: true,
-      class_name: 'error',
+      class_name: 'error', // eslint-disable-line camelcase
     });
   }
 
@@ -62,12 +66,21 @@ exports.documentReady = () => {
     sendTitle();
     window.document.title = $('#input_title').val();
     $('#title > h1 > a').text($('#input_title').val());
+    $('#title > h1 > a').removeAttr('data-l10n-id');
     $('#title, #edit_title').show();
     $('#input_title, #save_title').hide();
   });
 
+  function debounce(func, timeout = 300) {
+    let timer;
+    return (...args) => {
+      clearTimeout(timer);
+      timer = setTimeout(() => { func.apply(this, args); }, timeout);
+    };
+  }
+
   $('#input_title').keyup((e) => {
-    sendTitle();
+    debounce(sendTitle);
     window.document.title = $('#input_title').val();
     $('#title > h1').text($('#input_title').val());
     if (e.keyCode === 13) {