ep_rss 11.0.23 → 11.0.25

package/.github/workflows/backend-tests.yml

@@ -29,7 +29,7 @@ jobs:
       - uses: actions/setup-node@v6
         name: Install Node.js
         with:
-          node-version: 22
+          node-version: 25
       - uses: pnpm/action-setup@v6
         name: Install pnpm
         with:

package/.github/workflows/frontend-tests.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-node@v6
         name: Install Node.js
         with:
-          node-version: 22
+          node-version: 25
       - uses: pnpm/action-setup@v6
         name: Install pnpm
         with:

package/.github/workflows/npmpublish.yml

@@ -23,7 +23,7 @@ jobs:
           # OIDC trusted publishing needs npm >= 11.5.1, which requires
           # Node >= 20.17.0. setup-node's `20` resolves to the latest
           # 20.x, which satisfies that.
-          node-version: 20
+          node-version: 25
           registry-url: https://registry.npmjs.org/
       - name: Upgrade npm to >=11.5.1 (required for trusted publishing)
         run: npm install -g npm@latest

package/index.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const API = require('ep_etherpad-lite/node/db/API.js');
+const API = require('ep_etherpad-lite/node/db/API');
 const padManager = require('ep_etherpad-lite/node/db/PadManager');
 const settings = require('ep_etherpad-lite/node/utils/Settings');
 
@@ -20,33 +20,16 @@ exports.eejsBlock_htmlHead = (hookName, args, cb) => {
 };
 
 exports.registerRoute = (hookName, args, cb) => {
-  args.app.get('/p/*/rss', (req, res) => {
-    /* Sanity is in the crack of time*/
-    const path = req.url.split('/');
-    const padId = path[2];
-    res.redirect(`/p/${padId}/feed`);
-  });
-
-  args.app.get('/p/*/feed.rss', (req, res) => {
-    /* Sanity is in the crack of time*/
-    const path = req.url.split('/');
-    const padId = path[2];
-    res.redirect(`/p/${padId}/feed`);
-  });
-
-
-  args.app.get('/p/*/atom.xml', (req, res) => {
-    /* Sanity is in the crack of time*/
-    const path = req.url.split('/');
-    const padId = path[2];
-    res.redirect(`/p/${padId}/feed`);
-  });
-
-  args.app.get('/p/*/feed', async (req, res) => {
-    /* Sanity is in the cracks of lime*/
+  const redirectToFeed = (req, res) => {
+    res.redirect(`/p/${encodeURIComponent(req.params.padId)}/feed`);
+  };
+  args.app.get('/p/:padId/rss', redirectToFeed);
+  args.app.get('/p/:padId/feed.rss', redirectToFeed);
+  args.app.get('/p/:padId/atom.xml', redirectToFeed);
+
+  args.app.get('/p/:padId/feed', async (req, res) => {
     const fullURL = `${req.protocol}://${req.get('host')}${req.url}`;
-    const path = req.url.split('/');
-    const padId = path[2];
+    const padId = req.params.padId;
     const padURL = `${req.protocol}://${req.get('host')}/p/${padId}`;
     const dateString = new Date();
     let isPublished = false; // is this item already published?

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "ep_rss",
   "description": "Get an RSS feed of pad updates",
-  "version": "11.0.23",
+  "version": "11.0.25",
   "author": {
     "name": "John McLear",
     "email": "john@mclear.co.uk",

package/static/tests/frontend-new/specs/feed.spec.ts

@@ -0,0 +1,54 @@
+import {expect, test} from '@playwright/test';
+import {goToNewPad, writeToPad} from 'ep_etherpad-lite/tests/frontend-new/helper/padHelper';
+
+const BASE_URL = 'http://localhost:9001';
+
+const padIdFromUrl = (url: string) => url.split('/p/')[1].split('?')[0];
+
+test.describe('ep_rss feed', () => {
+  test('declares the RSS alternate link in the pad page head', async ({page}) => {
+    await goToNewPad(page);
+    const link = page.locator('head link[rel="alternate"][type="application/rss+xml"]');
+    await expect(link).toHaveAttribute('href', 'feed');
+  });
+
+  test('serves an RSS document at /p/<pad>/feed containing the pad text', async ({page, request}) => {
+    await goToNewPad(page);
+    const padId = padIdFromUrl(page.url());
+    const marker = `ep-rss-marker-${Date.now()}`;
+    await writeToPad(page, marker);
+    // Give the socket time to flush the change to the pad store before the
+    // route reads it back via API.getLastEdited / padManager.getPad.
+    await page.waitForTimeout(1200);
+
+    const res = await request.get(`${BASE_URL}/p/${padId}/feed`);
+    expect(res.status()).toBe(200);
+    expect(res.headers()['content-type']).toContain('application/rss+xml');
+    const body = await res.text();
+    expect(body).toMatch(/^<rss /);
+    expect(body).toContain(`<title>${padId}</title>`);
+    expect(body).toContain(marker);
+    expect(body.trim().endsWith('</rss>')).toBe(true);
+  });
+
+  test('escapes HTML special characters in the description', async ({page, request}) => {
+    await goToNewPad(page);
+    const padId = padIdFromUrl(page.url());
+    await writeToPad(page, 'tags <b>&</b>');
+    await page.waitForTimeout(1200);
+
+    const body = await (await request.get(`${BASE_URL}/p/${padId}/feed`)).text();
+    expect(body).toContain('&lt;b&gt;&amp;&lt;/b&gt;');
+    expect(body).not.toContain('<b>&</b>');
+  });
+
+  for (const alias of ['rss', 'feed.rss', 'atom.xml']) {
+    test(`/p/<pad>/${alias} redirects to /p/<pad>/feed`, async ({page, request}) => {
+      await goToNewPad(page);
+      const padId = padIdFromUrl(page.url());
+      const res = await request.get(`${BASE_URL}/p/${padId}/${alias}`, {maxRedirects: 0});
+      expect(res.status()).toBe(302);
+      expect(res.headers()['location']).toBe(`/p/${padId}/feed`);
+    });
+  }
+});