eoas 3.1.3 → 3.2.0-beta2

package/dist/commands/publish.js

@@ -72,8 +72,9 @@ class Publish extends core_1.Command {
             required: false,
         }),
         dumpSourcemap: core_1.Flags.boolean({
-            description: 'Emit Hermes source maps alongside the bundle so the published artifact can be symbolicated by tools like Sentry or PostHog.',
-            default: false,
+            description: 'Emit Hermes source maps alongside the bundle (default: true). Without a source map Hermes bakes a random temp path into the bytecode, so two exports of identical code never hash the same and server-side change detection cannot work. The maps also let tools like Sentry or PostHog symbolicate the published artifact; they stay in the output directory and are never uploaded. Disable with --no-dumpSourcemap.',
+            default: true,
+            allowNo: true,
         }),
         'rollout-percentage': core_1.Flags.integer({
             min: 1,
@@ -259,7 +260,7 @@ class Publish extends core_1.Command {
         });
         log_1.default.withInfo(`expoConfig.json file created in ${outputDir} directory`);
         const uploadFilesSpinner = (0, ora_1.ora)('📤 Uploading files...').start();
-        const files = (0, assets_1.computeFilesRequests)(projectDir, outputDir, platform || expoConfig_1.RequestedPlatform.All);
+        const files = await (0, assets_1.computeFilesRequests)(projectDir, outputDir, platform || expoConfig_1.RequestedPlatform.All);
         if (!files.length) {
             uploadFilesSpinner.fail('No files to upload');
             process.exit(1);
@@ -268,30 +269,47 @@ class Publish extends core_1.Command {
         // One group id for the whole run: every platform update of this publish
         // shares it, so control plane servers list them as a single publish.
         const publishGroupId = (0, crypto_1.randomUUID)();
+        // Collected rather than logged inline: writing to the terminal under a
+        // running spinner interleaves with its frames.
+        const unchangedPlatforms = [];
         try {
-            uploadUrls = await Promise.all(runtimeVersions.map(async ({ runtimeVersion, platform }) => {
+            const outcomes = await Promise.all(runtimeVersions.map(async ({ runtimeVersion, platform }) => {
                 if (!runtimeVersion) {
                     throw new Error('Runtime version is not resolved');
                 }
-                return {
-                    ...(await (0, assets_1.requestUploadUrls)({
-                        body: {
-                            fileNames: files.map(file => file.path),
-                        },
-                        requestUploadUrl: `${serverUrl}/${appId}/requestUploadUrl/${branch}`,
-                        auth: credentials,
+                try {
+                    return {
+                        ...(await (0, assets_1.requestUploadUrls)({
+                            body: { files: (0, assets_1.buildUploadFiles)(files, platform) },
+                            requestUploadUrl: `${serverUrl}/${appId}/requestUploadUrl/${branch}`,
+                            auth: credentials,
+                            runtimeVersion,
+                            platform,
+                            commitHash,
+                            message: resolvedMessage,
+                            rolloutPercentage,
+                            publishGroup: publishGroupId,
+                            branch,
+                        })),
                         runtimeVersion,
                         platform,
-                        commitHash,
-                        message: resolvedMessage,
-                        rolloutPercentage,
-                        publishGroup: publishGroupId,
-                        branch,
-                    })),
-                    runtimeVersion,
-                    platform,
-                };
+                    };
+                }
+                catch (error) {
+                    if (error instanceof assets_1.NoChangesDetectedError) {
+                        unchangedPlatforms.push(platform);
+                        return null;
+                    }
+                    throw error;
+                }
             }));
+            uploadUrls = outcomes.filter((entry) => {
+                return entry !== null;
+            });
+            if (!uploadUrls.length) {
+                uploadFilesSpinner.warn('⚠️ No changes found in the update, nothing to deploy');
+                return;
+            }
             // Every path and URL the server handed back is checked here, before a
             // single file is opened. A server that forges a filePath would otherwise
             // make the CLI read arbitrary files off this machine and PUT them wherever
@@ -358,6 +376,14 @@ class Publish extends core_1.Command {
                 }
             }));
             uploadFilesSpinner.succeed('✅ Files uploaded successfully');
+            for (const { platform: uploadedPlatform, uploadRequests } of uploadUrls) {
+                const totalFiles = (0, assets_1.buildUploadFiles)(files, uploadedPlatform).length;
+                const deduplicated = totalFiles - uploadRequests.length;
+                log_1.default.withInfo(`📊 ${uploadedPlatform}: ${uploadRequests.length}/${totalFiles} files uploaded, ${deduplicated} deduplicated (already on the server)`);
+            }
+            for (const skipped of unchangedPlatforms) {
+                log_1.default.withInfo(`⚠️ There is no change in the update for ${skipped}, ignored...`);
+            }
         }
         catch (e) {
             uploadFilesSpinner.fail('❌ Failed to upload static files');
@@ -423,9 +449,14 @@ class Publish extends core_1.Command {
         if (hasSuccess) {
             log_1.default.withInfo(`🌿 Branch: \`${branch}\``);
             log_1.default.withInfo(`⏳ Deployed at: \`${new Date().toUTCString()}\`\n`);
+            for (const { platform: publishedPlatform, updateId } of uploadUrls) {
+                log_1.default.withInfo(`🆔 ${publishedPlatform} update id: \`${updateId}\``);
+            }
             const groupAcknowledged = uploadUrls.every(u => u.publishGroup === publishGroupId);
             if (groupAcknowledged) {
-                log_1.default.withInfo(`📦 Publish group: \`${publishGroupId}\``);
+                log_1.default.withInfo(`📦 Publish group: \`${publishGroupId}\` (groups the ${uploadUrls
+                    .map(u => u.platform)
+                    .join(' + ')} updates of this run)`);
             }
             else if (uploadUrls.length > 1) {
                 // Only worth a note when several platforms were published: a single

package/dist/lib/assets.d.ts

@@ -1,3 +1,4 @@
+import { Platform } from '@expo/config';
 import Joi from 'joi';
 import { Credentials } from './auth';
 import { RequestedPlatform } from './expoConfig';
@@ -6,12 +7,26 @@ export interface AssetToUpload {
     path: string;
     name: string;
     ext: string;
+    hash: string;
+    key: string;
+    platform: Platform | null;
+    isLaunchAsset: boolean;
 }
-export declare function computeFilesRequests(projectDir: string, outputDir: string, requestedPlatform: RequestedPlatform): AssetToUpload[];
+export type FileRole = 'launch' | 'asset' | 'config';
+export interface FileUploadItem {
+    path: string;
+    hash: string;
+    key?: string;
+    ext?: string;
+    role: FileRole;
+}
+export declare function buildUploadFiles(files: AssetToUpload[], platform: string): FileUploadItem[];
+export declare function computeFilesRequests(projectDir: string, outputDir: string, requestedPlatform: RequestedPlatform): Promise<AssetToUpload[]>;
 export interface RequestUploadUrlItem {
     requestUploadUrl: string;
     fileName: string;
     filePath: string;
+    originalFileName: string;
     headers?: Record<string, string>;
 }
 export interface RequestUploadUrlsResponse {
@@ -41,9 +56,13 @@ export declare function resolveUploadRequests({ uploadRequests, exportDir, manif
     manifest: AssetToUpload[];
 }): Promise<ResolvedUploadRequest[]>;
 export declare function activeRolloutConflictMessage(branch: string): string;
+export declare class NoChangesDetectedError extends Error {
+    readonly platform: string;
+    constructor(platform: string);
+}
 export declare function requestUploadUrls({ body, requestUploadUrl, auth, runtimeVersion, platform, commitHash, message, rolloutPercentage, publishGroup, branch, }: {
     body: {
-        fileNames: string[];
+        files: FileUploadItem[];
     };
     requestUploadUrl: string;
     auth: Credentials;

package/dist/lib/assets.js

@@ -1,11 +1,12 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requestUploadUrls = exports.activeRolloutConflictMessage = exports.resolveUploadRequests = exports.RequestUploadUrlsResponseJoi = exports.computeFilesRequests = exports.MetadataJoi = void 0;
+exports.requestUploadUrls = exports.NoChangesDetectedError = exports.activeRolloutConflictMessage = exports.resolveUploadRequests = exports.RequestUploadUrlsResponseJoi = exports.computeFilesRequests = exports.buildUploadFiles = exports.MetadataJoi = void 0;
 const tslib_1 = require("tslib");
 const fs_extra_1 = tslib_1.__importDefault(require("fs-extra"));
 const joi_1 = tslib_1.__importDefault(require("joi"));
 const path_1 = tslib_1.__importDefault(require("path"));
 const auth_1 = require("./auth");
+const crypto_1 = require("./crypto");
 const expoConfig_1 = require("./expoConfig");
 const fetch_1 = require("./fetch");
 const log_1 = tslib_1.__importDefault(require("./log"));
@@ -24,6 +25,26 @@ exports.MetadataJoi = joi_1.default.object({
         web: fileMetadataJoi,
     }).required(),
 }).required();
+// buildUploadFiles is one platform's publish: its launch asset, its assets and
+// the config files, each stamped with its role. This is what tells the server
+// which bundle is which — only the CLI reads metadata.json.
+function buildUploadFiles(files, platform) {
+    return files
+        .filter(file => file.platform === null || file.platform === platform)
+        .map(file => {
+        if (file.platform === null) {
+            return { path: file.path, hash: file.hash, role: 'config' };
+        }
+        return {
+            path: file.path,
+            hash: file.hash,
+            key: file.key,
+            ext: file.ext,
+            role: file.isLaunchAsset ? 'launch' : 'asset',
+        };
+    });
+}
+exports.buildUploadFiles = buildUploadFiles;
 function loadMetadata(distRoot) {
     // eslint-disable-next-line
     const fileContent = fs_extra_1.default.readFileSync(path_1.default.join(distRoot, 'metadata.json'), 'utf8');
@@ -54,23 +75,65 @@ function loadMetadata(distRoot) {
     log_1.default.debug(`Loaded ${platforms.length} platform(s): ${platforms.join(', ')}`);
     return metadata;
 }
-function computeFilesRequests(projectDir, outputDir, requestedPlatform) {
-    const metadata = loadMetadata(path_1.default.join(projectDir, outputDir));
-    const assets = [
-        { path: 'metadata.json', name: 'metadata.json', ext: 'json' },
-        { path: 'expoConfig.json', name: 'expoConfig.json', ext: 'json' },
+async function digestExportFile(exportRoot, relativePath) {
+    const absolutePath = path_1.default.resolve(exportRoot, relativePath);
+    if (absolutePath !== exportRoot && !absolutePath.startsWith(exportRoot + path_1.default.sep)) {
+        throw new Error(`Refusing to hash "${relativePath}": it resolves outside the export directory.`);
+    }
+    return await (0, crypto_1.digestFile)(absolutePath);
+}
+async function computeFilesRequests(projectDir, outputDir, requestedPlatform) {
+    const exportDir = path_1.default.join(projectDir, outputDir);
+    let exportRoot;
+    try {
+        exportRoot = await fs_extra_1.default.realpath(exportDir);
+    }
+    catch {
+        throw new Error(`Export directory ${exportDir} could not be resolved.`);
+    }
+    const metadata = loadMetadata(exportRoot);
+    const pending = [
+        {
+            path: 'metadata.json',
+            name: 'metadata.json',
+            ext: 'json',
+            platform: null,
+            isLaunchAsset: false,
+        },
+        {
+            path: 'expoConfig.json',
+            name: 'expoConfig.json',
+            ext: 'json',
+            platform: null,
+            isLaunchAsset: false,
+        },
     ];
     for (const platform of Object.keys(metadata.fileMetadata)) {
         if (requestedPlatform !== expoConfig_1.RequestedPlatform.All && requestedPlatform !== platform) {
             continue;
         }
         const bundle = metadata.fileMetadata[platform].bundle;
-        assets.push({ path: bundle, name: path_1.default.basename(bundle), ext: 'hbc' });
+        pending.push({
+            path: bundle,
+            name: path_1.default.basename(bundle),
+            ext: 'hbc',
+            platform,
+            isLaunchAsset: true,
+        });
         for (const asset of metadata.fileMetadata[platform].assets) {
-            assets.push({ path: asset.path, name: path_1.default.basename(asset.path), ext: asset.ext });
+            pending.push({
+                path: asset.path,
+                name: path_1.default.basename(asset.path),
+                ext: asset.ext,
+                platform,
+                isLaunchAsset: false,
+            });
         }
     }
-    return assets;
+    return await Promise.all(pending.map(async (entry) => ({
+        ...entry,
+        ...(await digestExportFile(exportRoot, entry.path)),
+    })));
 }
 exports.computeFilesRequests = computeFilesRequests;
 // The server dictates which local files the CLI opens and where their bytes are
@@ -91,6 +154,7 @@ const uploadRequestJoi = joi_1.default.object({
         .required(),
     fileName: joi_1.default.string().required(),
     filePath: joi_1.default.string().required(),
+    originalFileName: joi_1.default.string().required(),
     headers: uploadRequestHeadersJoi,
     // Unknown keys are tolerated so a newer server can add fields without
     // breaking older CLIs; nothing reads them.
@@ -177,40 +241,41 @@ async function resolveUploadRequests({ uploadRequests, exportDir, manifest, }) {
     const resolved = [];
     for (const item of uploadRequests) {
         assertSafeUploadUrl(item.requestUploadUrl);
-        assertRelativePathShape(item.filePath);
-        const manifestEntry = manifestByPath.get(item.filePath);
+        const exportPath = item.originalFileName;
+        assertRelativePathShape(exportPath);
+        const manifestEntry = manifestByPath.get(exportPath);
         if (!manifestEntry) {
-            throw new Error(`Refusing to upload "${item.filePath}": the server asked for a file that is not part of this export.`);
+            throw new Error(`Refusing to upload "${exportPath}": the server asked for a file that is not part of this export.`);
         }
-        if (item.fileName !== path_1.default.basename(item.filePath)) {
-            throw new Error(`Refusing to upload "${item.filePath}": the server returned the mismatched name "${item.fileName}".`);
+        if (item.fileName !== path_1.default.basename(exportPath)) {
+            throw new Error(`Refusing to upload "${exportPath}": the server returned the mismatched name "${item.fileName}".`);
         }
-        if (seen.has(item.filePath)) {
-            throw new Error(`The server requested "${item.filePath}" more than once.`);
+        if (seen.has(exportPath)) {
+            throw new Error(`The server requested "${exportPath}" more than once.`);
         }
-        seen.add(item.filePath);
-        const absolutePath = path_1.default.resolve(exportRoot, item.filePath);
+        seen.add(exportPath);
+        const absolutePath = path_1.default.resolve(exportRoot, exportPath);
         // Unreachable on POSIX: a path with no '..' segment and no leading separator
         // cannot resolve out of the root. Kept for the Windows drive-relative case
         // ("C:file" when the export root sits on another drive) and as a backstop if
         // the checks above are ever relaxed.
         if (absolutePath !== exportRoot && !absolutePath.startsWith(exportRoot + path_1.default.sep)) {
-            throw new Error(`Refusing to upload "${item.filePath}": it resolves outside the export directory.`);
+            throw new Error(`Refusing to upload "${exportPath}": it resolves outside the export directory.`);
         }
         let realPath;
         try {
             realPath = await fs_extra_1.default.realpath(absolutePath);
         }
         catch {
-            throw new Error(`File ${item.filePath} not found in the export directory.`);
+            throw new Error(`File ${exportPath} not found in the export directory.`);
         }
         // The root is already canonical, so any difference here means a symlink was
         // traversed, either as the file itself or as one of its parent directories.
         if (realPath !== absolutePath) {
-            throw new Error(`Refusing to upload "${item.filePath}": it is or goes through a symlink.`);
+            throw new Error(`Refusing to upload "${exportPath}": it is or goes through a symlink.`);
         }
         if (!(await fs_extra_1.default.lstat(absolutePath)).isFile()) {
-            throw new Error(`Refusing to upload "${item.filePath}": it is not a regular file.`);
+            throw new Error(`Refusing to upload "${exportPath}": it is not a regular file.`);
         }
         resolved.push({ item, absolutePath, manifestEntry });
     }
@@ -221,6 +286,15 @@ function activeRolloutConflictMessage(branch) {
     return `A progressive rollout is already active for branch "${branch}" on this runtime version. End or revert it from the dashboard before publishing a new update.`;
 }
 exports.activeRolloutConflictMessage = activeRolloutConflictMessage;
+class NoChangesDetectedError extends Error {
+    platform;
+    constructor(platform) {
+        super(`There is no change in the update for ${platform}`);
+        this.platform = platform;
+        this.name = 'NoChangesDetectedError';
+    }
+}
+exports.NoChangesDetectedError = NoChangesDetectedError;
 async function requestUploadUrls({ body, requestUploadUrl, auth, runtimeVersion, platform, commitHash, message, rolloutPercentage, publishGroup, branch, }) {
     const uploadUrl = new URL(requestUploadUrl);
     uploadUrl.searchParams.set('runtimeVersion', runtimeVersion);
@@ -247,6 +321,9 @@ async function requestUploadUrls({ body, requestUploadUrl, auth, runtimeVersion,
     if (response.status === 409) {
         throw new Error(activeRolloutConflictMessage(branch));
     }
+    if (response.status === 406) {
+        throw new NoChangesDetectedError(platform);
+    }
     if (!response.ok) {
         const text = await response.text();
         throw new Error(`Failed to request upload URL: ${text}${(0, auth_1.missingEooTokenHint)(response.status)}`);

package/dist/lib/crypto.d.ts

@@ -0,0 +1,8 @@
+/// <reference types="node" />
+/// <reference types="node" />
+export declare function toBase64Url(buffer: Buffer): string;
+export interface FileDigest {
+    hash: string;
+    key: string;
+}
+export declare function digestFile(filePath: string): Promise<FileDigest>;

package/dist/lib/crypto.js

@@ -0,0 +1,27 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.digestFile = exports.toBase64Url = void 0;
+const tslib_1 = require("tslib");
+const crypto_1 = require("crypto");
+const fs_1 = tslib_1.__importDefault(require("fs"));
+// Same encoding as internal/crypto.GetBase64URLEncoding: the string
+// shapeManifestAsset puts on ManifestAsset.hash.
+function toBase64Url(buffer) {
+    return buffer.toString('base64').replace(/\+/g, '-').replace(/\//g, '_').replace(/=+$/, '');
+}
+exports.toBase64Url = toBase64Url;
+async function digestFile(filePath) {
+    const sha256 = (0, crypto_1.createHash)('sha256');
+    const md5 = (0, crypto_1.createHash)('md5');
+    await new Promise((resolve, reject) => {
+        fs_1.default.createReadStream(filePath)
+            .on('error', reject)
+            .on('data', chunk => {
+            sha256.update(chunk);
+            md5.update(chunk);
+        })
+            .on('end', resolve);
+    });
+    return { hash: toBase64Url(sha256.digest()), key: md5.digest('hex') };
+}
+exports.digestFile = digestFile;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eoas",
-  "version": "3.1.3",
+  "version": "3.2.0-beta2",
   "main": "index.js",
   "scripts": {
     "build": "tsc --project tsconfig.json",