envstash-cli 0.4.2 → 0.4.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "envstash-cli",
-  "version": "0.4.2",
+  "version": "0.4.3",
   "description": "Git-style CLI for EnvStash — keep your .env files in sync with your cloud account.",
   "keywords": [
     "env",

package/src/commands/login.mjs

@@ -1,4 +1,4 @@
-import { execFile } from 'node:child_process'
+import { spawn } from 'node:child_process'
 import { hostname, userInfo } from 'node:os'
 import { setTimeout as sleep } from 'node:timers/promises'
 
@@ -53,7 +53,12 @@ export async function login(flags) {
   out()
   out(`  Your code:  ${style.bold(style.cyan(started.userCode))}`)
   out()
-  out(`  ${style.dim('Open')} ${style.blue(verificationUrl ?? `${host}/cli`)}`)
+  // The URL on its own line, in the same visible cyan as the code above it:
+  // blue vanishes on dark terminals, and a line that is only the URL is what
+  // lets a terminal's double-click and link detection grab the whole thing.
+  out(`  ${style.dim('Open this link to approve:')}`)
+  out()
+  out(`  ${style.cyan(verificationUrl ?? `${host}/cli`)}`)
   out()
 
   if (!verificationUrl) {
@@ -217,8 +222,23 @@ function openBrowser(url) {
     }
 
     try {
-      child = execFile(command.file, command.args, { stdio: 'ignore' }, error => settle(!error))
+      // spawn, not execFile: execFile builds its own options object for spawn
+      // and does not forward `stdio`, so asking it for 'ignore' silently got
+      // the default three pipes instead. The opener passes those on to the
+      // browser it exec-s, and child.unref() releases the process handle but
+      // not the pipe handles — so the event loop stayed alive on a browser that
+      // could outlive the terminal, and `envs login` printed "✓ Signed in" and
+      // then hung at the prompt. Detaching as well puts the browser in its own
+      // process group, so Ctrl-C on a still-waiting login does not take it down
+      // (not on Windows, where detached means a new console window).
+      child = spawn(command.file, command.args, {
+        stdio: 'ignore',
+        detached: process.platform !== 'win32',
+        windowsHide: true,
+      })
+
       child.on('error', () => settle(false))
+      child.on('exit', code => settle(code === 0))
     } catch {
       settle(false)
       return