entodicton 9.7.1-beta.1 → 9.7.1-beta.3

package/client.js

@@ -12,7 +12,7 @@ const _ = require('lodash')
 const stringify = require('json-stable-stringify')
 const Lines = require('./lines')
 const flattens = require('./src/flatten')
-const { sortJson, appendNoDups, InitCalls, updateQueries, safeNoDups, stableId, where, suggestAssociationsFix, suggestAssociationsFixFromSummaries, validProps } = require('./src/helpers')
+const { sortJson, appendNoDups, InitCalls, updateQueries, safeNoDups, stableId, where, suggestAssociationsFix, suggestAssociationsFixFromSummaries, validProps, OverrideCheck, } = require('./src/helpers')
 const runtime = require('./runtime')
 const db = require('./src/debug')
 
@@ -2104,4 +2104,5 @@ module.exports = {
   writeTest,
   getConfigForTest,
   debug: db,
+  OverrideCheck,
 }

package/index.js

@@ -1,7 +1,7 @@
 const { Semantics, Semantic } = require('./src/semantics')
 const { Generators, Generator } = require('./src/generators')
 const { Config } = require('./src/config')
-const { w, where } = require('./src/helpers')
+const { w, where, OverrideCheck } = require('./src/helpers')
 const Digraph = require('./src/digraph')
 const client = require('./client')
 const flattens = require('./src/flatten')
@@ -28,5 +28,6 @@ module.exports = {
   flattens: flattens.flattens,
   flatten: flattens.flatten,
   unflatten: unflatten.unflatten,
-  debug
+  debug,
+  OverrideCheck,
 }

package/package.json

@@ -73,6 +73,6 @@
     "scriptjs": "^2.5.9",
     "uuid": "^8.3.2"
   },
-  "version": "9.7.1-beta.1",
+  "version": "9.7.1-beta.3",
   "license": "UNLICENSED"
 }

package/src/config.js

@@ -2313,6 +2313,7 @@ class Config {
     }
   }
 
+  // TODO Api or API -> pick one and do that
   async setMultiApi (initializer) {
     await this.setApi(() => multiApiImpl(initializer))
   }
@@ -2420,11 +2421,18 @@ class Config {
         if (!api.initialize) {
           throw new Error(`Expected the API for ${this.name} to have an initialize function.`)
         }
+        if (api.baseAPI) {
+          debugger
+          new helpers.OverrideCheck(api.baseAPI).check(api)
+        }
       }
     } else {
       if (!value.initialize) {
         throw new Error(`Expected the API to have an initialize function for ${this.name}. If you are trying to pass in multiple API configs at once use setApiKMs to set the names of the configs that you want set.`)
       }
+      if (value.baseAPI) {
+        new helpers.OverrideCheck(value.baseAPI).check(value)
+      }
     }
 
     if (this._api && this._api.multiApi) {

package/src/helpers.js

@@ -1,6 +1,23 @@
 const deepEqual = require('deep-equal')
 const stringify = require('json-stable-stringify')
 
+
+// check if member function of a class have been overriden by an subclass
+class OverrideCheck {
+  constructor(base, suffix='API') {
+    this.base = base
+    this.checks = Object.getOwnPropertyNames(base.prototype).filter(key => typeof base.prototype[key] === 'function' && key.endsWith(suffix));
+  }
+
+  check(obj) {
+    for (const check of this.checks) {
+      if (obj[check] == this.base.prototype[check]) {
+        throw new Error(`For ${obj.constructor.name} you need to override ${check}`)
+      }
+    }
+  }
+}
+
 function pathEquals (p1, p2) {
   if (p1.length !== p2.length) {
     return false
@@ -611,4 +628,5 @@ module.exports = {
   assignAssumed,
   watchProperty,
   pathEquals,
+  OverrideCheck,
 }