entkapp 5.2.0 → 5.2.2

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
   "name": "entkapp",
-  "version": "5.2.0",
+  "version": "5.2.2",
   "description": "The Ultimate Enterprise Codebase Janitor. Faster than Knip with OXC integration, type-aware analysis, and automated structural healing. Fully standalone - solving what Knip cannot.",
   "type": "module",
   "main": "index.js",

package/src/EngineContext.js

@@ -86,10 +86,16 @@ export class GraphNode {
       }
 
       // Fuzzy / Dynamic usage (Identifiers, Strings, JSX, Decorators)
-      if (parentNode.instantiatedIdentifiers.has(symbolName)) return true;
-      if (parentNode.rawStringReferences.has(symbolName)) return true;
-      if (parentNode.jsxComponents.has(symbolName)) return true;
-      if (parentNode.decorators.has(symbolName)) return true;
+      // UPGRADE: Only check for fuzzy matches if we have a reason to believe it might be used.
+      // We skip global names like 'toLowerCase' unless they are explicitly imported.
+      const isGlobalName = ['toLowerCase', 'toUpperCase', 'toString', 'valueOf', 'hasOwnProperty', 'constructor'].includes(symbolName);
+      
+      if (!isGlobalName) {
+        if (parentNode.instantiatedIdentifiers.has(symbolName)) return true;
+        if (parentNode.rawStringReferences.has(symbolName)) return true;
+        if (parentNode.jsxComponents.has(symbolName)) return true;
+        if (parentNode.decorators.has(symbolName)) return true;
+      }
       
       for (const accessChain of parentNode.propertyAccessChains) {
         if (accessChain.endsWith(`.${symbolName}`) || accessChain.includes(`.${symbolName}.`)) return true;
@@ -390,7 +396,15 @@ export class EngineContext {
           continue;
         }
         
-        if (!usedByReachableFiles.has(dep)) {
+        // UPGRADE: Be more aggressive in detecting unused dependencies.
+        // Check both externalPackageUsage and rawStringReferences.
+        const isUsed = usedByReachableFiles.has(dep) || 
+                       Array.from(reachableFiles).some(f => {
+                         const node = this.projectGraph.get(f);
+                         return node && (node.externalPackageUsage.has(dep) || node.rawStringReferences.has(dep));
+                       });
+
+        if (!isUsed) {
           report.unusedDependencies.push({
             package: dep,
             type: deps.dependencies.includes(dep) ? 'dependency' : 'devDependency',

package/src/ast/ASTAnalyzer.js

@@ -604,8 +604,14 @@ export class ASTAnalyzer {
       if (this.context.verbose) console.log(`[AST-DEBUG] Found require() call in ${fileNode.filePath}`);
       const arg = node.arguments[0];
       if (arg && ts.isStringLiteral(arg)) {
-        if (this.context.verbose) console.log(`[AST-DEBUG] Added import: ${arg.text}`);
-        fileNode.explicitImports.add(arg.text);
+        const specifier = arg.text;
+        if (this.context.verbose) console.log(`[AST-DEBUG] Added import: ${specifier}`);
+        fileNode.explicitImports.add(specifier);
+        
+        // UPGRADE: Also track package usage for unlisted dependency detection
+        if (!specifier.startsWith('.') && !specifier.startsWith('/')) {
+          fileNode.externalPackageUsage.add(this._extractPackageName(specifier));
+        }
       }
     }
   }

package/src/index.js

@@ -498,40 +498,63 @@ export class RefactoringEngine {
         }
       }
 
+      // UPGRADE: Unlisted Dependency Audit (Unified Root & Workspace)
+      const auditManifests = [];
+      // 1. Collect Root Manifest
+      const rootPkgPath = path.join(this.context.cwd, 'package.json');
+      if (existsSync(rootPkgPath)) {
+        auditManifests.push({
+          rootDirectory: this.context.cwd,
+          manifestPath: rootPkgPath
+        });
+      }
+      // 2. Collect Workspace Manifests
       if (this.workspaceGraph && this.workspaceGraph.packageManifests) {
         for (const [_, metadata] of this.workspaceGraph.packageManifests.entries()) {
-          if (this.context.projectGraph) {
-            for (const [filePath, fileNode] of this.context.projectGraph.entries()) {
-              const cleanRelative = path.relative(metadata.rootDirectory, filePath).replace(/\\/g, '/');
-              
-              if (!cleanRelative.startsWith('..') && !cleanRelative.startsWith('/') && fileNode.explicitImports) {
-                try {
-                  const localManifest = JSON.parse(readFileSync(metadata.manifestPath, 'utf8'));
-                  const localDeps = new Set([
-                    ...Object.keys(localManifest.dependencies || {}),
-                    ...Object.keys(localManifest.devDependencies || {}),
-                    ...Object.keys(localManifest.peerDependencies || {})
-                  ]);
-
-                  fileNode.explicitImports.forEach(specifier => {
-                    if (specifier.startsWith('.') || specifier.startsWith('/')) return;
-                    const basePkg = specifier.startsWith('@') ? specifier.split('/').slice(0, 2).join('/') : specifier.split('/')[0];
-                    
-                    if (!localDeps.has(basePkg)) {
-                      const alreadyFlagged = this.context.unlistedDependencies.some(u => u.package === basePkg && u.file === filePath);
-                      if (!alreadyFlagged) {
-                        this.context.unlistedDependencies.push({
-                          package: basePkg,
-                          file: path.relative(this.context.cwd, filePath),
-                          manifest: path.relative(this.context.cwd, metadata.manifestPath)
-                        });
-                      }
+          auditManifests.push(metadata);
+        }
+      }
+
+      for (const metadata of auditManifests) {
+        if (this.context.projectGraph) {
+          for (const [filePath, fileNode] of this.context.projectGraph.entries()) {
+            const cleanRelative = path.relative(metadata.rootDirectory, filePath).replace(/\\/g, '/');
+            
+            // Check if file belongs to this manifest's directory scope
+            if (!cleanRelative.startsWith('..') && !cleanRelative.startsWith('/') && fileNode.explicitImports) {
+              try {
+                const localManifest = JSON.parse(readFileSync(metadata.manifestPath, 'utf8'));
+                const localDeps = new Set([
+                  ...Object.keys(localManifest.dependencies || {}),
+                  ...Object.keys(localManifest.devDependencies || {}),
+                  ...Object.keys(localManifest.peerDependencies || {}),
+                  ...Object.keys(localManifest.optionalDependencies || {})
+                ]);
+
+                fileNode.explicitImports.forEach(specifier => {
+                  if (specifier.startsWith('.') || specifier.startsWith('/')) return;
+                  
+                  // Extract base package name (handle scoped packages)
+                  const basePkg = specifier.startsWith('@') ? specifier.split('/').slice(0, 2).join('/') : specifier.split('/')[0];
+                  
+                  // Ignore Node.js built-ins
+                  const nodeBuiltins = ['assert', 'async_hooks', 'buffer', 'child_process', 'cluster', 'console', 'constants', 'crypto', 'dgram', 'dns', 'domain', 'events', 'fs', 'http', 'http2', 'https', 'inspector', 'module', 'net', 'os', 'path', 'perf_hooks', 'process', 'punycode', 'querystring', 'readline', 'repl', 'stream', 'string_decoder', 'timers', 'tls', 'trace_events', 'tty', 'url', 'util', 'v8', 'vm', 'worker_threads', 'zlib'];
+                  if (nodeBuiltins.includes(basePkg) || nodeBuiltins.includes(basePkg.replace('node:', ''))) return;
+
+                  if (!localDeps.has(basePkg)) {
+                    const alreadyFlagged = this.context.unlistedDependencies.some(u => u.package === basePkg && u.file === filePath);
+                    if (!alreadyFlagged) {
+                      this.context.unlistedDependencies.push({
+                        package: basePkg,
+                        file: path.relative(this.context.cwd, filePath),
+                        manifest: path.relative(this.context.cwd, metadata.manifestPath)
+                      });
                     }
-                  });
-                } catch (error) {
-                  if (this.context.options.verbose) {
-                    console.error(ansis.red(`      ❌ Manifest Parsing Exception: ${error.message}`));
                   }
+                });
+              } catch (error) {
+                if (this.context.options.verbose) {
+                  console.error(ansis.red(`      ❌ Manifest Parsing Exception: ${error.message}`));
                 }
               }
             }
@@ -940,7 +963,9 @@ export class RefactoringEngine {
       if (isProtected || isExplicitlyDeclared) {
         finalIsEntry = true;
       } else if (!hasManifestEntries && hasNoIncoming && hasOutgoing && !isLikelyBarrel) {
-        finalIsEntry = true;
+        // UPGRADE: Orphan files with imports are NOT entry points by default.
+        // They must have side effects (detected in AST pass) to be entries.
+        finalIsEntry = node.isEntry; 
       }
 
       node.isEntry = finalIsEntry;