entangled-worlds-orbiters-shared 2.5.0 → 2.7.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "entangled-worlds-orbiters-shared",
-  "version": "2.5.0",
+  "version": "2.7.0",
   "description": "Shared library for entangled worlds orbiters - contains core world rendering, moons system, and UI components",
   "type": "module",
   "main": "src/index.js",
@@ -42,6 +42,7 @@
   "files": [
     "src/**/*",
     "!src/**/*.test.ts",
+    "!src/**/*.test.js",
     "dist/**/*",
     "public/**/*",
     "README.md",
@@ -90,6 +91,7 @@
     "typecheck": "tsc -p tsconfig.json --noEmit",
     "test:clock": "node --test --import tsx src/clock/*.test.ts",
     "test:render": "node --test src/render/*.test.js",
-    "test": "npm run test:clock && npm run test:render"
+    "test": "npm run test:clock && npm run test:render && npm run test:moons",
+    "test:moons": "node --test src/moons/*.test.js"
   }
 }

package/src/moons/moonsGeneration.js

@@ -38,7 +38,6 @@ export async function generateMoons({
   debugShowReferenceMoon = false, // changed from true to prevent extra moon
   referenceMoonScale = 0.25,
   // behavior flags
-  preserveInstanceTint = false,      // keep per-instance color even when textured
   useEmissiveMapFromTexture = true,  // reuse color texture as emissiveMap to lift dark sides
   // The renderer whose KTX2 transcoder decodes the moon texture. Required on any page with more than
   // one renderer; falls back to the standalone app's global inside the loader.
@@ -118,10 +117,20 @@ export async function generateMoons({
     }
   }
 
-  const enableVertexColors = !sharedTexture || preserveInstanceTint;
+  // `vertexColors` is deliberately NOT set, and setting it here was a bug worth spelling out.
+  //
+  // The per-moon tint rides on `instanceColor` (set by `setColorAt` below). Three defines
+  // USE_INSTANCING_COLOR for that on its own and multiplies it into `vColor` — no material flag
+  // needed. `vertexColors` is a DIFFERENT feature: it multiplies by the geometry's `color`
+  // ATTRIBUTE. This geometry is a plain SphereGeometry and has no such attribute, so enabling it
+  // made the shader multiply by an absent attribute — zero — and every moon rendered BLACK, with the
+  // tint annihilated along with it.
+  //
+  // It only bit the untextured path (`!sharedTexture`), which is the one the performance look uses:
+  // moons there carry no texture, so their colour IS the moon, and it was the one case where the
+  // colour silently could not work.
   const moonMaterial = new THREE.MeshStandardMaterial({
     map: sharedTexture || null,
-    vertexColors: enableVertexColors,
     roughness,
     metalness,
     emissive: new THREE.Color(emissiveColor),

package/src/render/frameBudget.test.js

@@ -1,62 +0,0 @@
-import test from 'node:test';
-import assert from 'node:assert/strict';
-import { createFrameBudget, CAPPED_FPS } from './frameBudget.js';
-
-test('the first frame is always allowed', () => {
-  const budget = createFrameBudget();
-  assert.equal(budget.shouldRender(0), true);
-});
-
-test('a 60Hz display yields 30fps, not 20', () => {
-  // The whole reason the tolerance exists. rAF on a 60Hz display delivers at ~16.7ms intervals; a
-  // strict >= 33.3 test rejects the frame at 33.3 and waits for 50, which is 20fps.
-  const budget = createFrameBudget();
-  const accepted = [];
-  for (let i = 0; i < 12; i += 1) {
-    const now = i * (1000 / 60);
-    if (budget.shouldRender(now)) accepted.push(i);
-  }
-  // Every other frame: 0, 2, 4, ... — half of 60 is the 30 that was asked for.
-  assert.deepEqual(accepted, [0, 2, 4, 6, 8, 10]);
-});
-
-test('a 120Hz display is capped to the same rate', () => {
-  const budget = createFrameBudget();
-  let accepted = 0;
-  for (let i = 0; i < 120; i += 1) {
-    if (budget.shouldRender(i * (1000 / 120))) accepted += 1;
-  }
-  // One second of 120Hz ticks, capped at 30 — allow the boundary frame either way.
-  assert.ok(accepted >= CAPPED_FPS && accepted <= CAPPED_FPS + 1, `accepted ${accepted}`);
-});
-
-test('a rejected frame does not move the clock forward', () => {
-  // Otherwise a burst of rejected frames would keep pushing the next allowed one further out.
-  const budget = createFrameBudget();
-  budget.shouldRender(0);
-  assert.equal(budget.shouldRender(10), false);
-  assert.equal(budget.shouldRender(20), false);
-  assert.equal(budget.shouldRender(30), true);
-});
-
-test('reset makes the next frame the first one again', () => {
-  const budget = createFrameBudget();
-  budget.shouldRender(0);
-  assert.equal(budget.shouldRender(5), false);
-  budget.reset();
-  assert.equal(budget.shouldRender(5), true);
-});
-
-test('a missing timestamp never blocks a frame', () => {
-  // rAF always supplies one, but `renderOnce` can be driven by tooling that does not.
-  const budget = createFrameBudget();
-  assert.equal(budget.shouldRender(undefined), true);
-  assert.equal(budget.shouldRender(Number.NaN), true);
-});
-
-test('a custom rate is honoured', () => {
-  const budget = createFrameBudget({ fps: 10, toleranceMs: 0 });
-  assert.equal(budget.shouldRender(0), true);
-  assert.equal(budget.shouldRender(99), false);
-  assert.equal(budget.shouldRender(100), true);
-});