engineering-memory 0.2.1 → 0.2.3

package/bin/engineering-memory.mjs

@@ -29,8 +29,6 @@ Choose the hook mode through the Codex or Claude native questionnaire before
 passing a repository. The installer never opens a questionnaire or an
 authentication web page.`;
 
-// The backend this package was published for. An installation only names one
-// when it points at a different, self-hosted backend.
 async function publishedApiUrl() {
   const manifest = await readJson(join(packageRoot, 'package.json'));
   const apiUrl = manifest?.engineeringMemory?.apiUrl;

package/install/installer.mjs

@@ -107,8 +107,29 @@ export async function installEngineeringMemory(options = {}) {
       dispatcherSection: dispatcherSections.claude,
     },
   };
+  const mcpPlans = await planMcpRegistrations({
+    selectedClients,
+    bridgeEntry,
+    nodePath,
+    apiUrl,
+    clientVersion,
+    state: existingState,
+    commandRunner,
+    clientsWereRequested: options.selectedClients !== undefined,
+  });
+  const absentClients = mcpPlans
+    .filter((plan) => plan.action === 'absent')
+    .map((plan) => plan.clientName);
+  const installedClients = selectedClients.filter(
+    (clientName) => !absentClients.includes(clientName),
+  );
+  if (installedClients.length === 0) {
+    throw new Error(
+      `None of the supported agent CLIs are on PATH: ${selectedClients.join(', ')}. Install one, then rerun the installer.`,
+    );
+  }
   const clientPlans = await Promise.all(
-    selectedClients.map(async (clientName) => {
+    installedClients.map(async (clientName) => {
       const target = clientTargets[clientName];
       return {
         clientName,
@@ -120,15 +141,6 @@ export async function installEngineeringMemory(options = {}) {
       };
     }),
   );
-  const mcpPlans = await planMcpRegistrations({
-    selectedClients,
-    bridgeEntry,
-    nodePath,
-    apiUrl,
-    clientVersion,
-    state: existingState,
-    commandRunner,
-  });
   const hookPlan = await planGitHook({
     repoRoot: options.repoRoot ? resolve(options.repoRoot) : null,
     mode: options.hookMode ?? 'cancel',
@@ -189,7 +201,8 @@ export async function installEngineeringMemory(options = {}) {
       statePath,
       skillPaths: clientPlans.map((plan) => plan.skillPath),
       dispatcherPaths: clientPlans.map((plan) => plan.dispatcherPath),
-      selectedClients,
+      selectedClients: installedClients,
+      absentClients,
       apiUrl,
       clientVersion,
       runtimePath,

package/install/mcp-registration.mjs

@@ -48,6 +48,7 @@ export async function planMcpRegistrations({
   clientVersion,
   state,
   commandRunner,
+  clientsWereRequested = true,
 }) {
   const plans = [];
   for (const clientName of selectedClients) {
@@ -55,6 +56,10 @@ export async function planMcpRegistrations({
     if (!client) throw new Error(`Unsupported client: ${clientName}`);
     const version = await commandRunner(client.executable, ['--version']);
     if (version.code !== 0) {
+      if (!clientsWereRequested && !state?.mcp?.[clientName]) {
+        plans.push({ clientName, client, action: 'absent' });
+        continue;
+      }
       throw new Error(
         `${clientName} CLI is unavailable. Install its native CLI, ensure it is on PATH, then rerun the installer. ${commandFailure(client.executable, version)}`,
       );
@@ -121,6 +126,7 @@ export async function planMcpRegistrations({
 export async function applyMcpRegistrations(plans, commandRunner, transaction) {
   const result = {};
   for (const plan of plans) {
+    if (plan.action === 'absent') continue;
     if (plan.action === 'add') {
       await addRegistration(plan, plan.registration, commandRunner);
       transaction.add(() => removeRegistration(plan, commandRunner));
@@ -211,6 +217,19 @@ function registrationFingerprint(clientName, registration) {
     .digest('hex');
 }
 
+function fingerprintBeforeClientVersion(clientName, registration) {
+  return createHash('sha256')
+    .update(
+      JSON.stringify({
+        clientName,
+        nodePath: registration.nodePath,
+        bridgeEntry: registration.bridgeEntry,
+        apiUrl: registration.apiUrl ?? null,
+      }),
+    )
+    .digest('hex');
+}
+
 function sameRegistration(left, right) {
   return (
     left?.nodePath === right.nodePath &&
@@ -462,9 +481,13 @@ function isOwnedRegistration(clientName, managed) {
       typeof managed.bridgeEntry === 'string'
     );
   }
+  if (typeof managed.apiUrl !== 'string') return false;
+  if (managed.fingerprint === registrationFingerprint(clientName, managed)) {
+    return true;
+  }
   return (
-    typeof managed.apiUrl === 'string' &&
-    managed.fingerprint === registrationFingerprint(clientName, managed)
+    managed.clientVersion === undefined &&
+    managed.fingerprint === fingerprintBeforeClientVersion(clientName, managed)
   );
 }
 

package/lib/stage-runtime.mjs

@@ -3,10 +3,6 @@ import { tmpdir } from 'node:os';
 import { dirname, join } from 'node:path';
 import { readJson, resolveProductionPackagePaths } from '../install/files.mjs';
 
-// The published package cannot carry node_modules, because npm excludes it from
-// every tarball. The bridge runtime is assembled here from the dependencies npm
-// installed for this package, into the exact layout the installer verifies
-// against the bridge lockfile.
 export async function stageBridgeRuntime(packageRoot, resolver) {
   const source = join(packageRoot, 'runtime');
   const packageJson = await readJson(join(source, 'package.json'));
@@ -37,8 +33,6 @@ export async function stageBridgeRuntime(packageRoot, resolver) {
   return staged;
 }
 
-// A package is free to keep package.json out of its exports map, and several do,
-// so the directory is found on disk rather than through module resolution.
 async function locate(name, resolver) {
   for (const directory of resolver.resolve.paths(name) ?? []) {
     const candidate = join(directory, ...name.split('/'));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "engineering-memory",
-  "version": "0.2.1",
+  "version": "0.2.3",
   "description": "Installs the Engineering Memory skill and its local MCP bridge. Sign in after installing; your organization and project are resolved from your account.",
   "license": "UNLICENSED",
   "type": "module",

package/runtime/dist/src/runtime/bridge-service.js

@@ -1160,9 +1160,6 @@ export class BridgeService {
             });
         });
     }
-    // What the backend expects of this client, and whether the user has already
-    // been asked about it. A required update leaves no choice; an optional one is
-    // offered once per version and never raised again after a refusal.
     async clientUpdate(authenticated) {
         const installed = this.dependencies.clientVersion;
         if (!authenticated) {
@@ -1799,9 +1796,6 @@ export class BridgeService {
         if (pointer.verificationIntent || pointer.closeIntent) {
             throw new Error('A clean active task snapshot is required for checkpointing');
         }
-        // The slug names the task's journal directory, and a directory is the same
-        // one whatever case it is typed in. Rejecting KAN-1003 against kan-1003
-        // refuses a correct checkpoint over nothing.
         if (pointer.taskSlug.toLowerCase() !== input.taskSlug.toLowerCase()) {
             throw new Error(`Checkpoint task slug ${input.taskSlug} does not match the active task ${pointer.taskSlug}`);
         }

package/runtime/dist/src/runtime/repository-decision-store.js

@@ -1,8 +1,5 @@
 import { join } from 'node:path';
 import { readJson, removeFile, writeJson } from '../utilities/files.js';
-// What a user decided about Engineering Memory in one repository, on one
-// machine. It never lives in the repository: a developer switching it off must
-// not switch it off for everyone who clones after them.
 export class RepositoryDecisionStore {
     root;
     queues = new Map();

package/runtime/dist/src/runtime/update-choice-store.js

@@ -1,7 +1,5 @@
 import { join } from 'node:path';
 import { readJson, writeJson } from '../utilities/files.js';
-// Which client version the user was offered and turned down. Asking again for
-// the same version is nagging; asking when a newer one arrives is news.
 export class UpdateChoiceStore {
     path;
     root;

package/skill/references/questionnaires.md

@@ -68,6 +68,12 @@ Before proposing a flow record, ask the user what the design cannot answer: whic
 
 When the user names a different Figma file or link, treat it as a correction to the `figma_reference` record and propose the revision in the same reply, with the new file key and URL. Ask for approval there and then. Do not carry the new address only in the conversation: the next session reads the record, not the chat.
 
+## Running the Application
+
+When the change is something a person sees or interacts with and this environment can run the application, ask before launching it rather than starting on your own. A run occupies the user's machine, can take minutes, and they may be using it. Say what you would exercise and what you are looking for, so the answer is about the work rather than about the tooling.
+
+Ask again nothing when they decline. Verify what you can without it and state in the handoff that the flow was not exercised in a running application.
+
 ## Correction Scope
 
 At a natural checkpoint after recording and fixing a user correction, first state how the correction was classified and why, then offer the scopes that classification allows.