emi-indo-cordova-plugin-admob 1.5.8 → 1.6.0

package/example/www/js/bannerAd.js

@@ -20,7 +20,7 @@ function loadBanner() {
         cordova.plugins.emiAdmobPlugin.loadBannerAd({
             adUnitId: Banner_ID, //Banner_ID,
             position: "bottom-center",
-            size: "responsive_adaptive", // autoResize: true (only responsive_adaptive)
+            size: "banner", // autoResize: true (only responsive_adaptive)
             collapsible: "bottom", // position: top | bottom (disable, empty string)
             autoResize: true, // default false
             autoShow: true, // default false

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "emi-indo-cordova-plugin-admob",
-  "version": "1.5.8",
+  "version": "1.6.0",
   "description": "Cordova Plugin Admob Android IOS",
   "cordova": {
     "id": "emi-indo-cordova-plugin-admob",

package/plugin.xml

@@ -1,6 +1,6 @@
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
   xmlns:android="http://schemas.android.com/apk/res/android"
-  id="emi-indo-cordova-plugin-admob" version="1.5.8">
+  id="emi-indo-cordova-plugin-admob" version="1.6.0">
 
   <name>emiAdmobPlugin</name>
   <description>Cordova Plugin Admob Android IOS</description>

package/src/android/emiAdmobPlugin.kt

@@ -161,6 +161,7 @@ class emiAdmobPlugin : CordovaPlugin() {
                 if(mActivity != null) {
                     mActivity!!.runOnUiThread {
                         try {
+                            bannerOverlappingToZero()
                             if (bannerViewLayout != null && bannerView != null) {
                                 val parentView = bannerViewLayout!!.parent as ViewGroup
                                 parentView.removeView(bannerViewLayout)
@@ -169,22 +170,17 @@ class emiAdmobPlugin : CordovaPlugin() {
                                     FrameLayout.LayoutParams.MATCH_PARENT,
                                     FrameLayout.LayoutParams.WRAP_CONTENT
                                 )
-                                val rootView =
-                                    mActivity!!.window.decorView.findViewById<View>(View.generateViewId())
-                                if (rootView is ViewGroup) {
-                                    rootView.addView(bannerViewLayout, params)
-                                } else {
-                                    mActivity!!.addContentView(bannerViewLayout, params)
-                                }
-                                bannerView = AdView(mContext!!)
+                                val decorView = mActivity!!.window.decorView as ViewGroup
+                                decorView.addView(bannerViewLayout, params)
+                                bannerView = AdView(mActivity!!)
                                 setBannerPosition(this.isPosition)
                                 setBannerSiz(this.isSize)
                                 bannerView!!.adUnitId = bannerAdUnitId!!
                                 bannerView!!.adListener = bannerAdListener
                                 bannerView!!.loadAd(buildAdRequest())
-                                adjustWebViewForBanner(this.isPosition)
                                 bannerViewLayout!!.addView(bannerView)
                                 bannerViewLayout!!.bringToFront()
+                                bannerOverlappingToZero()
                             }
                         } catch (e: Exception) {
                             PUBLIC_CALLBACKS!!.error("Error adjusting banner size: " + e.message)
@@ -195,9 +191,15 @@ class emiAdmobPlugin : CordovaPlugin() {
 
             when (orientation) {
                 Configuration.ORIENTATION_PORTRAIT -> {
+                    if (isOverlapping) {
+                        bannerOverlapping()
+                    }
                     cWebView!!.loadUrl("javascript:cordova.fireDocumentEvent('on.orientation.portrait');")
                 }
                 Configuration.ORIENTATION_LANDSCAPE -> {
+                    if (isOverlapping) {
+                        bannerOverlapping()
+                    }
                     cWebView!!.loadUrl("javascript:cordova.fireDocumentEvent('on.orientation.landscape');")
                 }
                 Configuration.ORIENTATION_UNDEFINED -> {
@@ -464,17 +466,17 @@ class emiAdmobPlugin : CordovaPlugin() {
                                 }
 
                                 private fun openAutoShow() {
-                                        try {
-                                            if (mActivity != null && isAppOpenAdShow && appOpenAd != null) {
-                                                mActivity!!.runOnUiThread {
-                                                    appOpenAd!!.show(
-                                                        mActivity!!
-                                                    )
-                                                }
+                                    try {
+                                        if (mActivity != null && isAppOpenAdShow && appOpenAd != null) {
+                                            mActivity!!.runOnUiThread {
+                                                appOpenAd!!.show(
+                                                    mActivity!!
+                                                )
                                             }
-                                        } catch (e: Exception) {
-                                            PUBLIC_CALLBACKS!!.error(e.toString())
                                         }
+                                    } catch (e: Exception) {
+                                        PUBLIC_CALLBACKS!!.error(e.toString())
+                                    }
                                 }
 
                                 override fun onAdFailedToLoad(loadAdError: LoadAdError) {
@@ -499,16 +501,16 @@ class emiAdmobPlugin : CordovaPlugin() {
             return true
         } else if (action == "showAppOpenAd") {
 
-                try {
-                    if (mActivity != null && isAppOpenAdShow && appOpenAd != null) {
-                        mActivity!!.runOnUiThread { appOpenAd!!.show(mActivity!!) }
-                        appOpenAdLoadCallback()
-                    } else {
-                        callbackContext.error("The App Open Ad wasn't ready yet")
-                    }
-                } catch (e: Exception) {
-                    PUBLIC_CALLBACKS!!.error(e.toString())
+            try {
+                if (mActivity != null && isAppOpenAdShow && appOpenAd != null) {
+                    mActivity!!.runOnUiThread { appOpenAd!!.show(mActivity!!) }
+                    appOpenAdLoadCallback()
+                } else {
+                    callbackContext.error("The App Open Ad wasn't ready yet")
                 }
+            } catch (e: Exception) {
+                PUBLIC_CALLBACKS!!.error(e.toString())
+            }
 
             return true
         } else if (action == "loadInterstitialAd") {
@@ -613,12 +615,12 @@ class emiAdmobPlugin : CordovaPlugin() {
             return true
         } else if (action == "showInterstitialAd") {
 
-                if (mActivity != null && isInterstitialLoad && mInterstitialAd != null) {
-                    mActivity!!.runOnUiThread { mInterstitialAd!!.show(mActivity!!) }
-                    interstitialAdLoadCallback()
-                } else {
-                    callbackContext.error("The Interstitial ad wasn't ready yet")
-                }
+            if (mActivity != null && isInterstitialLoad && mInterstitialAd != null) {
+                mActivity!!.runOnUiThread { mInterstitialAd!!.show(mActivity!!) }
+                interstitialAdLoadCallback()
+            } else {
+                callbackContext.error("The Interstitial ad wasn't ready yet")
+            }
             return true
         } else if (action == "loadRewardedAd") {
             val options = args.getJSONObject(0)
@@ -738,8 +740,8 @@ class emiAdmobPlugin : CordovaPlugin() {
                                                     }
                                                 }
                                             }
+                                        }
                                     }
-                                }
                             })
                     } catch (e: Exception) {
                         callbackContext.error(e.toString())
@@ -1071,6 +1073,13 @@ class emiAdmobPlugin : CordovaPlugin() {
                         try {
                             bannerView!!.visibility = View.VISIBLE
                             bannerView!!.resume()
+                           // bannerOverlappingToZero()
+
+                            if (isOverlapping) {
+                                 bannerOverlapping()
+                            }
+
+
                         } catch (e: Exception) {
                             callbackContext.error(e.toString())
                         }
@@ -1121,6 +1130,7 @@ class emiAdmobPlugin : CordovaPlugin() {
                             bannerView!!.pause()
                             isBannerLoad = false
                             isBannerPause = 1
+                            bannerOverlappingToZero()
                         } catch (e: Exception) {
                             callbackContext.error(e.toString())
                         }
@@ -1133,6 +1143,7 @@ class emiAdmobPlugin : CordovaPlugin() {
                 mActivity!!.runOnUiThread {
                     try {
                         if (bannerViewLayout != null && bannerView != null) {
+                            bannerOverlappingToZero()
                             bannerViewLayout!!.removeView(bannerView)
                             bannerView!!.destroy()
                             bannerView = null
@@ -1229,6 +1240,11 @@ class emiAdmobPlugin : CordovaPlugin() {
         }
     }
 
+
+
+
+
+
     @SuppressLint("RtlHardcoded")
     private fun setBannerPosition(position: String?) {
         val bannerParams = FrameLayout.LayoutParams(
@@ -1247,6 +1263,7 @@ class emiAdmobPlugin : CordovaPlugin() {
                 bannerParams.gravity = Gravity.TOP or Gravity.CENTER_HORIZONTAL
                 bannerParams.setMargins(0, marginsInPx, 0, 0)
                 bannerViewLayout!!.setPadding(0, paddingInPx, 0, 0)
+
             }
 
             "left" -> {
@@ -1290,7 +1307,7 @@ class emiAdmobPlugin : CordovaPlugin() {
 
     private fun isBannerAutoShow() {
         try {
-            if (bannerView != null && bannerViewLayout != null) {
+            if (mActivity != null && bannerView != null && bannerViewLayout != null) {
                 if (lock) {
                     bannerViewLayout!!.addView(bannerView)
                     bannerViewLayout!!.bringToFront()
@@ -1313,7 +1330,7 @@ class emiAdmobPlugin : CordovaPlugin() {
 
     private val isShowBannerAds: Unit
         get() {
-            if (isBannerLoad && bannerView != null) {
+            if (mActivity != null && isBannerLoad && bannerView != null) {
                 try {
                     if (lock) {
                         bannerViewLayout!!.addView(bannerView)
@@ -1348,16 +1365,18 @@ class emiAdmobPlugin : CordovaPlugin() {
                 put("cause", adError.cause?.toString() ?: "null")
             }
 
-                    if (bannerViewLayout != null && bannerView != null) {
-                        bannerViewLayout!!.removeView(bannerView)
-                        bannerView!!.destroy()
-                        bannerView = null
-                        bannerViewLayout = null
-                        isBannerLoad = false
-                        isBannerShow = false
-                        isBannerPause = 2
-                        lock = true
-                    }
+            bannerOverlappingToZero()
+
+            if (bannerViewLayout != null && bannerView != null) {
+                bannerViewLayout!!.removeView(bannerView)
+                bannerView!!.destroy()
+                bannerView = null
+                bannerViewLayout = null
+                isBannerLoad = false
+                isBannerShow = false
+                isBannerPause = 2
+                lock = true
+            }
 
 
             cWebView!!.loadUrl("javascript:cordova.fireDocumentEvent('on.banner.failed.load', ${errorData});")
@@ -1424,32 +1443,70 @@ class emiAdmobPlugin : CordovaPlugin() {
     }
 
 
-    // fix https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/issues/26
-    private fun bannerOverlapping() {
+
+    private fun bannerOverlappingToZero() {
         if (bannerView != null && mActivity != null && cWebView != null) {
             mActivity!!.runOnUiThread {
                 try {
-                    val bannerHeightInPx = bannerView!!.height
-                    val displayMetrics = DisplayMetrics()
-                    mActivity!!.windowManager.defaultDisplay.getMetrics(displayMetrics)
-                    val screenHeightInPx = displayMetrics.heightPixels
-
-                    // Adjust the WebView height to account for the banner ad
-                    val webViewHeight = screenHeightInPx - (adSize.height+overlappingHeight)
-                    val layoutParams = cWebView!!.view.layoutParams
-                    layoutParams.height = webViewHeight
-                    cWebView!!.view.layoutParams = layoutParams
-
-                    // Log for debugging
-                    Log.d("BannerAdjustment", "Adjusted WebView height: $webViewHeight")
+                    val rootView = (cWebView!!.view.parent as View)
+                    rootView.post {
+                        // Get the total height of the parent view
+                        val totalHeight = rootView.height
+
+                        // Adjust WebView height to match parent height
+                        val layoutParams = cWebView!!.view.layoutParams
+                        layoutParams.height = totalHeight
+                        cWebView!!.view.layoutParams = layoutParams
+
+                        // Ensure no padding/margin in WebView or its parent
+                        cWebView!!.view.setPadding(0, 0, 0, 0)
+                        (cWebView!!.view.parent as? ViewGroup)?.setPadding(0, 0, 0, 0)
+
+                        // Force layout update
+                        cWebView!!.view.requestLayout()
+
+                        Log.d("BannerAdjustment", "WebView set to full height: $totalHeight")
+                    }
                 } catch (e: Exception) {
-                    Log.e("AdmobPlugin", "Error adjusting WebView for banner: ${e.message}")
+                    Log.e("AdmobPlugin", "Error setting WebView to full height: ${e.message}")
                 }
             }
         }
     }
 
 
+
+
+
+        // fix https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/issues/26
+        private fun bannerOverlapping() {
+            if (bannerView != null && mActivity != null && cWebView != null) {
+                mActivity!!.runOnUiThread {
+                    try {
+                        val bannerHeightInPx = bannerView!!.height
+                        val displayMetrics = DisplayMetrics()
+                        mActivity!!.windowManager.defaultDisplay.getMetrics(displayMetrics)
+                        val screenHeightInPx = displayMetrics.heightPixels
+
+                        // Adjust the WebView height to account for the banner ad
+                        val webViewHeight = screenHeightInPx - (adSize.height + overlappingHeight)
+                        val layoutParams = cWebView!!.view.layoutParams
+                        layoutParams.height = webViewHeight
+                        cWebView!!.view.layoutParams = layoutParams
+
+                        // Log for debugging
+                        Log.d("BannerAdjustment", "Adjusted WebView height: $webViewHeight")
+                    } catch (e: Exception) {
+                        Log.e("AdmobPlugin", "Error adjusting WebView for banner: ${e.message}")
+                    }
+                }
+            }
+        }
+
+
+
+
+
     private val bannerPaidAdListener = OnPaidEventListener { adValue ->
         val valueMicros = adValue.valueMicros
         val currencyCode = adValue.currencyCode
@@ -2024,8 +2081,8 @@ class emiAdmobPlugin : CordovaPlugin() {
                 return cWebView as View?
             }
 
-           return mActivity!!.window.decorView.findViewById(View.generateViewId())
-          //  return mActivity!!.window.decorView.findViewById(R.id.content)
+            return mActivity!!.window.decorView.findViewById(View.generateViewId())
+            //  return mActivity!!.window.decorView.findViewById(R.id.content)
         }
 
     override fun onPause(multitasking: Boolean) {