emdash 0.7.0 → 0.8.0

package/src/database/repositories/redirect.ts

@@ -182,14 +182,12 @@ export class RedirectRepository {
 
 		if (opts.cursor) {
 			const decoded = decodeCursor(opts.cursor);
-			if (decoded) {
-				query = query.where((eb) =>
-					eb.or([
-						eb("created_at", "<", decoded.orderValue),
-						eb.and([eb("created_at", "=", decoded.orderValue), eb("id", "<", decoded.id)]),
-					]),
-				);
-			}
+			query = query.where((eb) =>
+				eb.or([
+					eb("created_at", "<", decoded.orderValue),
+					eb.and([eb("created_at", "=", decoded.orderValue), eb("id", "<", decoded.id)]),
+				]),
+			);
 		}
 
 		const rows = await query.execute();
@@ -509,14 +507,12 @@ export class RedirectRepository {
 
 		if (opts.cursor) {
 			const decoded = decodeCursor(opts.cursor);
-			if (decoded) {
-				query = query.where((eb) =>
-					eb.or([
-						eb("created_at", "<", decoded.orderValue),
-						eb.and([eb("created_at", "=", decoded.orderValue), eb("id", "<", decoded.id)]),
-					]),
-				);
-			}
+			query = query.where((eb) =>
+				eb.or([
+					eb("created_at", "<", decoded.orderValue),
+					eb.and([eb("created_at", "=", decoded.orderValue), eb("id", "<", decoded.id)]),
+				]),
+			);
 		}
 
 		const rows = await query.execute();

package/src/database/repositories/taxonomy.ts

@@ -41,12 +41,15 @@ export class TaxonomyRepository {
 	async create(input: CreateTaxonomyInput): Promise<Taxonomy> {
 		const id = ulid();
 
+		// Empty-string parentId is coerced to null defensively. Higher layers
+		// also normalize this — see handleTermCreate / handleTermUpdate.
+		const parentId = input.parentId === undefined || input.parentId === "" ? null : input.parentId;
 		const row: TaxonomyTable = {
 			id,
 			name: input.name,
 			slug: input.slug,
 			label: input.label,
-			parent_id: input.parentId ?? null,
+			parent_id: parentId,
 			data: input.data ? JSON.stringify(input.data) : null,
 		};
 
@@ -90,11 +93,15 @@ export class TaxonomyRepository {
 	 * Get all terms for a taxonomy (e.g., all categories)
 	 */
 	async findByName(name: string, options: { parentId?: string | null } = {}): Promise<Taxonomy[]> {
+		// `id asc` is a stable tiebreaker for terms that share a label.
+		// Without it the SQL ordering is implementation-defined when labels
+		// match, which breaks keyset pagination over `(label, id)`.
 		let query = this.db
 			.selectFrom("taxonomies")
 			.selectAll()
 			.where("name", "=", name)
-			.orderBy("label", "asc");
+			.orderBy("label", "asc")
+			.orderBy("id", "asc");
 
 		if (options.parentId !== undefined) {
 			if (options.parentId === null) {
@@ -117,6 +124,7 @@ export class TaxonomyRepository {
 			.selectAll()
 			.where("parent_id", "=", parentId)
 			.orderBy("label", "asc")
+			.orderBy("id", "asc")
 			.execute();
 
 		return rows.map((row) => this.rowToTaxonomy(row));
@@ -132,7 +140,10 @@ export class TaxonomyRepository {
 		const updates: Partial<TaxonomyTable> = {};
 		if (input.slug !== undefined) updates.slug = input.slug;
 		if (input.label !== undefined) updates.label = input.label;
-		if (input.parentId !== undefined) updates.parent_id = input.parentId;
+		if (input.parentId !== undefined) {
+			// Defense in depth: empty-string parentId means null (no parent).
+			updates.parent_id = input.parentId === "" ? null : input.parentId;
+		}
 		if (input.data !== undefined) updates.data = JSON.stringify(input.data);
 
 		if (Object.keys(updates).length > 0) {

package/src/database/repositories/types.ts

@@ -1,5 +1,15 @@
 import { encodeBase64, decodeBase64 } from "../../utils/base64.js";
 
+/**
+ * Hard cap on cursor length. Cursors we issue are short JSON-in-base64
+ * blobs; a real cursor is well under 200 chars. This guards against
+ * malicious callers passing megabyte-sized strings to force the base64
+ * decoder to allocate (decodeBase64 is O(N) in input size). The MCP and
+ * REST schemas also clamp at 2048 — this 4096 cap is a defense-in-depth
+ * floor inside the repository helpers.
+ */
+const MAX_CURSOR_LENGTH = 4096;
+
 export interface CreateContentInput {
 	type: string;
 	slug?: string | null;
@@ -87,17 +97,45 @@ export function encodeCursor(orderValue: string, id: string): string {
 	return encodeBase64(JSON.stringify({ orderValue, id }));
 }
 
-/** Decode a cursor to order value + id. Returns null if invalid. */
-export function decodeCursor(cursor: string): { orderValue: string; id: string } | null {
+/**
+ * Thrown when a pagination cursor cannot be decoded.
+ *
+ * Repository callers should let this propagate; handler catch blocks
+ * map it to a structured `INVALID_CURSOR` error so client pagination
+ * bugs surface immediately rather than silently re-fetching the first
+ * page.
+ */
+export class InvalidCursorError extends Error {
+	constructor(cursor: string) {
+		const display = cursor.length > 50 ? `${cursor.slice(0, 47)}...` : cursor;
+		super(`Invalid pagination cursor: ${display}`);
+		this.name = "InvalidCursorError";
+	}
+}
+
+/**
+ * Decode a cursor to order value + id.
+ *
+ * Throws `InvalidCursorError` if the cursor is empty, not valid base64,
+ * not valid JSON, or doesn't contain string `orderValue` and `id` fields.
+ */
+export function decodeCursor(cursor: string): { orderValue: string; id: string } {
+	if (!cursor) throw new InvalidCursorError(cursor);
+	if (cursor.length > MAX_CURSOR_LENGTH) throw new InvalidCursorError(cursor);
+	let parsed: unknown;
 	try {
-		const parsed = JSON.parse(decodeBase64(cursor));
-		if (typeof parsed.orderValue === "string" && typeof parsed.id === "string") {
-			return parsed;
-		}
-		return null;
+		parsed = JSON.parse(decodeBase64(cursor));
 	} catch {
-		return null;
+		throw new InvalidCursorError(cursor);
+	}
+	if (parsed === null || typeof parsed !== "object") {
+		throw new InvalidCursorError(cursor);
+	}
+	const candidate = parsed as { orderValue?: unknown; id?: unknown };
+	if (typeof candidate.orderValue !== "string" || typeof candidate.id !== "string") {
+		throw new InvalidCursorError(cursor);
 	}
+	return { orderValue: candidate.orderValue, id: candidate.id };
 }
 
 export interface ContentItem {
@@ -121,6 +159,17 @@ export interface ContentItem {
 	translationGroup: string | null;
 	/** SEO metadata — only populated for collections with `has_seo` enabled */
 	seo?: ContentSeo;
+	/**
+	 * For collections that support `revisions`: when a draft revision exists,
+	 * `data` reflects the unsaved draft and `liveData` carries the currently-
+	 * published values. When no draft exists, `liveData` is undefined.
+	 *
+	 * Hydrated by `EmDashRuntime.hydrateDraftData()` — repositories themselves
+	 * never set this field; it's purely a runtime-overlay concept that gives
+	 * agents a clear picture of "draft vs. live" without re-fetching the
+	 * revision history.
+	 */
+	liveData?: Record<string, unknown>;
 }
 
 export class EmDashValidationError extends Error {

package/src/database/repositories/user.ts

@@ -123,14 +123,12 @@ export class UserRepository {
 
 		if (options.cursor) {
 			const decoded = decodeCursor(options.cursor);
-			if (decoded) {
-				query = query.where((eb) =>
-					eb.or([
-						eb("created_at", "<", decoded.orderValue),
-						eb.and([eb("created_at", "=", decoded.orderValue), eb("id", "<", decoded.id)]),
-					]),
-				);
-			}
+			query = query.where((eb) =>
+				eb.or([
+					eb("created_at", "<", decoded.orderValue),
+					eb.and([eb("created_at", "=", decoded.orderValue), eb("id", "<", decoded.id)]),
+				]),
+			);
 		}
 
 		const rows = await query.execute();