ember.nvp 1.9.0 → 1.10.0

package/src/layers/eslint-bundled-nvp/app.test.ts

@@ -1,91 +0,0 @@
-import { beforeAll, describe, it, expect as hardExpect, afterAll } from "vitest";
-import { expectIsSetup, generate, layers, reapply } from "#test-helpers";
-
-import type { Project } from "ember.nvp";
-import { rm } from "node:fs/promises";
-
-const expect = hardExpect.soft;
-
-let layer = layers.find((layer) => layer.name === "eslint-bundled-nvp")!;
-
-describe("starting without eslint-bundled-nvp", () => {
-  let project: Project;
-
-  beforeAll(async () => {
-    project = await generate({
-      type: "app",
-      packageManager: "pnpm",
-      layers: ["git"],
-    });
-  });
-
-  afterAll(async () => {
-    await rm(project.directory, { recursive: true, force: true });
-  });
-
-  it("applying eslint-bundled-nvp", async () => {
-    await reapply(project, ["eslint-bundled-nvp"]);
-
-    await expectIsSetup(project, layer);
-    expect(await project.gitHasDiff()).toBe(false);
-  });
-});
-
-describe("starting with eslint-bundled-nvp", () => {
-  let project: Project;
-
-  beforeAll(async () => {
-    project = await generate({
-      type: "app",
-      packageManager: "pnpm",
-      layers: ["eslint-bundled-nvp", "git"],
-    });
-  });
-
-  afterAll(async () => {
-    await rm(project.directory, { recursive: true, force: true });
-  });
-
-  it("reapplying eslint-bundled-nvp causes no changes", async () => {
-    await reapply(project, ["eslint-bundled-nvp"]);
-
-    await expectIsSetup(project, layer);
-    expect(await project.gitHasDiff()).toBe(false);
-  });
-});
-
-describe("package.json scripts", () => {
-  let project: Project;
-
-  beforeAll(async () => {
-    project = await generate({
-      type: "app",
-      packageManager: "pnpm",
-      layers: ["eslint-bundled-nvp", "git"],
-    });
-
-    let { exitCode } = await project.run("pnpm install");
-
-    hardExpect(exitCode).toBe(0);
-
-    await expectIsSetup(project, layer);
-  });
-
-  afterAll(async () => {
-    await rm(project.directory, { recursive: true, force: true });
-  });
-
-  it("linting and fixing works", async () => {
-    {
-      let { exitCode } = await project.run("pnpm lint:eslint --fix");
-
-      expect(exitCode).toBe(0);
-    }
-
-    {
-      let { exitCode } = await project.run("pnpm lint:eslint");
-
-      expect(exitCode).toBe(0);
-    }
-  });
-});

package/src/layers/eslint-bundled-nvp/index.js

@@ -1,91 +0,0 @@
-import { getLatest } from "#utils/npm.js";
-import { files, packageJson } from "ember-apply";
-import { formatLabel } from "#utils/cli.js";
-import { maybeLintWithConcurrently } from "#consolidators/linting.js";
-import { existsSync } from "node:fs";
-import { join } from "node:path";
-import { hasDevDeps } from "#utils/manifest.js";
-
-/**
- * @type {import('#types').Layer}
- */
-export default {
-  label: formatLabel("ESLint", "NullVoxPopuli's encapsulated config"),
-  hint: `Minimal dependencies added to package.json`,
-
-  async run(project) {
-    await files.applyFolder(join(import.meta.dirname, "files"), project.directory);
-
-    await packageJson.addDevDependencies(
-      await getLatest({
-        "@nullvoxpopuli/eslint-configs": "^7.0.0",
-        eslint: "^10.9.1",
-      }),
-      project.directory,
-    );
-
-    await packageJson.addScripts(
-      {
-        "lint:eslint": "eslint . --cache",
-        "lint:eslint:fix": "eslint . --fix",
-      },
-      project.directory,
-    );
-
-    await maybeLintWithConcurrently(project);
-  },
-
-  /**
-   * @overload
-   * @param {import('#utils/project.js').Project} project
-   * @param {true} explain
-   * @returns {Promise<{ isSetup: boolean; reasons: string[] }>}
-   */
-  /**
-   * @overload
-   * @param {import('#utils/project.js').Project} project
-   * @param {boolean | undefined} [explain]
-   * @returns {Promise<boolean>}
-   */
-  async isSetup(project, explain) {
-    const reasons = [];
-
-    if (!existsSync(join(project.directory, "eslint.config.js"))) {
-      reasons.push("eslint.config.js is missing");
-
-      if (!explain) return false;
-    }
-
-    let manifest = await packageJson.read(project.directory);
-
-    if (!hasDevDeps(manifest, ["@nullvoxpopuli/eslint-configs", "eslint"])) {
-      reasons.push("missing required dependencies: @nullvoxpopuli/eslint-configs, eslint");
-
-      if (!explain) return false;
-    }
-
-    let scripts = Object.values(manifest.scripts ?? {}).filter((script) =>
-      script.includes("eslint"),
-    );
-
-    if (!scripts.some((script) => script.includes("--cache"))) {
-      reasons.push("missing eslint script with --cache flag");
-
-      if (!explain) return false;
-    }
-    if (!scripts.some((script) => script.includes("--fix"))) {
-      reasons.push("missing eslint script with --fix flag");
-
-      if (!explain) return false;
-    }
-
-    if (explain) {
-      return {
-        isSetup: reasons.length === 0,
-        reasons,
-      };
-    }
-
-    return reasons.length === 0;
-  },
-};