ember.nvp 1.13.0 → 1.14.0

package/.release-plan.json

@@ -2,8 +2,8 @@
   "solution": {
     "ember.nvp": {
       "impact": "minor",
-      "oldVersion": "1.12.0",
-      "newVersion": "1.13.0",
+      "oldVersion": "1.13.0",
+      "newVersion": "1.14.0",
       "tagName": "latest",
       "constraints": [
         {
@@ -23,5 +23,5 @@
       "oldVersion": "1.2.0"
     }
   },
-  "description": "## Release (2026-09-30)\n\n* ember.nvp 1.13.0 (minor)\n\n#### :rocket: Enhancement\n* `ember.nvp`\n  * [#154](https://github.com/NullVoxPopuli/ember.nvp/pull/154) Default the project type to the detected type on update ([@NullVoxPopuli-ai-agent](https://github.com/NullVoxPopuli-ai-agent))\n\n#### Committers: 1\n- @NullVoxPopuli's reduced-access machine account for AI usage ([@NullVoxPopuli-ai-agent](https://github.com/NullVoxPopuli-ai-agent))\n"
+  "description": "## Release (2026-09-30)\n\n* ember.nvp 1.14.0 (minor)\n\n#### :rocket: Enhancement\n* `ember.nvp`\n  * [#156](https://github.com/NullVoxPopuli/ember.nvp/pull/156) Give TypeScript libraries with tests a publish tsconfig ([@NullVoxPopuli-ai-agent](https://github.com/NullVoxPopuli-ai-agent))\n\n#### Committers: 1\n- @NullVoxPopuli's reduced-access machine account for AI usage ([@NullVoxPopuli-ai-agent](https://github.com/NullVoxPopuli-ai-agent))\n"
 }

package/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 ## Release (2026-09-30)
 
+* ember.nvp 1.14.0 (minor)
+
+#### :rocket: Enhancement
+* `ember.nvp`
+  * [#156](https://github.com/NullVoxPopuli/ember.nvp/pull/156) Give TypeScript libraries with tests a publish tsconfig ([@NullVoxPopuli-ai-agent](https://github.com/NullVoxPopuli-ai-agent))
+
+#### Committers: 1
+- @NullVoxPopuli's reduced-access machine account for AI usage ([@NullVoxPopuli-ai-agent](https://github.com/NullVoxPopuli-ai-agent))
+
+## Release (2026-09-30)
+
 * ember.nvp 1.13.0 (minor)
 
 #### :rocket: Enhancement

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember.nvp",
-  "version": "1.13.0",
+  "version": "1.14.0",
   "description": "ember project generator, alternative to the official blueprints, but more modern -- hopefully one day to upstream back in to ember-cli / official blueprints",
   "repository": {
     "type": "git",

package/src/layers/qunit/index.js

@@ -1,7 +1,8 @@
 import { applyFolderTo } from "#utils/fs.js";
 import { getLatest } from "#utils/npm.js";
 import { hasConfiguredPlugin, prependPlugin, removeConfiguredPlugin } from "#utils/babel.js";
-import { packageJson } from "ember-apply";
+import { addTsdownConfigProperty } from "#utils/tsdown-config.js";
+import { packageJson, tsconfig } from "ember-apply";
 import { join } from "node:path";
 
 const deps = {
@@ -39,6 +40,7 @@ const libraryTsDeps = {
 };
 
 const TEST_BABEL_CONFIG = "config/test/babel.config.js";
+const PUBLISH_TSCONFIG = "config/tsconfig.publish.json";
 
 /**
  * @param {import('#utils/project.js').Project} project
@@ -72,6 +74,10 @@ export default {
 
     if (isLibrary) {
       await syncTestBabelConfig(project, ts);
+
+      if (ts) {
+        await usePublishTsconfig(project);
+      }
     }
 
     await packageJson.addDevDependencies(
@@ -141,6 +147,12 @@ export default {
       }
     }
 
+    if (project.isLibrary && project.wantsTypeScript && !project.hasFile(PUBLISH_TSCONFIG)) {
+      if (!explain) return false;
+
+      reasons.push(`${PUBLISH_TSCONFIG} is missing`);
+    }
+
     if (explain) {
       return {
         isSetup: reasons.length === 0,
@@ -203,3 +215,45 @@ async function syncTestBabelConfig(project, ts) {
     TEST_BABEL_CONFIG,
   );
 }
+
+/**
+ * A library's tsconfig.json starts as its publish config:
+ * it covers only `src`, with `isolatedDeclarations` for the declarations tsdown emits.
+ *
+ * Tests live outside `src`, and editors, `lint:types`, and eslint read tsconfig.json.
+ * So in a TypeScript library, this layer:
+ * - widens tsconfig.json to `src` and `tests`, without the publish-only settings
+ * - moves those settings to `config/tsconfig.publish.json`, which the build uses
+ *
+ * @param {import('#utils/project.js').Project} project
+ */
+async function usePublishTsconfig(project) {
+  await applyFolderTo(join(import.meta.dirname, "library-ts-files"), project);
+  await addTsdownConfigProperty(project, "tsconfig", `tsconfig: "./${PUBLISH_TSCONFIG}"`);
+
+  let config = await tsconfig.read(project.directory);
+
+  if (!needsWidening(config)) return;
+
+  await tsconfig.modify((json) => {
+    json.include ||= [];
+
+    if (!json.include.includes("tests")) {
+      json.include.push("tests");
+    }
+
+    delete json.compilerOptions?.rootDir;
+    delete json.compilerOptions?.isolatedDeclarations;
+  }, project.directory);
+}
+
+/**
+ * @param {Record<string, any>} config
+ */
+function needsWidening(config) {
+  return (
+    !config.include?.includes("tests") ||
+    config.compilerOptions?.rootDir !== undefined ||
+    config.compilerOptions?.isolatedDeclarations !== undefined
+  );
+}

package/src/layers/qunit/library-ts-files/config/tsconfig.publish.json

@@ -0,0 +1,8 @@
+{
+  "extends": "../tsconfig.json",
+  "include": ["../src"],
+  "compilerOptions": {
+    "rootDir": "../src",
+    "isolatedDeclarations": true
+  }
+}

package/test/ember.nvp/layer-qunit.test.ts

@@ -161,6 +161,7 @@ describe("layer: qunit", () => {
           "README.md",
           "config/test/babel.config.js",
           "config/test/testem.cjs",
+          "config/tsconfig.publish.json",
           "package.json",
           "src/index.ts",
           "tests/rendering/.gitkeep",
@@ -258,15 +259,38 @@ describe("layer: qunit", () => {
       `);
     });
 
-    it("leaves the publish build config alone", async () => {
+    it("builds with a publish tsconfig, so tsconfig.json can cover the tests", async () => {
       expect(await project.read("tsdown.config.js")).toMatchInlineSnapshot(`
         "import { defineConfig } from "tsdown";
         import { ember } from "@nullvoxpopuli/ember-rolldown";
-
-        export default defineConfig({
-          entry: ["./src/index.ts"],
-          plugins: [ember()],
-        });
+        export default defineConfig({ entry: ["./src/index.ts"], plugins: [ember()], tsconfig: "./config/tsconfig.publish.json" })"
+      `);
+      expect(await project.read("config/tsconfig.publish.json")).toMatchInlineSnapshot(`
+        "{
+          "extends": "../tsconfig.json",
+          "include": ["../src"],
+          "compilerOptions": {
+            "rootDir": "../src",
+            "isolatedDeclarations": true
+          }
+        }
+        "
+      `);
+      expect(await project.read("tsconfig.json")).toMatchInlineSnapshot(`
+        "{
+          "extends": "@ember/library-tsconfig",
+          "include": ["src", "tests"],
+          "compilerOptions": {
+            "lib": ["esnext", "dom", "dom.iterable"],
+            "types": ["ember-source/types", "@glint/ember-tsc/types"],
+          },
+          "contentMappers": [
+            {
+              "package": "ember-content-mapper",
+              "extensions": [".gts", ".gjs"],
+            },
+          ],
+        }
         "
       `);
     });
@@ -292,6 +316,29 @@ describe("layer: qunit", () => {
     });
   });
 
+  describe("library (TypeScript) with eslint", () => {
+    it("lints the tests", { timeout: 300_000 }, async () => {
+      const project = await generate({
+        type: "library",
+        name: "my-lib",
+        layers: ["eslint-bundled", "qunit", "typescript"],
+      });
+      dirs.push(project.directory);
+
+      let install = await execa("pnpm install", { cwd: project.directory, shell: true });
+      expect(install.exitCode).toBe(0);
+
+      // eslint's project service cannot parse a file that no tsconfig includes
+      let lint = await execa("pnpm lint:eslint", {
+        cwd: project.directory,
+        shell: true,
+        reject: false,
+        all: true,
+      });
+      expect(lint.exitCode, lint.all).toBe(0);
+    });
+  });
+
   describe("library (JavaScript)", () => {
     let project: Project;