ember.nvp 0.2.0 → 0.2.1

package/.github/workflows/publish.yml

@@ -27,13 +27,12 @@ jobs:
 
     steps:
       - uses: actions/checkout@v6
-      - uses: pnpm/action-setup@v4
+      - uses: pnpm/action-setup@v5
       - uses: actions/setup-node@v6
         with:
-          node-version: 22
+          node-version: 24
           registry-url: "https://registry.npmjs.org"
           cache: pnpm
-      - run: npm install -g npm@latest # ensure that the globally installed npm is new enough to support OIDC
       - run: pnpm install --frozen-lockfile
       - name: Publish to NPM
         run: NPM_CONFIG_PROVENANCE=true pnpm release-plan publish

package/.release-plan.json

@@ -1,23 +1,15 @@
 {
   "solution": {
     "ember.nvp": {
-      "impact": "minor",
-      "oldVersion": "0.1.0",
-      "newVersion": "0.2.0",
+      "impact": "patch",
+      "oldVersion": "0.2.0",
+      "newVersion": "0.2.1",
       "tagName": "latest",
       "constraints": [
-        {
-          "impact": "minor",
-          "reason": "Appears in changelog section :rocket: Enhancement"
-        },
         {
           "impact": "patch",
           "reason": "Appears in changelog section :bug: Bug Fix"
         },
-        {
-          "impact": "patch",
-          "reason": "Appears in changelog section :memo: Documentation"
-        },
         {
           "impact": "patch",
           "reason": "Appears in changelog section :house: Internal"
@@ -26,5 +18,5 @@
       "pkgJSONPath": "./package.json"
     }
   },
-  "description": "## Release (2026-01-28)\n\n* ember.nvp 0.2.0 (minor)\n\n#### :rocket: Enhancement\n* `ember.nvp`\n  * [#20](https://github.com/NullVoxPopuli/ember.nvp/pull/20) Implement idemponent and modern qunit layer ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#18](https://github.com/NullVoxPopuli/ember.nvp/pull/18) Ensure the TS utilities handle the babel plugin ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#17](https://github.com/NullVoxPopuli/ember.nvp/pull/17) Support emitting JavaScript projects ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#16](https://github.com/NullVoxPopuli/ember.nvp/pull/16) Commit changes automatically if git is in use ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#14](https://github.com/NullVoxPopuli/ember.nvp/pull/14) Add idempotent GitHub Actions ci.yml ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#11](https://github.com/NullVoxPopuli/ember.nvp/pull/11) Add idempotent renovate config generation ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#9](https://github.com/NullVoxPopuli/ember.nvp/pull/9)  Add eslint codemod/applyable, enable type checking internally on the JS ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#8](https://github.com/NullVoxPopuli/ember.nvp/pull/8) Add idempotent prettier codemod/applyable ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#6](https://github.com/NullVoxPopuli/ember.nvp/pull/6) Add git support with proper defaults (ie automatic --skip-git if you are already in a git repo) ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#4](https://github.com/NullVoxPopuli/ember.nvp/pull/4) Implementation: minimal-app ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n\n#### :bug: Bug Fix\n* `ember.nvp`\n  * [#22](https://github.com/NullVoxPopuli/ember.nvp/pull/22) Fix accidental stdoutput during git interactions ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#10](https://github.com/NullVoxPopuli/ember.nvp/pull/10) Various CLI fixes ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n\n#### :memo: Documentation\n* `ember.nvp`\n  * [#12](https://github.com/NullVoxPopuli/ember.nvp/pull/12) Clarify rationale and usage caveats in README ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n\n#### :house: Internal\n* `ember.nvp`\n  * [#19](https://github.com/NullVoxPopuli/ember.nvp/pull/19) Forgot to enable tests for GH Actions ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#21](https://github.com/NullVoxPopuli/ember.nvp/pull/21) Refactor hases and wantses ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#15](https://github.com/NullVoxPopuli/ember.nvp/pull/15) Add reapply test utility for more easily re-applying layers in the manual testing ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#13](https://github.com/NullVoxPopuli/ember.nvp/pull/13) Speed up permutations test ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#7](https://github.com/NullVoxPopuli/ember.nvp/pull/7) Implement idempotent testing for layers that may (or may not) have been applied during the initial generation of a project ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n\n#### Committers: 1\n- [@NullVoxPopuli](https://github.com/NullVoxPopuli)\n"
+  "description": "## Release (2026-05-15)\n\n* ember.nvp 0.2.1 (patch)\n\n#### :bug: Bug Fix\n* `ember.nvp`\n  * [#29](https://github.com/NullVoxPopuli/ember.nvp/pull/29) Fix production vite build broken by setTesting in app/config.ts ([@Copilot](https://github.com/apps/copilot-swe-agent))\n\n#### :house: Internal\n* `ember.nvp`\n  * [#31](https://github.com/NullVoxPopuli/ember.nvp/pull/31) Update release-plan ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n\n#### Committers: 2\n- Copilot [Bot] ([@copilot-swe-agent](https://github.com/apps/copilot-swe-agent))\n- [@NullVoxPopuli](https://github.com/NullVoxPopuli)\n"
 }

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## Release (2026-05-15)
+
+* ember.nvp 0.2.1 (patch)
+
+#### :bug: Bug Fix
+* `ember.nvp`
+  * [#29](https://github.com/NullVoxPopuli/ember.nvp/pull/29) Fix production vite build broken by setTesting in app/config.ts ([@Copilot](https://github.com/apps/copilot-swe-agent))
+
+#### :house: Internal
+* `ember.nvp`
+  * [#31](https://github.com/NullVoxPopuli/ember.nvp/pull/31) Update release-plan ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
+
+#### Committers: 2
+- Copilot [Bot] ([@copilot-swe-agent](https://github.com/apps/copilot-swe-agent))
+- [@NullVoxPopuli](https://github.com/NullVoxPopuli)
+
 ## Release (2026-01-28)
 
 * ember.nvp 0.2.0 (minor)

package/package.json

@@ -1,14 +1,12 @@
 {
   "name": "ember.nvp",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "ember project generator, alternative to the official blueprints, but more modern -- hopefully one day to upstream back in to ember-cli / official blueprints",
   "repository": {
     "type": "git",
     "url": "git@github.com:NullVoxPopuli/ember.nvp.git"
   },
   "type": "module",
-  "bin": "./src/cli/index.js",
-  "exports": "./src/index.js",
   "imports": {
     "#args": "./src/cli/args.js",
     "#bases/*": "./src/bases/*/index.js",
@@ -18,6 +16,8 @@
     "#utils/*": "./src/utils/*",
     "#test-helpers": "./test/test-helpers.ts"
   },
+  "exports": "./src/index.js",
+  "bin": "./src/cli/index.js",
   "dependencies": {
     "@clack/prompts": "^0.11.0",
     "babel-remove-types": "^1.1.0",
@@ -37,7 +37,7 @@
     "ember-source": "^6.10.0",
     "prettier": "^3.7.4",
     "prettier-plugin-ember-template-tag": "^2.1.2",
-    "release-plan": "^0.17.4",
+    "release-plan": "^0.18.0",
     "rimraf": "^6.1.2",
     "vite": "^7.3.1",
     "vitest": "^4.0.17"
@@ -46,11 +46,11 @@
     "node": ">= 24"
   },
   "scripts": {
+    "format": "prettier . --write",
     "lint": "concurrently \"pnpm:lint:*(!fix)\" --names \"lint:\" --prefixColors auto",
     "lint:fix": "pnpm format",
-    "lint:types": "tsc --noEmit",
-    "format": "prettier . --write",
     "lint:format": "prettier . --check",
+    "lint:types": "tsc --noEmit",
     "new": "./test/manual.sh",
     "test:node": "FORCE_COLOR=1 vitest run --reporter=verbose --printConsoleTrace",
     "test:vitest": "FORCE_COLOR=1 vitest"

package/src/bases/minimal-app/files/app/config.ts

@@ -15,16 +15,3 @@ const ENV: Config = {
 };
 
 export default ENV;
-
-// @ts-expect-error: Ignoreing private API
-import { getGlobalConfig } from "@embroider/macros/src/addon/runtime";
-
-export function enterTestMode() {
-  ENV.locationType = "none";
-  ENV.APP.rootElement = "#ember-testing";
-  ENV.APP.autoboot = false;
-
-  const theMacrosGlobal = getGlobalConfig();
-  theMacrosGlobal["@embroider/macros"] ||= {};
-  theMacrosGlobal["@embroider/macros"].isTesting ||= true;
-}

package/src/bases/minimal-app/files/babel.config.js

@@ -1,6 +1,12 @@
 import { buildMacros } from "@embroider/macros/babel";
 
-const macros = buildMacros();
+const macros = buildMacros({
+  configure(config) {
+    if (process.env.EMBER_ENV === "test") {
+      config.enableRuntimeMode();
+    }
+  },
+});
 
 export default {
   plugins: [

package/src/layers/qunit/files/tests/test-helper.ts

@@ -11,12 +11,13 @@ import { getPendingWaiterState } from "@ember/test-waiters";
 import * as QUnit from "qunit";
 import { setup } from "qunit-dom";
 import { setupEmberOnerrorValidation, start as qunitStart } from "ember-qunit";
+import { setTesting } from "@embroider/macros";
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-expect-error
 import { getGlobalConfig } from "@embroider/macros/src/addon/runtime";
 
 import Application from "#app/app";
-import config, { enterTestMode } from "#config";
+import config from "#config";
 
 Object.assign(window, {
   visit,
@@ -39,7 +40,10 @@ Object.assign(window, {
 });
 
 export function start() {
-  enterTestMode();
+  config.locationType = "none";
+  config.APP.rootElement = "#ember-testing";
+  config.APP.autoboot = false;
+  setTesting(true);
 
   const theMacrosGlobal = getGlobalConfig();
 

package/src/layers/qunit/files/tests/unit/macros-test.ts

@@ -0,0 +1,26 @@
+import { module, test } from "qunit";
+import { isTesting } from "@embroider/macros";
+import { assert as emberAssert } from "@ember/debug";
+
+module("@embroider/macros | runtime mode in tests", function () {
+  /**
+   * In compile-time mode `isTesting()` is inlined as `false` at build time,
+   * regardless of what the runtime global config says. Only when the test
+   * build runs the macros plugin in runtime mode (see babel.config.js +
+   * EMBER_ENV=test) does `isTesting()` reflect the value set by
+   * `setTesting(true)` in tests/test-helper.ts.
+   */
+  test("isTesting() is true", function (assert) {
+    assert.strictEqual(isTesting(), true);
+  });
+
+  /**
+   * `@ember/debug`'s `assert(description, condition)` is only active when
+   * DEBUG is true (i.e. non-production builds). Assertions are stripped
+   * from production bundles, so this also doubles as a sanity check that
+   * the test build keeps DEBUG enabled.
+   */
+  test("@ember/debug assert throws when the condition is false", function (assert) {
+    assert.throws(() => emberAssert("string", false));
+  });
+});

package/src/layers/qunit/index.js

@@ -38,7 +38,7 @@ export default {
     // Add scripts
     await packageJson.addScripts(
       {
-        "build:test": "vite build --mode development",
+        "build:test": "EMBER_ENV=test NODE_ENV=development vite build --mode development",
         "test:ci": "testem ci --port 0",
         test: "pnpm build:test && pnpm test:ci",
       },