ember-source 4.8.3 → 4.8.5

package/dist/header/license.js

@@ -5,5 +5,5 @@
  *            Portions Copyright 2008-2011 Apple Inc. All rights reserved.
  * @license   Licensed under MIT license
  *            See https://raw.github.com/emberjs/ember.js/master/LICENSE
- * @version   4.8.3
+ * @version   4.8.5
  */

package/dist/packages/@ember/array/index.js

@@ -1470,7 +1470,7 @@ let NativeArray = Mixin.create(MutableArray, Observable, {
 const ignore = ['length'];
 NativeArray.keys().forEach(methodName => {
   // SAFETY: It's safe to read unknown properties from an object
-  if (Array.prototype[methodName]) {
+  if (Reflect.has(Array.prototype, methodName)) {
     ignore.push(methodName);
   }
 });

package/dist/packages/@ember/object/mixin.js

@@ -1,5 +1,5 @@
 /**
-@module @ember/object/mixin
+@module @ember/object
 */
 import { INIT_FACTORY } from '@ember/-internals/container';
 import { meta as metaFor, peekMeta } from '@ember/-internals/meta';
@@ -7,8 +7,8 @@ import { guidFor, makeArray, observerListenerMetaFor, ROOT, wrap } from '@ember/
 import { assert } from '@ember/debug';
 import { DEBUG } from '@glimmer/env';
 import { _WeakSet } from '@glimmer/util';
-import { ComputedProperty, descriptorForDecorator, makeComputedDecorator, nativeDescDecorator, setUnprocessedMixins, addObserver, removeObserver, revalidateObservers, defineDecorator, defineValue } from '@ember/-internals/metal';
-import { addListener, removeListener } from '@ember/object/events';
+import { ComputedProperty, addObserver, defineDecorator, defineValue, descriptorForDecorator, isClassicDecorator, makeComputedDecorator, nativeDescDecorator, removeObserver, revalidateObservers, setUnprocessedMixins } from '@ember/-internals/metal';
+import { addListener, removeListener } from './events';
 const a_concat = Array.prototype.concat;
 const {
   isArray
@@ -18,6 +18,7 @@ function extractAccessors(properties) {
   if (properties !== undefined) {
     for (let key of Object.keys(properties)) {
       let desc = Object.getOwnPropertyDescriptor(properties, key);
+      assert(`a property descriptor for ${key} must exist`, desc !== undefined);
 
       if (desc.get !== undefined || desc.set !== undefined) {
         Object.defineProperty(properties, key, {
@@ -222,12 +223,17 @@ function mergeProps(meta, props, descs, values, base, keys, keysWithSuper) {
       let desc = meta.peekDescriptors(key);
 
       if (desc === undefined) {
-        // The superclass did not have a CP, which means it may have
-        // observers or listeners on that property.
-        let prev = values[key] = base[key];
-
-        if (typeof prev === 'function') {
-          updateObserversAndListeners(base, key, prev, false);
+        // If the value is a classic decorator, we don't want to actually
+        // access it, because that will execute the decorator while we're
+        // building the class.
+        if (!isClassicDecorator(value)) {
+          // The superclass did not have a CP, which means it may have
+          // observers or listeners on that property.
+          let prev = values[key] = base[key];
+
+          if (typeof prev === 'function') {
+            updateObserversAndListeners(base, key, prev, false);
+          }
         }
       } else {
         descs[key] = desc; // The super desc will be overwritten on descs, so save off the fact that
@@ -646,9 +652,7 @@ function _keys(mixin, ret = new Set(), seen = new Set()) {
   seen.add(mixin);
 
   if (mixin.properties) {
-    let props = Object.keys(mixin.properties);
-
-    for (let prop of props) {
+    for (const prop of Object.keys(mixin.properties)) {
       ret.add(prop);
     }
   } else if (mixin.mixins) {
@@ -656,4 +660,6 @@ function _keys(mixin, ret = new Set(), seen = new Set()) {
   }
 
   return ret;
-}
+}
+
+export { Mixin };

package/dist/packages/ember/version.js

@@ -1 +1 @@
-export default "4.8.3";
+export default "4.8.5";

package/docs/data.json

@@ -3,7 +3,7 @@
     "name": "The Ember API",
     "description": "The Ember API: a framework for building ambitious web applications",
     "url": "https://emberjs.com/",
-    "version": "4.8.3"
+    "version": "4.8.5"
   },
   "files": {
     "node_modules/rsvp/lib/rsvp/promise/all.js": {
@@ -1292,9 +1292,7 @@
     },
     "packages/@ember/object/mixin.ts": {
       "name": "packages/@ember/object/mixin.ts",
-      "modules": {
-        "@ember/object/mixin": 1
-      },
+      "modules": {},
       "classes": {
         "Mixin": 1
       },
@@ -1936,7 +1934,9 @@
         "@ember/object/observers": 1,
         "@ember/object/internals": 1,
         "@ember/object/compat": 1,
-        "EmberObject": 1
+        "EmberObject": 1,
+        "Mixin": 1,
+        "@ember/object/mixin": 1
       },
       "fors": {
         "@ember/object": 1,
@@ -1947,12 +1947,13 @@
         "@ember/object/observers": 1,
         "Ember": 1,
         "@ember/object/internals": 1,
-        "@ember/object/compat": 1
+        "@ember/object/compat": 1,
+        "@ember/object/mixin": 1
       },
       "namespaces": {},
       "tag": "module",
-      "file": "packages/@ember/object/index.ts",
-      "line": 30
+      "file": "packages/@ember/object/mixin.ts",
+      "line": 446
     },
     "@ember/application": {
       "name": "@ember/application",
@@ -2258,22 +2259,6 @@
       "file": "packages/@ember/object/evented.ts",
       "line": 10
     },
-    "@ember/object/mixin": {
-      "name": "@ember/object/mixin",
-      "submodules": {},
-      "elements": {},
-      "classes": {
-        "Mixin": 1,
-        "@ember/object/mixin": 1
-      },
-      "fors": {
-        "@ember/object/mixin": 1
-      },
-      "namespaces": {},
-      "tag": "module",
-      "file": "packages/@ember/object/mixin.ts",
-      "line": 439
-    },
     "@ember/object/observable": {
       "name": "@ember/object/observable",
       "submodules": {},
@@ -3660,10 +3645,10 @@
       "extensions": [],
       "plugin_for": [],
       "extension_for": [],
-      "module": "@ember/object/mixin",
+      "module": "@ember/object",
       "namespace": "",
       "file": "packages/@ember/object/mixin.ts",
-      "line": 439,
+      "line": 446,
       "description": "The `Mixin` class allows you to create mixins, whose properties can be\nadded to other classes. For instance,\n\n```javascript\nimport Mixin from '@ember/object/mixin';\n\nconst EditableMixin = Mixin.create({\n  edit() {\n    console.log('starting to edit');\n    this.set('isEditing', true);\n  },\n  isEditing: false\n});\n```\n\n```javascript\nimport EmberObject from '@ember/object';\nimport EditableMixin from '../mixins/editable';\n\n// Mix mixins into classes by passing them as the first arguments to\n// `.extend.`\nconst Comment = EmberObject.extend(EditableMixin, {\n  post: null\n});\n\nlet comment = Comment.create({\n  post: somePost\n});\n\ncomment.edit(); // outputs 'starting to edit'\n```\n\nNote that Mixins are created with `Mixin.create`, not\n`Mixin.extend`.\n\nNote that mixins extend a constructor's prototype so arrays and object literals\ndefined as properties will be shared amongst objects that implement the mixin.\nIf you want to define a property in a mixin that is not shared, you can define\nit either as a computed property or have it be created on initialization of the object.\n\n```javascript\n// filters array will be shared amongst any object implementing mixin\nimport Mixin from '@ember/object/mixin';\nimport { A } from '@ember/array';\n\nconst FilterableMixin = Mixin.create({\n  filters: A()\n});\n```\n\n```javascript\nimport Mixin from '@ember/object/mixin';\nimport { A } from '@ember/array';\nimport { computed } from '@ember/object';\n\n// filters will be a separate array for every object implementing the mixin\nconst FilterableMixin = Mixin.create({\n  filters: computed(function() {\n    return A();\n  })\n});\n```\n\n```javascript\nimport Mixin from '@ember/object/mixin';\nimport { A } from '@ember/array';\n\n// filters will be created as a separate array during the object's initialization\nconst Filterable = Mixin.create({\n  filters: null,\n\n  init() {\n    this._super(...arguments);\n    this.set(\"filters\", A());\n  }\n});\n```",
       "access": "public",
       "tagname": ""
@@ -3676,7 +3661,7 @@
       "extensions": [],
       "plugin_for": [],
       "extension_for": [],
-      "module": "@ember/object/mixin",
+      "module": "@ember/object",
       "namespace": ""
     },
     "Observable": {
@@ -13649,7 +13634,7 @@
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 425,
+      "line": 432,
       "itemtype": "method",
       "name": "mixin",
       "params": [
@@ -13669,47 +13654,47 @@
       "access": "private",
       "tagname": "",
       "class": "Mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 522,
+      "line": 529,
       "class": "Mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 525,
+      "line": 532,
       "class": "Mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 528,
+      "line": 535,
       "class": "Mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 531,
+      "line": 538,
       "class": "Mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 534,
+      "line": 541,
       "class": "Mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 539,
+      "line": 544,
       "class": "Mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 565,
+      "line": 570,
       "itemtype": "method",
       "name": "create",
       "static": 1,
@@ -13723,17 +13708,17 @@
       "access": "public",
       "tagname": "",
       "class": "@ember/object/mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 580,
+      "line": 585,
       "class": "@ember/object/mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 598,
+      "line": 603,
       "itemtype": "method",
       "name": "reopen",
       "params": [
@@ -13747,11 +13732,11 @@
       "tagname": "",
       "internal": "",
       "class": "@ember/object/mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 621,
+      "line": 626,
       "itemtype": "method",
       "name": "apply",
       "params": [
@@ -13767,17 +13752,17 @@
       "tagname": "",
       "internal": "",
       "class": "@ember/object/mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 637,
+      "line": 642,
       "class": "@ember/object/mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 642,
+      "line": 647,
       "itemtype": "method",
       "name": "detect",
       "params": [
@@ -13794,25 +13779,25 @@
       "tagname": "",
       "internal": "",
       "class": "@ember/object/mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 663,
+      "line": 668,
       "class": "@ember/object/mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 670,
+      "line": 675,
       "class": "@ember/object/mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/mixin.ts",
-      "line": 677,
+      "line": 682,
       "class": "@ember/object/mixin",
-      "module": "@ember/object/mixin"
+      "module": "@ember/object"
     },
     {
       "file": "packages/@ember/object/observable.ts",
@@ -18807,15 +18792,15 @@
     },
     {
       "message": "unknown tag: internal",
-      "line": " packages/@ember/object/mixin.ts:598"
+      "line": " packages/@ember/object/mixin.ts:603"
     },
     {
       "message": "unknown tag: internal",
-      "line": " packages/@ember/object/mixin.ts:621"
+      "line": " packages/@ember/object/mixin.ts:626"
     },
     {
       "message": "unknown tag: internal",
-      "line": " packages/@ember/object/mixin.ts:642"
+      "line": " packages/@ember/object/mixin.ts:647"
     },
     {
       "message": "replacing incorrect tag: returns with return",
@@ -19251,47 +19236,47 @@
     },
     {
       "message": "Missing item type",
-      "line": " packages/@ember/object/mixin.ts:522"
+      "line": " packages/@ember/object/mixin.ts:529"
     },
     {
       "message": "Missing item type",
-      "line": " packages/@ember/object/mixin.ts:525"
+      "line": " packages/@ember/object/mixin.ts:532"
     },
     {
       "message": "Missing item type",
-      "line": " packages/@ember/object/mixin.ts:528"
+      "line": " packages/@ember/object/mixin.ts:535"
     },
     {
       "message": "Missing item type",
-      "line": " packages/@ember/object/mixin.ts:531"
+      "line": " packages/@ember/object/mixin.ts:538"
     },
     {
       "message": "Missing item type",
-      "line": " packages/@ember/object/mixin.ts:534"
+      "line": " packages/@ember/object/mixin.ts:541"
     },
     {
       "message": "Missing item type",
-      "line": " packages/@ember/object/mixin.ts:539"
+      "line": " packages/@ember/object/mixin.ts:544"
     },
     {
       "message": "Missing item type",
-      "line": " packages/@ember/object/mixin.ts:580"
+      "line": " packages/@ember/object/mixin.ts:585"
     },
     {
       "message": "Missing item type",
-      "line": " packages/@ember/object/mixin.ts:637"
+      "line": " packages/@ember/object/mixin.ts:642"
     },
     {
       "message": "Missing item type",
-      "line": " packages/@ember/object/mixin.ts:663"
+      "line": " packages/@ember/object/mixin.ts:668"
     },
     {
       "message": "Missing item type",
-      "line": " packages/@ember/object/mixin.ts:670"
+      "line": " packages/@ember/object/mixin.ts:675"
     },
     {
       "message": "Missing item type",
-      "line": " packages/@ember/object/mixin.ts:677"
+      "line": " packages/@ember/object/mixin.ts:682"
     },
     {
       "message": "Missing item type\nRetrieves the value of a property from the object.",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-source",
-  "version": "4.8.3",
+  "version": "4.8.5",
   "description": "A JavaScript framework for creating ambitious web applications",
   "keywords": [
     "ember-addon"
@@ -178,7 +178,7 @@
       ]
     }
   },
-  "_originalVersion": "4.8.3",
+  "_originalVersion": "4.8.5",
   "_versionPreviouslyCalculated": true,
   "publishConfig": {
     "tag": "old"

package/types/preview/@ember/debug/container-debug-adapter.d.ts

@@ -1,11 +1,12 @@
 declare module '@ember/debug/container-debug-adapter' {
+  import EmberObject from '@ember/object';
   import type { Resolver } from '@ember/-internals/resolver';
 
   /**
    * The ContainerDebugAdapter helps the container and resolver interface
    * with tools that debug Ember such as the Ember Inspector for Chrome and Firefox.
    */
-  export default class ContainerDebugAdapter extends Object {
+  export default class ContainerDebugAdapter extends EmberObject {
     resolver: Resolver;
     canCatalogEntriesByType(type: string): boolean;
     catalogEntriesByType(type: string): string[];