ember-source 4.6.0-alpha.2 → 4.6.0-alpha.3

package/dist/header/license.js

@@ -5,5 +5,5 @@
  *            Portions Copyright 2008-2011 Apple Inc. All rights reserved.
  * @license   Licensed under MIT license
  *            See https://raw.github.com/emberjs/ember.js/master/LICENSE
- * @version   4.6.0-alpha.2
+ * @version   4.6.0-alpha.3
  */

package/dist/packages/@ember/-internals/error-handling/index.js

@@ -13,7 +13,7 @@ export function getOnerror() {
 export function setOnerror(handler) {
   onerror = handler;
 }
-let dispatchOverride; // allows testing adapter to override dispatch
+let dispatchOverride = null; // allows testing adapter to override dispatch
 
 export function getDispatchOverride() {
   return dispatchOverride;

package/dist/packages/@ember/-internals/metal/index.js

@@ -625,12 +625,19 @@ function objectAt(array, index) {
   } else {
     return array.objectAt(index);
   }
+} // Ideally, we'd use MutableArray.detect but for unknown reasons this causes
+// the node tests to fail strangely.
+
+function isMutableArray(obj) {
+  return obj != null && typeof obj.replace === 'function';
 }
+
 function replace(array, start, deleteCount, items = EMPTY_ARRAY) {
-  if (Array.isArray(array)) {
-    replaceInNativeArray(array, start, deleteCount, items);
-  } else {
+  if (isMutableArray(array)) {
     array.replace(start, deleteCount, items);
+  } else {
+    assert('Can only replace content of a native array or MutableArray', Array.isArray(array));
+    replaceInNativeArray(array, start, deleteCount, items);
   }
 }
 const CHUNK_SIZE = 60000; // To avoid overflowing the stack, we splice up to CHUNK_SIZE items at a time.
@@ -3146,7 +3153,10 @@ class Mixin {
 
 
   keys() {
-    return _keys(this);
+    let keys = _keys(this);
+
+    assert('[BUG] Missing keys for mixin!', keys);
+    return keys;
   }
   /** @internal */
 
@@ -3222,8 +3232,8 @@ function _keys(mixin, ret = new Set(), seen = new Set()) {
   if (mixin.properties) {
     let props = Object.keys(mixin.properties);
 
-    for (let i = 0; i < props.length; i++) {
-      ret.add(props[i]);
+    for (let prop of props) {
+      ret.add(prop);
     }
   } else if (mixin.mixins) {
     mixin.mixins.forEach(x => _keys(x, ret, seen));

package/dist/packages/@ember/-internals/runtime/lib/compare.js

@@ -35,9 +35,10 @@ const TYPE_ORDER = {
 //                                              SSt  `------'`
 
 function spaceship(a, b) {
-  let diff = a - b; // SAFETY: Number casts true into 1 and false into 0. Therefore, this must end up as one of the Compare values.
-
-  return Number(diff > 0) - Number(diff < 0);
+  // SAFETY: `Math.sign` always returns `-1` for negative, `0` for zero, and `1`
+  // for positive numbers. (The extra precision is useful for the way we use
+  // this in the context of `compare`.)
+  return Math.sign(a - b);
 }
 /**
  @module @ember/utils