ember-source 4.4.0-alpha.3 → 4.4.0-alpha.6

package/dist/packages/@ember/-internals/metal/index.js

@@ -1755,9 +1755,6 @@ function isPath(path) {
   return typeof path === 'string' && firstDotIndexCache.get(path) !== -1;
 }
 
-/**
-@module @ember/object
-*/
 const PROXY_CONTENT = symbol('PROXY_CONTENT');
 let getPossibleMandatoryProxyValue;
 
@@ -2759,7 +2756,7 @@ function mergeMixins(mixins, meta$$1, descs, values, base, keys, keysWithSuper)
       } else if (mixins !== undefined) {
         mergeMixins(mixins, meta$$1, descs, values, base, keys, keysWithSuper);
 
-        if (currentMixin._without !== undefined) {
+        if (currentMixin instanceof Mixin && currentMixin._without !== undefined) {
           currentMixin._without.forEach(keyName => {
             // deleting the key means we won't process the value
             let index = keys.indexOf(keyName);
@@ -3421,30 +3418,28 @@ class TrackedDescriptor {
 // NOTE: copied from: https://github.com/glimmerjs/glimmer.js/pull/358
 
 const cached = (...args) => {
-  {
-    const [target, key, descriptor] = args; // Error on `@cached()`, `@cached(...args)`, and `@cached propName = value;`
+  const [target, key, descriptor] = args; // Error on `@cached()`, `@cached(...args)`, and `@cached propName = value;`
 
-    if (DEBUG && target === undefined) throwCachedExtraneousParens();
+  if (DEBUG && target === undefined) throwCachedExtraneousParens();
 
-    if (DEBUG && (typeof target !== 'object' || typeof key !== 'string' || typeof descriptor !== 'object' || args.length !== 3)) {
-      throwCachedInvalidArgsError(args);
-    }
+  if (DEBUG && (typeof target !== 'object' || typeof key !== 'string' || typeof descriptor !== 'object' || args.length !== 3)) {
+    throwCachedInvalidArgsError(args);
+  }
 
-    if (DEBUG && (!('get' in descriptor) || typeof descriptor.get !== 'function')) {
-      throwCachedGetterOnlyError(key);
-    }
+  if (DEBUG && (!('get' in descriptor) || typeof descriptor.get !== 'function')) {
+    throwCachedGetterOnlyError(key);
+  }
 
-    const caches = new WeakMap();
-    const getter = descriptor.get;
+  const caches = new WeakMap();
+  const getter = descriptor.get;
 
-    descriptor.get = function () {
-      if (!caches.has(this)) {
-        caches.set(this, createCache(getter.bind(this)));
-      }
+  descriptor.get = function () {
+    if (!caches.has(this)) {
+      caches.set(this, createCache(getter.bind(this)));
+    }
 
-      return getValue(caches.get(this));
-    };
-  }
+    return getValue(caches.get(this));
+  };
 };
 
 function throwCachedExtraneousParens() {

package/dist/packages/@ember/-internals/routing/lib/services/router.js

@@ -26,151 +26,6 @@ function cleanURL(url, rootURL) {
 }
 
 class RouterService extends Service.extend(Evented) {
-  constructor() {
-    super(...arguments);
-    /**
-      You can register a listener for events emitted by this service with `.on()`:
-             ```app/routes/contact-form.js
-      import Route from '@ember/routing';
-      import { service } from '@ember/service';
-             export default class extends Route {
-        @service router;
-               activate() {
-          this.router.on('routeWillChange', (transition) => {
-            if (!transition.to.find(route => route.name === this.routeName)) {
-              alert("Please save or cancel your changes.");
-              transition.abort();
-            }
-          })
-        }
-      }
-      ```
-             @method on
-      @param {String} eventName
-      @param {Function} callback
-      @public
-    */
-
-    /**
-      You can unregister a listener for events emitted by this service with `.off()`:
-             ```app/routes/contact-form.js
-      import Route from '@ember/routing';
-      import { service } from '@ember/service';
-             export default class extends Route {
-        @service router;
-               callback = (transition) =>  {
-          if (!transition.to.find(route => route.name === this.routeName)) {
-            alert("Please save or cancel your changes.");
-            transition.abort();
-          }
-        };
-               activate() {
-          this.router.on('routeWillChange', this.callback);
-        }
-               deactivate() {
-          this.router.off('routeWillChange', this.callback);
-      }
-      ```
-             @method off
-      @param {String} eventName
-      @param {Function} callback
-      @public
-    */
-
-    /**
-      The `routeWillChange` event is fired at the beginning of any
-      attempted transition with a `Transition` object as the sole
-      argument. This action can be used for aborting, redirecting,
-      or decorating the transition from the currently active routes.
-             A good example is preventing navigation when a form is
-      half-filled out:
-             ```app/routes/contact-form.js
-      import Route from '@ember/routing';
-      import { service } from '@ember/service';
-             export default class extends Route {
-        @service router;
-               activate() {
-          this.router.on('routeWillChange', (transition) => {
-            if (!transition.to.find(route => route.name === this.routeName)) {
-              alert("Please save or cancel your changes.");
-              transition.abort();
-            }
-          })
-        }
-      }
-      ```
-             The `routeWillChange` event fires whenever a new route is chosen as the desired target of a transition. This includes `transitionTo`, `replaceWith`, all redirection for any reason including error handling, and abort. Aborting implies changing the desired target back to where you already were. Once a transition has completed, `routeDidChange` fires.
-             @event routeWillChange
-      @param {Transition} transition
-      @public
-    */
-
-    /**
-      The `routeDidChange` event only fires once a transition has settled.
-      This includes aborts and error substates. Like the `routeWillChange` event
-      it receives a Transition as the sole argument.
-             A good example is sending some analytics when the route has transitioned:
-             ```app/routes/contact-form.js
-      import Route from '@ember/routing';
-      import { service } from '@ember/service';
-             export default class extends Route {
-        @service router;
-               activate() {
-          this.router.on('routeDidChange', (transition) => {
-            ga.send('pageView', {
-              current: transition.to.name,
-              from: transition.from.name
-            });
-          })
-        }
-      }
-      ```
-             `routeDidChange` will be called after any `Route`'s
-      [didTransition](/ember/release/classes/Route/events/didTransition?anchor=didTransition)
-      action has been fired.
-      The updates of properties
-      [currentURL](/ember/release/classes/RouterService/properties/currentURL?anchor=currentURL),
-      [currentRouteName](/ember/release/classes/RouterService/properties/currentURL?anchor=currentRouteName)
-      and
-      [currentRoute](/ember/release/classes/RouterService/properties/currentURL?anchor=currentRoute)
-      are completed at the time `routeDidChange` is called.
-             @event routeDidChange
-      @param {Transition} transition
-      @public
-    */
-    // Canary features
-
-    /**
-     * Refreshes all currently active routes, doing a full transition.
-     * If a route name is provided and refers to a currently active route,
-     * it will refresh only that route and its descendents.
-     * Returns a promise that will be resolved once the refresh is complete.
-     * All resetController, beforeModel, model, afterModel, redirect, and setupController
-     * hooks will be called again. You will get new data from the model hook.
-     *
-     * @method refresh
-     * @param {String} [routeName] the route to refresh (along with all child routes)
-     * @return Transition
-     * @category EMBER_ROUTING_ROUTER_SERVICE_REFRESH
-     * @public
-     */
-
-    this.refresh = true
-    /* EMBER_ROUTING_ROUTER_SERVICE_REFRESH */
-    ? function (pivotRouteName) {
-      if (!pivotRouteName) {
-        return this._router._routerMicrolib.refresh();
-      }
-
-      assert(`The route "${pivotRouteName}" was not found`, this._router.hasRoute(pivotRouteName));
-      assert(`The route "${pivotRouteName}" is currently not active`, this.isActive(pivotRouteName));
-      let owner = getOwner(this);
-      assert('RouterService is unexpectedly missing an owner', owner);
-      let pivotRoute = owner.lookup(`route:${pivotRouteName}`);
-      return this._router._routerMicrolib.refresh(pivotRoute);
-    } : undefined;
-  }
-
   get _router() {
     let router = this[ROUTER];
 
@@ -494,6 +349,146 @@ class RouterService extends Service.extend(Evented) {
     let internalURL = cleanURL(url, this.rootURL);
     return this._router._routerMicrolib.recognizeAndLoad(internalURL);
   }
+  /**
+    You can register a listener for events emitted by this service with `.on()`:
+       ```app/routes/contact-form.js
+    import Route from '@ember/routing';
+    import { service } from '@ember/service';
+       export default class extends Route {
+      @service router;
+         activate() {
+        this.router.on('routeWillChange', (transition) => {
+          if (!transition.to.find(route => route.name === this.routeName)) {
+            alert("Please save or cancel your changes.");
+            transition.abort();
+          }
+        })
+      }
+    }
+    ```
+       @method on
+    @param {String} eventName
+    @param {Function} callback
+    @public
+  */
+
+  /**
+    You can unregister a listener for events emitted by this service with `.off()`:
+       ```app/routes/contact-form.js
+    import Route from '@ember/routing';
+    import { service } from '@ember/service';
+       export default class extends Route {
+      @service router;
+         callback = (transition) =>  {
+        if (!transition.to.find(route => route.name === this.routeName)) {
+          alert("Please save or cancel your changes.");
+          transition.abort();
+        }
+      };
+         activate() {
+        this.router.on('routeWillChange', this.callback);
+      }
+         deactivate() {
+        this.router.off('routeWillChange', this.callback);
+    }
+    ```
+       @method off
+    @param {String} eventName
+    @param {Function} callback
+    @public
+  */
+
+  /**
+    The `routeWillChange` event is fired at the beginning of any
+    attempted transition with a `Transition` object as the sole
+    argument. This action can be used for aborting, redirecting,
+    or decorating the transition from the currently active routes.
+       A good example is preventing navigation when a form is
+    half-filled out:
+       ```app/routes/contact-form.js
+    import Route from '@ember/routing';
+    import { service } from '@ember/service';
+       export default class extends Route {
+      @service router;
+         activate() {
+        this.router.on('routeWillChange', (transition) => {
+          if (!transition.to.find(route => route.name === this.routeName)) {
+            alert("Please save or cancel your changes.");
+            transition.abort();
+          }
+        })
+      }
+    }
+    ```
+       The `routeWillChange` event fires whenever a new route is chosen as the desired target of a transition. This includes `transitionTo`, `replaceWith`, all redirection for any reason including error handling, and abort. Aborting implies changing the desired target back to where you already were. Once a transition has completed, `routeDidChange` fires.
+       @event routeWillChange
+    @param {Transition} transition
+    @public
+  */
+
+  /**
+    The `routeDidChange` event only fires once a transition has settled.
+    This includes aborts and error substates. Like the `routeWillChange` event
+    it receives a Transition as the sole argument.
+       A good example is sending some analytics when the route has transitioned:
+       ```app/routes/contact-form.js
+    import Route from '@ember/routing';
+    import { service } from '@ember/service';
+       export default class extends Route {
+      @service router;
+         activate() {
+        this.router.on('routeDidChange', (transition) => {
+          ga.send('pageView', {
+            current: transition.to.name,
+            from: transition.from.name
+          });
+        })
+      }
+    }
+    ```
+       `routeDidChange` will be called after any `Route`'s
+    [didTransition](/ember/release/classes/Route/events/didTransition?anchor=didTransition)
+    action has been fired.
+    The updates of properties
+    [currentURL](/ember/release/classes/RouterService/properties/currentURL?anchor=currentURL),
+    [currentRouteName](/ember/release/classes/RouterService/properties/currentURL?anchor=currentRouteName)
+    and
+    [currentRoute](/ember/release/classes/RouterService/properties/currentURL?anchor=currentRoute)
+    are completed at the time `routeDidChange` is called.
+       @event routeDidChange
+    @param {Transition} transition
+    @public
+  */
+
+  /**
+   * Refreshes all currently active routes, doing a full transition.
+   * If a route name is provided and refers to a currently active route,
+   * it will refresh only that route and its descendents.
+   * Returns a promise that will be resolved once the refresh is complete.
+   * All resetController, beforeModel, model, afterModel, redirect, and setupController
+   * hooks will be called again. You will get new data from the model hook.
+   *
+   * @method refresh
+   * @param {String} [routeName] the route to refresh (along with all child routes)
+   * @return Transition
+   * @public
+   */
+
+
+  refresh(pivotRouteName) {
+    if (!pivotRouteName) {
+      return this._router._routerMicrolib.refresh();
+    }
+
+    assert(`The route "${pivotRouteName}" was not found`, this._router.hasRoute(pivotRouteName));
+    assert(`The route "${pivotRouteName}" is currently not active`, this.isActive(pivotRouteName));
+    let owner = getOwner(this);
+    assert('RouterService is unexpectedly missing an owner', owner);
+    let pivotRoute = owner.lookup(`route:${pivotRouteName}`); // R could be instantiated with a different sub-type
+    // @ts-ignore
+
+    return this._router._routerMicrolib.refresh(pivotRoute);
+  }
 
 }
 

package/dist/packages/@ember/-internals/routing/lib/system/router.js

@@ -225,6 +225,8 @@ class EmberRouter extends EmberObject.extend(Evented) {
         seen[name] = true;
 
         if (!route) {
+          // SAFETY: this is configured in `commonSetupRegistry` in the
+          // `@ember/application/lib` package.
           let DefaultRoute = routeOwner.factoryFor('route:basic').class;
           routeOwner.register(fullRouteName, DefaultRoute.extend());
           route = routeOwner.lookup(fullRouteName);
@@ -1629,7 +1631,7 @@ function representEmptyRoute(liveRoutes, defaultParentState, {
     // Create an entry to represent our default template name,
     // just so other routes can target it and inherit its place
     // in the outlet hierarchy.
-    defaultParentState.outlets.main = {
+    defaultParentState.outlets['main'] = {
       render: {
         name: routeName,
         outlet: 'main'

package/dist/packages/@ember/-internals/runtime/lib/ext/rsvp.js

@@ -25,13 +25,17 @@ export function onerrorDefault(reason) {
 
 function errorFor(reason) {
   if (!reason) return;
+  let withErrorThrown = reason;
 
-  if (reason.errorThrown) {
-    return unwrapErrorThrown(reason);
+  if (withErrorThrown.errorThrown) {
+    return unwrapErrorThrown(withErrorThrown);
   }
 
-  if (reason.name === 'UnrecognizedURLError') {
-    assert(`The URL '${reason.message}' did not match any routes in your application`, false);
+  let withName = reason;
+
+  if (withName.name === 'UnrecognizedURLError') {
+    assert(`The URL '${withName.message}' did not match any routes in your application`, false); // @ts-expect-error We'll hit this if the assert is stripped
+
     return;
   }
 

package/dist/packages/@ember/-internals/runtime/lib/mixins/-proxy.js

@@ -53,7 +53,7 @@ function customTagForProxy(proxy, key, addMandatorySetter) {
 export default Mixin.create({
   /**
     The object whose properties will be forwarded.
-       @property content
+     @property content
     @type {unknown}
     @default null
     @public

package/dist/packages/@ember/-internals/runtime/lib/mixins/array.js

@@ -1351,7 +1351,7 @@ const MutableArray = Mixin.create(ArrayMixin, MutableEnumerable, {
     colors.unshiftObjects('yellow'); // Type Error: 'undefined' is not a function
     ```
      @method unshiftObjects
-    @param {Enumberable} objects the objects to add
+    @param {Enumerable} objects the objects to add
     @return {EmberArray} receiver
     @public
   */

package/dist/packages/@ember/-internals/runtime/lib/mixins/promise_proxy.js

@@ -98,7 +98,7 @@ export default Mixin.create({
   /**
     If the proxied promise is rejected this will contain the reason
     provided.
-       @property reason
+     @property reason
     @default null
     @public
   */
@@ -106,7 +106,7 @@ export default Mixin.create({
 
   /**
     Once the proxied promise has settled this will become `false`.
-       @property isPending
+     @property isPending
     @default true
     @public
   */
@@ -116,7 +116,7 @@ export default Mixin.create({
 
   /**
     Once the proxied promise has settled this will become `true`.
-       @property isSettled
+     @property isSettled
     @default false
     @public
   */
@@ -126,7 +126,7 @@ export default Mixin.create({
 
   /**
     Will become `true` if the proxied promise is rejected.
-       @property isRejected
+     @property isRejected
     @default false
     @public
   */
@@ -134,7 +134,7 @@ export default Mixin.create({
 
   /**
     Will become `true` if the proxied promise is fulfilled.
-       @property isFulfilled
+     @property isFulfilled
     @default false
     @public
   */
@@ -142,17 +142,17 @@ export default Mixin.create({
 
   /**
     The promise whose fulfillment value is being proxied by this object.
-       This property must be specified upon creation, and should not be
+     This property must be specified upon creation, and should not be
     changed once created.
-       Example:
-       ```javascript
+     Example:
+     ```javascript
     import ObjectProxy from '@ember/object/proxy';
     import PromiseProxyMixin from '@ember/object/promise-proxy-mixin';
-       ObjectProxy.extend(PromiseProxyMixin).create({
+     ObjectProxy.extend(PromiseProxyMixin).create({
       promise: <thenable>
     });
     ```
-       @property promise
+     @property promise
     @public
   */
   promise: computed({
@@ -168,8 +168,8 @@ export default Mixin.create({
 
   /**
     An alias to the proxied promise's `then`.
-       See RSVP.Promise.then.
-       @method then
+     See RSVP.Promise.then.
+     @method then
     @param {Function} callback
     @return {RSVP.Promise}
     @public
@@ -178,8 +178,8 @@ export default Mixin.create({
 
   /**
     An alias to the proxied promise's `catch`.
-       See RSVP.Promise.catch.
-       @method catch
+     See RSVP.Promise.catch.
+     @method catch
     @param {Function} callback
     @return {RSVP.Promise}
     @since 1.3.0
@@ -189,8 +189,8 @@ export default Mixin.create({
 
   /**
     An alias to the proxied promise's `finally`.
-       See RSVP.Promise.finally.
-       @method finally
+     See RSVP.Promise.finally.
+     @method finally
     @param {Function} callback
     @return {RSVP.Promise}
     @since 1.3.0

package/dist/packages/@ember/-internals/runtime/lib/mixins/target_action_support.js

@@ -41,9 +41,9 @@ const TargetActionSupport = Mixin.create({
   /**
   Send an `action` with an `actionContext` to a `target`. The action, actionContext
   and target will be retrieved from properties of the object. For example:
-     ```javascript
+   ```javascript
   import { alias } from '@ember/object/computed';
-     App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
+   App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
     target: alias('controller'),
     action: 'save',
     actionContext: alias('context'),
@@ -53,9 +53,9 @@ const TargetActionSupport = Mixin.create({
     }
   });
   ```
-     The `target`, `action`, and `actionContext` can be provided as properties of
+   The `target`, `action`, and `actionContext` can be provided as properties of
   an optional object argument to `triggerAction` as well.
-     ```javascript
+   ```javascript
   App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
     click() {
       this.triggerAction({
@@ -67,12 +67,12 @@ const TargetActionSupport = Mixin.create({
     }
   });
   ```
-     The `actionContext` defaults to the object you are mixing `TargetActionSupport` into.
+   The `actionContext` defaults to the object you are mixing `TargetActionSupport` into.
   But `target` and `action` must be specified either as properties or with the argument
   to `triggerAction`, or a combination:
-     ```javascript
+   ```javascript
   import { alias } from '@ember/object/computed';
-     App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
+   App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
     target: alias('controller'),
     click() {
       this.triggerAction({
@@ -82,7 +82,7 @@ const TargetActionSupport = Mixin.create({
     }
   });
   ```
-     @method triggerAction
+   @method triggerAction
   @param opts {Object} (optional, with the optional keys action, target and/or actionContext)
   @return {Boolean} true if the action was sent successfully and did not return false
   @private

package/dist/packages/@ember/-internals/views/lib/system/utils.js

@@ -1,6 +1,4 @@
 import { getOwner } from '@ember/-internals/owner';
-/* globals Element */
-
 import { guidFor } from '@ember/-internals/utils';
 import { assert } from '@ember/debug';
 /**
@@ -8,6 +6,10 @@ import { assert } from '@ember/debug';
 */
 
 export function isSimpleClick(event) {
+  if (!(event instanceof MouseEvent)) {
+    return false;
+  }
+
   let modifier = event.shiftKey || event.metaKey || event.altKey || event.ctrlKey;
   let secondaryClick = event.which > 1; // IE9 may return undefined
 

package/dist/packages/@ember/-internals/views/lib/views/core_view.js

@@ -1,23 +1,6 @@
 import { inject } from '@ember/-internals/metal';
 import { ActionHandler, Evented, FrameworkObject } from '@ember/-internals/runtime';
 import states from './states';
-/**
-  `Ember.CoreView` is an abstract class that exists to give view-like behavior
-  to both Ember's main view class `Component` and other classes that don't need
-  the full functionality of `Component`.
-
-  Unless you have specific needs for `CoreView`, you will use `Component`
-  in your applications.
-
-  @class CoreView
-  @namespace Ember
-  @extends EmberObject
-  @deprecated Use `Component` instead.
-  @uses Evented
-  @uses Ember.ActionHandler
-  @private
-*/
-
 const CoreView = FrameworkObject.extend(Evented, ActionHandler, {
   isView: true,
   _states: states,
@@ -34,7 +17,7 @@ const CoreView = FrameworkObject.extend(Evented, ActionHandler, {
   /**
     If the view is currently inserted into the DOM of a parent view, this
     property will point to the parent of the view.
-     @property parentView
+       @property parentView
     @type Ember.View
     @default null
     @private
@@ -42,16 +25,16 @@ const CoreView = FrameworkObject.extend(Evented, ActionHandler, {
   parentView: null,
 
   instrumentDetails(hash) {
-    hash.object = this.toString();
-    hash.containerKey = this._debugContainerKey;
-    hash.view = this;
+    hash['object'] = this.toString();
+    hash['containerKey'] = this._debugContainerKey;
+    hash['view'] = this;
     return hash;
   },
 
   /**
     Override the default event firing from `Evented` to
     also call methods with the given name.
-     @method trigger
+       @method trigger
     @param name {String}
     @private
   */

package/dist/packages/@ember/canary-features/index.js

@@ -13,9 +13,7 @@ import { ENV } from '@ember/-internals/environment';
 export const DEFAULT_FEATURES = {
   EMBER_LIBRARIES_ISREGISTERED: null,
   EMBER_IMPROVED_INSTRUMENTATION: null,
-  EMBER_ROUTING_ROUTER_SERVICE_REFRESH: true,
-  EMBER_CACHED: true,
-  EMBER_UNIQUE_ID_HELPER: null
+  EMBER_UNIQUE_ID_HELPER: true
 };
 /**
   The hash of enabled Canary features. Add to this, any canary features
@@ -66,6 +64,4 @@ function featureValue(value) {
 
 export const EMBER_LIBRARIES_ISREGISTERED = featureValue(FEATURES.EMBER_LIBRARIES_ISREGISTERED);
 export const EMBER_IMPROVED_INSTRUMENTATION = featureValue(FEATURES.EMBER_IMPROVED_INSTRUMENTATION);
-export const EMBER_ROUTING_ROUTER_SERVICE_REFRESH = featureValue(FEATURES.EMBER_ROUTING_ROUTER_SERVICE_REFRESH);
-export const EMBER_CACHED = featureValue(FEATURES.EMBER_CACHED);
 export const EMBER_UNIQUE_ID_HELPER = featureValue(FEATURES.EMBER_UNIQUE_ID_HELPER);

package/dist/packages/@ember/debug/index.js

@@ -260,7 +260,7 @@ let _warnIfUsingStrippedFeatureFlags;
 if (DEBUG && !isTesting()) {
   if (typeof window !== 'undefined' && (isFirefox || isChrome) && window.addEventListener) {
     window.addEventListener('load', () => {
-      if (document.documentElement && document.documentElement.dataset && !document.documentElement.dataset.emberExtension) {
+      if (document.documentElement && document.documentElement.dataset && !document.documentElement.dataset['emberExtension']) {
         let downloadURL;
 
         if (isChrome) {