ember-source 4.4.0-alpha.2 → 4.4.0-alpha.5

package/dist/packages/@ember/-internals/metal/index.js

@@ -145,7 +145,7 @@ function sendEvent(obj, eventName, params, actions, _meta) {
   return true;
 }
 /**
-  @private
+  @public
   @method hasListeners
   @static
   @for @ember/object/events
@@ -1755,9 +1755,6 @@ function isPath(path) {
   return typeof path === 'string' && firstDotIndexCache.get(path) !== -1;
 }
 
-/**
-@module @ember/object
-*/
 const PROXY_CONTENT = symbol('PROXY_CONTENT');
 let getPossibleMandatoryProxyValue;
 
@@ -2125,7 +2122,6 @@ function eachProxyArrayDidChange(array, idx, removedCnt, addedCnt) {
   confusing.
 
   ```javascript
-  isNone();              // true
   isNone(null);          // true
   isNone(undefined);     // true
   isNone('');            // false
@@ -2159,7 +2155,6 @@ function isNone(obj) {
   to check emptiness.
 
   ```javascript
-  isEmpty();                 // true
   isEmpty(null);             // true
   isEmpty(undefined);        // true
   isEmpty('');               // true
@@ -2183,19 +2178,15 @@ function isNone(obj) {
 */
 
 function isEmpty(obj) {
-  let none = obj === null || obj === undefined;
-
-  if (none) {
-    return none;
+  if (obj === null || obj === undefined) {
+    return true;
   }
 
   if (typeof obj.unknownProperty !== 'function' && typeof obj.size === 'number') {
     return !obj.size;
   }
 
-  let objectType = typeof obj;
-
-  if (objectType === 'object') {
+  if (typeof obj === 'object') {
     let size = get(obj, 'size');
 
     if (typeof size === 'number') {
@@ -2209,7 +2200,7 @@ function isEmpty(obj) {
     }
   }
 
-  if (typeof obj.length === 'number' && objectType !== 'function') {
+  if (typeof obj.length === 'number' && typeof obj !== 'function') {
     return !obj.length;
   }
 
@@ -2226,7 +2217,6 @@ function isEmpty(obj) {
   ```javascript
   import { isBlank } from '@ember/utils';
 
-  isBlank();                // true
   isBlank(null);            // true
   isBlank(undefined);       // true
   isBlank('');              // true
@@ -2260,7 +2250,6 @@ function isBlank(obj) {
   A value is present if it not `isBlank`.
 
   ```javascript
-  isPresent();                // false
   isPresent(null);            // false
   isPresent(undefined);       // false
   isPresent('');              // false
@@ -2767,7 +2756,7 @@ function mergeMixins(mixins, meta$$1, descs, values, base, keys, keysWithSuper)
       } else if (mixins !== undefined) {
         mergeMixins(mixins, meta$$1, descs, values, base, keys, keysWithSuper);
 
-        if (currentMixin._without !== undefined) {
+        if (currentMixin instanceof Mixin && currentMixin._without !== undefined) {
           currentMixin._without.forEach(keyName => {
             // deleting the key means we won't process the value
             let index = keys.indexOf(keyName);

package/dist/packages/@ember/-internals/routing/lib/location/hash_location.js

@@ -124,7 +124,7 @@ export default class HashLocation extends EmberObject {
   onUpdateURL(callback) {
     this._removeEventListener();
 
-    this._hashchangeHandler = bind(this, function () {
+    this._hashchangeHandler = bind(this, function (_event) {
       let path = this.getURL();
 
       if (this.lastSetURL === path) {

package/dist/packages/@ember/-internals/routing/lib/services/router.js

@@ -28,6 +28,55 @@ function cleanURL(url, rootURL) {
 class RouterService extends Service.extend(Evented) {
   constructor() {
     super(...arguments);
+    /**
+      You can register a listener for events emitted by this service with `.on()`:
+             ```app/routes/contact-form.js
+      import Route from '@ember/routing';
+      import { service } from '@ember/service';
+             export default class extends Route {
+        @service router;
+               activate() {
+          this.router.on('routeWillChange', (transition) => {
+            if (!transition.to.find(route => route.name === this.routeName)) {
+              alert("Please save or cancel your changes.");
+              transition.abort();
+            }
+          })
+        }
+      }
+      ```
+             @method on
+      @param {String} eventName
+      @param {Function} callback
+      @public
+    */
+
+    /**
+      You can unregister a listener for events emitted by this service with `.off()`:
+             ```app/routes/contact-form.js
+      import Route from '@ember/routing';
+      import { service } from '@ember/service';
+             export default class extends Route {
+        @service router;
+               callback = (transition) =>  {
+          if (!transition.to.find(route => route.name === this.routeName)) {
+            alert("Please save or cancel your changes.");
+            transition.abort();
+          }
+        };
+               activate() {
+          this.router.on('routeWillChange', this.callback);
+        }
+               deactivate() {
+          this.router.off('routeWillChange', this.callback);
+      }
+      ```
+             @method off
+      @param {String} eventName
+      @param {Function} callback
+      @public
+    */
+
     /**
       The `routeWillChange` event is fired at the beginning of any
       attempted transition with a `Transition` object as the sole
@@ -40,9 +89,8 @@ class RouterService extends Service.extend(Evented) {
       import { service } from '@ember/service';
              export default class extends Route {
         @service router;
-               constructor() {
-          super(...arguments);
-                 this.router.on('routeWillChange', (transition) => {
+               activate() {
+          this.router.on('routeWillChange', (transition) => {
             if (!transition.to.find(route => route.name === this.routeName)) {
               alert("Please save or cancel your changes.");
               transition.abort();
@@ -67,9 +115,8 @@ class RouterService extends Service.extend(Evented) {
       import { service } from '@ember/service';
              export default class extends Route {
         @service router;
-               constructor() {
-          super(...arguments);
-                 this.router.on('routeDidChange', (transition) => {
+               activate() {
+          this.router.on('routeDidChange', (transition) => {
             ga.send('pageView', {
               current: transition.to.name,
               from: transition.from.name
@@ -197,7 +244,6 @@ class RouterService extends Service.extend(Evented) {
 
     let transition = this._router._doTransition(routeName, models, queryParams, true);
 
-    transition['_keepDefaultQueryParamValues'] = true;
     return transition;
   }
   /**
@@ -368,19 +414,26 @@ class RouterService extends Service.extend(Evented) {
     let hasQueryParams = Object.keys(queryParams).length > 0;
 
     if (hasQueryParams) {
-      queryParams = Object.assign({}, queryParams);
-
-      this._router._prepareQueryParams( // UNSAFE: casting `routeName as string` here encodes the existing
+      // UNSAFE: casting `routeName as string` here encodes the existing
       // assumption but may be wrong: `extractRouteArgs` correctly returns it
       // as `string | undefined`. There may be bugs if `_prepareQueryParams`
       // does not correctly account for `undefined` values for `routeName`.
       //  Spoilers: under the hood this currently uses router.js APIs which
       // *do not* account for this being `undefined`.
-      routeName, models, queryParams, true
+      let targetRouteName = routeName;
+      queryParams = Object.assign({}, queryParams);
+
+      this._router._prepareQueryParams(targetRouteName, models, queryParams, true
+      /* fromRouterService */
+      );
+
+      let currentQueryParams = Object.assign({}, routerMicrolib.state.queryParams);
+
+      this._router._prepareQueryParams(targetRouteName, models, currentQueryParams, true
       /* fromRouterService */
       );
 
-      return shallowEqual(queryParams, routerMicrolib.state.queryParams);
+      return shallowEqual(queryParams, currentQueryParams);
     }
 
     return true;

package/dist/packages/@ember/-internals/routing/lib/system/route.js

@@ -1663,7 +1663,7 @@ Route.reopen({
         qp.serializedValue = svalue;
         let thisQueryParamHasDefaultValue = qp.serializedDefaultValue === svalue;
 
-        if (!thisQueryParamHasDefaultValue || transition._keepDefaultQueryParamValues) {
+        if (!thisQueryParamHasDefaultValue) {
           finalParams.push({
             value: svalue,
             visible: true,

package/dist/packages/@ember/-internals/routing/lib/system/router.js

@@ -94,6 +94,7 @@ class EmberRouter extends EmberObject.extend(Evented) {
     this._handledErrors = new Set();
     this._engineInstances = Object.create(null);
     this._engineInfoByRoute = Object.create(null);
+    this._slowTransitionTimer = null;
     this.currentState = null;
     this.targetState = null;
 
@@ -701,11 +702,13 @@ class EmberRouter extends EmberObject.extend(Evented) {
     let instances = this._engineInstances;
 
     for (let name in instances) {
-      let instance = instances[name];
-      assert('has instance', instance);
+      let instanceMap = instances[name];
+      assert('has instanceMap', instanceMap);
 
-      for (let id in instance) {
-        run(instance[id], 'destroy');
+      for (let id in instanceMap) {
+        let instance = instanceMap[id];
+        assert('has instance', instance);
+        run(instance, 'destroy');
       }
     }
   }
@@ -918,7 +921,7 @@ class EmberRouter extends EmberObject.extend(Evented) {
     }
   }
 
-  _doTransition(_targetRouteName, models, _queryParams, _keepDefaultQueryParamValues) {
+  _doTransition(_targetRouteName, models, _queryParams, _fromRouterService) {
     let targetRouteName = _targetRouteName || getActiveTargetName(this._routerMicrolib);
 
     assert(`The route ${targetRouteName} was not found`, Boolean(targetRouteName) && this._routerMicrolib.hasRoute(targetRouteName));
@@ -929,7 +932,7 @@ class EmberRouter extends EmberObject.extend(Evented) {
 
     Object.assign(queryParams, _queryParams);
 
-    this._prepareQueryParams(targetRouteName, models, queryParams, Boolean(_keepDefaultQueryParamValues));
+    this._prepareQueryParams(targetRouteName, models, queryParams, Boolean(_fromRouterService));
 
     let transition = this._routerMicrolib.transitionTo(targetRouteName, ...models, {
       queryParams
@@ -1167,7 +1170,7 @@ class EmberRouter extends EmberObject.extend(Evented) {
   _scheduleLoadingEvent(transition, originRoute) {
     this._cancelSlowTransitionTimer();
 
-    this._slowTransitionTimer = scheduleOnce('routerTransitions', this, '_handleSlowTransition', transition, originRoute);
+    this._slowTransitionTimer = scheduleOnce('routerTransitions', this, this._handleSlowTransition, transition, originRoute);
   }
 
   _handleSlowTransition(transition, originRoute) {
@@ -1626,7 +1629,7 @@ function representEmptyRoute(liveRoutes, defaultParentState, {
     // Create an entry to represent our default template name,
     // just so other routes can target it and inherit its place
     // in the outlet hierarchy.
-    defaultParentState.outlets.main = {
+    defaultParentState.outlets['main'] = {
       render: {
         name: routeName,
         outlet: 'main'

package/dist/packages/@ember/-internals/runtime/lib/compare.js

@@ -1,5 +1,6 @@
 import { typeOf } from './type-of';
 import Comparable from './mixins/comparable';
+import { assert } from '@ember/debug';
 const TYPE_ORDER = {
   undefined: 0,
   null: 1,
@@ -31,8 +32,9 @@ const TYPE_ORDER = {
 //                                              SSt  `------'`
 
 function spaceship(a, b) {
-  let diff = a - b;
-  return (diff > 0) - (diff < 0);
+  let diff = a - b; // SAFETY: Number casts true into 1 and false into 0. Therefore, this must end up as one of the Compare values.
+
+  return Number(diff > 0) - Number(diff < 0);
 }
 /**
  @module @ember/utils
@@ -94,11 +96,12 @@ export default function compare(v, w) {
   let type1 = typeOf(v);
   let type2 = typeOf(w);
 
-  if (type1 === 'instance' && Comparable.detect(v) && v.constructor.compare) {
+  if (type1 === 'instance' && isComparable(v) && v.constructor.compare) {
     return v.constructor.compare(v, w);
   }
 
-  if (type2 === 'instance' && Comparable.detect(w) && w.constructor.compare) {
+  if (type2 === 'instance' && isComparable(w) && w.constructor.compare) {
+    // SAFETY: Multiplying by a negative just changes the sign
     return w.constructor.compare(w, v) * -1;
   }
 
@@ -111,14 +114,20 @@ export default function compare(v, w) {
 
   switch (type1) {
     case 'boolean':
+      assert('both are boolean', typeof v === 'boolean' && typeof w === 'boolean');
+      return spaceship(Number(v), Number(w));
+
     case 'number':
+      assert('both are numbers', typeof v === 'number' && typeof w === 'number');
       return spaceship(v, w);
 
     case 'string':
+      assert('both are strings', typeof v === 'string' && typeof w === 'string');
       return spaceship(v.localeCompare(w), 0);
 
     case 'array':
       {
+        assert('both are arrays', Array.isArray(v) && Array.isArray(w));
         let vLen = v.length;
         let wLen = w.length;
         let len = Math.min(vLen, wLen);
@@ -137,16 +146,21 @@ export default function compare(v, w) {
       }
 
     case 'instance':
-      if (Comparable.detect(v)) {
+      if (isComparable(v) && v.compare) {
         return v.compare(v, w);
       }
 
       return 0;
 
     case 'date':
+      assert('both are dates', v instanceof Date && w instanceof Date);
       return spaceship(v.getTime(), w.getTime());
 
     default:
       return 0;
   }
+}
+
+function isComparable(value) {
+  return Comparable.detect(value);
 }

package/dist/packages/@ember/-internals/runtime/lib/ext/rsvp.js

@@ -25,13 +25,17 @@ export function onerrorDefault(reason) {
 
 function errorFor(reason) {
   if (!reason) return;
+  let withErrorThrown = reason;
 
-  if (reason.errorThrown) {
-    return unwrapErrorThrown(reason);
+  if (withErrorThrown.errorThrown) {
+    return unwrapErrorThrown(withErrorThrown);
   }
 
-  if (reason.name === 'UnrecognizedURLError') {
-    assert(`The URL '${reason.message}' did not match any routes in your application`, false);
+  let withName = reason;
+
+  if (withName.name === 'UnrecognizedURLError') {
+    assert(`The URL '${withName.message}' did not match any routes in your application`, false); // @ts-expect-error We'll hit this if the assert is stripped
+
     return;
   }
 

package/dist/packages/@ember/-internals/runtime/lib/mixins/-proxy.js

@@ -53,7 +53,7 @@ function customTagForProxy(proxy, key, addMandatorySetter) {
 export default Mixin.create({
   /**
     The object whose properties will be forwarded.
-       @property content
+     @property content
     @type {unknown}
     @default null
     @public

package/dist/packages/@ember/-internals/runtime/lib/mixins/array.js

@@ -1351,7 +1351,7 @@ const MutableArray = Mixin.create(ArrayMixin, MutableEnumerable, {
     colors.unshiftObjects('yellow'); // Type Error: 'undefined' is not a function
     ```
      @method unshiftObjects
-    @param {Enumberable} objects the objects to add
+    @param {Enumerable} objects the objects to add
     @return {EmberArray} receiver
     @public
   */

package/dist/packages/@ember/-internals/runtime/lib/mixins/comparable.js

@@ -18,13 +18,13 @@ import { Mixin } from '@ember/-internals/metal';
 export default Mixin.create({
   /**
     __Required.__ You must implement this method to apply this mixin.
-       Override to return the result of the comparison of the two parameters. The
+     Override to return the result of the comparison of the two parameters. The
     compare method should return:
-       - `-1` if `a < b`
+     - `-1` if `a < b`
     - `0` if `a == b`
     - `1` if `a > b`
-       Default implementation raises an exception.
-       @method compare
+     Default implementation raises an exception.
+     @method compare
     @param a {Object} the first object to compare
     @param b {Object} the second object to compare
     @return {Number} the result of the comparison

package/dist/packages/@ember/-internals/runtime/lib/mixins/promise_proxy.js

@@ -98,7 +98,7 @@ export default Mixin.create({
   /**
     If the proxied promise is rejected this will contain the reason
     provided.
-       @property reason
+     @property reason
     @default null
     @public
   */
@@ -106,7 +106,7 @@ export default Mixin.create({
 
   /**
     Once the proxied promise has settled this will become `false`.
-       @property isPending
+     @property isPending
     @default true
     @public
   */
@@ -116,7 +116,7 @@ export default Mixin.create({
 
   /**
     Once the proxied promise has settled this will become `true`.
-       @property isSettled
+     @property isSettled
     @default false
     @public
   */
@@ -126,7 +126,7 @@ export default Mixin.create({
 
   /**
     Will become `true` if the proxied promise is rejected.
-       @property isRejected
+     @property isRejected
     @default false
     @public
   */
@@ -134,7 +134,7 @@ export default Mixin.create({
 
   /**
     Will become `true` if the proxied promise is fulfilled.
-       @property isFulfilled
+     @property isFulfilled
     @default false
     @public
   */
@@ -142,17 +142,17 @@ export default Mixin.create({
 
   /**
     The promise whose fulfillment value is being proxied by this object.
-       This property must be specified upon creation, and should not be
+     This property must be specified upon creation, and should not be
     changed once created.
-       Example:
-       ```javascript
+     Example:
+     ```javascript
     import ObjectProxy from '@ember/object/proxy';
     import PromiseProxyMixin from '@ember/object/promise-proxy-mixin';
-       ObjectProxy.extend(PromiseProxyMixin).create({
+     ObjectProxy.extend(PromiseProxyMixin).create({
       promise: <thenable>
     });
     ```
-       @property promise
+     @property promise
     @public
   */
   promise: computed({
@@ -168,8 +168,8 @@ export default Mixin.create({
 
   /**
     An alias to the proxied promise's `then`.
-       See RSVP.Promise.then.
-       @method then
+     See RSVP.Promise.then.
+     @method then
     @param {Function} callback
     @return {RSVP.Promise}
     @public
@@ -178,8 +178,8 @@ export default Mixin.create({
 
   /**
     An alias to the proxied promise's `catch`.
-       See RSVP.Promise.catch.
-       @method catch
+     See RSVP.Promise.catch.
+     @method catch
     @param {Function} callback
     @return {RSVP.Promise}
     @since 1.3.0
@@ -189,8 +189,8 @@ export default Mixin.create({
 
   /**
     An alias to the proxied promise's `finally`.
-       See RSVP.Promise.finally.
-       @method finally
+     See RSVP.Promise.finally.
+     @method finally
     @param {Function} callback
     @return {RSVP.Promise}
     @since 1.3.0

package/dist/packages/@ember/-internals/runtime/lib/mixins/target_action_support.js

@@ -41,9 +41,9 @@ const TargetActionSupport = Mixin.create({
   /**
   Send an `action` with an `actionContext` to a `target`. The action, actionContext
   and target will be retrieved from properties of the object. For example:
-     ```javascript
+   ```javascript
   import { alias } from '@ember/object/computed';
-     App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
+   App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
     target: alias('controller'),
     action: 'save',
     actionContext: alias('context'),
@@ -53,9 +53,9 @@ const TargetActionSupport = Mixin.create({
     }
   });
   ```
-     The `target`, `action`, and `actionContext` can be provided as properties of
+   The `target`, `action`, and `actionContext` can be provided as properties of
   an optional object argument to `triggerAction` as well.
-     ```javascript
+   ```javascript
   App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
     click() {
       this.triggerAction({
@@ -67,12 +67,12 @@ const TargetActionSupport = Mixin.create({
     }
   });
   ```
-     The `actionContext` defaults to the object you are mixing `TargetActionSupport` into.
+   The `actionContext` defaults to the object you are mixing `TargetActionSupport` into.
   But `target` and `action` must be specified either as properties or with the argument
   to `triggerAction`, or a combination:
-     ```javascript
+   ```javascript
   import { alias } from '@ember/object/computed';
-     App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
+   App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
     target: alias('controller'),
     click() {
       this.triggerAction({
@@ -82,7 +82,7 @@ const TargetActionSupport = Mixin.create({
     }
   });
   ```
-     @method triggerAction
+   @method triggerAction
   @param opts {Object} (optional, with the optional keys action, target and/or actionContext)
   @return {Boolean} true if the action was sent successfully and did not return false
   @private

package/dist/packages/@ember/-internals/views/lib/system/utils.js

@@ -1,6 +1,4 @@
 import { getOwner } from '@ember/-internals/owner';
-/* globals Element */
-
 import { guidFor } from '@ember/-internals/utils';
 import { assert } from '@ember/debug';
 /**
@@ -8,6 +6,10 @@ import { assert } from '@ember/debug';
 */
 
 export function isSimpleClick(event) {
+  if (!(event instanceof MouseEvent)) {
+    return false;
+  }
+
   let modifier = event.shiftKey || event.metaKey || event.altKey || event.ctrlKey;
   let secondaryClick = event.which > 1; // IE9 may return undefined
 

package/dist/packages/@ember/-internals/views/lib/views/core_view.js

@@ -1,23 +1,6 @@
 import { inject } from '@ember/-internals/metal';
 import { ActionHandler, Evented, FrameworkObject } from '@ember/-internals/runtime';
 import states from './states';
-/**
-  `Ember.CoreView` is an abstract class that exists to give view-like behavior
-  to both Ember's main view class `Component` and other classes that don't need
-  the full functionality of `Component`.
-
-  Unless you have specific needs for `CoreView`, you will use `Component`
-  in your applications.
-
-  @class CoreView
-  @namespace Ember
-  @extends EmberObject
-  @deprecated Use `Component` instead.
-  @uses Evented
-  @uses Ember.ActionHandler
-  @private
-*/
-
 const CoreView = FrameworkObject.extend(Evented, ActionHandler, {
   isView: true,
   _states: states,
@@ -34,7 +17,7 @@ const CoreView = FrameworkObject.extend(Evented, ActionHandler, {
   /**
     If the view is currently inserted into the DOM of a parent view, this
     property will point to the parent of the view.
-     @property parentView
+       @property parentView
     @type Ember.View
     @default null
     @private
@@ -42,16 +25,16 @@ const CoreView = FrameworkObject.extend(Evented, ActionHandler, {
   parentView: null,
 
   instrumentDetails(hash) {
-    hash.object = this.toString();
-    hash.containerKey = this._debugContainerKey;
-    hash.view = this;
+    hash['object'] = this.toString();
+    hash['containerKey'] = this._debugContainerKey;
+    hash['view'] = this;
     return hash;
   },
 
   /**
     Override the default event firing from `Evented` to
     also call methods with the given name.
-     @method trigger
+       @method trigger
     @param name {String}
     @private
   */

package/dist/packages/@ember/canary-features/index.js

@@ -14,7 +14,8 @@ export const DEFAULT_FEATURES = {
   EMBER_LIBRARIES_ISREGISTERED: null,
   EMBER_IMPROVED_INSTRUMENTATION: null,
   EMBER_ROUTING_ROUTER_SERVICE_REFRESH: true,
-  EMBER_CACHED: true
+  EMBER_CACHED: true,
+  EMBER_UNIQUE_ID_HELPER: true
 };
 /**
   The hash of enabled Canary features. Add to this, any canary features
@@ -66,4 +67,5 @@ function featureValue(value) {
 export const EMBER_LIBRARIES_ISREGISTERED = featureValue(FEATURES.EMBER_LIBRARIES_ISREGISTERED);
 export const EMBER_IMPROVED_INSTRUMENTATION = featureValue(FEATURES.EMBER_IMPROVED_INSTRUMENTATION);
 export const EMBER_ROUTING_ROUTER_SERVICE_REFRESH = featureValue(FEATURES.EMBER_ROUTING_ROUTER_SERVICE_REFRESH);
-export const EMBER_CACHED = featureValue(FEATURES.EMBER_CACHED);
+export const EMBER_CACHED = featureValue(FEATURES.EMBER_CACHED);
+export const EMBER_UNIQUE_ID_HELPER = featureValue(FEATURES.EMBER_UNIQUE_ID_HELPER);

package/dist/packages/@ember/debug/index.js

@@ -260,7 +260,7 @@ let _warnIfUsingStrippedFeatureFlags;
 if (DEBUG && !isTesting()) {
   if (typeof window !== 'undefined' && (isFirefox || isChrome) && window.addEventListener) {
     window.addEventListener('load', () => {
-      if (document.documentElement && document.documentElement.dataset && !document.documentElement.dataset.emberExtension) {
+      if (document.documentElement && document.documentElement.dataset && !document.documentElement.dataset['emberExtension']) {
         let downloadURL;
 
         if (isChrome) {