ember-source 4.3.0-alpha.1 → 4.3.0-beta.1

package/dist/packages/@ember/-internals/runtime/lib/mixins/promise_proxy.js

@@ -98,7 +98,7 @@ export default Mixin.create({
   /**
     If the proxied promise is rejected this will contain the reason
     provided.
-     @property reason
+       @property reason
     @default null
     @public
   */
@@ -106,7 +106,7 @@ export default Mixin.create({
 
   /**
     Once the proxied promise has settled this will become `false`.
-     @property isPending
+       @property isPending
     @default true
     @public
   */
@@ -116,7 +116,7 @@ export default Mixin.create({
 
   /**
     Once the proxied promise has settled this will become `true`.
-     @property isSettled
+       @property isSettled
     @default false
     @public
   */
@@ -126,7 +126,7 @@ export default Mixin.create({
 
   /**
     Will become `true` if the proxied promise is rejected.
-     @property isRejected
+       @property isRejected
     @default false
     @public
   */
@@ -134,7 +134,7 @@ export default Mixin.create({
 
   /**
     Will become `true` if the proxied promise is fulfilled.
-     @property isFulfilled
+       @property isFulfilled
     @default false
     @public
   */
@@ -142,17 +142,17 @@ export default Mixin.create({
 
   /**
     The promise whose fulfillment value is being proxied by this object.
-     This property must be specified upon creation, and should not be
+       This property must be specified upon creation, and should not be
     changed once created.
-     Example:
-     ```javascript
+       Example:
+       ```javascript
     import ObjectProxy from '@ember/object/proxy';
     import PromiseProxyMixin from '@ember/object/promise-proxy-mixin';
-     ObjectProxy.extend(PromiseProxyMixin).create({
+       ObjectProxy.extend(PromiseProxyMixin).create({
       promise: <thenable>
     });
     ```
-     @property promise
+       @property promise
     @public
   */
   promise: computed({
@@ -168,8 +168,8 @@ export default Mixin.create({
 
   /**
     An alias to the proxied promise's `then`.
-     See RSVP.Promise.then.
-     @method then
+       See RSVP.Promise.then.
+       @method then
     @param {Function} callback
     @return {RSVP.Promise}
     @public
@@ -178,8 +178,8 @@ export default Mixin.create({
 
   /**
     An alias to the proxied promise's `catch`.
-     See RSVP.Promise.catch.
-     @method catch
+       See RSVP.Promise.catch.
+       @method catch
     @param {Function} callback
     @return {RSVP.Promise}
     @since 1.3.0
@@ -189,8 +189,8 @@ export default Mixin.create({
 
   /**
     An alias to the proxied promise's `finally`.
-     See RSVP.Promise.finally.
-     @method finally
+       See RSVP.Promise.finally.
+       @method finally
     @param {Function} callback
     @return {RSVP.Promise}
     @since 1.3.0

package/dist/packages/@ember/-internals/runtime/lib/mixins/registry_proxy.js

@@ -16,7 +16,7 @@ export default Mixin.create({
 
   /**
    Given a fullName return the corresponding factory.
-    @public
+      @public
    @method resolveRegistration
    @param {String} fullName
    @return {Function} fullName's factory
@@ -30,48 +30,48 @@ export default Mixin.create({
     Registers a factory that can be used for dependency injection (with
     `inject`) or for service lookup. Each factory is registered with
     a full name including two parts: `type:name`.
-     A simple example:
-     ```javascript
+       A simple example:
+       ```javascript
     import Application from '@ember/application';
     import EmberObject from '@ember/object';
-     let App = Application.create();
-     App.Orange = EmberObject.extend();
+       let App = Application.create();
+       App.Orange = EmberObject.extend();
     App.register('fruit:favorite', App.Orange);
     ```
-     Ember will resolve factories from the `App` namespace automatically.
+       Ember will resolve factories from the `App` namespace automatically.
     For example `App.CarsController` will be discovered and returned if
     an application requests `controller:cars`.
-     An example of registering a controller with a non-standard name:
-     ```javascript
+       An example of registering a controller with a non-standard name:
+       ```javascript
     import Application from '@ember/application';
     import Controller from '@ember/controller';
-     let App = Application.create();
+       let App = Application.create();
     let Session = Controller.extend();
-     App.register('controller:session', Session);
-     // The Session controller can now be treated like a normal controller,
+       App.register('controller:session', Session);
+       // The Session controller can now be treated like a normal controller,
     // despite its non-standard name.
     App.ApplicationController = Controller.extend({
       needs: ['session']
     });
     ```
-     Registered factories are **instantiated** by having `create`
+       Registered factories are **instantiated** by having `create`
     called on them. Additionally they are **singletons**, each time
     they are looked up they return the same instance.
-     Some examples modifying that default behavior:
-     ```javascript
+       Some examples modifying that default behavior:
+       ```javascript
     import Application from '@ember/application';
     import EmberObject from '@ember/object';
-     let App = Application.create();
-     App.Person = EmberObject.extend();
+       let App = Application.create();
+       App.Person = EmberObject.extend();
     App.Orange = EmberObject.extend();
     App.Email = EmberObject.extend();
     App.session = EmberObject.create();
-     App.register('model:user', App.Person, { singleton: false });
+       App.register('model:user', App.Person, { singleton: false });
     App.register('fruit:favorite', App.Orange);
     App.register('communication:main', App.Email, { singleton: false });
     App.register('session', App.session, { instantiate: false });
     ```
-     @method register
+       @method register
     @param  fullName {String} type:name (e.g., 'model:user')
     @param  factory {any} (e.g., App.Person)
     @param  options {Object} (optional) disable instantiation or singleton usage
@@ -81,17 +81,17 @@ export default Mixin.create({
 
   /**
    Unregister a factory.
-    ```javascript
+      ```javascript
    import Application from '@ember/application';
    import EmberObject from '@ember/object';
-    let App = Application.create();
+      let App = Application.create();
    let User = EmberObject.extend();
    App.register('model:user', User);
-    App.resolveRegistration('model:user').create() instanceof User //=> true
-    App.unregister('model:user')
+      App.resolveRegistration('model:user').create() instanceof User //=> true
+      App.unregister('model:user')
    App.resolveRegistration('model:user') === undefined //=> true
    ```
-    @public
+      @public
    @method unregister
    @param {String} fullName
    */
@@ -99,7 +99,7 @@ export default Mixin.create({
 
   /**
    Check if a factory is registered.
-    @public
+      @public
    @method hasRegistration
    @param {String} fullName
    @return {Boolean}
@@ -108,7 +108,7 @@ export default Mixin.create({
 
   /**
    Return a specific registered option for a particular factory.
-    @public
+      @public
    @method registeredOption
    @param  {String} fullName
    @param  {String} optionName
@@ -118,7 +118,7 @@ export default Mixin.create({
 
   /**
    Register options for a particular factory.
-    @public
+      @public
    @method registerOptions
    @param {String} fullName
    @param {Object} options
@@ -127,7 +127,7 @@ export default Mixin.create({
 
   /**
    Return registered options for a particular factory.
-    @public
+      @public
    @method registeredOptions
    @param  {String} fullName
    @return {Object} options
@@ -136,22 +136,22 @@ export default Mixin.create({
 
   /**
    Allow registering options for all factories of a type.
-    ```javascript
+      ```javascript
    import Application from '@ember/application';
-    let App = Application.create();
+      let App = Application.create();
    let appInstance = App.buildInstance();
-    // if all of type `connection` must not be singletons
+      // if all of type `connection` must not be singletons
    appInstance.registerOptionsForType('connection', { singleton: false });
-    appInstance.register('connection:twitter', TwitterConnection);
+      appInstance.register('connection:twitter', TwitterConnection);
    appInstance.register('connection:facebook', FacebookConnection);
-    let twitter = appInstance.lookup('connection:twitter');
+      let twitter = appInstance.lookup('connection:twitter');
    let twitter2 = appInstance.lookup('connection:twitter');
-    twitter === twitter2; // => false
-    let facebook = appInstance.lookup('connection:facebook');
+      twitter === twitter2; // => false
+      let facebook = appInstance.lookup('connection:facebook');
    let facebook2 = appInstance.lookup('connection:facebook');
-    facebook === facebook2; // => false
+      facebook === facebook2; // => false
    ```
-    @public
+      @public
    @method registerOptionsForType
    @param {String} type
    @param {Object} options
@@ -160,7 +160,7 @@ export default Mixin.create({
 
   /**
    Return the registered options for all factories of a type.
-    @public
+      @public
    @method registeredOptionsForType
    @param {String} type
    @return {Object} options
@@ -170,37 +170,37 @@ export default Mixin.create({
   /**
     Define a dependency injection onto a specific factory or all factories
     of a type.
-     When Ember instantiates a controller, view, or other framework component
+       When Ember instantiates a controller, view, or other framework component
     it can attach a dependency to that component. This is often used to
     provide services to a set of framework components.
-     An example of providing a session object to all controllers:
-     ```javascript
+       An example of providing a session object to all controllers:
+       ```javascript
     import { alias } from '@ember/object/computed';
     import Application from '@ember/application';
     import Controller from '@ember/controller';
     import EmberObject from '@ember/object';
-     let App = Application.create();
+       let App = Application.create();
     let Session = EmberObject.extend({ isAuthenticated: false });
-     // A factory must be registered before it can be injected
+       // A factory must be registered before it can be injected
     App.register('session:main', Session);
-     // Inject 'session:main' onto all factories of the type 'controller'
+       // Inject 'session:main' onto all factories of the type 'controller'
     // with the name 'session'
     App.inject('controller', 'session', 'session:main');
-     App.IndexController = Controller.extend({
+       App.IndexController = Controller.extend({
       isLoggedIn: alias('session.isAuthenticated')
     });
     ```
-     Injections can also be performed on specific factories.
-     ```javascript
+       Injections can also be performed on specific factories.
+       ```javascript
     App.inject(<full_name or type>, <property name>, <full_name>)
     App.inject('route', 'source', 'source:main')
     App.inject('route:application', 'email', 'model:email')
     ```
-     It is important to note that injections can only be performed on
+       It is important to note that injections can only be performed on
     classes that are instantiated by Ember itself. Instantiating a class
     directly (via `create` or `new`) bypasses the dependency injection
     system.
-     @public
+       @public
     @method inject
     @param  factoryNameOrType {String}
     @param  property {String}

package/dist/packages/@ember/-internals/runtime/lib/mixins/target_action_support.js

@@ -41,9 +41,9 @@ const TargetActionSupport = Mixin.create({
   /**
   Send an `action` with an `actionContext` to a `target`. The action, actionContext
   and target will be retrieved from properties of the object. For example:
-   ```javascript
+     ```javascript
   import { alias } from '@ember/object/computed';
-   App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
+     App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
     target: alias('controller'),
     action: 'save',
     actionContext: alias('context'),
@@ -53,9 +53,9 @@ const TargetActionSupport = Mixin.create({
     }
   });
   ```
-   The `target`, `action`, and `actionContext` can be provided as properties of
+     The `target`, `action`, and `actionContext` can be provided as properties of
   an optional object argument to `triggerAction` as well.
-   ```javascript
+     ```javascript
   App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
     click() {
       this.triggerAction({
@@ -67,12 +67,12 @@ const TargetActionSupport = Mixin.create({
     }
   });
   ```
-   The `actionContext` defaults to the object you are mixing `TargetActionSupport` into.
+     The `actionContext` defaults to the object you are mixing `TargetActionSupport` into.
   But `target` and `action` must be specified either as properties or with the argument
   to `triggerAction`, or a combination:
-   ```javascript
+     ```javascript
   import { alias } from '@ember/object/computed';
-   App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
+     App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
     target: alias('controller'),
     click() {
       this.triggerAction({
@@ -82,7 +82,7 @@ const TargetActionSupport = Mixin.create({
     }
   });
   ```
-   @method triggerAction
+     @method triggerAction
   @param opts {Object} (optional, with the optional keys action, target and/or actionContext)
   @return {Boolean} true if the action was sent successfully and did not return false
   @private

package/dist/packages/@ember/-internals/runtime/lib/system/namespace.js

@@ -1,5 +1,5 @@
 /**
-@module ember
+@module @ember/application
 */
 import { NAMESPACES, NAMESPACES_BY_ID, addNamespace, findNamespace, findNamespaces, get, processNamespace, processAllNamespaces, removeNamespace } from '@ember/-internals/metal'; // Preloaded into namespaces
 
@@ -19,7 +19,6 @@ import EmberObject from './object';
   ```
 
   @class Namespace
-  @namespace Ember
   @extends EmberObject
   @public
 */

package/dist/packages/@ember/-internals/runtime/lib/type-of.js

@@ -77,7 +77,7 @@ const {
 
   @method typeOf
   @for @ember/utils
-  @param {Object} item the item to check
+  @param item the item to check
   @return {String} the type
   @public
   @static

package/dist/packages/@ember/-internals/utils/index.js

@@ -140,7 +140,7 @@ const GUID_KEY = intern(`__ember${Date.now()}`);
 */
 
 function generateGuid(obj, prefix = GUID_PREFIX) {
-  let guid = prefix + uuid();
+  let guid = prefix + uuid().toString();
 
   if (isObject(obj)) {
     OBJECT_GUIDS.set(obj, guid);
@@ -170,7 +170,7 @@ function guidFor(value) {
     guid = OBJECT_GUIDS.get(value);
 
     if (guid === undefined) {
-      guid = GUID_PREFIX + uuid();
+      guid = `${GUID_PREFIX}${uuid()}`;
       OBJECT_GUIDS.set(value, guid);
     }
   } else {
@@ -180,13 +180,13 @@ function guidFor(value) {
       let type = typeof value;
 
       if (type === 'string') {
-        guid = 'st' + uuid();
+        guid = `st${uuid()}`;
       } else if (type === 'number') {
-        guid = 'nu' + uuid();
+        guid = `nu${uuid()}`;
       } else if (type === 'symbol') {
-        guid = 'sy' + uuid();
+        guid = `sy${uuid()}`;
       } else {
-        guid = '(' + value + ')';
+        guid = `(${value})`;
       }
 
       NON_OBJECT_GUIDS.set(value, guid);
@@ -207,7 +207,7 @@ function enumerableSymbol(debugName) {
   // TODO: Investigate using platform symbols, but we do not
   // want to require non-enumerability for this API, which
   // would introduce a large cost.
-  let id = GUID_KEY + Math.floor(Math.random() * Date.now());
+  let id = GUID_KEY + Math.floor(Math.random() * Date.now()).toString();
   let symbol = intern(`__${debugName}${id}__`);
 
   if (DEBUG) {
@@ -507,7 +507,9 @@ function inspectObject(obj, depth, seen) {
     }
 
     let key = keys[i];
-    s += inspectKey(key) + ': ' + inspectValue(obj[key], depth, seen);
+    assert('has key', key); // Looping over array
+
+    s += `${inspectKey(key)}: ${inspectValue(obj[key], depth, seen)}`;
   }
 
   s += ' }';
@@ -786,7 +788,7 @@ if (DEBUG) {
 
     if (setters !== undefined && setters[keyName] !== undefined) {
       Object.defineProperty(obj, keyName, setters[keyName]);
-      setters[keyName] = undefined;
+      delete setters[keyName];
     }
   };
 

package/dist/packages/@ember/-internals/views/lib/mixins/view_support.js

@@ -326,11 +326,9 @@ let mixin = {
    @private
    */
   init() {
-    this._super(...arguments); // tslint:disable-next-line:max-line-length
-
-
-    assert(`You cannot use a computed property for the component's \`elementId\` (${this}).`, descriptorForProperty(this, 'elementId') === undefined); // tslint:disable-next-line:max-line-length
+    this._super(...arguments);
 
+    assert(`You cannot use a computed property for the component's \`elementId\` (${this}).`, descriptorForProperty(this, 'elementId') === undefined);
     assert(`You cannot use a computed property for the component's \`tagName\` (${this}).`, descriptorForProperty(this, 'tagName') === undefined);
 
     if (!this.elementId && this.tagName !== '') {

package/dist/packages/@ember/-internals/views/lib/system/utils.js

@@ -27,6 +27,7 @@ export function getRootViews(owner) {
   let rootViews = [];
   Object.keys(registry).forEach(id => {
     let view = registry[id];
+    assert('expected view', view);
 
     if (view.parentView === null) {
       rootViews.push(view);
@@ -86,6 +87,7 @@ const CHILD_VIEW_IDS = new WeakMap();
 
 export function getChildViews(view) {
   let owner = getOwner(view);
+  assert('View is unexpectedly missing an owner', owner);
   let registry = owner.lookup('-view-registry:main');
   return collectChildViews(view, registry);
 }

package/dist/packages/@ember/application/lib/application.js

@@ -310,7 +310,6 @@ const Application = Engine.extend({
   _applicationInstances: null,
 
   init() {
-    // eslint-disable-line no-unused-vars
     this._super(...arguments);
 
     if (DEBUG) {
@@ -929,7 +928,6 @@ Application.reopenClass({
     @private
   */
   buildRegistry() {
-    // eslint-disable-line no-unused-vars
     let registry = this._super(...arguments);
 
     commonSetupRegistry(registry);

package/dist/packages/@ember/array/index.js

@@ -1,2 +1,2 @@
-export { Array as default, isArray, A } from '@ember/-internals/runtime';
+export { Array as default, NativeArray, isArray, A } from '@ember/-internals/runtime';
 export { makeArray } from '@ember/-internals/utils';

package/dist/packages/@ember/canary-features/index.js

@@ -11,8 +11,8 @@ import { ENV } from '@ember/-internals/environment';
 */
 
 export const DEFAULT_FEATURES = {
-  EMBER_LIBRARIES_ISREGISTERED: null,
-  EMBER_IMPROVED_INSTRUMENTATION: null,
+  EMBER_LIBRARIES_ISREGISTERED: false,
+  EMBER_IMPROVED_INSTRUMENTATION: false,
   EMBER_NAMED_BLOCKS: true,
   EMBER_GLIMMER_HELPER_MANAGER: true,
   EMBER_GLIMMER_INVOKE_HELPER: true,

package/dist/packages/@ember/controller/index.js

@@ -1,61 +1,10 @@
 import { FrameworkObject } from '@ember/-internals/runtime';
 import { inject as metalInject } from '@ember/-internals/metal';
 import ControllerMixin from './lib/controller_mixin';
-/**
-@module @ember/controller
-*/
 
-/**
-  @class Controller
-  @extends EmberObject
-  @uses Ember.ControllerMixin
-  @public
-*/
+class Controller extends FrameworkObject.extend(ControllerMixin) {}
 
-const Controller = FrameworkObject.extend(ControllerMixin);
-/**
-  Creates a property that lazily looks up another controller in the container.
-  Can only be used when defining another controller.
-
-  Example:
-
-  ```app/controllers/post.js
-  import Controller, {
-    inject as controller
-  } from '@ember/controller';
-
-  export default class PostController extends Controller {
-    @controller posts;
-  }
-  ```
-
-  Classic Class Example:
-
-  ```app/controllers/post.js
-  import Controller, {
-    inject as controller
-  } from '@ember/controller';
-
-  export default Controller.extend({
-    posts: controller()
-  });
-  ```
-
-  This example will create a `posts` property on the `post` controller that
-  looks up the `posts` controller in the container, making it easy to reference
-  other controllers.
-
-  @method inject
-  @static
-  @for @ember/controller
-  @since 1.10.0
-  @param {String} name (optional) name of the controller to inject, defaults to
-         the property's name
-  @return {ComputedDecorator} injection decorator instance
-  @public
-*/
-
-export function inject() {
-  return metalInject('controller', ...arguments);
+export function inject(...args) {
+  return metalInject('controller', ...args);
 }
 export default Controller;

package/dist/packages/@ember/debug/index.js

@@ -150,7 +150,7 @@ if (DEBUG) {
     } else {
       console.log(`DEBUG: ${message}`);
     }
-    /* eslint-ensable no-console */
+    /* eslint-enable no-console */
 
   });
   /**

package/dist/packages/@ember/debug/lib/deprecate.js

@@ -98,17 +98,19 @@ if (DEBUG) {
       let error = captureErrorForStack();
       let stack;
 
-      if (error.stack) {
-        if (error['arguments']) {
-          // Chrome
-          stack = error.stack.replace(/^\s+at\s+/gm, '').replace(/^([^(]+?)([\n$])/gm, '{anonymous}($1)$2').replace(/^Object.<anonymous>\s*\(([^)]+)\)/gm, '{anonymous}($1)').split('\n');
-          stack.shift();
-        } else {
-          // Firefox
-          stack = error.stack.replace(/(?:\n@:0)?\s+$/m, '').replace(/^\(/gm, '{anonymous}(').split('\n');
+      if (error instanceof Error) {
+        if (error.stack) {
+          if (error['arguments']) {
+            // Chrome
+            stack = error.stack.replace(/^\s+at\s+/gm, '').replace(/^([^(]+?)([\n$])/gm, '{anonymous}($1)$2').replace(/^Object.<anonymous>\s*\(([^)]+)\)/gm, '{anonymous}($1)').split('\n');
+            stack.shift();
+          } else {
+            // Firefox
+            stack = error.stack.replace(/(?:\n@:0)?\s+$/m, '').replace(/^\(/gm, '{anonymous}(').split('\n');
+          }
+
+          stackStr = `\n    ${stack.slice(2).join('\n    ')}`;
         }
-
-        stackStr = `\n    ${stack.slice(2).join('\n    ')}`;
       }
 
       let updatedMessage = formatMessage(message, options);