ember-source 4.2.0-alpha.6 → 4.3.0-alpha.2

package/dist/packages/@ember/-internals/routing/lib/ext/controller.js

@@ -144,10 +144,15 @@ ControllerMixin.reopen({
     @public
   */
   transitionToRoute(...args) {
+    var _a;
+
     deprecateTransitionMethods('controller', 'transitionToRoute'); // target may be either another controller or a router
 
-    let target = get(this, 'target');
-    let method = target.transitionToRoute || target.transitionTo;
+    let target = get(this, 'target'); // SAFETY: We can't actually assert that this is a full Controller or Router since some tests
+    // mock out an object that only has the single method. Since this is deprecated, I think it's
+    // ok to be a little less than proper here.
+
+    let method = (_a = target.transitionToRoute) !== null && _a !== void 0 ? _a : target.transitionTo;
     return method.apply(target, prefixRouteNameArg(this, args));
   },
 
@@ -201,10 +206,15 @@ ControllerMixin.reopen({
     @public
   */
   replaceRoute(...args) {
+    var _a;
+
     deprecateTransitionMethods('controller', 'replaceRoute'); // target may be either another controller or a router
 
-    let target = get(this, 'target');
-    let method = target.replaceRoute || target.replaceWith;
+    let target = get(this, 'target'); // SAFETY: We can't actually assert that this is a full Controller or Router since some tests
+    // mock out an object that only has the single method. Since this is deprecated, I think it's
+    // ok to be a little less than proper here.
+
+    let method = (_a = target.replaceRoute) !== null && _a !== void 0 ? _a : target.replaceWith;
     return method.apply(target, prefixRouteNameArg(this, args));
   }
 

package/dist/packages/@ember/-internals/routing/lib/location/api.js

@@ -93,6 +93,7 @@ export default {
       url: 'https://emberjs.com/deprecations/v4.x#toc_deprecate-auto-location',
       for: 'ember-source',
       since: {
+        available: '4.1.0',
         enabled: '4.1.0'
       }
     });

package/dist/packages/@ember/-internals/routing/lib/services/router.js

@@ -65,46 +65,6 @@ export default class RouterService extends Service {
     super.willDestroy(...arguments);
     this[ROUTER] = null;
   }
-  /**
-     Transition the application into another route. The route may
-     be either a single route or route path:
-        See [transitionTo](/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo) for more info.
-        Calling `transitionTo` from the Router service will cause default query parameter values to be included in the URL.
-     This behavior is different from calling `transitionTo` on a route or `transitionToRoute` on a controller.
-     See the [Router Service RFC](https://github.com/emberjs/rfcs/blob/master/text/0095-router-service.md#query-parameter-semantics) for more info.
-        In the following example we use the Router service to navigate to a route with a
-     specific model from a Component in the first action, and in the second we trigger
-     a query-params only transition.
-        ```app/components/example.js
-     import Component from '@glimmer/component';
-     import { action } from '@ember/object';
-     import { service } from '@ember/service';
-        export default class extends Component {
-       @service router;
-          @action
-       goToComments(post) {
-         this.router.transitionTo('comments', post);
-       }
-          @action
-       fetchMoreComments(latestComment) {
-         this.router.transitionTo({
-           queryParams: { commentsAfter: latestComment }
-         });
-       }
-     }
-     ```
-        @method transitionTo
-     @param {String} [routeNameOrUrl] the name of the route or a URL
-     @param {...Object} [models] the model(s) or identifier(s) to be used while
-       transitioning to the route.
-     @param {Object} [options] optional hash with a queryParams property
-       containing a mapping of query parameters. May be supplied as the only
-      parameter to trigger a query-parameter-only transition.
-     @return {Transition} the transition object associated with this
-       attempted transition
-     @public
-   */
-
 
   transitionTo(...args) {
     if (resemblesURL(args[0])) {
@@ -157,9 +117,7 @@ export default class RouterService extends Service {
    */
 
 
-  replaceWith()
-  /* routeNameOrUrl, ...models, options */
-  {
+  replaceWith() {
     return this.transitionTo(...arguments).method('replace');
   }
   /**
@@ -304,10 +262,7 @@ export default class RouterService extends Service {
       // does not correctly account for `undefined` values for `routeName`.
       //  Spoilers: under the hood this currently uses router.js APIs which
       // *do not* account for this being `undefined`.
-      routeName, models, // UNSAFE: downstream consumers treat this as `QueryParam`, which the
-      // type system here *correctly* reports as incorrect, because it may be
-      // just an empty object.
-      queryParams, true
+      routeName, models, queryParams, true
       /* fromRouterService */
       );
 

package/dist/packages/@ember/-internals/routing/lib/system/route.js

@@ -106,9 +106,10 @@ class Route extends EmberObject.extend(ActionHandler, Evented) {
     if (!names.length) {
       routeInfo = dynamicParent;
       names = routeInfo && routeInfo['_names'] || [];
-    }
+    } // SAFETY: Since `_qp` is protected we can't infer the type
+
 
-    let qps = get(this, '_qp.qps');
+    let qps = get(this, '_qp').qps;
     let namePaths = new Array(names.length);
 
     for (let a = 0; a < names.length; ++a) {
@@ -301,8 +302,9 @@ class Route extends EmberObject.extend(ActionHandler, Evented) {
 
 
   _internalReset(isExiting, transition) {
-    let controller = this.controller;
-    controller['_qpDelegate'] = get(this, '_qp.states.inactive');
+    let controller = this.controller; // SAFETY: Since `_qp` is protected we can't infer the type
+
+    controller['_qpDelegate'] = get(this, '_qp').states.inactive;
     this.resetController(controller, isExiting, transition);
   }
   /**
@@ -774,18 +776,18 @@ class Route extends EmberObject.extend(ActionHandler, Evented) {
       controller = definedController;
     } else {
       controller = this.generateController(controllerName);
-    } // Assign the route's controller so that it can more easily be
-    // referenced in action handlers. Side effects. Side effects everywhere.
+    } // SAFETY: Since `_qp` is protected we can't infer the type
+
 
+    let queryParams = get(this, '_qp'); // Assign the route's controller so that it can more easily be
+    // referenced in action handlers. Side effects. Side effects everywhere.
 
     if (!this.controller) {
-      let qp = get(this, '_qp');
-      let propNames = qp !== undefined ? get(qp, 'propertyNames') : [];
+      let propNames = queryParams.propertyNames;
       addQueryParamsObservers(controller, propNames);
       this.controller = controller;
     }
 
-    let queryParams = get(this, '_qp');
     let states = queryParams.states;
     controller._qpDelegate = states.allowOverrides;
 
@@ -994,8 +996,9 @@ class Route extends EmberObject.extend(ActionHandler, Evented) {
 
 
   model(params, transition) {
-    let name, sawParams, value;
-    let queryParams = get(this, '_qp.map');
+    let name, sawParams, value; // SAFETY: Since `_qp` is protected we can't infer the type
+
+    let queryParams = get(this, '_qp').map;
 
     for (let prop in params) {
       if (prop === 'queryParams' || queryParams && prop in queryParams) {
@@ -1105,7 +1108,6 @@ class Route extends EmberObject.extend(ActionHandler, Evented) {
 
 
   setupController(controller, context, _transition) {
-    // eslint-disable-line no-unused-vars
     if (controller && context !== undefined) {
       set(controller, 'model', context);
     }
@@ -1398,7 +1400,7 @@ class Route extends EmberObject.extend(ActionHandler, Evented) {
 
       let desc = combinedQueryParameterConfiguration[propName];
       let scope = desc.scope || 'model';
-      let parts;
+      let parts = undefined;
 
       if (scope === 'controller') {
         parts = [];
@@ -1594,13 +1596,12 @@ function buildRenderOptions(route, nameOrOptions, options) {
 }
 
 export function getFullQueryParams(router, state) {
-  if (state['fullQueryParams']) {
-    return state['fullQueryParams'];
+  if (state.fullQueryParams) {
+    return state.fullQueryParams;
   }
 
-  let fullQueryParamsState = {};
   let haveAllRouteInfosResolved = state.routeInfos.every(routeInfo => routeInfo.route);
-  Object.assign(fullQueryParamsState, state.queryParams);
+  let fullQueryParamsState = Object.assign({}, state.queryParams);
 
   router._deserializeQueryParams(state.routeInfos, fullQueryParamsState); // only cache query params state if all routeinfos have resolved; it's possible
   // for lazy routes to not have resolved when `getFullQueryParams` is called, so
@@ -1608,24 +1609,25 @@ export function getFullQueryParams(router, state) {
 
 
   if (haveAllRouteInfosResolved) {
-    state['fullQueryParams'] = fullQueryParamsState;
+    state.fullQueryParams = fullQueryParamsState;
   }
 
   return fullQueryParamsState;
 }
 
 function getQueryParamsFor(route, state) {
-  state['queryParamsFor'] = state['queryParamsFor'] || {};
+  state.queryParamsFor = state.queryParamsFor || {};
   let name = route.fullRouteName;
 
-  if (state['queryParamsFor'][name]) {
-    return state['queryParamsFor'][name];
+  if (state.queryParamsFor[name]) {
+    return state.queryParamsFor[name];
   }
 
   let fullQueryParams = getFullQueryParams(route._router, state);
-  let params = state['queryParamsFor'][name] = {}; // Copy over all the query params for this route/controller into params hash.
+  let params = state.queryParamsFor[name] = {}; // Copy over all the query params for this route/controller into params hash.
+  // SAFETY: Since `_qp` is protected we can't infer the type
 
-  let qps = get(route, '_qp.qps');
+  let qps = get(route, '_qp').qps;
 
   for (let i = 0; i < qps.length; ++i) {
     // Put deserialized qp on params hash.
@@ -1824,15 +1826,22 @@ Route.reopen({
     @private
     */
     queryParamsDidChange(changed, _totalPresent, removed) {
+      // SAFETY: Since `_qp` is protected we can't infer the type
       let qpMap = get(this, '_qp').map;
       let totalChanged = Object.keys(changed).concat(Object.keys(removed));
 
       for (let i = 0; i < totalChanged.length; ++i) {
         let qp = qpMap[totalChanged[i]];
 
-        if (qp && get(this._optionsForQueryParam(qp), 'refreshModel') && this._router.currentState) {
-          this.refresh();
-          break;
+        if (qp) {
+          let options = this._optionsForQueryParam(qp);
+
+          assert('options exists', options && typeof options === 'object');
+
+          if (get(options, 'refreshModel') && this._router.currentState) {
+            this.refresh();
+            break;
+          }
         }
       }
 
@@ -1867,7 +1876,8 @@ Route.reopen({
         // param URL key corresponds to a QP property on
         // this controller.
 
-        let value, svalue;
+        let value;
+        let svalue;
 
         if (changes.has(qp.urlKey)) {
           // Value updated in/before setupController
@@ -1885,9 +1895,10 @@ Route.reopen({
             svalue = qp.serializedDefaultValue;
             value = copyDefaultValue(qp.defaultValue);
           }
-        }
+        } // SAFETY: Since `_qp` is protected we can't infer the type
+
 
-        controller._qpDelegate = get(route, '_qp.states.inactive');
+        controller._qpDelegate = get(route, '_qp').states.inactive;
         let thisQueryParamChanged = svalue !== qp.serializedValue;
 
         if (thisQueryParamChanged) {
@@ -1932,6 +1943,7 @@ Route.reopen({
       }
 
       qpMeta.qps.forEach(qp => {
+        // SAFETY: Since `_qp` is protected we can't infer the type
         let routeQpMeta = get(qp.route, '_qp');
         let finalizedController = qp.route.controller;
         finalizedController['_qpDelegate'] = get(routeQpMeta, 'states.active');

package/dist/packages/@ember/-internals/routing/lib/system/router.js

@@ -80,7 +80,8 @@ class EmberRouter extends EmberObject.extend(Evented) {
     this.currentRouteName = null;
     this.currentPath = null;
     this.currentRoute = null;
-    this._qpCache = Object.create(null);
+    this._qpCache = Object.create(null); // Set of QueryParam['urlKey']
+
     this._qpUpdates = new Set();
     this._queuedQPChanges = {};
     this._toplevelView = null;
@@ -580,8 +581,8 @@ class EmberRouter extends EmberObject.extend(Evented) {
       let infos = this._routerMicrolib.currentRouteInfos;
 
       if (this.namespace.LOG_TRANSITIONS) {
-        // eslint-disable-next-line no-console
-        assert('expected infos to be set', infos);
+        assert('expected infos to be set', infos); // eslint-disable-next-line no-console
+
         console.log(`Intermediate-transitioned into '${EmberRouter._routePath(infos)}'`);
       }
     }
@@ -686,7 +687,8 @@ class EmberRouter extends EmberObject.extend(Evented) {
   _activeQPChanged(queryParameterName, newValue) {
     this._queuedQPChanges[queryParameterName] = newValue;
     once(this, this._fireQueryParamTransition);
-  }
+  } // The queryParameterName is QueryParam['urlKey']
+
 
   _updatingQPChanged(queryParameterName) {
     this._qpUpdates.add(queryParameterName);
@@ -729,6 +731,7 @@ class EmberRouter extends EmberObject.extend(Evented) {
           url: 'https://emberjs.com/deprecations/v4.x#toc_deprecate-auto-location',
           for: 'ember-source',
           since: {
+            available: '4.1.0',
             enabled: '4.1.0'
           }
         });
@@ -761,6 +764,7 @@ class EmberRouter extends EmberObject.extend(Evented) {
             url: 'https://emberjs.com/deprecations/v4.x#toc_deprecate-auto-location',
             for: 'ember-source',
             since: {
+              available: '4.1.0',
               enabled: '4.1.0'
             }
           });

package/dist/packages/@ember/-internals/routing/lib/utils.js

@@ -6,16 +6,14 @@ import { STATE_SYMBOL } from 'router_js';
 const ALL_PERIODS_REGEX = /\./g;
 export function extractRouteArgs(args) {
   args = args.slice();
-  let possibleQueryParams = args[args.length - 1];
+  let possibleQueryParams = args.pop();
   let queryParams;
 
-  if (possibleQueryParams && Object.prototype.hasOwnProperty.call(possibleQueryParams, 'queryParams')) {
-    // SAFETY: this cast is safe because we have just checked whether
-    // `possibleQueryParams` -- defined as the last item in args -- both exists
-    // and has the property `queryParams`. If either of these invariants change,
-    // ***this is unsafe and should be changed***.
-    queryParams = args.pop().queryParams;
+  if (hasQueryParams(possibleQueryParams)) {
+    queryParams = possibleQueryParams.queryParams;
   } else {
+    // Not query params so return to the array
+    args.push(possibleQueryParams);
     queryParams = {};
   } // UNSAFE: these are simply assumed as the existing behavior of the system.
   // However, this could break if upstream refactors change it, and the types
@@ -185,12 +183,12 @@ function accumulateQueryParamDescriptors(_desc, accum) {
       };
     }
 
-    tmp = accum[key] || {
+    let val = accum[key] || {
       as: null,
       scope: 'model'
     };
-    Object.assign(tmp, singleDesc);
-    accum[key] = tmp;
+    Object.assign(val, singleDesc);
+    accum[key] = val;
   }
 }
 /*
@@ -253,9 +251,22 @@ export function deprecateTransitionMethods(frameworkClass, methodName) {
     id: 'routing.transition-methods',
     for: 'ember-source',
     since: {
+      available: '3.26.0',
       enabled: '3.26.0'
     },
     until: '5.0.0',
     url: 'https://deprecations.emberjs.com/v3.x/#toc_routing-transition-methods'
   });
+}
+
+function hasQueryParams(value) {
+  if (value && typeof value === 'object') {
+    let qps = value.queryParams;
+
+    if (qps && typeof qps === 'object') {
+      return Object.keys(qps).every(k => typeof k === 'string');
+    }
+  }
+
+  return false;
 }

package/dist/packages/@ember/-internals/utils/index.js

@@ -786,7 +786,7 @@ if (DEBUG) {
 
     if (setters !== undefined && setters[keyName] !== undefined) {
       Object.defineProperty(obj, keyName, setters[keyName]);
-      setters[keyName] = undefined;
+      delete setters[keyName];
     }
   };
 

package/dist/packages/@ember/-internals/views/lib/mixins/view_support.js

@@ -326,11 +326,9 @@ let mixin = {
    @private
    */
   init() {
-    this._super(...arguments); // tslint:disable-next-line:max-line-length
-
-
-    assert(`You cannot use a computed property for the component's \`elementId\` (${this}).`, descriptorForProperty(this, 'elementId') === undefined); // tslint:disable-next-line:max-line-length
+    this._super(...arguments);
 
+    assert(`You cannot use a computed property for the component's \`elementId\` (${this}).`, descriptorForProperty(this, 'elementId') === undefined);
     assert(`You cannot use a computed property for the component's \`tagName\` (${this}).`, descriptorForProperty(this, 'tagName') === undefined);
 
     if (!this.elementId && this.tagName !== '') {

package/dist/packages/@ember/application/lib/application.js

@@ -310,7 +310,6 @@ const Application = Engine.extend({
   _applicationInstances: null,
 
   init() {
-    // eslint-disable-line no-unused-vars
     this._super(...arguments);
 
     if (DEBUG) {
@@ -929,7 +928,6 @@ Application.reopenClass({
     @private
   */
   buildRegistry() {
-    // eslint-disable-line no-unused-vars
     let registry = this._super(...arguments);
 
     commonSetupRegistry(registry);

package/dist/packages/@ember/debug/index.js

@@ -150,7 +150,7 @@ if (DEBUG) {
     } else {
       console.log(`DEBUG: ${message}`);
     }
-    /* eslint-ensable no-console */
+    /* eslint-enable no-console */
 
   });
   /**

package/dist/packages/@ember/debug/lib/deprecate.js

@@ -98,17 +98,19 @@ if (DEBUG) {
       let error = captureErrorForStack();
       let stack;
 
-      if (error.stack) {
-        if (error['arguments']) {
-          // Chrome
-          stack = error.stack.replace(/^\s+at\s+/gm, '').replace(/^([^(]+?)([\n$])/gm, '{anonymous}($1)$2').replace(/^Object.<anonymous>\s*\(([^)]+)\)/gm, '{anonymous}($1)').split('\n');
-          stack.shift();
-        } else {
-          // Firefox
-          stack = error.stack.replace(/(?:\n@:0)?\s+$/m, '').replace(/^\(/gm, '{anonymous}(').split('\n');
+      if (error instanceof Error) {
+        if (error.stack) {
+          if (error['arguments']) {
+            // Chrome
+            stack = error.stack.replace(/^\s+at\s+/gm, '').replace(/^([^(]+?)([\n$])/gm, '{anonymous}($1)$2').replace(/^Object.<anonymous>\s*\(([^)]+)\)/gm, '{anonymous}($1)').split('\n');
+            stack.shift();
+          } else {
+            // Firefox
+            stack = error.stack.replace(/(?:\n@:0)?\s+$/m, '').replace(/^\(/gm, '{anonymous}(').split('\n');
+          }
+
+          stackStr = `\n    ${stack.slice(2).join('\n    ')}`;
         }
-
-        stackStr = `\n    ${stack.slice(2).join('\n    ')}`;
       }
 
       let updatedMessage = formatMessage(message, options);

package/dist/packages/@ember/polyfills/lib/assign.js

@@ -28,6 +28,7 @@ export function assign(target, ...rest) {
     url: 'https://deprecations.emberjs.com/v4.x/#toc_ember-polyfills-deprecate-assign',
     for: 'ember-source',
     since: {
+      available: '4.0.0',
       enabled: '4.0.0'
     }
   });

package/dist/packages/@ember/runloop/index.js

@@ -308,9 +308,9 @@ export function end() {
   @public
 */
 
-export function schedule()
-/* queue, target, method */
-{
+export function
+  /* queue, target, method */
+schedule() {
   return _backburner.schedule(...arguments);
 } // Used by global test teardown
 
@@ -352,9 +352,9 @@ export function _cancelTimers() {
   @public
 */
 
-export function later()
-/*target, method*/
-{
+export function
+  /*target, method*/
+later() {
   return _backburner.later(...arguments);
 }
 /**
@@ -450,9 +450,9 @@ export function once(...args) {
   @public
 */
 
-export function scheduleOnce()
-/* queue, target, method*/
-{
+export function
+  /* queue, target, method*/
+scheduleOnce() {
   return _backburner.scheduleOnce(...arguments);
 }
 /**

package/dist/packages/@ember/string/index.js

@@ -212,6 +212,7 @@ function deprecateImportFromString(name, message = `Importing ${name} from '@emb
     id: 'ember-string.htmlsafe-ishtmlsafe',
     for: 'ember-source',
     since: {
+      available: '3.25',
       enabled: '3.25'
     },
     until: '4.0.0',

package/dist/packages/ember/index.js

@@ -16,8 +16,7 @@ import Service, { service } from '@ember/service';
 import { action, computed } from '@ember/object';
 import { dependentKeyCompat } from '@ember/object/compat';
 import { Object as EmberObject, RegistryProxyMixin, ContainerProxyMixin, compare, isEqual, Array as EmberArray, MutableEnumerable, MutableArray, Evented, PromiseProxyMixin, Observable, typeOf, isArray, _ProxyMixin, RSVP, Comparable, Namespace, Enumerable, ArrayProxy, ObjectProxy, ActionHandler, CoreObject, NativeArray, A } from '@ember/-internals/runtime';
-import { Component, componentCapabilities, modifierCapabilities, setComponentManager, escapeExpression, getTemplates, Helper, helper, htmlSafe, isHTMLSafe, setTemplates, template, Input, isSerializationFirstNode } from '@ember/-internals/glimmer'; // eslint-disable-next-line import/no-unresolved
-
+import { Component, componentCapabilities, modifierCapabilities, setComponentManager, escapeExpression, getTemplates, Helper, helper, htmlSafe, isHTMLSafe, setTemplates, template, Input, isSerializationFirstNode } from '@ember/-internals/glimmer';
 import VERSION from './version';
 import * as views from '@ember/-internals/views';
 import * as routing from '@ember/-internals/routing';

package/dist/packages/ember/version.js

@@ -1 +1 @@
-export default "4.2.0-alpha.6";
+export default "4.3.0-alpha.2";