ember-source 4.0.0-beta.5 → 4.0.0-beta.9

package/CHANGELOG.md

@@ -1,5 +1,34 @@
 # Ember Changelog
 
+### v4.0.0-beta.9 (November 20, 2021)
+
+- [#19749](https://github.com/emberjs/ember.js/pull/19749) [CLEANUP] Remove `deprecate-router-events` support code
+- [#19762](https://github.com/emberjs/ember.js/pull/19762) [CLEANUP] Update GlimmerVM to 0.81
+  - removes deprecation of mutations during helper compute 
+  - removes deprecation of mutations during unknownProperty
+  - `@glimmer/integration-tests`, `@glimmer/manager`, `@glimmer/validator`
+    * [#1330](https://github.com/glimmerjs/glimmer-vm/pull/1330) Remove deprecated support for mutation after consumption during certain manager hooks ([@snewcomer](https://github.com/snewcomer))
+  - `@glimmer/manager`
+    * [#1328](https://github.com/glimmerjs/glimmer-vm/pull/1328) Remove deprecated Component Manager version 3.4 ([@nlfurniss](https://github.com/nlfurniss))
+  - `@glimmer/integration-tests`, `@glimmer/manager`
+    * [#1329](https://github.com/glimmerjs/glimmer-vm/pull/1329) Remove deprecated Modifier Manager version 3.13 ([@nlfurniss](https://github.com/nlfurniss))
+- [#19806](https://github.com/emberjs/ember.js/pull/19806) [CLEANUP] Drop export of built-ins, remove legacy components 
+
+### v4.0.0-beta.8 (November 5, 2021)
+
+- [#19823](https://github.com/emberjs/ember.js/pull/19823) / [#19828](https://github.com/emberjs/ember.js/pull/19828) [BUGFIX] Fix deprecation `until` and link for Component.reopenClass and Component.reopen
+- [#19825](https://github.com/emberjs/ember.js/pull/19825) [BUGFIX] Replace `assert.equal` in blueprints with `assert.strictEqual` to pass eslint-plugin-qunit v7 on generation
+- [#19808](https://github.com/emberjs/ember.js/pull/19808) [CLEANUP] Remove the `--test-type` option from the helper blueprint
+- [#19820](https://github.com/emberjs/ember.js/pull/19820) Fix memory leak when looking up non-instantiable objects from the owner
+
+### v4.0.0-beta.7 (November 1, 2021)
+
+- [#19677](https://github.com/emberjs/ember.js/pull/19677) [CLEANUP] Remove jQuery from build
+
+### v4.0.0-beta.6 (October 26, 2021)
+
+- [#19799](https://github.com/emberjs/ember.js/pull/19799) / [glimmerjs/glimmer-vm#1354](https://github.com/glimmerjs/glimmer-vm/pull/1354) Fixes for errors while precompiling inline templates (introduced in 3.28.2)
+
 ### v4.0.0-beta.5 (October 11, 2021)
 
 - [#19761](https://github.com/emberjs/ember.js/pull/19761) [BREAKING] Require ember-auto-import >= 2 or higher to enable ember-source to become a v2 addon in the 4.x cycle
@@ -65,7 +94,19 @@
 - [#19695](https://github.com/emberjs/ember.js/pull/19695) [CLEANUP] Remove {{partial}}
 - [#19691](https://github.com/emberjs/ember.js/pull/19691) Add build assertion against `{{outlet named}}`
 
-### v3.28.1 (August 30, 2021)
+## v3.28.5 (November 3, 2021)
+
+- [#19820](https://github.com/emberjs/ember.js/pull/19820) Fix memory leak when looking up non-instantiable objects from the owner
+
+## v3.28.3 (October 22, 2021)
+
+- [#19799](https://github.com/emberjs/ember.js/pull/19799) / [glimmerjs/glimmer-vm#1354](https://github.com/glimmerjs/glimmer-vm/pull/1354) Fixes for errors while precompiling inline templates (introduced in 3.28.2)
+
+## v3.28.2 (October 21, 2021)
+
+- [glimmerjs/glimmer-vm#1351](https://github.com/glimmerjs/glimmer-vm/pull/1351) Support lexical scope in loose mode
+
+## v3.28.1 (August 30, 2021)
 
 - [#19733](https://github.com/emberjs/ember.js/pull/19733) [BUGFIX] Ensure that using `routerService.urlFor(...)` and `routerService.recognize(...)` does not error if the router is not fully initialized
 

package/blueprints/acceptance-test/qunit-files/tests/acceptance/__name__-test.js

@@ -7,6 +7,6 @@ test('visiting /<%= dasherizedModuleName %>', function(assert) {
   visit('/<%= dasherizedModuleName %>');
 
   andThen(function() {
-    assert.equal(currentURL(), '/<%= dasherizedModuleName %>');
+    assert.strictEqual(currentURL(), '/<%= dasherizedModuleName %>');
   });
 });

package/blueprints/acceptance-test/qunit-rfc-232-files/tests/acceptance/__name__-test.js

@@ -8,6 +8,6 @@ module('<%= friendlyTestName %>', function(hooks) {
   test('visiting /<%= dasherizedModuleName %>', async function(assert) {
     await visit('/<%= dasherizedModuleName %>');
 
-    assert.equal(currentURL(), '/<%= dasherizedModuleName %>');
+    assert.strictEqual(currentURL(), '/<%= dasherizedModuleName %>');
   });
 });

package/blueprints/component-test/qunit-files/__root__/__testType__/__path__/__test__.js

@@ -13,7 +13,7 @@ test('it renders', function(assert) {
 
   this.render(hbs`<%= selfCloseComponent(componentName) %>`);
 
-  assert.equal(this.$().text().trim(), '');
+  assert.strictEqual(this.$().text().trim(), '');
 
   // Template block usage:
   this.render(hbs`
@@ -22,10 +22,10 @@ test('it renders', function(assert) {
     <%= closeComponent(componentName) %>
   `);
 
-  assert.equal(this.$().text().trim(), 'template block text');<% } else if(testType === 'unit') { %>
+  assert.strictEqual(this.$().text().trim(), 'template block text');<% } else if(testType === 'unit') { %>
   // Creates the component instance
   /*let component =*/ this.subject();
   // Renders the component to the page
   this.render();
-  assert.equal(this.$().text().trim(), '');<% } %>
+  assert.strictEqual(this.$().text().trim(), '');<% } %>
 });

package/blueprints/helper-test/index.js

@@ -7,29 +7,15 @@ const semver = require('semver');
 const useTestFrameworkDetector = require('../test-framework-detector');
 
 module.exports = useTestFrameworkDetector({
-  description: 'Generates a helper integration test or a unit test.',
-
-  availableOptions: [
-    {
-      name: 'test-type',
-      type: ['integration', 'unit'],
-      default: 'integration',
-      aliases: [
-        { i: 'integration' },
-        { u: 'unit' },
-        { integration: 'integration' },
-        { unit: 'unit' },
-      ],
-    },
-  ],
+  description: 'Generates a helper integration test.',
 
   fileMapTokens: function () {
     return {
       __root__() {
         return 'tests';
       },
-      __testType__(options) {
-        return options.locals.testType || 'integration';
+      __testType__() {
+        return 'integration';
       },
       __collection__() {
         return 'helpers';
@@ -38,9 +24,7 @@ module.exports = useTestFrameworkDetector({
   },
 
   locals: function (options) {
-    let testType = options.testType || 'integration';
-    let testName = testType === 'integration' ? 'Integration' : 'Unit';
-    let friendlyTestName = [testName, 'Helper', options.entity.name].join(' | ');
+    let friendlyTestName = ['Integration', 'Helper', options.entity.name].join(' | ');
     let dasherizedModulePrefix = stringUtils.dasherize(options.project.config().modulePrefix);
 
     let hbsImportStatement = this._useNamedHbsImport()
@@ -48,7 +32,6 @@ module.exports = useTestFrameworkDetector({
       : "import hbs from 'htmlbars-inline-precompile';";
 
     return {
-      testType,
       friendlyTestName,
       dasherizedModulePrefix,
       hbsImportStatement,
@@ -68,7 +51,6 @@ module.exports = useTestFrameworkDetector({
   afterInstall: function (options) {
     if (
       !options.dryRun &&
-      options.testType === 'integration' &&
       !this._useNamedHbsImport() &&
       isPackageMissing(this, 'ember-cli-htmlbars-inline-precompile')
     ) {

package/blueprints/helper-test/mocha-0.12-files/__root__/__testType__/__collection__/__name__-test.js

@@ -1,5 +1,5 @@
 import { expect } from 'chai';
-<% if (testType == 'integration') { %>import { describe, it } from 'mocha';
+import { describe, it } from 'mocha';
 import { setupComponentTest } from 'ember-mocha';
 import hbs from 'htmlbars-inline-precompile';
 
@@ -24,15 +24,3 @@ describe('<%= friendlyTestName %>', function() {
     expect(this.$().text().trim()).to.equal('1234');
   });
 });
-<% } else if (testType == 'unit') { %>import { describe, it } from 'mocha';
-import { <%= camelizedModuleName %> } from '<%= dasherizedPackageName %>/helpers/<%= dasherizedModuleName %>';
-
-describe('<%= friendlyTestName %>', function() {
-
-  // TODO: Replace this with your real tests.
-  it('works', function() {
-    let result = <%= camelizedModuleName %>(42);
-    expect(result).to.be.ok;
-  });
-});
-<% } %>

package/blueprints/helper-test/mocha-files/__root__/__testType__/__collection__/__name__-test.js

@@ -1,5 +1,4 @@
 import { expect } from 'chai';
-<% if (testType == 'integration') { %>
 import { describeComponent, it } from 'ember-mocha';
 import hbs from 'htmlbars-inline-precompile';
 
@@ -25,15 +24,3 @@ describeComponent('<%= dasherizedModuleName %>', 'helper:<%= dasherizedModuleNam
     });
   }
 );
-<% } else if (testType == 'unit') { %>import { describe, it } from 'mocha';
-import { <%= camelizedModuleName %> } from '<%= dasherizedPackageName %>/helpers/<%= dasherizedModuleName %>';
-
-describe('<%= friendlyTestName %>', function() {
-
-  // TODO: Replace this with your real tests.
-  it('works', function() {
-    let result = <%= camelizedModuleName %>(42);
-    expect(result).to.be.ok;
-  });
-});
-<% } %>

package/blueprints/helper-test/mocha-rfc-232-files/__root__/__testType__/__collection__/__name__-test.js

@@ -1,5 +1,5 @@
 import { expect } from 'chai';
-<% if (testType == 'integration') { %>import { describe, it } from 'mocha';
+import { describe, it } from 'mocha';
 import { setupRenderingTest } from 'ember-mocha';
 import { render } from '@ember/test-helpers';
 <%= hbsImportStatement %>
@@ -15,14 +15,4 @@ describe('<%= friendlyTestName %>', function() {
 
     expect(this.element.textContent.trim()).to.equal('1234');
   });
-});<% } else if (testType == 'unit') { %>import { describe, it } from 'mocha';
-import { <%= camelizedModuleName %> } from '<%= dasherizedPackageName %>/helpers/<%= dasherizedModuleName %>';
-
-describe('<%= friendlyTestName %>', function() {
-
-  // TODO: Replace this with your real tests.
-  it('works', function() {
-    let result = <%= camelizedModuleName %>(42);
-    expect(result).to.be.ok;
-  });
-});<% } %>
+});

package/blueprints/helper-test/qunit-files/__root__/__testType__/__collection__/__name__-test.js

@@ -1,4 +1,4 @@
-<% if (testType == 'integration') { %>import { moduleForComponent, test } from 'ember-qunit';
+import { moduleForComponent, test } from 'ember-qunit';
 import hbs from 'htmlbars-inline-precompile';
 
 moduleForComponent('<%= dasherizedModuleName %>', 'helper:<%= dasherizedModuleName %>', {
@@ -11,16 +11,5 @@ test('it renders', function(assert) {
 
   this.render(hbs`{{<%= dasherizedModuleName %> this.inputValue}}`);
 
-  assert.equal(this.$().text().trim(), '1234');
-});<% } else if (testType == 'unit') { %>
-import { <%= camelizedModuleName %> } from '<%= dasherizedModulePrefix %>/helpers/<%= dasherizedModuleName %>';
-import { module, test } from 'qunit';
-
-module('<%= friendlyTestName %>');
-
-// TODO: Replace this with your real tests.
-test('it works', function(assert) {
-  let result = <%= camelizedModuleName %>([42]);
-  assert.ok(result);
+  assert.strictEqual(this.$().text().trim(), '1234');
 });
-<% } %>

package/blueprints/helper-test/qunit-rfc-232-files/__root__/__testType__/__collection__/__name__-test.js

@@ -1,4 +1,4 @@
-<% if (testType === 'integration') { %>import { module, test } from 'qunit';
+import { module, test } from 'qunit';
 import { setupRenderingTest } from 'ember-qunit';
 import { render } from '@ember/test-helpers';
 <%= hbsImportStatement %>
@@ -14,16 +14,4 @@ module('<%= friendlyTestName %>', function(hooks) {
 
     assert.dom(this.element).hasText('1234');
   });
-});<% } else if (testType === 'unit') { %>import { <%= camelizedModuleName %> } from '<%= dasherizedModulePrefix %>/helpers/<%= dasherizedModuleName %>';
-import { module, test } from 'qunit';
-import { setupTest } from 'ember-qunit';
-
-module('<%= friendlyTestName %>', function(hooks) {
-  setupTest(hooks);
-
-  // TODO: Replace this with your real tests.
-  test('it works', function(assert) {
-    let result = <%= camelizedModuleName %>([42]);
-    assert.ok(result);
-  });
-});<% } %>
+});

package/build-metadata.json

@@ -1,6 +1,6 @@
 {
-  "version": "4.0.0-beta.5",
+  "version": "4.0.0-beta.9",
   "buildType": "tag",
-  "SHA": "1b443eccb4d119b2a5151f67ffa7a052a23991f4",
-  "assetPath": "/tag/shas/1b443eccb4d119b2a5151f67ffa7a052a23991f4.tgz"
+  "SHA": "c4be3a86a7c03860bde7f4928ff6fc54a3216e24",
+  "assetPath": "/tag/shas/c4be3a86a7c03860bde7f4928ff6fc54a3216e24.tgz"
 }

package/dist/dependencies/@glimmer/manager.js

@@ -1,9 +1,8 @@
 import { DEBUG } from '@glimmer/env';
-import { debugToString, _WeakSet, HAS_NATIVE_PROXY, assign, dict } from '@glimmer/util';
+import { debugToString, _WeakSet, HAS_NATIVE_PROXY } from '@glimmer/util';
 import { valueForRef, createConstRef, createComputeRef, UNDEFINED_REFERENCE } from '@glimmer/reference';
-import { track, deprecateMutationsInTrackingTransaction, createUpdatableTag, untrack } from '@glimmer/validator';
+import { track, createUpdatableTag, untrack } from '@glimmer/validator';
 import { registerDestructor, associateDestroyableChild } from '@glimmer/destroyable';
-import { setOwner } from '@glimmer/owner';
 
 const COMPONENT_MANAGERS = new WeakMap();
 const MODIFIER_MANAGERS = new WeakMap();
@@ -382,16 +381,11 @@ const CAPABILITIES = {
   hasSubOwner: false
 };
 function componentCapabilities(managerAPI, options = {}) {
-  if (DEBUG && managerAPI !== '3.4' && managerAPI !== '3.13') {
+  if (DEBUG && managerAPI !== '3.13') {
     throw new Error('Invalid component manager compatibility specified');
   }
 
-  let updateHook = true;
-
-  if (managerAPI === '3.13') {
-    updateHook = Boolean(options.updateHook);
-  }
-
+  let updateHook = Boolean(options.updateHook);
   return buildCapabilities({
     asyncLifeCycleCallbacks: Boolean(options.asyncLifecycleCallbacks),
     destructor: Boolean(options.destructor),
@@ -456,7 +450,7 @@ class CustomComponentManager {
 
       if (DEBUG && !FROM_CAPABILITIES.has(delegate.capabilities)) {
         // TODO: This error message should make sense in both Ember and Glimmer https://github.com/glimmerjs/glimmer-vm/issues/1200
-        throw new Error(`Custom component managers must have a \`capabilities\` property that is the result of calling the \`capabilities('3.4' | '3.13')\` (imported via \`import { capabilities } from '@ember/component';\`). Received: \`${JSON.stringify(delegate.capabilities)}\` for: \`${delegate}\``);
+        throw new Error(`Custom component managers must have a \`capabilities\` property that is the result of calling the \`capabilities('3.13')\` (imported via \`import { capabilities } from '@ember/component';\`). Received: \`${JSON.stringify(delegate.capabilities)}\` for: \`${delegate}\``);
       }
 
       componentManagerDelegates.set(owner, delegate);
@@ -468,16 +462,7 @@ class CustomComponentManager {
   create(owner, definition, vmArgs) {
     let delegate = this.getDelegateFor(owner);
     let args = argsProxyFor(vmArgs.capture(), 'component');
-    let component;
-
-    if (DEBUG && deprecateMutationsInTrackingTransaction !== undefined) {
-      deprecateMutationsInTrackingTransaction(() => {
-        component = delegate.createComponent(definition, args);
-      });
-    } else {
-      component = delegate.createComponent(definition, args);
-    }
-
+    let component = delegate.createComponent(definition, args);
     return new CustomComponentState(component, delegate, args);
   }
 
@@ -563,16 +548,12 @@ class CustomComponentState {
 }
 
 function modifierCapabilities(managerAPI, optionalFeatures = {}) {
-  if (DEBUG && managerAPI !== '3.13' && managerAPI !== '3.22') {
+  if (DEBUG && managerAPI !== '3.22') {
     throw new Error('Invalid modifier manager compatibility specified');
   }
 
   return buildCapabilities({
-    disableAutoTracking: Boolean(optionalFeatures.disableAutoTracking),
-    useArgsProxy: managerAPI === '3.13' ? false : true,
-    // This capability is used in Ember, exclusively in resolution mode. See the
-    // Ember glimmer resolver for details.
-    passFactoryToCreate: managerAPI === '3.13'
+    disableAutoTracking: Boolean(optionalFeatures.disableAutoTracking)
   });
 }
 /**
@@ -620,7 +601,7 @@ class CustomModifierManager {
 
       if (DEBUG && !FROM_CAPABILITIES.has(delegate.capabilities)) {
         // TODO: This error message should make sense in both Ember and Glimmer https://github.com/glimmerjs/glimmer-vm/issues/1200
-        throw new Error(`Custom modifier managers must have a \`capabilities\` property that is the result of calling the \`capabilities('3.13' | '3.22')\` (imported via \`import { capabilities } from '@ember/modifier';\`). Received: \`${JSON.stringify(delegate.capabilities)}\` for: \`${delegate}\``);
+        throw new Error(`Custom modifier managers must have a \`capabilities\` property that is the result of calling the \`capabilities('3.22')\` (imported via \`import { capabilities } from '@ember/modifier';\`). Received: \`${JSON.stringify(delegate.capabilities)}\` for: \`${delegate}\``);
       }
 
       componentManagerDelegates.set(owner, delegate);
@@ -631,67 +612,23 @@ class CustomModifierManager {
 
   create(owner, element, definition, capturedArgs) {
     let delegate = this.getDelegateFor(owner);
-    let {
-      useArgsProxy,
-      passFactoryToCreate
-    } = delegate.capabilities;
-    let argsProxy = argsProxyFor(capturedArgs, 'modifier');
-    let args = useArgsProxy ? argsProxy : reifyArgs(capturedArgs);
-    let instance;
-    let factoryOrDefinition = definition;
-
-    if (passFactoryToCreate) {
-      // Make a fake factory. While not perfect, this should generally prevent
-      // breakage in users of older modifier capabilities.
-      factoryOrDefinition = {
-        create(args) {
-          let params = assign({}, args);
-          setOwner(params, owner);
-          return definition.create(args);
-        },
-
-        class: definition
-      };
-    }
-
-    if (DEBUG && deprecateMutationsInTrackingTransaction !== undefined) {
-      deprecateMutationsInTrackingTransaction(() => {
-        instance = delegate.createModifier(factoryOrDefinition, args);
-      });
-    } else {
-      instance = delegate.createModifier(factoryOrDefinition, args);
-    }
-
+    let args = argsProxyFor(capturedArgs, 'modifier');
+    let instance = delegate.createModifier(definition, args);
     let tag = createUpdatableTag();
     let state;
-
-    if (useArgsProxy) {
-      state = {
-        tag,
-        element,
-        delegate,
-        args,
-        modifier: instance
-      };
-    } else {
-      state = {
-        tag,
-        element,
-        modifier: instance,
-        delegate,
-
-        get args() {
-          return reifyArgs(capturedArgs);
-        }
-
-      };
-    }
+    state = {
+      tag,
+      element,
+      delegate,
+      args,
+      modifier: instance
+    };
 
     if (DEBUG) {
       state.debugName = typeof definition === 'function' ? definition.name : definition.toString();
     }
 
-    registerDestructor(state, () => delegate.destroyModifier(instance, argsProxy));
+    registerDestructor(state, () => delegate.destroyModifier(instance, args));
     return state;
   }
 
@@ -745,22 +682,6 @@ class CustomModifierManager {
   }
 
 }
-function reifyArgs({
-  named,
-  positional
-}) {
-  let reifiedNamed = dict();
-
-  for (let key in named) {
-    reifiedNamed[key] = valueForRef(named[key]);
-  }
-
-  let reifiedPositional = positional.map(valueForRef);
-  return {
-    named: reifiedNamed,
-    positional: reifiedPositional
-  };
-}
 
 function helperCapabilities(managerAPI, options = {}) {
   if (DEBUG && managerAPI !== '3.23') {