ember-resize-modifier 0.4.0 → 0.4.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -11,6 +11,21 @@ Please upgrade or ask whatever dependency you are using to upgrade.
11
11
  https://github.com/highlightjs/highlight.js/issues/2877
12
12
 
13
13
 
14
+
15
+ ## v0.4.1 (2022-05-13)
16
+
17
+ #### :rocket: Enhancement
18
+ * [#514](https://github.com/elwayman02/ember-resize-modifier/pull/514) Performance: avoid creating callbacks for the destructor ([@chriskrycho](https://github.com/chriskrycho))
19
+
20
+ #### :bug: Bug Fix
21
+ * [#515](https://github.com/elwayman02/ember-resize-modifier/pull/515) Require ember-modifier@^3.2 ([@chriskrycho](https://github.com/chriskrycho))
22
+
23
+ #### :house: Internal
24
+ * [#514](https://github.com/elwayman02/ember-resize-modifier/pull/514) Performance: avoid creating callbacks for the destructor ([@chriskrycho](https://github.com/chriskrycho))
25
+
26
+ #### Committers: 1
27
+ - Chris Krycho ([@chriskrycho](https://github.com/chriskrycho))
28
+
14
29
  ## v0.4.0 (2022-05-13)
15
30
 
16
31
  #### :boom: Breaking Change
@@ -30,11 +30,11 @@ export default class DidResizeModifier extends Modifier {
30
30
  });
31
31
  }
32
32
 
33
- registerDestructor(this, (instance) => instance.unobserve());
33
+ registerDestructor(this, unobserve);
34
34
  }
35
35
 
36
36
  modify(element, positional /*, named*/) {
37
- this.unobserve();
37
+ unobserve(this);
38
38
 
39
39
  this.element = element;
40
40
 
@@ -54,13 +54,6 @@ export default class DidResizeModifier extends Modifier {
54
54
  }
55
55
  }
56
56
 
57
- unobserve() {
58
- if (this.element && DidResizeModifier.observer) {
59
- DidResizeModifier.observer.unobserve(this.element);
60
- this.removeHandler();
61
- }
62
- }
63
-
64
57
  addHandler() {
65
58
  DidResizeModifier.handlers.set(this.element, this.handler);
66
59
  }
@@ -69,3 +62,14 @@ export default class DidResizeModifier extends Modifier {
69
62
  DidResizeModifier.handlers.delete(this.element);
70
63
  }
71
64
  }
65
+
66
+ /**
67
+ *
68
+ * @param {DidResizeModifier} instance
69
+ */
70
+ function unobserve(instance) {
71
+ if (instance.element && DidResizeModifier.observer) {
72
+ DidResizeModifier.observer.unobserve(instance.element);
73
+ instance.removeHandler();
74
+ }
75
+ }
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "ember-resize-modifier",
3
- "version": "0.4.0",
3
+ "version": "0.4.1",
4
4
  "description": "Resize Modifier for Ember.js Applications using ResizeObserver",
5
5
  "keywords": [
6
6
  "ember-addon",
@@ -31,7 +31,7 @@
31
31
  "dependencies": {
32
32
  "ember-cli-babel": "^7.26.11",
33
33
  "ember-cli-htmlbars": "^6.0.1",
34
- "ember-modifier": "^3.0.0"
34
+ "ember-modifier": "^3.2.0"
35
35
  },
36
36
  "devDependencies": {
37
37
  "@ember/optional-features": "^2.0.0",