ember-primitives 0.62.0 → 0.63.0

package/dist/{rating-BrIiwDLw.js → rating-CKWhrr-L.js}

@@ -10,7 +10,7 @@ import { assert } from '@ember/debug';
 import { localCopy } from 'tracked-toolbox';
 import { g, i, n } from 'decorator-transforms/runtime';
 
-const RatingRange = setComponentTemplate(precompileTemplate("<input ...attributes name={{@name}} type=\"range\" max={{@max}} value={{@value}} {{on \"change\" @handleChange}} />", {
+const RatingRange = setComponentTemplate(precompileTemplate("<input min=\"0\" step={{@step}} ...attributes name={{@name}} type=\"range\" max={{@max}} value={{@value}} {{on \"change\" @handleChange}} />", {
   strictMode: true,
   scope: () => ({
     on
@@ -24,7 +24,7 @@ function lte(a, b) {
   return a <= b;
 }
 
-const Stars = setComponentTemplate(precompileTemplate("<div class=\"ember-primitives__rating__items\">\n  {{#each @stars as |star|}}\n    {{#let (uniqueId) as |id|}}\n      <span class=\"ember-primitives__rating__item\" data-number={{star}} data-selected={{lte star @currentValue}} data-readonly={{@isReadonly}}>\n        <label for=\"input-{{id}}\">\n          <span visually-hidden>{{star}} star</span>\n          {{#if @icon}}\n            <span aria-hidden=\"true\">\n              {{#if (isString @icon)}}\n                {{@icon}}\n              {{else}}\n                <@icon @value={{star}} @isSelected={{lte star @currentValue}} @readonly={{@isReadonly}} />\n              {{/if}}\n            </span>\n          {{/if}}\n        </label>\n\n        <input id=\"input-{{id}}\" type=\"radio\" name={{@name}} value={{star}} readonly={{@isReadonly}} checked={{Object.is star @currentValue}} />\n      </span>\n    {{/let}}\n  {{/each}}\n</div>", {
+const Stars = setComponentTemplate(precompileTemplate("<div class=\"ember-primitives__rating__items\">\n  {{#each @stars as |star|}}\n    {{#let (uniqueId) as |id|}}\n      <span class=\"ember-primitives__rating__item\" data-number={{star}} data-selected={{lte star @currentValue}} data-readonly={{@isReadonly}}>\n        <label for=\"input-{{id}}\">\n          <span visually-hidden>{{star}} star</span>\n          {{#if @icon}}\n            <span aria-hidden=\"true\">\n              {{#if (isString @icon)}}\n                {{@icon}}\n              {{else}}\n                <@icon @value={{star}} @isSelected={{lte star @currentValue}} @readonly={{@isReadonly}} />\n              {{/if}}\n            </span>\n          {{/if}}\n        </label>\n\n        <input id=\"input-{{id}}\" type=\"radio\" name={{@name}} value={{star}} checked={{Object.is star @currentValue}} />\n      </span>\n    {{/let}}\n  {{/each}}\n</div>", {
   strictMode: true,
   scope: () => ({
     uniqueId,
@@ -94,6 +94,10 @@ class RatingState extends Component {
     // we don't do anything on other elements
     const isValid = event.target instanceof HTMLInputElement && event.target.name === this.args.name && event.target.type === "radio";
     if (!isValid) return;
+    if (this.args.readonly) {
+      /** `readonly` has no effect on a radio, cancelling is what restores the checked one. */event.preventDefault();
+      return;
+    }
     const selected = event.target?.value;
     this.setFromString(selected);
   };
@@ -107,7 +111,7 @@ class RatingState extends Component {
     this.setFromString(event.target.value);
   };
   static {
-    setComponentTemplate(precompileTemplate("{{yield (hash stars=this.stars total=this.stars.length handleClick=this.handleClick handleChange=this.handleChange setRating=this.setRating value=this.value step=this.step) (hash total=this.stars.length value=this.value)}}", {
+    setComponentTemplate(precompileTemplate("{{yield (hash stars=this.stars max=this.max total=this.stars.length handleClick=this.handleClick handleChange=this.handleChange setRating=this.setRating value=this.value step=this.step) (hash total=this.stars.length value=this.value)}}", {
       strictMode: true,
       scope: () => ({
         hash
@@ -135,7 +139,7 @@ class Rating extends Component {
     return !this.isInteractive;
   }
   static {
-    setComponentTemplate(precompileTemplate("<RatingState @max={{@max}} @step={{@step}} @value={{@value}} @name={{this.name}} @readonly={{this.isReadonly}} @onChange={{@onChange}} as |r publicState|>\n  <fieldset class=\"ember-primitives__rating\" data-total={{r.total}} data-value={{r.value}} data-readonly={{this.isReadonly}} {{!-- We use event delegation, this isn't a primary interactive -- we're capturing events from inputs --}} {{!-- template-lint-disable no-invalid-interactive --}} {{on \"click\" r.handleClick}} ...attributes>\n    {{#let (component Stars stars=r.stars icon=this.icon isReadonly=this.isReadonly name=this.name total=r.total currentValue=r.value) as |RatingStars|}}\n\n      {{#if (has-block)}}\n        {{yield (hash max=r.total total=r.total value=r.value name=this.name isReadonly=this.isReadonly isChangeable=this.isChangeable Stars=RatingStars Range=(component RatingRange step=r.step max=r.total value=r.value name=this.name handleChange=r.handleChange))}}\n      {{else}}\n        {{#if this.needsDescription}}\n          {{#if (has-block \"label\")}}\n            {{yield publicState to=\"label\"}}\n          {{else}}\n            <span visually-hidden class=\"ember-primitives__rating__label\">Rated\n              {{r.value}}\n              out of\n              {{r.total}}</span>\n          {{/if}}\n        {{else}}\n          {{#if (has-block \"label\")}}\n            <legend>\n              {{yield publicState to=\"label\"}}\n            </legend>\n          {{/if}}\n        {{/if}}\n\n        <RatingStars />\n      {{/if}}\n    {{/let}}\n\n  </fieldset>\n</RatingState>", {
+    setComponentTemplate(precompileTemplate("<RatingState @max={{@max}} @step={{@step}} @value={{@value}} @name={{this.name}} @readonly={{this.isReadonly}} @onChange={{@onChange}} as |r publicState|>\n  <fieldset class=\"ember-primitives__rating\" role=\"radiogroup\" aria-readonly={{if this.isReadonly \"true\"}} data-total={{r.total}} data-value={{r.value}} data-readonly={{this.isReadonly}} {{!-- We use event delegation, this isn't a primary interactive -- we're capturing events from inputs --}} {{!-- template-lint-disable no-invalid-interactive --}} {{on \"click\" r.handleClick}} ...attributes>\n    {{#let (component Stars stars=r.stars icon=this.icon isReadonly=this.isReadonly name=this.name total=r.total currentValue=r.value) as |RatingStars|}}\n\n      {{#if (has-block)}}\n        {{yield (hash max=r.total total=r.total value=r.value name=this.name isReadonly=this.isReadonly isChangeable=this.isChangeable Stars=RatingStars Range=(component RatingRange step=r.step max=r.max value=r.value name=this.name handleChange=r.handleChange))}}\n      {{else}}\n        {{#if this.needsDescription}}\n          {{#if (has-block \"label\")}}\n            {{yield publicState to=\"label\"}}\n          {{else}}\n            <span visually-hidden class=\"ember-primitives__rating__label\">Rated\n              {{r.value}}\n              out of\n              {{r.total}}</span>\n          {{/if}}\n        {{else}}\n          {{#if (has-block \"label\")}}\n            <legend>\n              {{yield publicState to=\"label\"}}\n            </legend>\n          {{/if}}\n        {{/if}}\n\n        <RatingStars />\n      {{/if}}\n    {{/let}}\n\n  </fieldset>\n</RatingState>", {
       strictMode: true,
       scope: () => ({
         RatingState,
@@ -149,4 +153,4 @@ class Rating extends Component {
 }
 
 export { Rating as R };
-//# sourceMappingURL=rating-BrIiwDLw.js.map
+//# sourceMappingURL=rating-CKWhrr-L.js.map

package/dist/rating-CKWhrr-L.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"rating-CKWhrr-L.js","sources":["../src/components/rating/range.gts","../src/components/rating/utils.ts","../src/components/rating/stars.gts","../src/components/rating/state.gts","../src/components/rating/rating.gts"],"sourcesContent":["import { on } from \"@ember/modifier\";\n\nimport type { TOC } from \"@ember/component/template-only\";\n\nexport const RatingRange: TOC<{\n  Element: HTMLInputElement;\n  Args: {\n    name: string;\n    step: number;\n    max: number;\n    value: number;\n    handleChange: (event: Event) => void;\n  };\n}> = <template>\n  <input\n    min=\"0\"\n    step={{@step}}\n    ...attributes\n    name={{@name}}\n    type=\"range\"\n    max={{@max}}\n    value={{@value}}\n    {{on \"change\" @handleChange}}\n  />\n</template>;\n","export function isString(x: unknown) {\n  return typeof x === 'string';\n}\n\nexport function lte(a: number, b: number) {\n  return a <= b;\n}\n","import { uniqueId } from \"../../utils.ts\";\nimport { isString, lte } from \"./utils.ts\";\n\nimport type { ComponentIcons, StringIcons } from \"./public-types.ts\";\nimport type { TOC } from \"@ember/component/template-only\";\n\nexport const Stars: TOC<{\n  Args: {\n    // Configuration\n    stars: number[];\n    icon: StringIcons[\"icon\"] | ComponentIcons[\"icon\"];\n    isReadonly: boolean;\n\n    // HTML Boilerplate\n    name: string;\n\n    // State\n    currentValue: number;\n    total: number;\n  };\n}> = <template>\n  <div class=\"ember-primitives__rating__items\">\n    {{#each @stars as |star|}}\n      {{#let (uniqueId) as |id|}}\n        <span\n          class=\"ember-primitives__rating__item\"\n          data-number={{star}}\n          data-selected={{lte star @currentValue}}\n          data-readonly={{@isReadonly}}\n        >\n          <label for=\"input-{{id}}\">\n            <span visually-hidden>{{star}} star</span>\n            {{#if @icon}}\n              <span aria-hidden=\"true\">\n                {{#if (isString @icon)}}\n                  {{@icon}}\n                {{else}}\n                  <@icon\n                    @value={{star}}\n                    @isSelected={{lte star @currentValue}}\n                    @readonly={{@isReadonly}}\n                  />\n                {{/if}}\n              </span>\n            {{/if}}\n          </label>\n\n          <input\n            id=\"input-{{id}}\"\n            type=\"radio\"\n            name={{@name}}\n            value={{star}}\n            checked={{Object.is star @currentValue}}\n          />\n        </span>\n      {{/let}}\n    {{/each}}\n  </div>\n</template>;\n","import Component from \"@glimmer/component\";\nimport { cached } from \"@glimmer/tracking\";\nimport { assert } from \"@ember/debug\";\nimport { hash } from \"@ember/helper\";\n\n// eslint-disable-next-line @typescript-eslint/ban-ts-comment\n// @ts-expect-error\nimport { localCopy } from \"tracked-toolbox\";\n\nexport class RatingState extends Component<{\n  Args: {\n    max: number | undefined;\n    value: number | undefined;\n    step: number | undefined;\n    readonly: boolean | undefined;\n    name: string;\n    onChange?: (value: number) => void;\n  };\n  Blocks: {\n    default: [\n      internalApi: {\n        stars: number[];\n        step: number;\n        value: number;\n        max: number;\n        total: number;\n        handleClick: (event: Event) => void;\n        handleChange: (event: Event) => void;\n        setRating: (num: number) => void;\n      },\n      publicApi: {\n        value: number;\n        total: number;\n      },\n    ];\n  };\n}> {\n  // eslint-disable-next-line @typescript-eslint/no-unsafe-call\n  @localCopy(\"args.value\") declare _value: number;\n\n  get value() {\n    return this._value ?? 0;\n  }\n\n  get step() {\n    return this.args.step ?? 1;\n  }\n\n  get max() {\n    return this.args.max ?? 5;\n  }\n\n  @cached\n  get stars() {\n    const result = [];\n\n    // 0 is \"none selected\"\n    let current = 0;\n\n    current += this.step;\n\n    while (current <= this.max) {\n      result.push(current);\n      current += this.step;\n    }\n\n    return result;\n  }\n\n  setRating = (value: number) => {\n    if (this.args.readonly) {\n      return;\n    }\n\n    if (value === this._value) {\n      this._value = 0;\n    } else {\n      this._value = value;\n    }\n\n    this.args.onChange?.(value);\n  };\n\n  setFromString = (value: unknown) => {\n    assert(\"[BUG]: value from input must be a string.\", typeof value === \"string\");\n\n    const num = parseFloat(value);\n\n    if (isNaN(num)) {\n      // something went wrong.\n      // Since we're using event delegation,\n      // this could be from an unrelated input\n      return;\n    }\n\n    this.setRating(num);\n  };\n\n  /**\n   * Click events are captured by\n   * - radio changes (mouse and keyboard)\n   *   - but only range clicks\n   */\n  handleClick = (event: Event) => {\n    // Since we're doing event delegation on a click, we want to make sure\n    // we don't do anything on other elements\n    const isValid =\n      event.target instanceof HTMLInputElement &&\n      event.target.name === this.args.name &&\n      event.target.type === \"radio\";\n\n    if (!isValid) return;\n\n    if (this.args.readonly) {\n      /** `readonly` has no effect on a radio, cancelling is what restores the checked one. */\n      event.preventDefault();\n\n      return;\n    }\n\n    const selected = event.target?.value;\n\n    this.setFromString(selected);\n  };\n\n  /**\n   * Only attached to a range element, if present.\n   * Range elements don't fire click events on keyboard usage, like radios do\n   */\n  handleChange = (event: Event) => {\n    const isValid = event.target !== null && \"value\" in event.target;\n\n    if (!isValid) return;\n\n    this.setFromString(event.target.value);\n  };\n\n  <template>\n    {{yield\n      (hash\n        stars=this.stars\n        max=this.max\n        total=this.stars.length\n        handleClick=this.handleClick\n        handleChange=this.handleChange\n        setRating=this.setRating\n        value=this.value\n        step=this.step\n      )\n      (hash total=this.stars.length value=this.value)\n    }}\n  </template>\n}\n","import Component from \"@glimmer/component\";\nimport { hash } from \"@ember/helper\";\nimport { on } from \"@ember/modifier\";\n\nimport { uniqueId } from \"../../utils.ts\";\nimport { RatingRange } from \"./range.gts\";\nimport { Stars } from \"./stars.gts\";\nimport { RatingState } from \"./state.gts\";\n\nimport type { ComponentIcons, StringIcons } from \"./public-types.ts\";\nimport type { WithBoundArgs } from \"@glint/template\";\n\nexport interface Signature {\n  /*\n   * The element all passed attributes / modifiers are applied to.\n   *\n   * This is a `<fieldset>`, becaues the rating elements are\n   * powered by a group of radio buttons.\n   */\n  Element: HTMLFieldSetElement;\n  Args: (ComponentIcons | StringIcons) & {\n    /**\n     * The number of stars/whichever-icon to show\n     *\n     * Defaults to 5\n     */\n    max?: number;\n\n    /**\n     * The current number of stars/whichever-icon to show as selected\n     *\n     * Defaults to 0\n     */\n    value?: number;\n\n    /**\n     * When generating the radio inputs, this changes what value of rating each radio\n     * input will be incremented by.\n     *\n     * e.g.: Set to 0.5 for half-star ratings.\n     *\n     * Defaults to 1\n     */\n    step?: number;\n\n    /**\n     * Prevents click events on the icons and sets aria-readonly.\n     *\n     * Also sets data-readonly=true on the wrapping element\n     */\n    readonly?: boolean;\n\n    /**\n     * Toggles the ability to interact with the rating component.\n     * When `true` (the default), the Rating component can be as a form input\n     * to gather user feedback.\n     *\n     * When false, only the `@value` will be shown, and it cannot be changed.\n     */\n    interactive?: boolean;\n\n    /**\n     * Callback when the selected rating changes.\n     * Can include half-ratings if the iconHalf argument is passed.\n     */\n    onChange?: (value: number) => void;\n  };\n\n  Blocks: {\n    default: [\n      rating: {\n        /**\n         * The maximum rating\n         */\n        max: number;\n        /**\n         * The maxium rating\n         */\n        total: number;\n        /**\n         * The current rating\n         */\n        value: number;\n        /**\n         * The name shared by the field group\n         */\n        name: string;\n        /**\n         * If the rating can be changed\n         */\n        isReadonly: boolean;\n        /**\n         * If the rating can be changed\n         */\n        isChangeable: boolean;\n        /**\n         * The stars / items radio group\n         */\n        Stars: WithBoundArgs<\n          typeof Stars,\n          \"stars\" | \"icon\" | \"isReadonly\" | \"name\" | \"total\" | \"currentValue\"\n        >;\n        /**\n         * Input range for adjusting the rating via fractional means\n         */\n        Range: WithBoundArgs<\n          typeof RatingRange,\n          \"step\" | \"max\" | \"value\" | \"name\" | \"handleChange\"\n        >;\n      },\n    ];\n    label: [\n      state: {\n        /**\n         * The current rating\n         */\n        value: number;\n\n        /**\n         * The maximum rating\n         */\n        total: number;\n      },\n    ];\n  };\n}\n\nexport class Rating extends Component<Signature> {\n  name = `rating-${uniqueId()}`;\n\n  get icon() {\n    return this.args.icon ?? \"★\";\n  }\n\n  get isInteractive() {\n    return this.args.interactive ?? true;\n  }\n\n  get isChangeable() {\n    const readonly = this.args.readonly ?? false;\n\n    return !readonly && this.isInteractive;\n  }\n\n  get isReadonly() {\n    return !this.isChangeable;\n  }\n\n  get needsDescription() {\n    return !this.isInteractive;\n  }\n\n  <template>\n    <RatingState\n      @max={{@max}}\n      @step={{@step}}\n      @value={{@value}}\n      @name={{this.name}}\n      @readonly={{this.isReadonly}}\n      @onChange={{@onChange}}\n      as |r publicState|\n    >\n      <fieldset\n        class=\"ember-primitives__rating\"\n        role=\"radiogroup\"\n        aria-readonly={{if this.isReadonly \"true\"}}\n        data-total={{r.total}}\n        data-value={{r.value}}\n        data-readonly={{this.isReadonly}}\n        {{! We use event delegation, this isn't a primary interactive -- we're capturing events from inputs }}\n        {{! template-lint-disable no-invalid-interactive }}\n        {{on \"click\" r.handleClick}}\n        ...attributes\n      >\n        {{#let\n          (component\n            Stars\n            stars=r.stars\n            icon=this.icon\n            isReadonly=this.isReadonly\n            name=this.name\n            total=r.total\n            currentValue=r.value\n          )\n          as |RatingStars|\n        }}\n\n          {{#if (has-block)}}\n            {{yield\n              (hash\n                max=r.total\n                total=r.total\n                value=r.value\n                name=this.name\n                isReadonly=this.isReadonly\n                isChangeable=this.isChangeable\n                Stars=RatingStars\n                Range=(component\n                  RatingRange\n                  step=r.step\n                  max=r.max\n                  value=r.value\n                  name=this.name\n                  handleChange=r.handleChange\n                )\n              )\n            }}\n          {{else}}\n            {{#if this.needsDescription}}\n              {{#if (has-block \"label\")}}\n                {{yield publicState to=\"label\"}}\n              {{else}}\n                <span visually-hidden class=\"ember-primitives__rating__label\">Rated\n                  {{r.value}}\n                  out of\n                  {{r.total}}</span>\n              {{/if}}\n            {{else}}\n              {{#if (has-block \"label\")}}\n                <legend>\n                  {{yield publicState to=\"label\"}}\n                </legend>\n              {{/if}}\n            {{/if}}\n\n            <RatingStars />\n          {{/if}}\n        {{/let}}\n\n      </fieldset>\n    </RatingState>\n  </template>\n}\n"],"names":["RatingRange","setComponentTemplate","precompileTemplate","strictMode","scope","on","templateOnly","isString","x","lte","a","b","Stars","uniqueId","Object","RatingState","Component","localCopy","i","value","_value","step","args","max","stars","result","current","push","n","prototype","cached","setRating","readonly","onChange","setFromString","assert","num","parseFloat","isNaN","handleClick","event","isValid","target","HTMLInputElement","name","type","preventDefault","selected","handleChange","hash","Rating","icon","isInteractive","interactive","isChangeable","isReadonly","needsDescription"],"mappings":";;;;;;;;;;;;AAIO,MAAMA,WASR,GAAAC,oBAAA,CAAAC,kBAAA,CAAA,8IAAA,EAWL;EAAAC,UAAA,EAAA,IAAA;AAAAC,EAAAA,KAAA,EAAAA,OAAA;AAAAC,IAAAA;AAAA,GAAA;AAAU,CAAA,CAAA,EAAAC,YAAA,EAAA,CAAA;;ACxBH,SAASC,QAAQA,CAACC,CAAU,EAAE;EACnC,OAAO,OAAOA,CAAC,KAAK,QAAQ;AAC9B;AAEO,SAASC,GAAGA,CAACC,CAAS,EAAEC,CAAS,EAAE;EACxC,OAAOD,CAAC,IAAIC,CAAC;AACf;;ACAO,MAAMC,KAcR,GAAAX,oBAAA,CAAAC,kBAAA,CAAA,02BAAA,EAsCL;EAAAC,UAAA,EAAA,IAAA;AAAAC,EAAAA,KAAA,EAAAA,OAAA;IAAAS,QAAA;IAAAJ,GAAA;IAAAF,QAAA;AAAAO,IAAAA;AAAA,GAAA;AAAU,CAAA,CAAA,EAAAR,YAAA,EAAA,CAAA;;ACjDH,MAAMS,WAAA,SAAoBC,SAAA;;iCA6B9BC,SAAA,CAAU,YAAA,CAAA,CAAA,CAAA;AAAA;EAAA,OAAA,IAAAC,CAAA,CAAA,IAAA,EAAA,QAAA,CAAA,EAAA,MAAA,EAAA;EAEX,IAAIC,KAAAA,GAAQ;AACV,IAAA,OAAO,IAAI,CAACC,MAAM,IAAI,CAAA;AACxB,EAAA;EAEA,IAAIC,IAAAA,GAAO;AACT,IAAA,OAAO,IAAI,CAACC,IAAI,CAACD,IAAI,IAAI,CAAA;AAC3B,EAAA;EAEA,IAAIE,GAAAA,GAAM;AACR,IAAA,OAAO,IAAI,CAACD,IAAI,CAACC,GAAG,IAAI,CAAA;AAC1B,EAAA;EAEA,IACIC,KAAAA,GAAQ;IACV,MAAMC,SAAS,EAAE;AAEjB;IACA,IAAIC,OAAA,GAAU,CAAA;IAEdA,OAAA,IAAW,IAAI,CAACL,IAAI;AAEpB,IAAA,OAAOK,OAAA,IAAW,IAAI,CAACH,GAAG,EAAE;AAC1BE,MAAAA,MAAA,CAAOE,IAAI,CAACD,OAAA,CAAA;MACZA,OAAA,IAAW,IAAI,CAACL,IAAI;AACtB,IAAA;AAEA,IAAA,OAAOI,MAAA;AACT,EAAA;AAAA,EAAA;IAAAG,CAAA,CAAA,IAAA,CAAAC,SAAA,EAAA,OAAA,EAAA,CAfCC,MAAA,CAAA,CAAA;AAAA;EAiBDC,SAAA,GAAaZ,KAAa,IAAA;AACxB,IAAA,IAAI,IAAI,CAACG,IAAI,CAACU,QAAQ,EAAE;AACtB,MAAA;AACF,IAAA;AAEA,IAAA,IAAIb,KAAA,KAAU,IAAI,CAACC,MAAM,EAAE;MACzB,IAAI,CAACA,MAAM,GAAG,CAAA;AAChB,IAAA,CAAA,MAAO;MACL,IAAI,CAACA,MAAM,GAAGD,KAAA;AAChB,IAAA;AAEA,IAAA,IAAI,CAACG,IAAI,CAACW,QAAQ,GAAGd,KAAA,CAAA;EACvB,CAAA;EAEAe,aAAA,GAAiBf,KAAc,IAAA;AAC7BgB,IAAAA,MAAA,CAAO,2CAAA,EAA6C,OAAOhB,KAAA,KAAU,QAAA,CAAA;AAErE,IAAA,MAAMiB,MAAMC,UAAA,CAAWlB,KAAA,CAAA;AAEvB,IAAA,IAAImB,MAAMF,GAAA,CAAA,EAAM;AACd;AACA;AACA;AACA,MAAA;AACF,IAAA;AAEA,IAAA,IAAI,CAACL,SAAS,CAACK,GAAA,CAAA;EACjB,CAAA;AAEA;;;;;EAKAG,WAAA,GAAeC,KAAO,IAAA;AACpB;AACA;IACA,MAAMC,OAAA,GACJD,MAAME,MAAM,YAAYC,oBACxBH,KAAA,CAAME,MAAM,CAACE,IAAI,KAAK,IAAI,CAACtB,IAAI,CAACsB,IAAI,IACpCJ,MAAME,MAAM,CAACG,IAAI,KAAK,OAAA;IAExB,IAAI,CAACJ,OAAA,EAAS;AAEd,IAAA,IAAI,IAAI,CAACnB,IAAI,CAACU,QAAQ,EAAE;AACtB,8FACAQ,MAAMM,cAAc,EAAA;AAEpB,MAAA;AACF,IAAA;AAEA,IAAA,MAAMC,QAAA,GAAWP,KAAA,CAAME,MAAM,EAAEvB,KAAA;AAE/B,IAAA,IAAI,CAACe,aAAa,CAACa,QAAA,CAAA;EACrB,CAAA;AAEA;;;;EAIAC,YAAA,GAAgBR,KAAO,IAAA;AACrB,IAAA,MAAMC,UAAUD,KAAA,CAAME,MAAM,KAAK,IAAA,IAAQ,OAAA,IAAWF,MAAME,MAAM;IAEhE,IAAI,CAACD,OAAA,EAAS;IAEd,IAAI,CAACP,aAAa,CAACM,KAAA,CAAME,MAAM,CAACvB,KAAK,CAAA;EACvC,CAAA;AAEA,EAAA;IAAAlB,oBAAA,CAAAC,kBAAA,CAAA,6OAAA,EAcA;MAAAC,UAAA,EAAA,IAAA;AAAAC,MAAAA,KAAA,EAAAA,OAAA;AAAA6C,QAAAA;AAAA,OAAA;KAAU,CAAA,EAAV,IAAW,CAAA;AAAD;AACZ;;ACzBO,MAAMC,eAAelC,SAAA,CAAU;AACpC4B,EAAAA,IAAA,GAAO,CAAA,OAAA,EAAU/B,QAAA,EAAA,CAAA,CAAY;EAE7B,IAAIsC,IAAAA,GAAO;AACT,IAAA,OAAO,IAAI,CAAC7B,IAAI,CAAC6B,IAAI,IAAI,GAAA;AAC3B,EAAA;EAEA,IAAIC,aAAAA,GAAgB;AAClB,IAAA,OAAO,IAAI,CAAC9B,IAAI,CAAC+B,WAAW,IAAI,IAAA;AAClC,EAAA;EAEA,IAAIC,YAAAA,GAAe;IACjB,MAAMtB,WAAW,IAAI,CAACV,IAAI,CAACU,QAAQ,IAAI,KAAA;AAEvC,IAAA,OAAO,CAACA,QAAA,IAAY,IAAI,CAACoB,aAAa;AACxC,EAAA;EAEA,IAAIG,UAAAA,GAAa;IACf,OAAO,CAAC,IAAI,CAACD,YAAY;AAC3B,EAAA;EAEA,IAAIE,gBAAAA,GAAmB;IACrB,OAAO,CAAC,IAAI,CAACJ,aAAa;AAC5B,EAAA;AAEA,EAAA;IAAAnD,oBAAA,CAAAC,kBAAA,CAAA,qmDAAA,EA+EA;MAAAC,UAAA,EAAA,IAAA;AAAAC,MAAAA,KAAA,EAAAA,OAAA;QAAAW,WAAA;QAAAV,EAAA;QAAAO,KAAA;QAAAqC,IAAA;AAAAjD,QAAAA;AAAA,OAAA;KAAU,CAAA,EAAV,IAAW,CAAA;AAAD;AACZ;;;;"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-primitives",
-  "version": "0.62.0",
+  "version": "0.63.0",
   "description": "Making apps easier to build",
   "keywords": [
     "ember-addon"

package/src/components/accordion/content.gts

@@ -7,7 +7,8 @@ import type { AccordionContentExternalSignature } from "./public.ts";
 interface Signature extends AccordionContentExternalSignature {
   Args: {
     isExpanded: boolean;
-    value: string;
+    triggerId: string;
+    contentId: string;
     disabled?: boolean;
   };
 }
@@ -16,7 +17,8 @@ export class AccordionContent extends Component<Signature> {
   <template>
     <div
       role="region"
-      id={{@value}}
+      id={{@contentId}}
+      aria-labelledby={{@triggerId}}
       data-state={{getDataState @isExpanded}}
       hidden={{this.isHidden}}
       data-disabled={{@disabled}}

package/src/components/accordion/header.gts

@@ -8,7 +8,8 @@ import type { TOC } from "@ember/component/template-only";
 
 interface Signature extends AccordionHeaderExternalSignature {
   Args: {
-    value: string;
+    triggerId: string;
+    contentId: string;
     isExpanded: boolean;
     disabled?: boolean;
     toggleItem: () => void;
@@ -26,7 +27,12 @@ export const AccordionHeader: TOC<Signature> = <template>
     {{yield
       (hash
         Trigger=(component
-          Trigger value=@value isExpanded=@isExpanded disabled=@disabled toggleItem=@toggleItem
+          Trigger
+          triggerId=@triggerId
+          contentId=@contentId
+          isExpanded=@isExpanded
+          disabled=@disabled
+          toggleItem=@toggleItem
         )
       )
     }}

package/src/components/accordion/item.gts

@@ -1,6 +1,7 @@
 import Component from "@glimmer/component";
 import { hash } from "@ember/helper";
 
+import { uniqueId } from "../../utils.ts";
 import Content from "./content.gts";
 import Header from "./header.gts";
 
@@ -19,6 +20,14 @@ interface Signature extends AccordionItemExternalSignature {
 }
 
 export class AccordionItem extends Component<Signature> {
+  /**
+   * `@value` only has to be unique within one accordion.
+   * Element ids have to be unique across the document.
+   */
+  id = `ember-primitives__accordion-${uniqueId()}`;
+  triggerId = `${this.id}__trigger`;
+  contentId = `${this.id}__content`;
+
   <template>
     <div data-state={{getDataState this.isExpanded}} data-disabled={{@disabled}} ...attributes>
       {{yield
@@ -26,12 +35,19 @@ export class AccordionItem extends Component<Signature> {
           isExpanded=this.isExpanded
           Header=(component
             Header
-            value=@value
+            triggerId=this.triggerId
+            contentId=this.contentId
             isExpanded=this.isExpanded
             disabled=@disabled
             toggleItem=this.toggleItem
           )
-          Content=(component Content value=@value isExpanded=this.isExpanded disabled=@disabled)
+          Content=(component
+            Content
+            triggerId=this.triggerId
+            contentId=this.contentId
+            isExpanded=this.isExpanded
+            disabled=@disabled
+          )
         )
       }}
     </div>

package/src/components/accordion/public.ts

@@ -29,7 +29,10 @@ export interface AccordionHeaderExternalSignature {
         /**
          * The AccordionTrigger component.
          */
-        Trigger: WithBoundArgs<typeof Trigger, 'value' | 'isExpanded' | 'disabled' | 'toggleItem'>;
+        Trigger: WithBoundArgs<
+          typeof Trigger,
+          'triggerId' | 'contentId' | 'isExpanded' | 'disabled' | 'toggleItem'
+        >;
       },
     ];
   };
@@ -47,11 +50,17 @@ export interface AccordionItemExternalSignature {
         /**
          * The AccordionHeader component.
          */
-        Header: WithBoundArgs<typeof Header, 'value' | 'isExpanded' | 'disabled' | 'toggleItem'>;
+        Header: WithBoundArgs<
+          typeof Header,
+          'triggerId' | 'contentId' | 'isExpanded' | 'disabled' | 'toggleItem'
+        >;
         /**
          * The AccordionContent component.
          */
-        Content: WithBoundArgs<typeof Content, 'value' | 'isExpanded' | 'disabled'>;
+        Content: WithBoundArgs<
+          typeof Content,
+          'triggerId' | 'contentId' | 'isExpanded' | 'disabled'
+        >;
       },
     ];
   };

package/src/components/accordion/trigger.gts

@@ -8,7 +8,8 @@ import type { TOC } from "@ember/component/template-only";
 interface Signature extends AccordionTriggerExternalSignature {
   Args: {
     isExpanded: boolean;
-    value: string;
+    triggerId: string;
+    contentId: string;
     disabled?: boolean;
     toggleItem: () => void;
   };
@@ -17,8 +18,9 @@ interface Signature extends AccordionTriggerExternalSignature {
 export const AccordionTrigger: TOC<Signature> = <template>
   <button
     type="button"
-    aria-controls={{@value}}
-    aria-expanded={{@isExpanded}}
+    id={{@triggerId}}
+    aria-controls={{@contentId}}
+    aria-expanded={{if @isExpanded "true" "false"}}
     data-state={{getDataState @isExpanded}}
     data-disabled={{@disabled}}
     aria-disabled={{if @disabled "true" "false"}}

package/src/components/command-palette.gts

@@ -29,6 +29,7 @@ import { getTabster } from "tabster";
 import { localCopy } from "tracked-toolbox";
 
 import { Link, type Signature as LinkSignature } from "./link.gts";
+import { VisuallyHidden } from "./visually-hidden.gts";
 
 import type { TOC } from "@ember/component/template-only";
 import type Owner from "@ember/owner";
@@ -297,6 +298,12 @@ export interface ItemsSignature {
      * Defaults to "Search".
      */
     placeholder?: string;
+    /**
+     * What a screen reader announces when the number of results changes.
+     *
+     * Defaults to "1 result" and "3 results".
+     */
+    resultsText?: (count: number) => string;
   };
   /**
    * No blocks: this form renders the rows. Passing one is an error.
@@ -348,6 +355,10 @@ export interface BlockSignature {
      * Not for this form: set it on `Input` yourself.
      */
     placeholder?: never;
+    /**
+     * Not for this form: the rows are yours, and so is announcing them.
+     */
+    resultsText?: never;
     /**
      * Called every time a row is chosen. Hand it `close` to make a modal
      * palette close itself.
@@ -370,6 +381,8 @@ export interface BlockSignature {
         setQuery: (query: string) => void;
         /**
          * The `<input>`, wired as a combobox over `List`.
+         *
+         * It needs a name: pass `aria-label`, or an `id` and a `<label>`.
          */
         Input: WithBoundArgs<
           typeof Input,
@@ -432,6 +445,13 @@ export class CommandPalette extends Component<Signature> {
     return this.args.placeholder ?? "Search";
   }
 
+  get resultsText() {
+    const count = this.args.items?.length ?? 0;
+    const custom = this.args.resultsText?.(count);
+
+    return custom ?? (count === 1 ? "1 result" : `${count} results`);
+  }
+
   /**
    * Whether `@items` was passed, not whether it has anything in it: an empty
    * array is falsy in a template, and a palette whose results have gone away
@@ -709,6 +729,8 @@ export class CommandPalette extends Component<Signature> {
             </l.Item>
           {{/each}}
         </PaletteList>
+
+        <VisuallyHidden role="status">{{this.resultsText}}</VisuallyHidden>
       {{else}}
         {{yield (hash query=this.query setQuery=this.setQuery Input=PaletteInput List=PaletteList)}}
       {{/if}}

package/src/components/dialog.gts

@@ -14,6 +14,11 @@ import { localCopy } from "tracked-toolbox";
 import type { TOC } from "@ember/component/template-only";
 import type { ModifierLike, WithBoundArgs } from "@glint/template";
 
+interface RegisterSignature {
+  Element: HTMLDialogElement;
+  Args: { Named: { open: boolean | undefined } };
+}
+
 const DialogElement: TOC<{
   Element: HTMLDialogElement;
   Args: {
@@ -29,11 +34,11 @@ const DialogElement: TOC<{
     /**
      * @internal
      */
-    register: ModifierLike<{ Element: HTMLDialogElement }>;
+    register: ModifierLike<RegisterSignature>;
   };
   Blocks: { default: [] };
 }> = <template>
-  <dialog ...attributes open={{@open}} {{on "close" @onClose}} {{@register}}>
+  <dialog ...attributes {{on "close" @onClose}} {{@register open=@open}}>
     {{yield}}
   </dialog>
 </template>;
@@ -144,7 +149,14 @@ class ModalDialog extends Component<Signature> {
 
   @tracked declare dialogElement: HTMLDialogElement | undefined;
 
-  register = eModifier((element: HTMLDialogElement) => {
+  register = eModifier<RegisterSignature>((element, _, { open }) => {
+    /** The `open` attribute shows a non-modal dialog, only `showModal` is modal. */
+    if (open && !element.open) {
+      element.showModal();
+    } else if (open === false && element.open) {
+      element.close();
+    }
+
     /**
      * This is very sad.
      *

package/src/components/drawer.gts

@@ -14,6 +14,11 @@ import { localCopy } from "tracked-toolbox";
 import type { TOC } from "@ember/component/template-only";
 import type { ModifierLike, WithBoundArgs } from "@glint/template";
 
+interface RegisterSignature {
+  Element: HTMLDialogElement;
+  Args: { Named: { open: boolean | undefined } };
+}
+
 const DrawerElement: TOC<{
   Element: HTMLDialogElement;
   Args: {
@@ -29,11 +34,11 @@ const DrawerElement: TOC<{
     /**
      * @internal
      */
-    register: ModifierLike<{ Element: HTMLDialogElement }>;
+    register: ModifierLike<RegisterSignature>;
   };
   Blocks: { default: [] };
 }> = <template>
-  <dialog ...attributes open={{@open}} {{on "close" @onClose}} {{@register}}>
+  <dialog ...attributes {{on "close" @onClose}} {{@register open=@open}}>
     {{yield}}
   </dialog>
 </template>;
@@ -144,7 +149,14 @@ class DrawerDialog extends Component<Signature> {
 
   @tracked declare drawerElement: HTMLDialogElement | undefined;
 
-  register = eModifier((element: HTMLDialogElement) => {
+  register = eModifier<RegisterSignature>((element, _, { open }) => {
+    /** The `open` attribute shows a non-modal drawer, only `showModal` is modal. */
+    if (open && !element.open) {
+      element.showModal();
+    } else if (open === false && element.open) {
+      element.close();
+    }
+
     /**
      * This is very sad.
      *

package/src/components/link.gts

@@ -159,6 +159,7 @@ export const Link: TOC<Signature> = <template>
     {{else}}
       <a
         data-active={{l.isActive}}
+        aria-current={{if l.isActive (if @activeOnSubPaths "true" "page")}}
         href={{if @href @href "##missing##"}}
         {{on "click" l.handleClick}}
         ...attributes

package/src/components/menu.gts

@@ -183,6 +183,8 @@ const installContent = eModifier<{
   // listen for the escape key
   function onDocumentKeydown(e: KeyboardEvent) {
     if (isOpen.current && e.key === "Escape") {
+      /** Otherwise the same key press also closes a `<dialog>` around the menu. */
+      e.preventDefault();
       isOpen.current = false;
     }
   }
@@ -226,6 +228,7 @@ const Content: TOC<PrivateContentSignature> = <template>
     <@PopoverContent
       id={{@contentId}}
       role="menu"
+      aria-labelledby={{@triggerElement.current.id}}
       data-tabster={{TABSTER_CONFIG_CONTENT}}
       tabindex="0"
       {{installContent isOpen=@isOpen triggerElement=@triggerElement}}
@@ -292,6 +295,10 @@ const trigger = eModifier<PrivateTriggerModifierSignature>(
 
     element.addEventListener("click", onTriggerClick);
 
+    if (!element.id) {
+      element.id = `${contentId}__trigger`;
+    }
+
     triggerElement.current = element;
 
     setReference(element);

package/src/components/one-time-password/input.gts

@@ -45,7 +45,7 @@ const Fields: TOC<{
         name="code{{i}}"
         type="text"
         inputmode="numeric"
-        autocomplete="off"
+        autocomplete="one-time-code"
         ...attributes
         {{on "click" selectAll}}
         {{on "paste" handlePaste}}

package/src/components/one-time-password/otp.gts

@@ -93,7 +93,7 @@ export const OTP: TOC<{
 
     /**
      * Whether or not to auto-submit after the code has been pasted
-     * in to the collective "field".  Default is true
+     * in to the collective "field".  Default is false
      */
     autoSubmit?: boolean;
   };

package/src/components/one-time-password/utils.ts

@@ -44,13 +44,21 @@ export function handlePaste(event: Event) {
   // multiple text fields
   event.preventDefault();
 
-  const value = clipboardData.getData('Text');
-  const digits = value;
+  fillFrom(target, clipboardData.getData('Text'));
+
+  // Selected again, so that another paste gives the same result.
+  target.select();
+
+  // A cancelled paste fires no input event, and @onChange listens for that event.
+  target.dispatchEvent(new InputEvent('input', { bubbles: true, inputType: 'insertFromPaste' }));
+}
+
+function fillFrom(target: HTMLInputElement, code: string) {
   let i = 0;
   let currElement: HTMLInputElement | null = target;
 
   while (currElement) {
-    currElement.value = digits[i++] || '';
+    currElement.value = code[i++] || '';
 
     const next = nextInput(currElement);
 
@@ -60,11 +68,6 @@ export function handlePaste(event: Event) {
       break;
     }
   }
-
-  // We want to select the first field again
-  // so that if someone holds paste, or
-  // pastes again, they get the same result.
-  target.select();
 }
 
 export function handleNavigation(event: KeyboardEvent) {
@@ -143,17 +146,27 @@ export const autoAdvance = (event: Event) => {
     event.target instanceof HTMLInputElement
   );
 
+  if ('inputType' in event && event.inputType === 'insertFromPaste') return;
+
   const value = event.target.value;
 
   if (value.length === 0) return;
 
-  if (value.length > 0) {
-    if ('data' in event && event.data && typeof event.data === 'string') {
-      event.target.value = event.data;
-    }
+  const data = 'data' in event && typeof event.data === 'string' ? event.data : '';
+
+  // Browser autofill puts the whole code in to the first field.
+  if (data.length > 1 || (!data && value.length > 1)) {
+    fillFrom(event.target, data || value);
+    event.target.select();
 
-    return focusRight(event);
+    return;
   }
+
+  if (data) {
+    event.target.value = data;
+  }
+
+  return focusRight(event);
 };
 
 export function getCollectiveValue(elementTarget: EventTarget | null, length: number) {

package/src/components/rating/range.gts

@@ -6,12 +6,15 @@ export const RatingRange: TOC<{
   Element: HTMLInputElement;
   Args: {
     name: string;
+    step: number;
     max: number;
     value: number;
     handleChange: (event: Event) => void;
   };
 }> = <template>
   <input
+    min="0"
+    step={{@step}}
     ...attributes
     name={{@name}}
     type="range"

package/src/components/rating/rating.gts

@@ -103,7 +103,10 @@ export interface Signature {
         /**
          * Input range for adjusting the rating via fractional means
          */
-        Range: WithBoundArgs<typeof RatingRange, "max" | "value" | "name" | "handleChange">;
+        Range: WithBoundArgs<
+          typeof RatingRange,
+          "step" | "max" | "value" | "name" | "handleChange"
+        >;
       },
     ];
     label: [
@@ -159,6 +162,8 @@ export class Rating extends Component<Signature> {
     >
       <fieldset
         class="ember-primitives__rating"
+        role="radiogroup"
+        aria-readonly={{if this.isReadonly "true"}}
         data-total={{r.total}}
         data-value={{r.value}}
         data-readonly={{this.isReadonly}}
@@ -193,7 +198,7 @@ export class Rating extends Component<Signature> {
                 Range=(component
                   RatingRange
                   step=r.step
-                  max=r.total
+                  max=r.max
                   value=r.value
                   name=this.name
                   handleChange=r.handleChange

package/src/components/rating/stars.gts

@@ -50,7 +50,6 @@ export const Stars: TOC<{
             type="radio"
             name={{@name}}
             value={{star}}
-            readonly={{@isReadonly}}
             checked={{Object.is star @currentValue}}
           />
         </span>

package/src/components/rating/state.gts

@@ -22,6 +22,7 @@ export class RatingState extends Component<{
         stars: number[];
         step: number;
         value: number;
+        max: number;
         total: number;
         handleClick: (event: Event) => void;
         handleChange: (event: Event) => void;
@@ -110,6 +111,13 @@ export class RatingState extends Component<{
 
     if (!isValid) return;
 
+    if (this.args.readonly) {
+      /** `readonly` has no effect on a radio, cancelling is what restores the checked one. */
+      event.preventDefault();
+
+      return;
+    }
+
     const selected = event.target?.value;
 
     this.setFromString(selected);
@@ -131,6 +139,7 @@ export class RatingState extends Component<{
     {{yield
       (hash
         stars=this.stars
+        max=this.max
         total=this.stars.length
         handleClick=this.handleClick
         handleChange=this.handleChange

package/src/components/slider.gts

@@ -160,6 +160,13 @@ class ThumbComponent extends Component<{
     return this.args.thumb?.inputValue ?? this.args.value ?? this.args.store.internalMin;
   }
 
+  /** With tick values the input holds an index, which means nothing when read aloud. */
+  get valueText(): string | undefined {
+    const tick = this.args.store.tickValues?.[this.value];
+
+    return tick === undefined ? undefined : String(tick);
+  }
+
   get isActive(): boolean {
     return this.args.store.activeThumbIndex === this.index;
   }
@@ -205,6 +212,7 @@ class ThumbComponent extends Component<{
 
   <template>
     <input
+      aria-valuetext={{this.valueText}}
       ...attributes
       class="ember-primitives__slider__thumb-input"
       type="range"