ember-nav-stack 6.0.0 → 6.0.1

package/.vscode/settings.json

@@ -0,0 +1,6 @@
+{
+  "eslint.validate": [
+    "glimmer-ts",
+    "glimmer-js"
+  ]
+}

package/CHANGELOG.md

@@ -1,3 +1,12 @@
+## v6.0.1 (2023-12-15)
+
+#### :bug: Bug Fix
+* [#74](https://github.com/yapplabs/ember-nav-stack/pull/74) Add some more checks to make sure element is not destroyed before accessing it ([@lukemelia](https://github.com/lukemelia))
+* [#73](https://github.com/yapplabs/ember-nav-stack/pull/73) Avoid trying to access this.element when component has been torn down ([@lukemelia](https://github.com/lukemelia))
+
+#### Committers: 1
+- Luke Melia ([@lukemelia](https://github.com/lukemelia))
+
 ## v6.0.0 (2023-12-03)
 
 #### :boom: Breaking Change

package/addon/components/nav-stack/component.js

@@ -157,10 +157,12 @@ export default class NavStack extends Component {
   @action
   tearDownHammer() {
     let { hammer, gesture } = this;
-    gesture.unregister(this, hammer.get('pan'));
-    hammer.off('pan');
-    hammer.destroy();
-    this.hammer = null;
+    if (hammer) {
+      gesture.unregister(this, hammer.get('pan'));
+      hammer.off('pan');
+      hammer.destroy();
+      this.hammer = null;
+    }
   }
 
   @action
@@ -169,6 +171,10 @@ export default class NavStack extends Component {
   }
 
   handleStackDepthChange(isInitialRender) {
+    if (this.isDestroying || this.isDestroyed) {
+      return;
+    }
+
     let stackItems = this.stackItems || [];
     let stackDepth = stackItems.length;
     let rootComponentRef = stackItems[0] && stackItems[0].component;
@@ -234,6 +240,10 @@ export default class NavStack extends Component {
   }
 
   cut() {
+    if (this.isDestroying || this.isDestroyed) {
+      return;
+    }
+
     this.horizontalTransition({
       toValue: this.computeXPosition(),
       animate: false,
@@ -249,6 +259,9 @@ export default class NavStack extends Component {
   }
 
   slideForward() {
+    if (this.isDestroying || this.isDestroyed) {
+      return;
+    }
     this.horizontalTransition({
       toValue: this.computeXPosition(),
       finishCallback: () => {
@@ -258,6 +271,9 @@ export default class NavStack extends Component {
   }
 
   slideBack() {
+    if (this.isDestroying || this.isDestroyed) {
+      return;
+    }
     this.horizontalTransition({
       toValue: this.computeXPosition(),
       finishCallback: () => {
@@ -268,6 +284,10 @@ export default class NavStack extends Component {
   }
 
   slideUp() {
+    if (this.isDestroying || this.isDestroyed) {
+      return;
+    }
+
     let debug = this.birdsEyeDebugging;
     this.verticalTransition({
       element: this.element,
@@ -277,6 +297,9 @@ export default class NavStack extends Component {
   }
 
   slideDown() {
+    if (this.isDestroying || this.isDestroyed) {
+      return;
+    }
     let debug = this.birdsEyeDebugging;
     let clonedElement = this.clones.elements[this.clones.elements.length - 1];
     let y = debug ? 480 : clonedElement.getBoundingClientRect().height;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-nav-stack",
-  "version": "6.0.0",
+  "version": "6.0.1",
   "description": "The default blueprint for ember-cli addons.",
   "keywords": [
     "ember-addon"