ember-native 3.0.0 → 3.0.1

package/declarations/dom/nodes/ViewNode.d.ts

@@ -8,8 +8,6 @@ export default class ViewNode {
     _tagName: any;
     parentNode: ViewNode | null;
     childNodes: ViewNode[];
-    prevSibling: ViewNode | null;
-    nextSibling: ViewNode | null;
     _ownerDocument: any;
     _meta: any;
     get textContent(): string;
@@ -26,6 +24,8 @@ export default class ViewNode {
     get tagName(): any;
     get firstChild(): ViewNode | null | undefined;
     get lastChild(): ViewNode | null | undefined;
+    get nextSibling(): ViewNode | null;
+    get prevSibling(): ViewNode | null;
     get meta(): any;
     get isConnected(): boolean;
     get ownerDocument(): DocumentNode | null;

package/dist/dom/native/FrameElement.js

@@ -74,12 +74,6 @@ class FrameElement extends NativeElementNode {
       return;
     }
     childNode.parentNode = null;
-
-    // reset the prevSibling and nextSibling. If not, a keep-alived component will
-    // still have a filled nextSibling attribute so vue will not
-    // insert the node again to the parent. See #220
-    childNode.prevSibling = null;
-    childNode.nextSibling = null;
     this.childNodes = this.childNodes.filter(node => node !== childNode);
     childNode.removeChildren();
     this.onRemovedChild(childNode);

package/dist/dom/nodes/ViewNode.js

@@ -50,16 +50,12 @@ class ViewNode {
     _defineProperty(this, "nodeType", void 0);
     _defineProperty(this, "_tagName", void 0);
     _defineProperty(this, "childNodes", void 0);
-    _defineProperty(this, "prevSibling", void 0);
-    _defineProperty(this, "nextSibling", void 0);
     _defineProperty(this, "_ownerDocument", void 0);
     _defineProperty(this, "_meta", void 0);
     this.nodeType = null;
     this._tagName = null;
     this.parentNode = null;
     this.childNodes = [];
-    this.prevSibling = null;
-    this.nextSibling = null;
     this._ownerDocument = null;
     this._meta = null;
     this.attributes = [];
@@ -87,6 +83,26 @@ class ViewNode {
   get lastChild() {
     return this.childNodes.length ? this.childNodes[this.childNodes.length - 1] : null;
   }
+  get nextSibling() {
+    if (!this.parentNode) {
+      return null;
+    }
+    const index = this.parentNode.childNodes.indexOf(this);
+    if (index === -1 || index === this.parentNode.childNodes.length - 1) {
+      return null;
+    }
+    return this.parentNode.childNodes[index + 1];
+  }
+  get prevSibling() {
+    if (!this.parentNode) {
+      return null;
+    }
+    const index = this.parentNode.childNodes.indexOf(this);
+    if (index <= 0) {
+      return null;
+    }
+    return this.parentNode.childNodes[index - 1];
+  }
   get meta() {
     if (this._meta) {
       return this._meta;
@@ -138,12 +154,15 @@ class ViewNode {
     if (childNode.parentNode && childNode.parentNode !== this) {
       throw new Error(`Can't insert child, because it already has a different parent.`);
     }
-    if (childNode.parentNode === this) ;
+    if (childNode.parentNode === this) {
+      // we don't need to throw an error here, because it is a valid case
+      // for example when switching the order of elements in the tree
+      // fixes #127 - see for more details
+      // fixes #240
+      // throw new Error(`Can't insert child, because it is already a child.`)
+      this.removeChild(childNode);
+    }
     const index = this.childNodes.indexOf(referenceNode);
-    childNode.nextSibling = referenceNode;
-    childNode.prevSibling = this.childNodes[index - 1];
-    this.childNodes[index - 1].nextSibling = childNode;
-    referenceNode.prevSibling = childNode;
     this.childNodes.splice(index, 0, childNode);
     childNode.parentNode = this;
     this.onInsertedChild(childNode, index);
@@ -155,10 +174,13 @@ class ViewNode {
     if (childNode.parentNode && childNode.parentNode !== this) {
       throw new Error(`Can't append child, because it already has a different parent.`);
     }
-    if (childNode.parentNode === this) ;
-    if (this.lastChild) {
-      childNode.prevSibling = this.lastChild;
-      this.lastChild.nextSibling = childNode;
+    if (childNode.parentNode === this) {
+      // we don't need to throw an error here, because it is a valid case
+      // for example when switching the order of elements in the tree
+      // fixes #127 - see for more details
+      // fixes #240
+      // throw new Error(`Can't append child, because it is already a child.`)
+      this.removeChild(childNode);
     }
     this.childNodes.push(childNode);
     childNode.parentNode = this;
@@ -175,12 +197,6 @@ class ViewNode {
       throw new Error(`Can't remove child, because it has a different parent.`);
     }
     childNode.parentNode = null;
-    if (childNode.prevSibling) {
-      childNode.prevSibling.nextSibling = childNode.nextSibling;
-    }
-    if (childNode.nextSibling) {
-      childNode.nextSibling.prevSibling = childNode.prevSibling;
-    }
 
     // reset the prevSibling and nextSibling. If not, a keep-alived component will
     // still have a filled nextSibling attribute so vue will not

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-native",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "description": "the Ember framework with Nativescript",
   "keywords": [
     "ember-addon"
@@ -57,9 +57,9 @@
     "@ember/optional-features": "^2.0.0",
     "@embroider/addon-dev": "^8.1.0",
     "@embroider/compat": "^4.1.0",
-    "@embroider/core": "^4.2.8",
-    "@embroider/macros": "^1.18.1",
-    "@embroider/shared-internals": "^3.0.0",
+    "@embroider/core": "^4.4.0",
+    "@embroider/macros": "^1.19.5",
+    "@embroider/shared-internals": "^3.0.1",
     "@embroider/vite": "^1.4.2",
     "@embroider/util": "^1.13.3",
     "@embroider/webpack": "^4.1.1",
@@ -67,28 +67,28 @@
     "@glint/core": "^1.5.0",
     "@glint/environment-ember-loose": "^1.5.0",
     "@glint/environment-ember-template-imports": "^1.5.0",
-    "@glint/template": "^1.5.0",
+    "@glint/template": "^1.7.3",
     "@nativescript/core": "^8.9.7",
     "@release-it-plugins/lerna-changelog": "^8.0.1",
-    "@rollup/plugin-babel": "^6.0.3",
-    "@tsconfig/ember": "^3.0.8",
+    "@rollup/plugin-babel": "^6.1.0",
+    "@tsconfig/ember": "^3.0.12",
     "@types/babel__core": "^7.20.5",
     "@types/jquery": "^3.5.16",
-    "@types/qunit": "^2.19.5",
+    "@types/qunit": "^2.19.13",
     "@types/qunit-dom": "^0.7.0",
-    "@typescript-eslint/eslint-plugin": "^8.13.0",
-    "@typescript-eslint/parser": "^8.38.0",
+    "@typescript-eslint/eslint-plugin": "^8.47.0",
+    "@typescript-eslint/parser": "^8.48.0",
     "typescript-eslint": "^8.38.0",
     "babel-import-util": "^3.0.0",
-    "babel-plugin-ember-template-compilation": "^3.0.0",
+    "babel-plugin-ember-template-compilation": "^3.0.1",
     "bower": "^1.8.8",
     "globals": "^16.5.0",
-    "broccoli": "^3.4.2",
+    "broccoli": "^4.0.0",
     "broccoli-asset-rev": "^3.0.0",
-    "concurrently": "^9.2.0",
+    "concurrently": "^9.2.1",
     "content-tag": "^4.0.0",
     "css-loader": "^7.1.2",
-    "ember-eslint-parser": "^0.5.9",
+    "ember-eslint-parser": "^0.5.13",
     "ember-modifier": "^4.2.0",
     "ember-source": "^6.6.0",
     "ember-template-lint": "^7.9.1",
@@ -100,19 +100,19 @@
     "eslint-plugin-n": "^17.21.3",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^5.5.4",
-    "eslint-plugin-qunit": "^8.1.1",
+    "eslint-plugin-qunit": "^8.2.5",
     "fix-bad-declaration-output": "^1.1.4",
     "loader.js": "^4.7.0",
     "nativescript-ui-listview": "^15.2.3",
     "prettier": "^3.6.2",
     "prettier-plugin-ember-template-tag": "^2.1.0",
-    "qunit": "^2.19.4",
+    "qunit": "^2.24.3",
     "qunit-dom": "^3.4.0",
     "release-it": "^15.10.3",
     "rollup": "^4.46.3",
     "rollup-plugin-copy": "^3.5.0",
     "router_js": "^8.0.6",
-    "sass": "^1.89.2",
+    "sass": "^1.94.2",
     "sass-embedded": "^1.90.0",
     "sass-loader": "^16.0.4",
     "typescript": "^5.9.2",