ember-inspector 4.8.0 → 4.9.0

package/.github/workflows/build.yml

@@ -20,7 +20,7 @@ jobs:
       CI: 'true'
     steps:
       - name: Checkout
-        uses: actions/checkout@v1
+        uses: actions/checkout@v3
       # Code Climate expects these variables to be set
       - name: Set up commit metadata
         if: github.event_name == 'push'
@@ -39,7 +39,7 @@ jobs:
           echo "GIT_COMMIT_SHA=${GIT_COMMIT_SHA}" >> $GITHUB_ENV
           echo "GIT_BRANCH=${GIT_BRANCH}" >> $GITHUB_ENV
       - name: Set up Volta
-        uses: volta-cli/action@v1
+        uses: volta-cli/action@v4
       - name: Install dependencies (yarn)
         run: yarn install
       - name: Lint (hbs)
@@ -94,9 +94,9 @@ jobs:
   
     steps:
       - name: Checkout
-        uses: actions/checkout@v1
+        uses: actions/checkout@v3
       - name: Set up Volta
-        uses: volta-cli/action@v1
+        uses: volta-cli/action@v4
       - name: Install dependencies (yarn)
         run: yarn install
       - name: Set NO_EXTEND_PROTOTYPES
@@ -118,9 +118,9 @@ jobs:
       CI: 'true'
     steps:
       - name: Checkout
-        uses: actions/checkout@v1
+        uses: actions/checkout@v3
       - name: Set up Volta
-        uses: volta-cli/action@v1
+        uses: volta-cli/action@v4
       - name: Install dependencies (yarn)
         run: yarn install
       - name: Download panes
@@ -232,9 +232,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download artifacts (bookmarklet)
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v3
         with:
           name: bookmarklet
+          path: bookmarklet
       - name: Upload to S3
         uses: jakejarvis/s3-sync-action@master
         with:
@@ -258,15 +259,16 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Set up Volta
-        uses: volta-cli/action@v1
+        uses: volta-cli/action@v4
         with:
           node-version: 14.x
       - name: Install dependencies (chrome-webstore-upload-cli)
         run: volta install chrome-webstore-upload-cli
       - name: Download artifacts (Chrome)
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v3
         with:
           name: chrome
+          path: chrome
       - name: Set Environment Variables
         run: |
           if [[ "$GITHUB_EVENT_NAME" == "schedule" ]]; then
@@ -291,7 +293,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Set up Volta
-        uses: volta-cli/action@v1
+        uses: volta-cli/action@v4
         with:
           node-version: 14.x
       - name: Install dependencies (web-ext)
@@ -300,7 +302,7 @@ jobs:
           # https://github.com/mozilla/web-ext/issues/804
           volta install web-ext-submit
       - name: Download artifacts (Firefox)
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v3
         with:
           name: firefox
       - name: Upload to AMO
@@ -323,7 +325,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Set up Volta
-        uses: volta-cli/action@v1
+        uses: volta-cli/action@v4
       - name: Set up NPM
         run: |
           echo "//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}"> ~/.npmrc
@@ -331,9 +333,10 @@ jobs:
         env:
           NPM_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
       - name: Download artifacts (npm)
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v3
         with:
           name: npm
+          path: npm
       - name: Publish to npm
         working-directory: npm
         run: |

package/CHANGELOG.md

@@ -1,6 +1,28 @@
 # Changelog
 
 
+
+## v4.9.0 (2022-10-23)
+
+#### :rocket: Enhancement
+* [#2201](https://github.com/emberjs/ember-inspector/pull/2201) bring back tracked dependencies ([@patricklx](https://github.com/patricklx))
+
+#### :bug: Bug Fix
+* [#1086](https://github.com/emberjs/ember-inspector/pull/1086) Fix more items indicator sometimes not appearing ([@patricklx](https://github.com/patricklx))
+* [#2202](https://github.com/emberjs/ember-inspector/pull/2202) [bug] component tree sometimes does not update ([@patricklx](https://github.com/patricklx))
+* [#2199](https://github.com/emberjs/ember-inspector/pull/2199) [bug] tree view sometimes not updating children ([@patricklx](https://github.com/patricklx))
+* [#2192](https://github.com/emberjs/ember-inspector/pull/2192) fix evented off  ([@patricklx](https://github.com/patricklx))
+* [#2189](https://github.com/emberjs/ember-inspector/pull/2189) fix post message for testem ([@patricklx](https://github.com/patricklx))
+
+#### :house: Internal
+* [#2191](https://github.com/emberjs/ember-inspector/pull/2191) use internal messaging to setup iframes ([@patricklx](https://github.com/patricklx))
+* [#2190](https://github.com/emberjs/ember-inspector/pull/2190) fix publishing  ([@patricklx](https://github.com/patricklx))
+* [#2187](https://github.com/emberjs/ember-inspector/pull/2187) Bump Github actions ([@ctjhoa](https://github.com/ctjhoa))
+
+#### Committers: 2
+- Camille TJHOA ([@ctjhoa](https://github.com/ctjhoa))
+- Patrick Pircher ([@patricklx](https://github.com/patricklx))
+
 ## v4.8.0 (2022-10-12)
 
 #### :rocket: Enhancement

package/app/components/object-inspector/dependent-keys.hbs

@@ -3,18 +3,26 @@
   <ul class="m-0 p-0 list-none">
     {{#each @keys as |depKey|}}
       <li class="mixin__property-dependency-item relative text-base12 text-sm">
+      {{#if (match depKey "•")}}
+        <span
+          class="mixin__property-dependency-name subkey"
+          data-label="object-property-name"
+        >
+          {{depKey}}
+        </span>
+      {{else}}
         {{svg-jar
           "dependent-key-bullet"
           width="9px"
           height="9px"
         }}
-
         <span
           class="mixin__property-dependency-name"
           data-label="object-property-name"
         >
           {{depKey}}
         </span>
+      {{/if}}
       </li>
     {{/each}}
   </ul>

package/app/components/object-inspector/sort-properties.js

@@ -1,13 +1,13 @@
 import { map, sort } from '@ember/object/computed';
 import Component from '@glimmer/component';
-import { get, set, computed } from '@ember/object';
+import { set, computed } from '@ember/object';
 import { A } from '@ember/array';
 
 export default class SortProperties extends Component {
   @computed('args.properties')
   get isArray() {
     const props = A(this.args.properties || []);
-    return props.findBy('name', 'length') && props.findBy('name', 0);
+    return props.findBy('name', 'length') && props.findBy('name', '0');
   }
 
   /**
@@ -19,14 +19,20 @@ export default class SortProperties extends Component {
   @computed('isArray', 'sorted.length')
   get sortedProperties() {
     // limit arrays
-    if (this.isArray && get(this, 'sorted.length') > 100) {
+    let props = A(this.sorted);
+    if (this.isArray) {
+      const item = props.findBy('name', 'length');
+      props.removeObject(item);
+      props.splice(0, 0, item);
+    }
+    if (this.isArray && this.sorted.length > 100) {
       const indicator = {
         name: '...',
         value: {
           inspect: 'there are more items, send to console to see all',
         },
       };
-      const props = this.sorted.slice(0, 100);
+      props = props.slice(0, 100);
       props.push(indicator);
       return props;
     }

package/app/controllers/component-tree.js

@@ -274,6 +274,7 @@ function arrowKeyPressed(keyCode) {
 
 class RenderItem {
   @tracked isExpanded;
+  @tracked renderNode;
 
   constructor(controller, parentItem, renderNode) {
     this.controller = controller;

package/app/services/adapters/basic.js

@@ -93,9 +93,9 @@ export default class Basic extends Service {
     this._messageCallbacks.push(callback);
   }
 
-  _messageReceived(message) {
+  _messageReceived(...args) {
     this._messageCallbacks.forEach((callback) => {
-      callback(message);
+      callback(...args);
     });
   }
 

package/app/services/adapters/web-extension.js

@@ -19,8 +19,8 @@ export default class WebExtension extends BasicAdapter {
   init() {
     this._connect();
     this._handleReload();
-    this._injectDebugger();
     this._setThemeColors();
+    this._sendEmberDebug();
 
     return super.init(...arguments);
   }
@@ -30,6 +30,29 @@ export default class WebExtension extends BasicAdapter {
     this._chromePort.postMessage(options);
   }
 
+  _sendEmberDebug() {
+    loadEmberDebug().then((emberDebug) => {
+      // first send to all frames in current tab
+      this.sendMessage({
+        from: 'devtools',
+        tabId: chrome.devtools.inspectedWindow.tabId,
+        type: 'inject-ember-debug',
+        value: emberDebug,
+      });
+      this.onMessageReceived((message, sender) => {
+        if (message === 'ember-content-script-ready') {
+          this.sendMessage({
+            from: 'devtools',
+            type: 'inject-ember-debug',
+            value: emberDebug,
+            tabId: chrome.devtools.inspectedWindow.tabId,
+            frameId: sender.frameId,
+          });
+        }
+      });
+    });
+  }
+
   @computed
   get _chromePort() {
     return chrome.runtime.connect();
@@ -39,8 +62,8 @@ export default class WebExtension extends BasicAdapter {
     let chromePort = this._chromePort;
     chromePort.postMessage({ appId: chrome.devtools.inspectedWindow.tabId });
 
-    chromePort.onMessage.addListener((message) => {
-      this._messageReceived(message);
+    chromePort.onMessage.addListener((...args) => {
+      this._messageReceived(...args);
     });
   }
 
@@ -137,25 +160,6 @@ function loadEmberDebug() {
       window.addEventListener('Ember', resolve, { once: true });
     });
     waitForEmberLoad.then(() => 'replace-with-ember-debug');
-    const emberInspectorDebug =
-      '(' + loadEmberDebugInWebpage.toString() + ')()';
-    const injectIntoIframe = () => {
-      for (let i = 0; i < window.frames.length; i++) {
-        window.frames[i].postMessage(
-          {
-            type: 'inject-ember-debug',
-            value: emberInspectorDebug,
-          },
-          '*'
-        );
-      }
-    };
-    injectIntoIframe();
-    window.addEventListener('message', (event) => {
-      if (event.data?.type === 'ember-inspector-iframe-ready') {
-        injectIntoIframe();
-      }
-    });
   }
   return new Promise((resolve) => {
     if (!emberDebug) {

package/app/services/port.js

@@ -72,4 +72,12 @@ export default class PortService extends Service.extend(Evented) {
     message.applicationName = this.applicationName;
     this.adapter.sendMessage(message);
   }
+
+  off(...args) {
+    try {
+      super.off(...args);
+    } catch (e) {
+      console.error(e);
+    }
+  }
 }

package/app/styles/object_inspector.scss

@@ -53,6 +53,11 @@
   }
 }
 
+.mixin__property-dependency-name.subkey {
+  left: -11px;
+  position: relative;
+}
+
 .mixin__property-dependency-item:first-child:before {
   display: none;
 }

package/dist/bookmarklet/panes-3-16-0/assets/{chunk.143.8e39f623b854874c76cc.js → chunk.143.3e5a98d07bb218f42c73.js}

@@ -1,5 +1,5 @@
-var __ember_auto_import__;(()=>{var e,r={540:(e,r,t)=>{var o,i
-e.exports=(o=_eai_d,i=_eai_r,window.emberAutoImportDynamic=function(e){return 1===arguments.length?i("_eai_dyn_"+e):i("_eai_dynt_"+e)(Array.prototype.slice.call(arguments,1))},window.emberAutoImportSync=function(e){return i("_eai_sync_"+e)(Array.prototype.slice.call(arguments,1))},o("ember-cli-page-object",[],(function(){return t(359)})),o("ember-cli-page-object/extend",[],(function(){return t(490)})),o("ember-cli-page-object/macros",[],(function(){return t(413)})),void o("tracked-toolbox",[],(function(){return t(173)})))},391:function(e,r){window._eai_r=require,window._eai_d=define},353:e=>{"use strict"
+var __ember_auto_import__;(()=>{var e,r={966:(e,r,t)=>{var o,i
+e.exports=(o=_eai_d,i=_eai_r,window.emberAutoImportDynamic=function(e){return 1===arguments.length?i("_eai_dyn_"+e):i("_eai_dynt_"+e)(Array.prototype.slice.call(arguments,1))},window.emberAutoImportSync=function(e){return i("_eai_sync_"+e)(Array.prototype.slice.call(arguments,1))},o("ember-cli-page-object",[],(function(){return t(359)})),o("ember-cli-page-object/extend",[],(function(){return t(490)})),o("ember-cli-page-object/macros",[],(function(){return t(413)})),void o("tracked-toolbox",[],(function(){return t(173)})))},831:function(e,r){window._eai_r=require,window._eai_d=define},353:e=>{"use strict"
 e.exports=require("@ember/debug")},219:e=>{"use strict"
 e.exports=require("@ember/object")},550:e=>{"use strict"
 e.exports=require("@ember/test-helpers")},521:e=>{"use strict"
@@ -21,6 +21,6 @@ var r=(r,t)=>{var i,n,[a,u,c]=t,l=0
 if(a.some((r=>0!==e[r]))){for(i in u)o.o(u,i)&&(o.m[i]=u[i])
 if(c)var _=c(o)}for(r&&r(t);l<a.length;l++)n=a[l],o.o(e,n)&&e[n]&&e[n][0](),e[n]=0
 return o.O(_)},t=globalThis.webpackChunk_ember_auto_import_=globalThis.webpackChunk_ember_auto_import_||[]
-t.forEach(r.bind(null,0)),t.push=r.bind(null,t.push.bind(t))})(),o.O(void 0,[527],(()=>o(391)))
-var i=o.O(void 0,[527],(()=>o(540)))
+t.forEach(r.bind(null,0)),t.push=r.bind(null,t.push.bind(t))})(),o.O(void 0,[527],(()=>o(831)))
+var i=o.O(void 0,[527],(()=>o(966)))
 i=o.O(i),__ember_auto_import__=i})()

package/dist/{firefox/panes-3-16-0/assets/chunk.178.aceef4d5ceb9d49b48f7.js → bookmarklet/panes-3-16-0/assets/chunk.178.8599f53165a2cb11480c.js}

@@ -1,4 +1,4 @@
-var __ember_auto_import__;(()=>{var r,e={391:function(r,e){window._eai_r=require,window._eai_d=define},253:(r,e,o)=>{var i,t
+var __ember_auto_import__;(()=>{var r,e={831:function(r,e){window._eai_r=require,window._eai_d=define},411:(r,e,o)=>{var i,t
 r.exports=(i=_eai_d,t=_eai_r,window.emberAutoImportDynamic=function(r){return 1===arguments.length?t("_eai_dyn_"+r):t("_eai_dynt_"+r)(Array.prototype.slice.call(arguments,1))},window.emberAutoImportSync=function(r){return t("_eai_sync_"+r)(Array.prototype.slice.call(arguments,1))},void i("qunit",[],(function(){return o(916)})))}},o={}
 function i(r){var t=o[r]
 if(void 0!==t)return t.exports
@@ -15,6 +15,6 @@ var e=(e,o)=>{var t,n,[a,_,l]=o,p=0
 if(a.some((e=>0!==r[e]))){for(t in _)i.o(_,t)&&(i.m[t]=_[t])
 if(l)var u=l(i)}for(e&&e(o);p<a.length;p++)n=a[p],i.o(r,n)&&r[n]&&r[n][0](),r[n]=0
 return i.O(u)},o=globalThis.webpackChunk_ember_auto_import_=globalThis.webpackChunk_ember_auto_import_||[]
-o.forEach(e.bind(null,0)),o.push=e.bind(null,o.push.bind(o))})(),i.O(void 0,[916],(()=>i(391)))
-var t=i.O(void 0,[916],(()=>i(253)))
+o.forEach(e.bind(null,0)),o.push=e.bind(null,o.push.bind(o))})(),i.O(void 0,[916],(()=>i(831)))
+var t=i.O(void 0,[916],(()=>i(411)))
 t=i.O(t),__ember_auto_import__=t})()

package/dist/{firefox/panes-3-16-0/assets/chunk.527.7db717391df5e1aa2388.js → bookmarklet/panes-3-16-0/assets/chunk.527.bedf7967198bca66753a.js}

@@ -1,4 +1,4 @@
-/*! For license information please see chunk.527.7db717391df5e1aa2388.js.LICENSE.txt */
+/*! For license information please see chunk.527.bedf7967198bca66753a.js.LICENSE.txt */
 (globalThis.webpackChunk_ember_auto_import_=globalThis.webpackChunk_ember_auto_import_||[]).push([[527],{348:(e,t,n)=>{"use strict"
 function r(e){return e&&e.isDescriptor?"descriptor":null===e?"null":typeof e}function i(e,t,n,i){var o={configurable:!0,enumerable:!0}
 "undefined"!==r(i)?o.get=i:(o.writable=!1,o.value=n),Object.defineProperty(e,t,o)}function o(e,t){delete e.__parentTreeNode,t&&Object.defineProperty(e,"__parentTreeNode",{value:t,configurable:!0,enumerable:!1})}function s(e,t){this.blueprint=e,this.builders=t}n.d(t,{Z:()=>u}),s.prototype={builderFor:function(e){return this.builders[r(e)]||this.builders.default},build:function(e){var t,n={}