ember-exam 7.0.0 → 7.0.1

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## v7.0.1 (2021-11-02)
+#### :bug: Bug Fix
+* [#760](https://github.com/ember-cli/ember-exam/pull/760) Wait for all browser to completet beforer cleaning up StateManager([@step2yeung](https://github.com/step2yeung))
+* [#750](https://github.com/ember-cli/ember-exam/pull/750) Ember exam failing when browser ID not found, return 0([@step2yeung](https://github.com/step2yeung))
+
+#### :house: Internal
+* [#748](https://github.com/ember-cli/ember-exam/pull/748) Add eslint-plugin-qunit per latest addon blueprint  internal ([@SergeAstapov](https://github.com/SergeAstapov))
+* [#744](https://github.com/ember-cli/ember-exam/pull/744) Update npmignore file internal([@Turbo87](https://github.com/Turbo87))
+#### Committers: 4
+
+- Sergey Astapov ([@SergeAstapov](https://github.com/SergeAstapov))
+- Tobias Bieniek ([@Turbo87](https://github.com/Turbo87))
+- Stephen Yeung ([@step2yeung](https://github.com/step2yeung))
+
 ## v7.0.0 (2021-10-22)
 
 #### :boom: Breaking Change

package/lib/commands/exam.js

@@ -292,26 +292,24 @@ module.exports = TestCommand.extend({
     const browserExitHandler = function (failed = false) {
       const launcherId = this.launcher.id;
       if (!failed && commands.get('loadBalance')) {
-        try {
-          const browserId = getBrowserId(this.launcher);
-          log.info(
-            `Browser ${browserId} exiting. [ # of modules in current module queue ${
-              testemEvents.stateManager.getTestModuleQueue().length
-            } ]`
-          );
-        } catch (err) {
-          const moduleQueueMessage =
-            testemEvents.stateManager.getTestModuleQueue() === null
-              ? 'testModuleQueue is not set.'
-              : `[ # of modules in current module queue ${
-                  testemEvents.stateManager.getTestModuleQueue().length
-                } ]`;
-
-          if (typeof err === 'object' && err !== null) {
-            err.message = `${err.message} \n ${moduleQueueMessage}`;
-            ui.writeLine(err.message);
+        const browserId = getBrowserId(this.launcher);
+        log.info(
+          `Browser ${browserId} exiting. [ # of modules in current module queue ${
+            testemEvents.stateManager.getTestModuleQueue().length
+          } ]`
+        );
+        // if getBrowserId cannot get the browserId
+        // but the test queue is not empty, report the number of test modules left in the queue
+        // otherwise, fail because testModuleQueue was not set
+        if (browserId === 0) {
+          if (testemEvents.stateManager.getTestModuleQueue() !== null) {
+            ui.writeLine(
+              `[ # of modules in current module queue ${
+                testemEvents.stateManager.getTestModuleQueue().length
+              } ]`
+            );
           } else {
-            throw new Error(moduleQueueMessage);
+            throw new Error('testModuleQueue is not set.');
           }
         }
       }

package/lib/utils/test-page-helper.js

@@ -137,8 +137,9 @@ function getBrowserId(launcher) {
     const errMsg = `${err.message} \n${
       err.stack
     } \nLauncher Settings: ${JSON.stringify(launcher.settings, null, 2)}`;
-    throw new Error(errMsg);
+    console.warn(errMsg);
   }
+  return 0;
 }
 
 /**

package/lib/utils/testem-events.js

@@ -224,7 +224,8 @@ class TestemEvents {
     let browsersCompleted = false;
 
     this.stateManager.incrementCompletedBrowsers(launcherId);
-    if (this.stateManager.getCompletedBrowser() === browsersStarted.size) {
+    const completedBrowser = this.stateManager.getCompletedBrowser();
+    if (completedBrowser === browsersStarted.size) {
       if (commands.get('writeModuleMetadataFile')) {
         const moduleDetailFileName = path.join(
           this.root,
@@ -260,9 +261,16 @@ class TestemEvents {
       }
 
       ui.writeLine(
-        `Out of requested ${browserCount} browser(s), ${browsersStarted.size} browser(s) has launched.`
+        `Out of requested ${browserCount} browser(s), ${browsersStarted.size} browser(s) was launched & completed.`
       );
 
+      if (browserCount !== browsersStarted.size) {
+        ui.writeLine('Waiting for remaining browsers to exited.');
+      }
+    }
+
+    if (completedBrowser === browserCount) {
+      ui.writeLine('All browsers to exited.');
       // --server mode allows rerun of tests by refreshing the browser
       // replayExecutionMap should be reused so the test-execution json
       // does not need to be reread

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-exam",
-  "version": "7.0.0",
+  "version": "7.0.1",
   "description": "Run your tests with randomization, splitting, and parallelization for beautiful tests.",
   "keywords": [
     "ember-addon"
@@ -84,11 +84,12 @@
     "eslint-plugin-ember": "^8.9.1",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^4.0.0",
+    "eslint-plugin-qunit": "^6.2.0",
     "fixturify": "^1.2.0",
     "istanbul": "^0.4.3",
     "loader.js": "^4.7.0",
     "lodash.mergewith": "^4.6.2",
-    "mocha": "^8.4.0",
+    "mocha": "^9.1.3",
     "mocha-eslint": "^6.0.0",
     "npm-run-all": "^4.1.5",
     "nyc": "^15.1.0",

package/.codeclimate.yml

@@ -1,20 +0,0 @@
----
-engines:
-  duplication:
-    enabled: true
-    config:
-      languages:
-        javascript:
-          mass_threshold: 50
-
-  eslint:
-    enabled: true
-  fixme:
-    enabled: true
-ratings:
-  paths:
-  - "**.js"
-exclude_paths:
-- config/
-- tests/
-- vendor/

package/.github/dependabot.yml

@@ -1,40 +0,0 @@
-version: 2
-updates:
-- package-ecosystem: npm
-  directory: "/"
-  schedule:
-    interval: monthly
-    time: "03:00"
-  open-pull-requests-limit: 10
-  versioning-strategy: increase
-  ignore:
-  - dependency-name: ember-cli-babel
-    versions:
-    - 7.23.1
-  - dependency-name: eslint
-    versions:
-    - 7.16.0
-    - 7.19.0
-  - dependency-name: ember-source
-    versions:
-    - 3.24.0
-    - 3.24.1
-  - dependency-name: ember-cli
-    versions:
-    - 3.23.0
-    - 3.24.0
-  - dependency-name: sinon
-    versions:
-    - 9.2.2
-  - dependency-name: eslint-plugin-ember
-    versions:
-    - 10.1.1
-  - dependency-name: ini
-    versions:
-    - 1.3.7
-  - dependency-name: mocha
-    versions:
-    - 8.2.1
-  - dependency-name: elliptic
-    versions:
-    - 6.5.3

package/.github/workflows/ci.yml

@@ -1,68 +0,0 @@
-name: CI Build
-
-on:
-  push:
-    branches: [ master, 'v*' ]
-  pull_request:
-    branches: [ master ]
-
-
-jobs:
-  test:
-    name: Tests
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v2
-      - uses: volta-cli/action@v1
-      - run: yarn install --frozen-lockfile
-      - run: yarn lint
-      - run: yarn test:ember
-
-  floating-dependencies:
-    name: "Floating Dependencies"
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v2
-      - uses: volta-cli/action@v1
-      - run: yarn install --no-lockfile
-      - run: yarn test:ember
-
-  try-scenarios:
-    name: "Try: ${{ matrix.ember-try-scenario }}"
-
-    runs-on: ubuntu-latest
-
-    needs: test
-
-    strategy:
-      fail-fast: false
-      matrix:
-        ember-try-scenario:
-          - ember-default-with-jquery
-          - ember-default-with-mocha
-          - ember-classic
-          - embroider-safe
-          - embroider-safe-with-mocha
-          - embroider-optimized
-          - embroider-optimized-with-mocha
-          - ember-lts-3.24
-          - ember-lts-3.20
-          - ember-lts-3.16
-          - ember-lts-3.12
-          - ember-release
-          # temporarily disabled until we've fixed support for Ember.js v4
-          # - ember-beta
-          # - ember-canary
-          - ember-qunit-4
-
-    steps:
-      - uses: actions/checkout@v2
-      - uses: volta-cli/action@v1
-        with:
-          node-version: 12.x
-      - name: install dependencies
-        run: yarn install --frozen-lockfile
-      - name: test
-        run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup

package/.github/workflows/release.yml

@@ -1,25 +0,0 @@
-name: Release
-
-on:
-  push:
-    tags:
-      - 'v*'
-
-jobs:
-  release:
-    name: release
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
-        with:
-          node-version: 14
-          registry-url: 'https://registry.npmjs.org'
-
-      - run: yarn install
-      - run: yarn auto-dist-tag --write
-
-      - run: npm publish
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

package/.prettierignore

@@ -1,25 +0,0 @@
-# unconventional js
-/blueprints/*/files/
-/vendor/
-
-# compiled output
-/dist/
-/tmp/
-
-# dependencies
-/bower_components/
-/node_modules/
-
-# misc
-/coverage/
-!.*
-.eslintcache
-.lint-todo/
-
-# ember-try
-/.node_modules.ember-try/
-/bower.json.ember-try
-/npm-shrinkwrap.json.ember-try
-/package.json.ember-try
-/package-lock.json.ember-try
-/yarn.lock.ember-try

package/.prettierrc.js

@@ -1,5 +0,0 @@
-'use strict';
-
-module.exports = {
-  singleQuote: true,
-};

package/CONTRIBUTING.md

@@ -1,27 +0,0 @@
-# How To Contribute
-
-## Installation
-
-- `git clone https://github.com/ember-cli/ember-exam.git`
-- `cd ember-exam`
-- `yarn install`
-
-## Linting
-
-- `yarn lint:hbs`
-- `yarn lint:js`
-- `yarn lint:js --fix`
-
-## Running tests
-
-- `ember test` – Runs the test suite on the current Ember version
-- `ember test --server` – Runs the test suite in "watch mode"
-- `yarn test:node` - Runs the node tests
-- `yarn test:all` – Runs the test suite against multiple Ember versions
-
-## Running the dummy application
-
-- `ember serve`
-- Visit the dummy application at [http://localhost:4200](http://localhost:4200).
-
-For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).

package/RELEASE.md

@@ -1,60 +0,0 @@
-# Release Process
-
-Releases are mostly automated using
-[release-it](https://github.com/release-it/release-it/) and
-[lerna-changelog](https://github.com/lerna/lerna-changelog/).
-
-## Preparation
-
-Since the majority of the actual release process is automated, the primary
-remaining task prior to releasing is confirming that all pull requests that
-have been merged since the last release have been labeled with the appropriate
-`lerna-changelog` labels and the titles have been updated to ensure they
-represent something that would make sense to our users. Some great information
-on why this is important can be found at
-[keepachangelog.com](https://keepachangelog.com/en/1.0.0/), but the overall
-guiding principle here is that changelogs are for humans, not machines.
-
-When reviewing merged PR's the labels to be used are:
-
-* breaking - Used when the PR is considered a breaking change.
-* enhancement - Used when the PR adds a new feature or enhancement.
-* bug - Used when the PR fixes a bug included in a previous release.
-* documentation - Used when the PR adds or updates documentation.
-* internal - Used for internal changes that still require a mention in the
-  changelog/release notes.
-
-## Release
-
-Once the prep work is completed, the actual release is straight forward:
-
-* First, ensure that you have installed your projects dependencies:
-
-```sh
-yarn install
-```
-
-* Second, ensure that you have obtained a
-  [GitHub personal access token][generate-token] with the `repo` scope (no
-  other permissions are needed). Make sure the token is available as the
-  `GITHUB_AUTH` environment variable.
-
-  For instance:
-
-  ```bash
-  export GITHUB_AUTH=abc123def456
-  ```
-
-[generate-token]: https://github.com/settings/tokens/new?scopes=repo&description=GITHUB_AUTH+env+variable
-
-* And last (but not least 😁) do your release.
-
-```sh
-npx release-it
-```
-
-[release-it](https://github.com/release-it/release-it/) manages the actual
-release process. It will prompt you to to choose the version number after which
-you will have the chance to hand tweak the changelog to be used (for the
-`CHANGELOG.md` and GitHub release), then `release-it` continues on to tagging,
-pushing the tag and commits, etc.

package/addon-test-support/.eslintrc

@@ -1,6 +0,0 @@
-{
-  "env": {
-    "browser": true,
-    "node": false
-  }
-}

package/bin/install-test-framework.sh

@@ -1,5 +0,0 @@
-#!/bin/bash
-set -ev
-if [ "${TEST_FRAMEWORK}" = "ember-mocha" ]; then
-  yarn remove ember-qunit 2>/dev/null && echo "n" | ember install ember-mocha || true
-fi

package/config/deploy.js

@@ -1,29 +0,0 @@
-/* eslint-env node */
-'use strict';
-
-module.exports = function (deployTarget) {
-  let ENV = {
-    build: {},
-    // include other plugin configuration that applies to all deploy targets here
-  };
-
-  if (deployTarget === 'development') {
-    ENV.build.environment = 'development';
-    // configure other plugins for development deploy target here
-  }
-
-  if (deployTarget === 'staging') {
-    ENV.build.environment = 'production';
-    // configure other plugins for staging deploy target here
-  }
-
-  if (deployTarget === 'production') {
-    ENV.build.environment = 'production';
-    // configure other plugins for production deploy target here
-  }
-
-  // Note: if you need to build some configuration asynchronously, you can return
-  // a promise that resolves with the ENV object instead of returning the
-  // ENV object synchronously.
-  return ENV;
-};

package/config/environment.js

@@ -1,5 +0,0 @@
-'use strict';
-
-module.exports = function (/* environment, appConfig */) {
-  return {};
-};

package/lib/.eslintrc

@@ -1,5 +0,0 @@
-{
-  "rules": {
-    "no-var": 0
-  }
-}

package/node-tests/.eslintrc

@@ -1,8 +0,0 @@
-{
-  "env": {
-    "mocha": true
-  },
-  "rules": {
-    "no-var": 0
-  }
-}

package/node-tests/acceptance/exam-iterate-test.js

@@ -1,177 +0,0 @@
-'use strict';
-
-const assert = require('assert');
-const execa = require('execa');
-const rimraf = require('rimraf');
-const fs = require('fs-extra');
-const path = require('path');
-
-function assertExpectRejection() {
-  assert.ok(false, 'Expected promise to reject, but it fullfilled');
-}
-
-describe('Acceptance | Exam Iterate Command', function () {
-  this.timeout(300000);
-
-  it('should build the app, test it a number of times, and clean it up', function () {
-    return execa('ember', ['exam:iterate', '2'], (child) => {
-      const stdout = child.stdout;
-      assert.ok(
-        stdout.includes('Building app for test iterations.'),
-        'Logged building message from command'
-      );
-      assert.ok(
-        stdout.includes('Built project successfully.'),
-        'Built successfully according to Ember-CLI'
-      );
-
-      assert.ok(
-        stdout.includes('Running iteration #1.'),
-        'Logs first iteration'
-      );
-      assert.ok(
-        stdout.includes('Running iteration #2.'),
-        'Logs second iteration'
-      );
-
-      const seedRE = /Randomizing tests with seed: (.*)/g;
-
-      const firstSeed = seedRE.exec(stdout)[1];
-      const secondSeed = seedRE.exec(stdout)[1];
-
-      assert.ok(firstSeed, 'first seed exists');
-      assert.ok(secondSeed, 'second seed exists');
-      assert.notEqual(
-        firstSeed,
-        secondSeed,
-        'the first and second seeds are not the same'
-      );
-
-      assert.ok(
-        stdout.includes('Cleaning up test iterations.'),
-        'Logged cleaning up message from command'
-      );
-      assert.throws(
-        () => fs.accessSync('iteration-dist', fs.F_OK),
-        'iteration-dist is cleaned up'
-      );
-    });
-  });
-
-  it('should test the app with additional options passed in and catch failure cases', function () {
-    const execution = execa('ember', [
-      'exam:iterate',
-      '2',
-      '--options',
-      '--parallel',
-    ]);
-    return execution.then(assertExpectRejection, (error) => {
-      const splitErrorRE =
-        /You must specify the `split` option in order to run your tests in parallel./g;
-
-      assert.ok(
-        splitErrorRE.test(error.stderr),
-        'expected stderr to contain the appropriate error message'
-      );
-      assert.equal(error.exitCode, 1);
-      assert.equal(error.failed, true);
-      assert.equal(error.killed, false);
-    });
-  });
-
-  describe('building', function () {
-    const buildDir = path.join(process.cwd(), 'dist');
-
-    afterEach(() => rimraf.sync(buildDir));
-
-    it('should not build the app or clean it up, but use an existing build to test', function () {
-      execa.sync('ember', ['build']);
-
-      return execa('ember', ['exam:iterate', '2', '--path', 'dist']).then(
-        (child) => {
-          const stdout = child.stdout;
-
-          assert.ok(
-            !stdout.includes('Building app for test iterations.'),
-            'No logged building message from command'
-          );
-          assert.ok(
-            !stdout.includes('Built project successfully.'),
-            'Not built successfully according to Ember-CLI'
-          );
-
-          assert.ok(
-            stdout.includes('Running iteration #1.'),
-            'Logs first iteration'
-          );
-          assert.ok(
-            stdout.includes('Running iteration #2.'),
-            'Logs second iteration'
-          );
-
-          const seedRE = /Randomizing tests with seed: (.*)/g;
-
-          const firstSeed = seedRE.exec(stdout)[1];
-          const secondSeed = seedRE.exec(stdout)[1];
-
-          assert.ok(firstSeed, 'first seed exists');
-          assert.ok(secondSeed, 'second seed exists');
-          assert.notEqual(
-            firstSeed,
-            secondSeed,
-            'the first and second seeds are not the same'
-          );
-
-          assert.ok(
-            !stdout.includes('Cleaning up test iterations.'),
-            'No logged cleaning up message from command'
-          );
-          assert.throws(
-            () => fs.accessSync('iteration-dist', fs.F_OK),
-            'iteration-dist is non-existent'
-          );
-
-          assert.doesNotThrow(
-            () => fs.accessSync(buildDir, fs.F_OK),
-            'dist is not cleaned up'
-          );
-        }
-      );
-    });
-  });
-
-  describe('Exit Code', function () {
-    const destPath = path.join(
-      __dirname,
-      '..',
-      '..',
-      'tests',
-      'unit',
-      'failing-test.js'
-    );
-
-    beforeEach(function () {
-      const failingTestPath = path.join(
-        __dirname,
-        '..',
-        'fixtures',
-        'failure.js'
-      );
-      fs.copySync(failingTestPath, destPath);
-    });
-
-    afterEach(function () {
-      fs.removeSync(destPath);
-    });
-
-    it('should have an exitCode of 1 when a test fails', function () {
-      return execa('ember', ['exam:iterate', '1']).then(
-        assertExpectRejection,
-        (error) => {
-          assert.equal(error.exitCode, 1);
-          assert.equal(error.killed, false);
-        }
-      );
-    });
-  });
-});