ember-exam 6.0.0 → 7.0.1

package/CHANGELOG.md

@@ -1,3 +1,67 @@
+# Changelog
+
+## v7.0.1 (2021-11-02)
+#### :bug: Bug Fix
+* [#760](https://github.com/ember-cli/ember-exam/pull/760) Wait for all browser to completet beforer cleaning up StateManager([@step2yeung](https://github.com/step2yeung))
+* [#750](https://github.com/ember-cli/ember-exam/pull/750) Ember exam failing when browser ID not found, return 0([@step2yeung](https://github.com/step2yeung))
+
+#### :house: Internal
+* [#748](https://github.com/ember-cli/ember-exam/pull/748) Add eslint-plugin-qunit per latest addon blueprint  internal ([@SergeAstapov](https://github.com/SergeAstapov))
+* [#744](https://github.com/ember-cli/ember-exam/pull/744) Update npmignore file internal([@Turbo87](https://github.com/Turbo87))
+#### Committers: 4
+
+- Sergey Astapov ([@SergeAstapov](https://github.com/SergeAstapov))
+- Tobias Bieniek ([@Turbo87](https://github.com/Turbo87))
+- Stephen Yeung ([@step2yeung](https://github.com/step2yeung))
+
+## v7.0.0 (2021-10-22)
+
+#### :boom: Breaking Change
+* [#739](https://github.com/ember-cli/ember-exam/pull/739) Update `ember-auto-import` to v2.x ([@Turbo87](https://github.com/Turbo87))
+* [#690](https://github.com/ember-cli/ember-exam/pull/690) Drop support for Node 10 and upgrade deps ([@nlfurniss](https://github.com/nlfurniss))
+
+#### :bug: Bug Fix
+* [#688](https://github.com/ember-cli/ember-exam/pull/688) Fix embroider tests ([@nlfurniss](https://github.com/nlfurniss))
+
+#### :memo: Documentation
+* [#687](https://github.com/ember-cli/ember-exam/pull/687) Update README.md: Fix typo in flag name ([@bantic](https://github.com/bantic))
+* [#644](https://github.com/ember-cli/ember-exam/pull/644) Docs: Fix information on Load Balancing ([@brkn](https://github.com/brkn))
+
+#### :house: Internal
+* [#743](https://github.com/ember-cli/ember-exam/pull/743) CI: Add `release` workflow ([@Turbo87](https://github.com/Turbo87))
+* [#737](https://github.com/ember-cli/ember-exam/pull/737) Use `prettier` to format JS files ([@Turbo87](https://github.com/Turbo87))
+* [#736](https://github.com/ember-cli/ember-exam/pull/736) CI: Disable Ember.js v4 scenarios ([@Turbo87](https://github.com/Turbo87))
+* [#689](https://github.com/ember-cli/ember-exam/pull/689) Set ember edition to Octane to quiet build logging ([@nlfurniss](https://github.com/nlfurniss))
+
+#### Committers: 4
+- Berkan Ünal ([@brkn](https://github.com/brkn))
+- Cory Forsyth ([@bantic](https://github.com/bantic))
+- Nathaniel Furniss ([@nlfurniss](https://github.com/nlfurniss))
+- Tobias Bieniek ([@Turbo87](https://github.com/Turbo87))
+
+
+## v6.1.0 (2021-02-17)
+
+#### :rocket: Enhancement
+* [#652](https://github.com/ember-cli/ember-exam/pull/652) Update to support `ember-qunit@5` ([@thoov](https://github.com/thoov))
+
+#### Committers: 1
+- Travis Hoover ([@thoov](https://github.com/thoov))
+
+
+## v6.0.1 (2020-10-28)
+
+#### :bug: Bug Fix
+* [#617](https://github.com/ember-cli/ember-exam/pull/617) Update @embroider/macros to fix ember-qunit@5.0.0-beta support. ([@rwjblue](https://github.com/rwjblue))
+
+#### :house: Internal
+* [#618](https://github.com/ember-cli/ember-exam/pull/618) Swap to GitHub actions for CI. ([@rwjblue](https://github.com/rwjblue))
+
+#### Committers: 2
+- Robert Jackson ([@rwjblue](https://github.com/rwjblue))
+- [@dependabot-preview[bot]](https://github.com/apps/dependabot-preview)
+
+
 ## v6.0.0 (2020-10-12)
 
 #### :boom: Breaking Change

package/README.md

@@ -302,7 +302,7 @@ You can also specify the `split` and `partition` options with `load-balance` to
 $ ember exam --split=<num> --partition=<num> --parallel=<num> --load-balance
 ```
 
-This command will split test files and load-balance tests from the specified partition across the browsers. For example `ember exam --split=2 -partition=1 --parallel=3 --load-balance`, the complete list of test files are split into two halves. With the first half of the list load balanced against three browsers. The output will look something like below:
+This command will split test files and load-balance tests from the specified partition across the browsers. For example `ember exam --split=2 --partition=1 --parallel=3 --load-balance`, the complete list of test files are split into two halves. With the first half of the list load balanced against three browsers. The output will look something like below:
 
 ```bash
 # ember exam --split=2 --partition=1 --parallel=3 --load-balance
@@ -317,9 +317,8 @@ ok 3 Chrome 66.0 - Exam Partition 1 - browser Id 3 - some the other test
 1. The `--load-balance` option is currently only supported in CI mode and for that reason no-launch cannot be used with load-balance.
 2. You must be using `ember-cli` version 3.2.0 or greater for load balancing and test failure reproduction features to work properly.
 3. You must be using `ember-qunit` version 4.1.1 or greater for this feature to work properly.
-4. You must be using `qunit` version 2.8.0 or greater for this feature to work properly.
+4. You must be using `qunit` version 2.13.0 or greater for this feature to work properly.
 5. This feature is not currently supported by Mocha.
-6. `--random[=<seed>]` does not (currently) work with load balancing. This will be fixed once https://github.com/qunitjs/qunit/pull/1417 lands. 
 
 ##### Test Failure Reproduction
 

package/addon-test-support/-private/async-iterator.js

@@ -39,9 +39,7 @@ export default class AsyncIterator {
    * @return {String} the stringified value of the iterator.
    */
   toString() {
-    return `<AsyncIterator (request: ${this._request} response: ${
-      this._response
-    })>`;
+    return `<AsyncIterator (request: ${this._request} response: ${this._response})>`;
   }
 
   /**
@@ -113,16 +111,14 @@ export default class AsyncIterator {
 
       if (this._emberExamExitOnError) {
         let err = new Error(
-          `EmberExam: Promise timed out after ${
-            this._timeout
-          } s while waiting for response for ${this._request}`
+          `EmberExam: Promise timed out after ${this._timeout} s while waiting for response for ${this._request}`
         );
         reject(err);
       } else {
         // eslint-disable-next-line no-console
-        console.error(`EmberExam: Promise timed out after ${
-          this._timeout
-        } s while waiting for response for ${this._request}. Closing browser to exit gracefully.`);
+        console.error(
+          `EmberExam: Promise timed out after ${this._timeout} s while waiting for response for ${this._request}. Closing browser to exit gracefully.`
+        );
         resolve(iteratorCompleteResponse);
       }
     }, this._timeout * 1000);
@@ -153,7 +149,7 @@ export default class AsyncIterator {
     this._current = {
       resolve,
       reject,
-      promise
+      promise,
     };
 
     this._makeNextRequest();

package/addon-test-support/-private/ember-exam-mocha-test-loader.js

@@ -1,6 +1,6 @@
 import getUrlParams from './get-url-params';
 import splitTestModules from './split-test-modules';
-import { filterTestModules} from './filter-test-modules';
+import { filterTestModules } from './filter-test-modules';
 import { TestLoader } from 'ember-mocha/test-loader';
 
 /**
@@ -28,7 +28,7 @@ export default class EmberExamMochaTestLoader extends TestLoader {
    * @method load
    */
   static load() {
-    throw new Error('`EmberExamMochaTestLoader` doesn\'t support `load()`.');
+    throw new Error("`EmberExamMochaTestLoader` doesn't support `load()`.");
   }
 
   /**

package/addon-test-support/-private/ember-exam-qunit-test-loader.js

@@ -33,7 +33,7 @@ export default class EmberExamQUnitTestLoader extends TestLoader {
    * @method load
    */
   static load() {
-    throw new Error('`EmberExamQUnitTestLoader` doesn\'t support `load()`.');
+    throw new Error("`EmberExamQUnitTestLoader` doesn't support `load()`.");
   }
 
   /**
@@ -178,8 +178,13 @@ export default class EmberExamQUnitTestLoader extends TestLoader {
               return nextModuleHandler();
             }
           }
-        }).catch(e => {
-          if (typeof e === 'object' && e !== null && typeof e.message === 'string') {
+        })
+        .catch((e) => {
+          if (
+            typeof e === 'object' &&
+            e !== null &&
+            typeof e.message === 'string'
+          ) {
             e.message = `EmberExam: Failed to get next test module: ${e.message}`;
           }
           throw new Error(`EmberExam: Failed to get next test module: ${e}`);

package/addon-test-support/-private/filter-test-modules.js

@@ -10,7 +10,7 @@ const TEST_PATH_REGEX = /\/tests\/(.*?)$/;
  * @param {*} modulePath
  */
 function getRegexFilter(modulePath) {
-  return MODULE_PATH_REGEXP.exec( modulePath );
+  return MODULE_PATH_REGEXP.exec(modulePath);
 }
 
 /**
@@ -23,7 +23,11 @@ function getRegexFilter(modulePath) {
  */
 function wildcardFilter(module, moduleFilter) {
   // Generate a regular expression to handle wildcard from path filter
-  const moduleFilterRule = ['^.*', moduleFilter.split('*').join('.*'), '$'].join('');
+  const moduleFilterRule = [
+    '^.*',
+    moduleFilter.split('*').join('.*'),
+    '$',
+  ].join('');
   return new RegExp(moduleFilterRule).test(module);
 }
 
@@ -35,7 +39,10 @@ function wildcardFilter(module, moduleFilter) {
  * @param {string} moduleFilter
  */
 function stringFilter(modules, moduleFilter) {
-  return modules.filter( module => module.includes(moduleFilter) || wildcardFilter(module, moduleFilter) );
+  return modules.filter(
+    (module) =>
+      module.includes(moduleFilter) || wildcardFilter(module, moduleFilter)
+  );
 }
 
 /**
@@ -49,7 +56,9 @@ function regexFilter(modules, modulePathRegexFilter) {
   const re = new RegExp(modulePathRegexFilter[2], modulePathRegexFilter[3]);
   const exclude = modulePathRegexFilter[1];
 
-  return modules.filter( module => !exclude && re.test(module) || exclude && !re.test(module) );
+  return modules.filter(
+    (module) => (!exclude && re.test(module)) || (exclude && !re.test(module))
+  );
 }
 
 /**
@@ -60,7 +69,7 @@ function regexFilter(modules, modulePathRegexFilter) {
  */
 function convertFilePathToModulePath(filePath) {
   const filePathWithNoExtension = filePath.replace(/\.[^/.]+$/, '');
-  const testFilePathMatch =  TEST_PATH_REGEX.exec( filePathWithNoExtension );
+  const testFilePathMatch = TEST_PATH_REGEX.exec(filePathWithNoExtension);
   if (typeof filePath !== 'undefined' && testFilePathMatch !== null) {
     return testFilePathMatch[0];
   }
@@ -78,26 +87,35 @@ function convertFilePathToModulePath(filePath) {
  */
 function filterTestModules(modules, modulePath, filePath) {
   // Generates an array with module filter value seperated by comma (,).
-  const moduleFilters = (filePath || modulePath).split(',').map( value => value.trim());
+  const moduleFilters = (filePath || modulePath)
+    .split(',')
+    .map((value) => value.trim());
 
   const filteredTestModules = moduleFilters.reduce((result, moduleFilter) => {
     const modulePath = convertFilePathToModulePath(moduleFilter);
     const modulePathRegex = getRegexFilter(modulePath);
 
     if (modulePathRegex) {
-      return result.concat(regexFilter(modules, modulePathRegex).filter( module => result.indexOf(module) === -1 ));
+      return result.concat(
+        regexFilter(modules, modulePathRegex).filter(
+          (module) => result.indexOf(module) === -1
+        )
+      );
     } else {
-      return result.concat(stringFilter(modules, modulePath).filter( module => result.indexOf(module) === -1 ));
+      return result.concat(
+        stringFilter(modules, modulePath).filter(
+          (module) => result.indexOf(module) === -1
+        )
+      );
     }
   }, []);
 
   if (filteredTestModules.length === 0) {
-    throw new Error(`No tests matched with the filter: ${modulePath || filePath}.`);
+    throw new Error(
+      `No tests matched with the filter: ${modulePath || filePath}.`
+    );
   }
   return filteredTestModules;
 }
 
-export {
-  convertFilePathToModulePath,
-  filterTestModules
-}
+export { convertFilePathToModulePath, filterTestModules };

package/addon-test-support/-private/get-test-loader.js

@@ -1,4 +1,8 @@
-import { dependencySatisfies, macroCondition, importSync } from '@embroider/macros';
+import {
+  dependencySatisfies,
+  macroCondition,
+  importSync,
+} from '@embroider/macros';
 
 /**
  * Returns ember-exam-qunit-test-loader or ember-exam-mocha-test-loader
@@ -8,11 +12,15 @@ import { dependencySatisfies, macroCondition, importSync } from '@embroider/macr
  * @return {Object}
  */
 export default function getTestLoader() {
-  if (macroCondition(dependencySatisfies('ember-qunit', '*'))){
-    const EmberExamQUnitTestLoader = importSync('./ember-exam-qunit-test-loader');
+  if (macroCondition(dependencySatisfies('ember-qunit', '*'))) {
+    const EmberExamQUnitTestLoader = importSync(
+      './ember-exam-qunit-test-loader'
+    );
     return EmberExamQUnitTestLoader['default'];
-  } else if (macroCondition(dependencySatisfies('ember-mocha', '*'))){
-    const EmberExamMochaTestLoader = importSync('./ember-exam-mocha-test-loader');
+  } else if (macroCondition(dependencySatisfies('ember-mocha', '*'))) {
+    const EmberExamMochaTestLoader = importSync(
+      './ember-exam-mocha-test-loader'
+    );
     return EmberExamMochaTestLoader['default'];
   }
 

package/addon-test-support/-private/split-test-modules.js

@@ -51,9 +51,9 @@ export default function splitTestModules(modules, split, partitions) {
     const partition = parseInt(partitions[i], 10);
     if (isNaN(partition)) {
       throw new Error(
-        'You must specify numbers for partition (you specified \'' +
+        "You must specify numbers for partition (you specified '" +
           partitions +
-          '\')'
+          "')"
       );
     }
 

package/addon-test-support/-private/weight-test-modules.js

@@ -2,7 +2,7 @@ const TEST_TYPE_WEIGHT = {
   eslint: 1,
   unit: 10,
   integration: 20,
-  acceptance: 150
+  acceptance: 150,
 };
 const WEIGHT_REGEX = /\/(eslint|unit|integration|acceptance)\//;
 const DEFAULT_WEIGHT = 50;

package/addon-test-support/start.js

@@ -1,5 +1,9 @@
 import loadEmberExam from 'ember-exam/test-support/load';
-import { dependencySatisfies, macroCondition, importSync } from '@embroider/macros';
+import {
+  dependencySatisfies,
+  macroCondition,
+  importSync,
+} from '@embroider/macros';
 
 /**
  * Equivalent to ember-qunit or ember-mocha's loadTest() except this does not create a new TestLoader instance
@@ -32,7 +36,7 @@ export default function start(qunitOptions) {
   loadTests(testLoader);
 
   let emberTestFramework;
-  if (macroCondition(dependencySatisfies('ember-qunit', '*'))){
+  if (macroCondition(dependencySatisfies('ember-qunit', '*'))) {
     emberTestFramework = importSync('ember-qunit');
   } else if (macroCondition(dependencySatisfies('ember-mocha', '*'))) {
     emberTestFramework = importSync('ember-mocha');

package/index.js

@@ -2,10 +2,41 @@
 
 'use strict';
 
+const VersionChecker = require('ember-cli-version-checker');
+
 module.exports = {
   name: require('./package').name,
 
   includedCommands() {
     return require('./lib/commands');
-  }
+  },
+
+  init() {
+    this._super.init.apply(this, arguments);
+    let versionChecker = new VersionChecker(this.project);
+
+    const hasMagicallyProvidedQUnit = versionChecker
+      .for('ember-qunit')
+      .lt('5.0.0-beta.1');
+
+    let options = {
+      exclude: ['ember-mocha', 'mocha'],
+    };
+
+    // Ember-qunit < 5 provides an AMD shim for qunit but newer versions now use
+    // ember-auto-import to include qunit. This means that qunit is no
+    // longer available for addons (if the parent app is using ember-qunit > 5) to
+    // directly import under embroider unless they are using ember-auto-import
+    // themselves. This condidionally falls back to not using ember-auto-import
+    // when the parent app is providing qunit because without this we would double
+    // include qunit resulting in a runtime error (qunit detects if it as
+    // already be added to the window object and errors if so).
+    if (hasMagicallyProvidedQUnit) {
+      this.options = this.options || {};
+      options.exclude.push('qunit');
+      this.options.autoImport = options;
+    } else {
+      this.options.autoImport = options;
+    }
+  },
 };

package/lib/commands/exam/iterate.js

@@ -6,7 +6,7 @@ module.exports = {
   name: 'exam:iterate',
 
   description:
-    'Runs your app\'s test suite in a random order for a number of iterations with the \'exam\' command.',
+    "Runs your app's test suite in a random order for a number of iterations with the 'exam' command.",
 
   works: 'insideProject',
 
@@ -17,14 +17,14 @@ module.exports = {
       name: 'options',
       type: String,
       default: '',
-      description: 'A string of options to passthrough to the exam command'
+      description: 'A string of options to passthrough to the exam command',
     },
     {
       name: 'path',
       type: String,
       default: '',
-      description: 'The output path of a previous build to run tests against'
-    }
+      description: 'The output path of a previous build to run tests against',
+    },
   ],
 
   /**
@@ -83,7 +83,9 @@ module.exports = {
   _buildForTests() {
     this._write('\nBuilding app for test iterations.');
     execa.sync(
-      './node_modules/.bin/ember', ['build', '--output-path', `${this._outputDir}`], ['stdio', 'inherit']
+      './node_modules/.bin/ember',
+      ['build', '--output-path', `${this._outputDir}`],
+      ['stdio', 'inherit']
     );
   },
 
@@ -92,9 +94,7 @@ module.exports = {
    */
   _cleanupBuild() {
     this._write('\nCleaning up test iterations.\n');
-    execa.sync(
-      'rm', ['-rf', `${this._outputDir}`]
-    );
+    execa.sync('rm', ['-rf', `${this._outputDir}`]);
   },
 
   /**
@@ -114,8 +114,8 @@ module.exports = {
         chalk.blue('Iteration'),
         chalk.blue('Seed'),
         chalk.blue('Exit Code'),
-        chalk.blue('Command')
-      ]
+        chalk.blue('Command'),
+      ],
     });
 
     for (let i = 0; i < numIterations; i++) {
@@ -139,9 +139,7 @@ module.exports = {
     const chalk = require('chalk');
     const execSync = require('child_process').execSync;
 
-    const seed = Math.random()
-      .toString(36)
-      .slice(2);
+    const seed = Math.random().toString(36).slice(2);
     const command =
       './node_modules/.bin/ember exam --random ' +
       seed +
@@ -162,5 +160,5 @@ module.exports = {
 
     const color = exitCode ? chalk.red : chalk.green;
     return [color(seed), color(exitCode), color(command)];
-  }
+  },
 };