ember-eslint-parser 0.5.4 → 0.5.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-eslint-parser",
-  "version": "0.5.4",
+  "version": "0.5.5",
   "description": "",
   "keywords": [],
   "repository": {
@@ -17,6 +17,14 @@
   "files": [
     "src"
   ],
+  "dependencies": {
+    "@babel/eslint-parser": "^7.23.10",
+    "@glimmer/syntax": "^0.92.0",
+    "content-tag": "^2.0.1",
+    "eslint-scope": "^7.2.2",
+    "html-tags": "^3.3.1",
+    "svg-tags": "^1.0.0"
+  },
   "devDependencies": {
     "@babel/core": "^7.23.6",
     "@typescript-eslint/parser": "^7.1.0",
@@ -34,21 +42,11 @@
     "fs-extra": "^11.2.0",
     "prettier": "^3.2.5",
     "publint": "^0.2.6",
-    "release-plan": "^0.8.0",
+    "release-plan": "^0.9.0",
     "typescript": "^5.3.3",
     "vite": "^5.0.12",
     "vitest": "^1.2.2"
   },
-  "dependencies": {
-    "@babel/eslint-parser": "^7.23.10",
-    "@glimmer/syntax": "^0.92.0",
-    "content-tag": "^2.0.1",
-    "eslint-scope": "^7.2.2",
-    "html-tags": "^3.3.1"
-  },
-  "engines": {
-    "node": ">=16.0.0"
-  },
   "peerDependencies": {
     "@babel/core": "^7.23.6",
     "@typescript-eslint/parser": "*"
@@ -58,12 +56,15 @@
       "optional": true
     }
   },
+  "engines": {
+    "node": ">=16.0.0"
+  },
   "scripts": {
-    "test": "vitest run",
     "lint": "concurrently \"npm:lint:*(!fix)\" --names \"lint:\"",
+    "lint:fix": "concurrently \"npm:lint:*:fix\" --names \"fix:\"",
     "lint:js": "eslint . --max-warnings=0",
+    "lint:js:fix": "eslint . --fix --max-warnings=0",
     "lint:package": "pnpm publint",
-    "lint:fix": "concurrently \"npm:lint:*:fix\" --names \"fix:\"",
-    "lint:js:fix": "eslint . --fix --max-warnings=0"
+    "test": "vitest run"
   }
 }

package/src/parser/transforms.js

@@ -4,6 +4,7 @@ const DocumentLines = require('../utils/document');
 const { visitorKeys: glimmerVisitorKeys } = require('@glimmer/syntax');
 const { Reference, Scope, Variable, Definition } = require('eslint-scope');
 const htmlTags = require('html-tags');
+const svgTags = require('svg-tags');
 
 let TypescriptScope = null;
 try {
@@ -476,9 +477,6 @@ module.exports.convertAst = function convertAst(result, preprocessedResult, visi
       }
     }
     if (node.type === 'GlimmerElementNode') {
-      if (node.tag === 'svg') {
-        path.context.inSvg = true;
-      }
       // always reference first part of tag name, this also has the advantage
       // that errors regarding this tag will only mark the tag name instead of
       // the whole tag + children
@@ -491,14 +489,27 @@ module.exports.convertAst = function convertAst(result, preprocessedResult, visi
       if we do not find a variable we register it with a missing variable if
         * it starts with upper case, it should be a component with a reference
         * it includes a dot, it's a path which should have a reference
-        * it's NOT a standard html tag, it should have a referenced variable
+        * it's NOT a standard html or svg tag, it should have a referenced variable
       */
       const ignore =
-        n.name === 'this' || n.name.startsWith(':') || n.name.startsWith('@') || !scope;
+        // Local instance access
+        n.name === 'this' ||
+        // named block
+        n.name.startsWith(':') ||
+        // argument
+        n.name.startsWith('@') ||
+        // defined locally
+        !scope ||
+        // custom-elements are allowed to be used even if they don't exist
+        // and are undefined
+        n.name.includes('-');
+
       const registerUndef =
-        isUpperCase(n.name[0]) || node.name.includes('.') || !htmlTags.includes(node.name);
-      const allowUndef = path.parentPath?.context.inSvg;
-      if (!ignore && (variable || (registerUndef && !allowUndef))) {
+        isUpperCase(n.name[0]) ||
+        node.name.includes('.') ||
+        (!htmlTags.includes(node.name) && !svgTags.includes(node.name));
+
+      if (!ignore && (variable || registerUndef)) {
         registerNodeInScope(n, scope, variable);
       }
     }