ember-eslint-parser 0.5.3 → 0.5.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-eslint-parser",
-  "version": "0.5.3",
+  "version": "0.5.5",
   "description": "",
   "keywords": [],
   "repository": {
@@ -17,6 +17,14 @@
   "files": [
     "src"
   ],
+  "dependencies": {
+    "@babel/eslint-parser": "^7.23.10",
+    "@glimmer/syntax": "^0.92.0",
+    "content-tag": "^2.0.1",
+    "eslint-scope": "^7.2.2",
+    "html-tags": "^3.3.1",
+    "svg-tags": "^1.0.0"
+  },
   "devDependencies": {
     "@babel/core": "^7.23.6",
     "@typescript-eslint/parser": "^7.1.0",
@@ -34,21 +42,11 @@
     "fs-extra": "^11.2.0",
     "prettier": "^3.2.5",
     "publint": "^0.2.6",
-    "release-plan": "^0.8.0",
+    "release-plan": "^0.9.0",
     "typescript": "^5.3.3",
     "vite": "^5.0.12",
     "vitest": "^1.2.2"
   },
-  "dependencies": {
-    "@babel/eslint-parser": "^7.23.10",
-    "@glimmer/syntax": "^0.92.0",
-    "content-tag": "^2.0.1",
-    "eslint-scope": "^7.2.2",
-    "html-tags": "^3.3.1"
-  },
-  "engines": {
-    "node": ">=16.0.0"
-  },
   "peerDependencies": {
     "@babel/core": "^7.23.6",
     "@typescript-eslint/parser": "*"
@@ -58,12 +56,15 @@
       "optional": true
     }
   },
+  "engines": {
+    "node": ">=16.0.0"
+  },
   "scripts": {
-    "test": "vitest run",
     "lint": "concurrently \"npm:lint:*(!fix)\" --names \"lint:\"",
+    "lint:fix": "concurrently \"npm:lint:*:fix\" --names \"fix:\"",
     "lint:js": "eslint . --max-warnings=0",
+    "lint:js:fix": "eslint . --fix --max-warnings=0",
     "lint:package": "pnpm publint",
-    "lint:fix": "concurrently \"npm:lint:*:fix\" --names \"fix:\"",
-    "lint:js:fix": "eslint . --fix --max-warnings=0"
+    "test": "vitest run"
   }
 }

package/src/parser/gjs-gts-parser.js

@@ -29,7 +29,7 @@ module.exports = {
     patchTs();
     registerParsedFile(options.filePath);
     let jsCode = code;
-    const info = transformForLint(code);
+    const info = transformForLint(code, options.filePath);
     jsCode = info.output;
 
     const isTypescript = options.filePath.endsWith('.gts') || options.filePath.endsWith('.ts');

package/src/parser/transforms.js

@@ -4,6 +4,7 @@ const DocumentLines = require('../utils/document');
 const { visitorKeys: glimmerVisitorKeys } = require('@glimmer/syntax');
 const { Reference, Scope, Variable, Definition } = require('eslint-scope');
 const htmlTags = require('html-tags');
+const svgTags = require('svg-tags');
 
 let TypescriptScope = null;
 try {
@@ -476,9 +477,6 @@ module.exports.convertAst = function convertAst(result, preprocessedResult, visi
       }
     }
     if (node.type === 'GlimmerElementNode') {
-      if (node.tag === 'svg') {
-        path.context.inSvg = true;
-      }
       // always reference first part of tag name, this also has the advantage
       // that errors regarding this tag will only mark the tag name instead of
       // the whole tag + children
@@ -491,14 +489,27 @@ module.exports.convertAst = function convertAst(result, preprocessedResult, visi
       if we do not find a variable we register it with a missing variable if
         * it starts with upper case, it should be a component with a reference
         * it includes a dot, it's a path which should have a reference
-        * it's NOT a standard html tag, it should have a referenced variable
+        * it's NOT a standard html or svg tag, it should have a referenced variable
       */
       const ignore =
-        n.name === 'this' || n.name.startsWith(':') || n.name.startsWith('@') || !scope;
+        // Local instance access
+        n.name === 'this' ||
+        // named block
+        n.name.startsWith(':') ||
+        // argument
+        n.name.startsWith('@') ||
+        // defined locally
+        !scope ||
+        // custom-elements are allowed to be used even if they don't exist
+        // and are undefined
+        n.name.includes('-');
+
       const registerUndef =
-        isUpperCase(n.name[0]) || node.name.includes('.') || !htmlTags.includes(node.name);
-      const allowUndef = path.parentPath?.context.inSvg;
-      if (!ignore && (variable || (registerUndef && !allowUndef))) {
+        isUpperCase(n.name[0]) ||
+        node.name.includes('.') ||
+        (!htmlTags.includes(node.name) && !svgTags.includes(node.name));
+
+      if (!ignore && (variable || registerUndef)) {
         registerNodeInScope(n, scope, variable);
       }
     }
@@ -567,7 +578,39 @@ module.exports.replaceRange = replaceRange;
 
 const processor = new ContentTag.Preprocessor();
 
-module.exports.transformForLint = function transformForLint(code) {
+class EmberParserError extends Error {
+  constructor(message, fileName, location) {
+    super(message);
+    this.location = location;
+    this.fileName = fileName;
+    Object.defineProperty(this, 'name', {
+      configurable: true,
+      enumerable: false,
+      value: new.target.name,
+    });
+  }
+
+  // For old version of ESLint https://github.com/typescript-eslint/typescript-eslint/pull/6556#discussion_r1123237311
+  get index() {
+    return this.location.start.offset;
+  }
+
+  // https://github.com/eslint/eslint/blob/b09a512107249a4eb19ef5a37b0bd672266eafdb/lib/linter/linter.js#L853
+  get lineNumber() {
+    return this.location.start.line;
+  }
+
+  // https://github.com/eslint/eslint/blob/b09a512107249a4eb19ef5a37b0bd672266eafdb/lib/linter/linter.js#L854
+  get column() {
+    return this.location.start.column;
+  }
+}
+
+function createError(code, message, fileName, start, end = start) {
+  return new EmberParserError(message, fileName, { end, start });
+}
+
+module.exports.transformForLint = function transformForLint(code, fileName) {
   let jsCode = code;
   /**
    *
@@ -593,7 +636,26 @@ module.exports.transformForLint = function transformForLint(code) {
    *   };
    * }[]}
    */
-  const result = processor.parse(code);
+  let result = null;
+  try {
+    result = processor.parse(code);
+  } catch (e) {
+    // Parse Error at <anon>:1:19: 1:19
+    if (e.message.includes('Parse Error at')) {
+      const [line, column] = e.message
+        .split(':')
+        .slice(-2)
+        .map((x) => parseInt(x));
+      // e.source_code has actually usable info, e.g × Expected ',', got 'string literal (, '')'
+      //     ╭─[9:1]
+      //   9 │
+      //  10 │ console.log(test'');
+      //     ·                 ──
+      //     ╰────
+      throw createError(code, e.source_code, fileName, { line, column });
+    }
+    throw e;
+  }
   for (const tplInfo of result.reverse()) {
     const content = tplInfo.contents.replace(/`/g, '\\`').replace(/\$/g, '\\$');
     if (tplInfo.type === 'class-member') {