ember-eslint-parser 0.14.5 → 0.14.7

package/README.md

@@ -31,6 +31,21 @@ It's recommended to only use _overrides_ when defining your eslint config, so us
 if we detect a typescript parser, it will also be used for all files, otherwise babel parser will be used.
 If we cannot find a typescript parser when linting gts we throw an error. 
 
+If you use type-aware rules, route `.js`/`.ts` through this parser too, as
+`eslint-plugin-ember`'s configs do:
+
+```js
+    {
+      files: ['**/*.{js,ts}'],
+      parser: 'ember-eslint-parser',
+      // ...
+    },
+```
+
+`@typescript-eslint/parser` hands TypeScript the source as ESLint read it, so a
+`.ts` file importing from a `.gts` gets an `error` type for that import. This
+parser rewrites the specifier first.
+
 ## HBS (Handlebars) support
 
 For `.hbs` template files, use the `ember-eslint-parser/hbs` parser. In ESLint's flat config format (ESLint 9+):

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-eslint-parser",
-  "version": "0.14.5",
+  "version": "0.14.7",
   "description": "",
   "keywords": [],
   "repository": {

package/src/parser/gjs-gts-parser.js

@@ -1,6 +1,6 @@
 import { createRequire } from 'node:module';
 import { registerParsedFile } from '../preprocessor/noop.js';
-import { patchTs, replaceExtensions, syncMtsGtsSourceFiles, typescriptParser } from './ts-patch.js';
+import { replaceExtensions, syncMtsGtsSourceFiles, typescriptParser } from './ts-patch.js';
 import { buildGlimmerVisitors } from './transforms.js';
 import { toTree } from 'ember-estree';
 
@@ -48,10 +48,6 @@ export const meta = {
 };
 
 export function parseForESLint(code, options) {
-  // Only patch TypeScript if we actually need it.
-  if (options.programs || options.projectService || options.project) {
-    patchTs();
-  }
   registerParsedFile(options.filePath);
 
   const isTypescript = options.filePath.endsWith('.gts') || options.filePath.endsWith('.ts');

package/src/parser/transforms.js

@@ -61,6 +61,13 @@ function findVarInParentScopes(scopeManager, nodePath, name) {
 
 function registerNodeInScope(node, scope, variable) {
   const ref = new Reference(node, scope, Reference.READ);
+  // A template reference always reads a value. typescript-eslint's scope
+  // manager flags every reference as a value or type reference, and its rules
+  // rely on that (no-unused-vars treats a reference without
+  // isValueReference as type-only since 8.71.1), but eslint-scope's
+  // Reference has neither flag.
+  ref.isValueReference = true;
+  ref.isTypeReference = false;
   if (variable) {
     variable.references.push(ref);
     ref.resolved = variable;

package/src/parser/ts-patch.js

@@ -123,6 +123,12 @@ try {
     return jsCode;
   };
 
+  // typescript-eslint copies `ts.sys` by value when it builds a program or
+  // project service, on the first type-aware parse in the process — which may be
+  // a plain .ts file that never reaches this parser. Patching at module load is
+  // what puts the wrappers in that copy, and in the project's first file scan.
+  patchTs();
+
   /**
    *
    * @param program {ts.Program}