ember-eslint-parser 0.14.4 → 0.14.6

package/README.md

@@ -31,6 +31,21 @@ It's recommended to only use _overrides_ when defining your eslint config, so us
 if we detect a typescript parser, it will also be used for all files, otherwise babel parser will be used.
 If we cannot find a typescript parser when linting gts we throw an error. 
 
+If you use type-aware rules, route `.js`/`.ts` through this parser too, as
+`eslint-plugin-ember`'s configs do:
+
+```js
+    {
+      files: ['**/*.{js,ts}'],
+      parser: 'ember-eslint-parser',
+      // ...
+    },
+```
+
+`@typescript-eslint/parser` hands TypeScript the source as ESLint read it, so a
+`.ts` file importing from a `.gts` gets an `error` type for that import. This
+parser rewrites the specifier first.
+
 ## HBS (Handlebars) support
 
 For `.hbs` template files, use the `ember-eslint-parser/hbs` parser. In ESLint's flat config format (ESLint 9+):

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-eslint-parser",
-  "version": "0.14.4",
+  "version": "0.14.6",
   "description": "",
   "keywords": [],
   "repository": {

package/src/parser/gjs-gts-parser.js

@@ -1,6 +1,6 @@
 import { createRequire } from 'node:module';
 import { registerParsedFile } from '../preprocessor/noop.js';
-import { patchTs, replaceExtensions, syncMtsGtsSourceFiles, typescriptParser } from './ts-patch.js';
+import { replaceExtensions, syncMtsGtsSourceFiles, typescriptParser } from './ts-patch.js';
 import { buildGlimmerVisitors } from './transforms.js';
 import { toTree } from 'ember-estree';
 
@@ -48,10 +48,6 @@ export const meta = {
 };
 
 export function parseForESLint(code, options) {
-  // Only patch TypeScript if we actually need it.
-  if (options.programs || options.projectService || options.project) {
-    patchTs();
-  }
   registerParsedFile(options.filePath);
 
   const isTypescript = options.filePath.endsWith('.gts') || options.filePath.endsWith('.ts');

package/src/parser/ts-patch.js

@@ -123,6 +123,12 @@ try {
     return jsCode;
   };
 
+  // typescript-eslint copies `ts.sys` by value when it builds a program or
+  // project service, on the first type-aware parse in the process — which may be
+  // a plain .ts file that never reaches this parser. Patching at module load is
+  // what puts the wrappers in that copy, and in the project's first file scan.
+  patchTs();
+
   /**
    *
    * @param program {ts.Program}
@@ -155,6 +161,14 @@ try {
             originalFileName: virtualSourceFile.originalFileName,
             resolvedPath: virtualSourceFile.resolvedPath,
             impliedNodeFormat: virtualSourceFile.impliedNodeFormat,
+            // The twin is a .mts/.mjs, so its script kind has to stay the one the language
+            // service host reports for that extension. Inheriting the .gts/.gjs file's
+            // Deferred kind makes TypeScript's getOrCreateSourceFileByPath see a script-kind
+            // mismatch on the next program sync, and it responds by releasing and
+            // re-acquiring the document instead of updating it — a full re-parse of every
+            // twin, on every parse. It never settles either: the re-acquired file comes back
+            // as TS, and the next call to this function stamps it back to Deferred.
+            scriptKind: virtualSourceFile.scriptKind,
           };
           Object.assign(virtualSourceFile, sourceFile, keep);
           virtualSourceFile[virtualFlag] = true;