ember-eslint-parser 0.1.1 → 0.2.1

package/README.md

@@ -1 +1,33 @@
 # ember-eslint-parser
+
+This is the eslint parser for ember's gjs and gts files (using `<template>`).
+
+It is meant to be used with [eslint-plugin-ember](https://github.com/ember-cli/eslint-plugin-ember), which provides nice defaults for all the different file types in ember projects.
+
+It's recommended to only use _overrides_ when defining your eslint config, so using this parser would look like this:
+```js 
+    {
+      files: ['**/*.gjs'],
+      parser: 'ember-eslint-parser',
+      plugins: ['ember'],
+      extends: [
+        'eslint:recommended',
+        'plugin:ember/recommended',
+        'plugin:ember/recommended-gjs',
+      ],
+    },
+    {
+      files: ['**/*.gts'],
+      parser: 'ember-eslint-parser',
+      plugins: ['ember'],
+      extends: [
+        'eslint:recommended',
+        'plugin:ember/recommended',
+        'plugin:ember/recommended-gts',
+      ],
+    },
+```
+
+## Support
+
+eslint-plugin-ember is the primary consumer of this parser library, so SemVer _may_ not be respected for other consumers.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-eslint-parser",
-  "version": "0.1.1",
+  "version": "0.2.1",
   "description": "",
   "keywords": [],
   "repository": {
@@ -10,7 +10,8 @@
   "license": "ISC",
   "author": "",
   "exports": {
-    ".": "./src/parser/gjs-gts-parser.js"
+    ".": "./src/parser/gjs-gts-parser.js",
+    "./noop": "./src/preprocessor/noop.js"
   },
   "main": "src/parser/gjs-gts-parser.js",
   "files": [
@@ -27,6 +28,8 @@
     "eslint-plugin-n": "^16.4.0",
     "eslint-plugin-prettier": "^5.0.1",
     "eslint-plugin-promise": "^6.0.0",
+    "execa": "^8.0.1",
+    "fs-extra": "^11.2.0",
     "jest": "^29.7.0",
     "prettier": "^3.1.1",
     "publint": "^0.2.6",
@@ -50,7 +53,6 @@
     "typescript": "^5.3.3"
   },
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1",
     "lint": "concurrently \"npm:lint:*(!fix)\" --names \"lint:\"",
     "lint:js": "eslint .",
     "lint:package": "pnpm publint",

package/src/parser/transforms.js

@@ -48,6 +48,7 @@ function findVarInParentScopes(scopeManager, nodePath, name) {
   if (!scope) {
     return { scope: currentScope };
   }
+
   return { scope: currentScope, variable: scope.set.get(name) };
 }
 
@@ -268,6 +269,10 @@ module.exports.preprocessGlimmerTemplates = function preprocessGlimmerTemplates(
         for (const part of n.tag.split('.')) {
           const regex = new RegExp(`\\b${part}\\b`);
           const match = codeSlice.match(regex);
+
+          // named-blocks are not ElementNodes
+          if (!match && part.startsWith(':')) continue;
+
           const range = [start + match.index, 0];
           range[1] = range[0] + part.length;
           codeSlice = code.slice(range[1], n.range[1]);
@@ -421,14 +426,21 @@ module.exports.convertAst = function convertAst(result, preprocessedResult, visi
       // always reference first part of tag name, this also has the advantage
       // that errors regarding this tag will only mark the tag name instead of
       // the whole tag + children
-      const n = node.parts[0];
+      //
+      // However, with plain <footer> type nodes, there will be no "parts"
+      const n = node.parts?.[0] ?? node;
+
+      const name = n?.name ?? n.tag;
+
+      if (htmlTags.includes(name)) {
+        return null;
+      }
+
       const { scope, variable } = findVarInParentScopes(result.scopeManager, path, n.name) || {};
       if (
         scope &&
-        (variable ||
-          isUpperCase(n.name[0]) ||
-          node.name.includes('.') ||
-          !htmlTags.includes(node.name))
+        !name.startsWith(':') &&
+        (variable || isUpperCase(n.name[0]) || name.includes('.') || !htmlTags.includes(name))
       ) {
         registerNodeInScope(n, scope, variable);
       }

package/src/preprocessor/noop.js

@@ -3,7 +3,7 @@
  * this preprocessor is setup by our recommended rules for gjs/gts, so it will always be called for it
  * the flow is the following:
  *  1. gjs/gts files goes through our parses, which calls registerParsedFile, if its not correctly setup, registerParsedFile will not be called
- *  2. postprocess checks if the file is registered and if not throws an error (only if parsing failed)
+ *  2. postprocess checks if the file is registered and if not throws an error
  *
  */
 
@@ -16,16 +16,13 @@ module.exports = {
   preprocess: null,
   postprocess: (messages, fileName) => {
     const msgs = messages.flat();
-    if (
-      msgs.length === 1 &&
-      msgs[0].ruleId === null &&
-      msgs[0].message.startsWith('Parsing error: ')
-    ) {
-      if (!parsedFiles.has(fileName)) {
-        msgs[0].message += '\n';
-        msgs[0].message +=
-          'To lint Gjs/Gts files please follow the setup guide at https://github.com/ember-cli/eslint-plugin-ember#gtsgjs';
-      }
+    if (!parsedFiles.has(fileName)) {
+      msgs[0] = msgs[0] || {
+        message: '',
+      };
+      msgs[0].message += '\n';
+      msgs[0].message +=
+        'To lint Gjs/Gts files please follow the setup guide at https://github.com/ember-cli/eslint-plugin-ember#gtsgjs';
     }
     parsedFiles.delete(fileName); // required for tests
     return msgs;